Re: [RFC PATCH 2/3] crypto: hisilicon hacv1 driver

2018-02-05 Thread Stephan Mueller
Am Montag, 5. Februar 2018, 15:02:03 CET schrieb Jonathan Cameron: Hi Jonathan, > I could drop this for the initial submission and bring it in as an > optimization with supporting numbers as a follow up patch. I am not disputing the code itself. It just occurred to me that the code is similar t

Re: [RFC PATCH 2/3] crypto: hisilicon hacv1 driver

2018-02-05 Thread Jonathan Cameron
On Sat, 3 Feb 2018 12:16:18 +0100 Stephan Müller wrote: > Am Dienstag, 30. Januar 2018, 16:29:52 CET schrieb Jonathan Cameron: > > Hi Jonathan, > > > + /* Special path for single element SGLs with small packets. */ > > + if (sg_is_last(sgl) && sgl->length <= SEC_SMALL_PACKET_SIZE) { > >

Re: [RFC PATCH 2/3] crypto: hisilicon hacv1 driver

2018-02-03 Thread Stephan Müller
Am Dienstag, 30. Januar 2018, 16:29:52 CET schrieb Jonathan Cameron: Hi Jonathan, > + /* Special path for single element SGLs with small packets. */ > + if (sg_is_last(sgl) && sgl->length <= SEC_SMALL_PACKET_SIZE) { This looks strangely familiar. Is this code affected by a similar issue

[RFC PATCH 2/3] crypto: hisilicon hacv1 driver

2018-01-30 Thread Jonathan Cameron
From: Jonathan Cameron This accelerator is found inside hisilicon hip06 and hip07 SoCs. Each instance provides a number of queues which feed a different number of backend accleration units. The queues are operating in an out of order mode in the interests of throughput. The silicon does not do t