Re: Bug in geode-aes.c ?

2009-11-23 Thread Herbert Xu
On Thu, Nov 12, 2009 at 08:36:42AM +, Sergey Mironov wrote: Hi. Ok, here is geode-patch Your patch is corrupted: $ git apply ~/p patch: malformed patch at line 51: *tfm, const u8 *key, $ Please resend. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: Bug in geode-aes.c ?

2009-11-23 Thread Herbert Xu
On Thu, Nov 12, 2009 at 01:18:53PM +0300, Sergey Mironov wrote: Here is similar patch for aes_s390: It doesn't apply either: $ git apply ~/p patch: malformed patch at line 75: *tfm, const u8 *in_key, $ Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~}

Re: Bug in geode-aes.c ?

2009-11-20 Thread Sebastian Andrzej Siewior
From 335b39e0c55a1dba13cda3e8222947f2cb4120ed Mon Sep 17 00:00:00 2001 From: Sergey Mironov ier...@gmail.com Date: Thu, 12 Nov 2009 13:10:05 +0300 Subject: [PATCH 2/2] aes_s390: access fallback.cip cipher fallback mode |The fallback code in cipher mode touch the union fallback.blk instead |of

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sergey Mironov
2009/11/12 Sebastian Andrzej Siewior linux-cry...@ml.breakpoint.cc: * Sergey Mironov | 2009-11-10 17:00:31 [+0300]: 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key, 117                 unsigned int len) 118 { ... /** BUG? Should it be 'op-fallback.cip' instead of

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sergey Mironov
2009/11/12 Sergey Mironov ier...@gmail.com: 2009/11/12 Sebastian Andrzej Siewior linux-cry...@ml.breakpoint.cc: * Sergey Mironov | 2009-11-10 17:00:31 [+0300]: 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key, 117                 unsigned int len) 118 { ... /** BUG?

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sebastian Andrzej Siewior
* Sergey Mironov | 2009-11-12 11:36:42 [+0300]: From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001 From: Sergey Mironov ier...@gmail.com Date: Thu, 12 Nov 2009 11:30:02 +0300 Subject: [PATCH] Fixed typo bugs in geod-aes.c Signed-off-by: Sergey Mironov ier...@gmail.com

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sebastian Andrzej Siewior
From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001 From: Sergey Mironov ier...@gmail.com Date: Thu, 12 Nov 2009 11:30:02 +0300 Subject: [PATCH] Fixed typo bugs in geod-aes.c On a second look could you please add something like: crypto/geode: access fallback.cip cipher

Re: Bug in geode-aes.c ?

2009-11-12 Thread Sergey Mironov
2009/11/12 Sebastian Andrzej Siewior sebast...@breakpoint.cc: From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001 From: Sergey Mironov ier...@gmail.com Date: Thu, 12 Nov 2009 11:30:02 +0300 Subject: [PATCH] Fixed typo bugs in geod-aes.c On a second look could you please add

Re: Bug in geode-aes.c ?

2009-11-11 Thread Sebastian Andrzej Siewior
* Sergey Mironov | 2009-11-10 17:00:31 [+0300]: 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key, 117 unsigned int len) 118 { ... /** BUG? Should it be 'op-fallback.cip' instead of 'op-fallback.blk' ? **/ 138 op-fallback.blk-base.crt_flags =

Bug in geode-aes.c ?

2009-11-10 Thread Sergey Mironov
Hello. I noticed strange thing in drivers/crypto/geode-aes.c ( function geode_setkey_cip() ) This code still the same in git://linux-arm.org/linux-2.6-stable.git (tag v2.6.28-arm2) Please, check. 116 static int geode_setkey_cip(struct crypto_tfm *tfm, const u8 *key, 117