[PATCH v3 1/6] staging: ccree: fix hash import/export

2017-06-25 Thread Gilad Ben-Yossef
Hash import and export was saving and restoring the wrong context and therefore disabled. Fix it by restoring intermediate digest and additional state needed. The hash and mac transform now pass testmgr partial hash tests. Signed-off-by: Gilad Ben-Yossef ---

Re: [PATCH v2 1/7] staging: ccree: fix hash import/export

2017-06-25 Thread Gilad Ben-Yossef
On Thu, Jun 22, 2017 at 4:58 PM, Dan Carpenter wrote: > On Thu, Jun 22, 2017 at 04:36:55PM +0300, Gilad Ben-Yossef wrote: >> static int ssi_ahash_export(struct ahash_request *req, void *out) >> { >> struct crypto_ahash *ahash = crypto_ahash_reqtfm(req); >>

Re: [PATCH v2 1/7] staging: ccree: fix hash import/export

2017-06-22 Thread Dan Carpenter
On Thu, Jun 22, 2017 at 04:36:55PM +0300, Gilad Ben-Yossef wrote: > static int ssi_ahash_export(struct ahash_request *req, void *out) > { > struct crypto_ahash *ahash = crypto_ahash_reqtfm(req); > struct ssi_hash_ctx *ctx = crypto_ahash_ctx(ahash); > + struct device *dev =

[PATCH v2 1/7] staging: ccree: fix hash import/export

2017-06-22 Thread Gilad Ben-Yossef
Hash import and export was saving and restoring the wrong context and therefore disabled. Fix it by restoring intermediate digest and additional state needed. The hash and mac transform now pass testmgr partial hash tests. Signed-off-by: Gilad Ben-Yossef ---

[PATCH 1/7] staging: ccree: fix hash import/export

2017-06-22 Thread Gilad Ben-Yossef
Hash import and export was saving and restoring the wrong context and therefore disabled. Fix it by restoring intermediate digest and additional state needed. The hash and mac transform now pass testmgr partial hash tests. Signed-off-by: Gilad Ben-Yossef ---

hash import/export

2015-10-11 Thread Russell King - ARM Linux
Herbert, I wonder if you can clear something up about the hash export/import functionality. In: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344120.html you seem to imply that the exported and imported state can't be defined by the driver. Boris tells me, "AFAIR, crypto

Re: hash import/export

2015-10-11 Thread Boris Brezillon
On Sun, 11 Oct 2015 20:34:27 +0100 Russell King - ARM Linux wrote: > Herbert, > > I wonder if you can clear something up about the hash export/import > functionality. In: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344120.html > > you seem to

Re: hash import/export

2015-10-11 Thread Russell King - ARM Linux
On Sun, Oct 11, 2015 at 08:34:27PM +0100, Russell King - ARM Linux wrote: > Herbert, > > I wonder if you can clear something up about the hash export/import > functionality. In: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344120.html > > you seem to imply that the

Re: hash import/export

2015-10-11 Thread Herbert Xu
On Sun, Oct 11, 2015 at 08:34:27PM +0100, Russell King - ARM Linux wrote: > > Is there any reason a driver can't define its own structure to be > exported here which can be shared between each of the different methods > it supports? For algorithms in general you can use any format you like and