Re: LRW implementation, please comment

2006-09-01 Thread Herbert Xu
On Fri, Sep 01, 2006 at 10:55:14AM +0200, [EMAIL PROTECTED] wrote: Can you give some examples about what I missed from CodingStyle? (I just reread it and I think my patch adheres pretty well to those rules: tabs=8, KR bracing, don't pollute global namespace etc...) It's only a few spots: *

[PATCHv2 5/6] LRW, Liskov Rivest Wagner, a tweakable narrow block cipher mode

2006-09-01 Thread rsnel
From: Rik Snel [EMAIL PROTECTED] Main module, this implements the Liskov Rivest Wagner block cipher mode in the new blockcipher API. The implementation is based on ecb.c. The LRW-32-AES specification I used can be found at: http://grouper.ieee.org/groups/1619/email/pdf00017.pdf It implements

[PATCHv2 6/6] LRW testvectors in tcrypt.[ch]

2006-09-01 Thread rsnel
From: Rik Snel [EMAIL PROTECTED] Do modprobe tcrypt mode=10 to check the included test vectors, they are from: http://grouper.ieee.org/groups/1619/email/pdf00017.pdf and from http://www.mail-archive.com/stds-p1619@listserv.ieee.org/msg00173.html. To make the last test vector fit, I had to

[PATCHv2 1/6] crypto: trivial comment improvements

2006-09-01 Thread rsnel
From: Rik Snel [EMAIL PROTECTED] Just some minor comment nits. - little-endian is better than low-endian - and since it is called essiv everywere it should also be essiv in the comments (and not ess_iv) Signed-off-by: Rik Snel [EMAIL PROTECTED] --- drivers/md/dm-crypt.c |8 1