RE: [PATCH v2 3/4] fsl-dma: change the release process of dma descriptor

2012-07-12 Thread Liu Qiang-B32616
-Original Message- From: Ira W. Snyder [mailto:i...@ovro.caltech.edu] Sent: Thursday, July 12, 2012 12:31 AM To: Liu Qiang-B32616 Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Vinod Koul; herb...@gondor.hengli.com.au; Dan Williams; da...@davemloft.net Subject: Re:

RE: [PATCH v2 3/4] fsl-dma: change the release process of dma descriptor

2012-07-12 Thread Liu Qiang-B32616
-Original Message- From: Linuxppc-dev [mailto:linuxppc-dev- bounces+qiang.liu=freescale@lists.ozlabs.org] On Behalf Of Liu Qiang- B32616 Sent: Thursday, July 12, 2012 3:12 PM To: Ira W. Snyder Cc: herb...@gondor.apana.org.au; Vinod Koul; linux-crypto@vger.kernel.org; Dan

RE: [linuxppc-release] [PATCH v2 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-07-12 Thread Liu Qiang-B32616
-Original Message- From: Tabi Timur-B04825 Sent: Wednesday, July 11, 2012 11:01 PM To: Liu Qiang-B32616 Cc: linux-crypto@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Vinod Koul; herb...@gondor.hengli.com.au; Dan Williams; Li Yang-R58472; da...@davemloft.net Subject: Re:

Re: [PATCH 14/14] crypto: arch/s390 - cleanup - remove unneeded cra_list initialization

2012-07-12 Thread Jan Glauber
On Wed, 2012-07-11 at 14:21 +0300, Jussi Kivilinna wrote: Initialization of cra_list is currently mixed, most ciphers initialize this field and most shashes do not. Initialization however is not needed at all since cra_list is initialized/overwritten in __crypto_register_alg() with list_add().

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-12 Thread Tejun Heo
Hello, Fengguang. On Thu, Jul 12, 2012 at 09:06:48PM +0800, Fengguang Wu wrote: [0.207977] WARNING: at /c/kernel-tests/mm/kernel/workqueue.c:1217 worker_enter_idle+0x2b8/0x32b() [0.207977] Modules linked in: [0.207977] Pid: 1, comm: swapper/0 Not tainted 3.5.0-rc6-08414-g9645fff

Re: [PATCH 3/6] workqueue: use @pool instead of @gcwq or @cpu where applicable

2012-07-12 Thread Tejun Heo
Hello, Tony. On Tue, Jul 10, 2012 at 04:30:36PM -0700, Tony Luck wrote: On Mon, Jul 9, 2012 at 11:41 AM, Tejun Heo t...@kernel.org wrote: @@ -1234,7 +1235,7 @@ static void worker_enter_idle(struct worker *worker) */ WARN_ON_ONCE(gcwq-trustee_state == TRUSTEE_DONE

Re: [PATCH 2/6] workqueue: factor out worker_pool from global_cwq

2012-07-12 Thread Tejun Heo
Hello, Namhyung. Sorry about the delay. On Tue, Jul 10, 2012 at 01:48:44PM +0900, Namhyung Kim wrote: + struct list_headidle_list; /* X: list of idle workers */ + struct timer_list idle_timer; /* L: worker idle timeout */ + struct timer_list mayday_timer;

Re: [linuxppc-release] [PATCH v2 4/4] fsl-dma: use spin_lock_bh to instead of spin_lock_irqsave

2012-07-12 Thread Timur Tabi
Liu Qiang-B32616 wrote: I compared my test result before and after this patch, write performance can improved by 15%. I will send the latest patches sooner because of Ira's concern. I will give a complete description about the improvement of spin_lock_bh(). About your question,

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-12 Thread Tejun Heo
Hello, again. On Thu, Jul 12, 2012 at 10:05:19AM -0700, Tejun Heo wrote: On Thu, Jul 12, 2012 at 09:06:48PM +0800, Fengguang Wu wrote: [0.207977] WARNING: at /c/kernel-tests/mm/kernel/workqueue.c:1217 worker_enter_idle+0x2b8/0x32b() [0.207977] Modules linked in: [0.207977]

[PATCH UPDATED 2/6] workqueue: factor out worker_pool from global_cwq

2012-07-12 Thread Tejun Heo
From bd7bdd43dcb81bb08240b9401b36a104f77dc135 Mon Sep 17 00:00:00 2001 From: Tejun Heo t...@kernel.org Date: Thu, 12 Jul 2012 14:46:37 -0700 Move worklist and all worker management fields from global_cwq into the new struct worker_pool. worker_pool points back to the containing gcwq. worker and

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-12 Thread Tony Luck
the boot log? Thank you. Patch applied on top of next-20120712 (which still has the same problem). dmesg output attached -Tony Linux version 3.5.0-rc6-zx1-smp-next-20120712-1-g1275170 (aegl@linux-bxb1) (gcc version 4.3.4 [gcc-4_3-branch revision 152973] (SUSE Linux) ) #1 SMP Thu Jul 12 15:09:17

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-12 Thread Tejun Heo
-zero at that point? Can you please apply the following patch and report the boot log? Thank you. Patch applied on top of next-20120712 (which still has the same problem). Can you please try the following debug patch instead? Yours is different from Fengguang's. Thanks a lot! --- kernel

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-12 Thread Tony Luck
On Thu, Jul 12, 2012 at 3:32 PM, Tejun Heo t...@kernel.org wrote: Can you please try the following debug patch instead? Yours is different from Fengguang's. New dmesg from mext-20120712 + this new patch (instead of previous one) [Note - I see some XXX traces, but no WARN_ON stack dump

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-12 Thread Tejun Heo
Hello, Tony. On Thu, Jul 12, 2012 at 04:24:47PM -0700, Tony Luck wrote: On Thu, Jul 12, 2012 at 3:32 PM, Tejun Heo t...@kernel.org wrote: Can you please try the following debug patch instead? Yours is different from Fengguang's. New dmesg from mext-20120712 + this new patch (instead

Re: [PATCH 6/6] workqueue: reimplement WQ_HIGHPRI using a separate worker_pool

2012-07-12 Thread Tony Luck
On Thu, Jul 12, 2012 at 4:36 PM, Tejun Heo t...@kernel.org wrote: The debug patch didn't do anything for the bug itself. I suppose it's timing dependent and doesn't always happen (it never reproduces here for some reason). Can you please repeat several times and see whether the warning can