Alignment of shash input buffers?

2016-10-28 Thread Eric Biggers
Hi, I'm having trouble understanding how alignment of shash input buffers is supposed to work. If you pass crypto_shash_update() a buffer that is not aligned to the shash algorithm's alignmask, it will call the underlying ->update() function twice, once with a temporary aligned buffer and once

[PATCH] crypto: skcipher - Get rid of crypto_grab_skcipher2()

2016-10-28 Thread Eric Biggers
Since commit 3a01d0ee2b99 ("crypto: skcipher - Remove top-level givcipher interface"), crypto_grab_skcipher2() and crypto_grab_skcipher() are equivalent. So switch callers of crypto_grab_skcipher2() to crypto_grab_skcipher() and remove it. Signed-off-by: Eric Biggers ---

[PATCH] crypto: skcipher - Get rid of crypto_spawn_skcipher2()

2016-10-28 Thread Eric Biggers
Since commit 3a01d0ee2b99 ("crypto: skcipher - Remove top-level givcipher interface"), crypto_spawn_skcipher2() and crypto_spawn_skcipher() are equivalent. So switch callers of crypto_spawn_skcipher2() to crypto_spawn_skcipher() and remove it. Signed-off-by: Eric Biggers

Re: ahash and crc32c

2016-10-28 Thread Horia Geanta Neag
On 2/26/2013 7:11 PM, Zeev Zilberman wrote: > Hi, > > I'm working on an ahash driver that supports CRC32C. > I saw that all existing CRC32C implementations (except blackfin) are > implementing shash interface, but ahash seems to be the correct choice > in our case. > On the other hand I saw that

Re: [PATCH] crypto: mxs-dcp - Remove hash support

2016-10-28 Thread Gianfranco Costamagna
Hi, (sending with my debian.org mail address to avoid spam filters) I tested the patch and indeed solves my problem (the driver loads correctly now with no warnings) Tested-by: Gianfranco Costamagna ' Just a side note about the patch if

Re: [PATCH] crypto: mxs-dcp - Remove hash support

2016-10-28 Thread Marek Vasut
On 10/28/2016 05:46 PM, Gianfranco Costamagna wrote: > Hi, > (sending with my debian.org mail address to avoid spam filters) > I tested the patch and indeed solves my problem (the driver loads correctly > now with no warnings) > > Tested-by: Gianfranco Costamagna

[PATCH v3] char: hw_random: atmel-rng: disable TRNG during suspend

2016-10-28 Thread Wenyou Yang
To fix the over consumption on the VDDCore due to the TRNG enabled, disable the TRNG during suspend, not only disable the user interface clock (which is controlled by PMC). Because the user interface clock is independent from any clock that may be used in the entropy source logic circuitry.

Re: [PATCH] sunrpc: don't pass on-stack memory to sg_set_buf

2016-10-28 Thread Fields Bruce James
On Tue, Oct 25, 2016 at 09:47:16PM +, Trond Myklebust wrote: > > > On Oct 25, 2016, at 15:59, Fields Bruce James wrote: > > > > On Tue, Oct 25, 2016 at 07:34:43PM +, Trond Myklebust wrote: > >> NACKā€¦ I agree that there may already be borkage in RPCSEC_GSS-land,

Re: [PATCH] sunrpc: don't pass on-stack memory to sg_set_buf

2016-10-28 Thread Fields Bruce James
On Fri, Oct 28, 2016 at 09:20:08AM -0400, Fields Bruce James wrote: > On Tue, Oct 25, 2016 at 09:47:16PM +, Trond Myklebust wrote: > > > > > On Oct 25, 2016, at 15:59, Fields Bruce James > > > wrote: > > > > > > On Tue, Oct 25, 2016 at 07:34:43PM +, Trond

Re: [PATCH] crypto: acomp: export all scomp interfaces

2016-10-28 Thread Arnd Bergmann
On Thursday, October 27, 2016 10:03:29 PM CEST Giovanni Cabiddu wrote: > Hi Arnd, > > On Thu, Oct 27, 2016 at 04:09:49PM +0200, Arnd Bergmann wrote: > > The newly added scomp/acomp interface has a couple of functions > > that should be exported to allow linking the two drivers > > as loadable

Re: [PATCH v2] crypto: mxs-dcp - Remove hash support

2016-10-28 Thread Horia Geanta Neag
On 10/25/2016 12:33 AM, Fabio Estevam wrote: > On Mon, Oct 24, 2016 at 6:39 PM, Marek Vasut wrote: > >> Can't you rather fix it? > > I would love to have this fixed, but I don't know how. Looking on the i.MX6 Solo Lite security manual, the fix seems to consist in enabling

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-28 Thread Mat Martineau
Stephan, On Fri, 28 Oct 2016, Stephan Mueller wrote: Am Donnerstag, 27. Oktober 2016, 14:42:14 CEST schrieb Mat Martineau: Hi Mat, Stephan and Herbert, On Thu, 27 Oct 2016, Stephan Mueller wrote: Hi Herbert, for this patch, I have updated the testing for libkcapi accordingly and all

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-28 Thread LABBE Corentin
On Tue, Oct 25, 2016 at 09:06:34AM +0200, Jean-Francois Moine wrote: > On Tue, 25 Oct 2016 07:38:55 +0200 > LABBE Corentin wrote: > > > > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > > > Since SID's content is constant over reboot, > > > > > >