Re: [Part2 PATCH v7 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-11-02 Thread Borislav Petkov
On Wed, Nov 01, 2017 at 04:15:58PM -0500, Brijesh Singh wrote: > AMD's new Secure Encrypted Virtualization (SEV) feature allows the > memory contents of virtual machines to be transparently encrypted with a > key unique to the VM. The programming and management of the encryption > keys are handled

Re: [PATCH 1/4] crypto: dh - fix double free of ctx->p

2017-11-02 Thread Eric Biggers
Hi Tudor, On Thu, Nov 02, 2017 at 12:55:56PM +0200, Tudor Ambarus wrote: > Hi, Eric, > > On 11/02/2017 12:25 AM, Eric Biggers wrote: > >When setting the secret with the software Diffie-Hellman implementation, > >if allocating 'g' failed (e.g. if it was longer than > >MAX_EXTERN_MPI_BITS), then

Re: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0

2017-11-02 Thread Eric Biggers
On Thu, Nov 02, 2017 at 01:40:51PM +0200, Tudor Ambarus wrote: > Hi, Eric, > > On 11/02/2017 12:25 AM, Eric Biggers wrote: > >If 'p' is 0 for the software Diffie-Hellman implementation, then > >dh_max_size() returns 0. > > dh_set_secret() returns -EINVAL if p_len < 1536, see >

Re: [PATCH 00/12] bcm63xx-rng conversion to bcm2835-rng

2017-11-02 Thread Stefan Wahren
Hi Florian, > Florian Fainelli hat am 2. November 2017 um 02:03 > geschrieben: > > > Hi, > > As it usually happens when there is a fair amount of HW IP block re-use, > competing implementations show up. In that case the BCM2835 HWRNG driver and > the BCM63xx RNG driver

Re: [PATCH 00/12] bcm63xx-rng conversion to bcm2835-rng

2017-11-02 Thread Florian Fainelli
Hi Stefan, On 11/02/2017 12:01 PM, Stefan Wahren wrote: > Hi Florian, > >> Florian Fainelli hat am 2. November 2017 um 02:03 >> geschrieben: >> >> >> Hi, >> >> As it usually happens when there is a fair amount of HW IP block re-use, >> competing implementations show up.

Re: [PATCH 00/12] bcm63xx-rng conversion to bcm2835-rng

2017-11-02 Thread Stefan Wahren
Hi Florian, > Florian Fainelli hat am 2. November 2017 um 02:03 > geschrieben: > > > Hi, > > As it usually happens when there is a fair amount of HW IP block re-use, > competing implementations show up. In that case the BCM2835 HWRNG driver and > the BCM63xx RNG driver

Re: [PATCH 0/2] hwrng: iproc-rng200: Add support for BCM7278

2017-11-02 Thread Scott Branden
Patch series looks fine. On 17-11-01 04:20 PM, Florian Fainelli wrote: Hi, This patch series adds support for the RNG200 block found on the BCM7278 SoC. This requires us to update the compatible string (and associated binding document) as well as the Kconfig option to make that driver

Re: [Part2 PATCH v6 00/38] x86: Secure Encrypted Virtualization (AMD)

2017-11-02 Thread Brijesh Singh
Hi Herbert, On 10/24/2017 07:14 AM, Brijesh Singh wrote: Hi Herbert and Paolo, Since the PSP patches touches both the CCP and KVM driver, hence I was wondering if you guys have any thought on how PSP patches will be merged? I am talking about Patch 9 to 20 from this series. I have

[PATCH v2 3/3] staging: ccree: remove dead code

2017-11-02 Thread Gilad Ben-Yossef
The inflight_counter field is updated in a single location and never used. Remove it. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 4 drivers/staging/ccree/ssi_driver.h | 1 - 2 files changed, 5 deletions(-) diff --git

[PATCH v2 1/3] staging: ccree: copy IV to DMAable memory

2017-11-02 Thread Gilad Ben-Yossef
We are being passed an IV buffer from unknown origin, which may be stack allocated and thus not safe for DMA. Allocate a DMA safe buffer for the IV and use that instead. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 20 ++--

[PATCH v2 0/3] staging: ccree: Fixes and cleanups

2017-11-02 Thread Gilad Ben-Yossef
Fixes and cleanups for 4.15 Changes from v1: - Move DMA mask code to before turning on clocks, based on feedback from Dan Carpenter. - Add missing kmalloc success check, as spotted by Dan Carpenter. Gilad Ben-Yossef (3): staging: ccree: copy IV to DMAable memory staging: ccree: handle

[PATCH v2 2/3] staging: ccree: handle limiting of DMA masks

2017-11-02 Thread Gilad Ben-Yossef
Properly handle limiting of DMA masks based on device and bus capabilities. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_driver.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 2/4] crypto: dh - don't permit 'p' to be 0

2017-11-02 Thread Tudor Ambarus
Hi, Eric, On 11/02/2017 12:25 AM, Eric Biggers wrote: If 'p' is 0 for the software Diffie-Hellman implementation, then dh_max_size() returns 0. dh_set_secret() returns -EINVAL if p_len < 1536, see dh_check_params_length(). What am I missing? Cheers, ta

Re: [PATCH RESEND 4/4] dma: caam: add dma memcpy driver

2017-11-02 Thread kbuild test robot
-ci/linux/commits/Horia-Geant/add-CAAM-DMA-memcpy-driver/20171102-081734 base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705 reproduce: wget

Re: [PATCH 1/4] crypto: dh - fix double free of ctx->p

2017-11-02 Thread Tudor Ambarus
Hi, Eric, On 11/02/2017 12:25 AM, Eric Biggers wrote: When setting the secret with the software Diffie-Hellman implementation, if allocating 'g' failed (e.g. if it was longer than MAX_EXTERN_MPI_BITS), then 'p' was freed twice: once immediately, and once later when the crypto_kpp tfm was

Re: [PATCH] crypto: ccm - preserve the IV buffer

2017-11-02 Thread Tudor Ambarus
On 10/31/2017 04:42 PM, Romain Izard wrote: The IV buffer used during CCM operations is used twice, during both the hashing step and the ciphering step. When using a hardware accelerator that updates the contents of the IV buffer at the end of ciphering operations, the value will be modified.

[PATCH] crypto: ecdh - remove empty exit()

2017-11-02 Thread Tudor Ambarus
Pointer members of an object with static storage duration, if not explicitly initialized, will be initialized to a NULL pointer. The crypto API checks if this pointer is not NULL before using it, we are safe to remove the function. Signed-off-by: Tudor Ambarus ---

[v3 PATCH 2/3] crypto: atmel-aes/tdes - remove empty functions

2017-11-02 Thread Tudor Ambarus
Pointer members of an object with static storage duration, if not explicitly initialized, will be initialized to a NULL pointer. The crypto API checks if these pointers are not NULL before using them, therefore we can safely remove these empty functions. Signed-off-by: Tudor Ambarus