Re: [PATCH] crypto: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-19 Thread Herbert Xu
On Mon, Mar 19, 2007 at 07:55:08PM -0400, J. Bruce Fields wrote: > In the loop in scatterwalk_copychunks(), if walk->offset is zero, > then scatterwalk_pagedone rounds that up to the nearest page boundary: > > walk->offset += PAGE_SIZE - 1; > walk->offset &= PAGE_MASK;

[PATCH] crypto: scatterwalk_copychunks() fails to advance through scatterlist

2007-03-19 Thread J. Bruce Fields
In the loop in scatterwalk_copychunks(), if walk->offset is zero, then scatterwalk_pagedone rounds that up to the nearest page boundary: walk->offset += PAGE_SIZE - 1; walk->offset &= PAGE_MASK; which is a no-op in this case, so we don't advance to the next element

Re: Problem with key sizes

2007-03-19 Thread Sebastian Siewior
* Jan Glauber | 2007-03-19 15:25:39 [+0100]: >Having fall back support for unsupported parts of an algorithm sounds like >the right thing to me. In include/linux/crypto.h I found: > >/* > * Set this bit if and only if the algorithm requires another algorithm of > * the same type to handle corner

Re: Problem with key sizes

2007-03-19 Thread Jan Glauber
On Sat, 2007-03-17 at 21:28 +0100, Sebastian Siewior wrote: > * Herbert Xu | 2007-03-17 15:12:17 [+1100]: > > >What exactly is the aes-special algorithm and where can I find a copy? > The only difference between -special and -generic is the limited key > size. It was just an example. > > >Yes key