Re: HMAC regression

2009-05-28 Thread Herbert Xu
On Fri, May 29, 2009 at 04:19:31PM +1000, Herbert Xu wrote: > > Here's a patch to detect this for future reference. > > commit dfddf5dbe683cfdeb84bd218a1f819c09f5ea44a > Author: Herbert Xu > Date: Fri May 29 16:05:42 2009 +1000 > > crypto: testmgr - Check all test vector lengths I also n

Re: HMAC regression

2009-05-28 Thread Herbert Xu
On Thu, May 28, 2009 at 05:09:08PM +0200, Martin Willi wrote: > > Switching the hash implementations to the new shash API introduced a > regression. HMACs are created incorrectly if the data is scattered over > multiple pages, resulting in very unreliable IPsec tunnels. What are the symptoms? >

HMAC regression

2009-05-28 Thread Martin Willi
Hi, Switching the hash implementations to the new shash API introduced a regression. HMACs are created incorrectly if the data is scattered over multiple pages, resulting in very unreliable IPsec tunnels. The appended patch adds a silly hmac(sha1) test vector larger than a 4KB page and fails on c