Re: [BUGFIX for .32] crypto, gcm, fix another complete call in complete fuction

2009-11-03 Thread Huang Ying
On Tue, 2009-11-03 at 23:53 +0800, Herbert Xu wrote: > On Tue, Nov 03, 2009 at 10:40:17AM +0800, Huang Ying wrote: > > The flow of the complete function (xxx_done) in gcm.c is as follow: > > > > void complete(struct crypto_async_request *areq, int err) > > { > > if (!err) { > > er

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-03 Thread H. Peter Anvin
On 11/03/2009 01:03 AM, Ingo Molnar wrote: >> >> .macro xmm_num opd xmm >> .ifc \xmm,%xmm0 >> \opd = 0 >> .endif >> .ifc \xmm,%xmm1 >> \opd = 1 >> .endif >> .ifc \xmm,%xmm2 >> \opd = 2 >> .endif >> .ifc \xmm,%xmm3 >> \opd = 3 >> .endif >> .ifc \xmm,%xmm4 >> \opd = 4 >> .endif >> .ifc \xmm,%xmm5 >>

Re: [BUGFIX for .32] crypto, gcm, fix another complete call in complete fuction

2009-11-03 Thread Herbert Xu
On Tue, Nov 03, 2009 at 10:40:17AM +0800, Huang Ying wrote: > The flow of the complete function (xxx_done) in gcm.c is as follow: > > void complete(struct crypto_async_request *areq, int err) > { > if (!err) { > err = async_next_step(); > if (err == -EINPROGRESS |

Re: [PATCH] crypto: padlock-aes: Use the correct mask when checking whether copying is required

2009-11-03 Thread Herbert Xu
On Mon, Nov 02, 2009 at 05:26:50PM -0500, Chuck Ebbert wrote: > crypto: padlock-aes: Use the correct mask when checking whether copying is > required > > Masking with PAGE_SIZE is just wrong... > > Signed-off-by: Chuck Ebbert Applied to crypto-2.6. Thanks Chuck! -- Visit Openswan at http://w

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-03 Thread Herbert Xu
On Mon, Nov 02, 2009 at 04:46:04PM +0100, Ingo Molnar wrote: > > Yeah. Or just a single block of: > > > #ifndef __ASSEMBLY__ > ... > #endif /* __ASSEMBLY__ */ > > around the C bits - anything outside that is good for assembly as well. OK I'll throw this into cryptodev: commit 3b0d65969

Re: [PATCH -v4] crypto: Add PCLMULQDQ accelerated GHASH implementation

2009-11-03 Thread Ingo Molnar
* Huang Ying wrote: > On Mon, 2009-11-02 at 22:32 +0800, Ingo Molnar wrote: > > * Herbert Xu wrote: > > > > > On Mon, Nov 02, 2009 at 08:50:39AM +0100, Ingo Molnar wrote: > > > > > > > > A cleanup request: mind creating two macros for this PSHUFB MMX/SSE > > > > instruction in arch/x86/incl