Re: [GIT PULL] Asymmetric keys and module signing

2012-09-27 Thread Rusty Russell
Mimi Zohar writes: > On Wed, 2012-09-26 at 13:16 +0930, Rusty Russell wrote: >> David Howells writes: >> > The module signing patches provide: >> > >> > - Some fixes to Rusty's patch. Also an additional patch to extend the >> > policy >> >handling for modules signed with an unknown key an

Re: [GIT PULL] Asymmetric keys and module signing

2012-09-27 Thread Geert Uytterhoeven
On Wed, Sep 26, 2012 at 5:46 AM, Rusty Russell wrote: > You previously wrote: >> You can't compare them that easily. One has a FIPS-mode panic and the other >> doesn't. Do we want to panic if we reject an unsigned module in enforcing >> mode when we're in FIPS mode? > > It's a line ball, but I t

[PATCH 2/2] modules: don't call eu-strip if it doesn't exist.

2012-09-27 Thread Rusty Russell
Signed-off-by: Rusty Russell diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index 90b1bb1..2a4d1a1 100644 --- a/scripts/Makefile.modpost +++ b/scripts/Makefile.modpost @@ -165,11 +165,13 @@ endif # We strip the module as best we can - note that using both strip and eu-strip

[PATCH 1/2] modsign: don't use bashism in sh scripts.

2012-09-27 Thread Rusty Russell
Signed-off-by: Rusty Russell diff --git a/scripts/sign-file b/scripts/sign-file index 1a472bb..e58e34e 100644 --- a/scripts/sign-file +++ b/scripts/sign-file @@ -10,7 +10,7 @@ scripts=`dirname $0` CONFIG_MODULE_SIG_SHA512=y if [ -r .config ] then -source ./.config +. ./.config fi k

Re: [GIT PULL] Asymmetric keys and module signing

2012-09-27 Thread Rusty Russell
David Howells writes: > Hi Rusty, > > Could you pull my tree? > > David > --- > > The following changes since commit eeea3ac912207dcf759b95b2b4c36f96bce583bf: > > Merge tag 'fixes-for-linus' of > git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2012-09-06 > 10:23:58 -0700) > > are a

Re: [GIT PULL] Asymmetric keys and module signing

2012-09-27 Thread Rusty Russell
David Howells writes: > Hi Rusty, > > Could you pull my tree? And after those three fixes, I still get all fail: [3.361036] Request for unknown module key 'Magrathea: Glacier signing key: 6 e03943da0f3b015ba6ed7f5e0cac4fe48680994' err -11 rusty@rusty-x201:~/devel/kernel/linux (tmp-merge)$

[PATCH] crypto: convert to use be16_add_cpu()

2012-09-27 Thread Wei Yongjun
From: Wei Yongjun Convert cpu_to_be16(be16_to_cpu(E1) + E2) to use be16_add_cpu(). dpatch engine is used to auto generate this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun --- drivers/crypto/talitos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a

Re: [PATCH 0/3 v2] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

2012-09-27 Thread H. Peter Anvin
On 09/27/2012 03:44 PM, Tim Chen wrote: Version 2 This version of the patch series fixes compilation errors for 32 bit x86 targets. Version 1 This patch series optimized CRC32C calculations with PCLMULQDQ instruction for crc32c-intel module. It speeds up the original implementation by 1.6x for

[PATCH 3/3 v2] Added speed test in tcrypt for crc32c

2012-09-27 Thread Tim Chen
This patch adds a test case in tcrypt to perform speed test for crc32c checksum calculation. Signed-off-by: Tim Chen --- crypto/tcrypt.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 581081d..6deb77f 100644 --- a/crypto/tcrypt

[PATCH 1/3 v2] Rename crc32c-intel.c to crc32c-intel_glue.c

2012-09-27 Thread Tim Chen
This patch renames the crc32c-intel.c file to crc32c-intel_glue.c file in preparation for linking with the new crc32c-pcl-intel-asm.S file, which contains optimized crc32c calculation based on PCLMULQDQ instruction. Signed-off-by: Tim Chen --- arch/x86/crypto/Makefile |

[PATCH 0/3 v2] Optimize CRC32C calculation using PCLMULQDQ in crc32c-intel module

2012-09-27 Thread Tim Chen
Version 2 This version of the patch series fixes compilation errors for 32 bit x86 targets. Version 1 This patch series optimized CRC32C calculations with PCLMULQDQ instruction for crc32c-intel module. It speeds up the original implementation by 1.6x for 1K buffer and by 3x for buffer 4k or more.

[PATCH 2/3 v2] Optimize CRC32C calculation with PCLMULQDQ instruction

2012-09-27 Thread Tim Chen
This patch adds the crc_pcl function that calculates CRC32C checksum using the PCLMULQDQ instruction on processors that support this feature. This will provide speedup over using CRC32 instruction only. The usage of PCLMULQDQ necessitate the invocation of kernel_fpu_begin and kernel_fpu_end and inc

Re: [PATCH 0/3] crypto: talitos fixes for 3.6-rc7

2012-09-27 Thread Herbert Xu
On Thu, Sep 27, 2012 at 11:42:15AM +0300, Horia Geanta wrote: > On 9/27/2012 11:14 AM, Herbert Xu wrote: > >On Thu, Sep 27, 2012 at 11:01:50AM +0300, Horia Geanta wrote: > >> > >>Again, this patch (e46e9a) is not the culprit, it merely exposes the > >>deficiencies in the talitos driver. > >>AFAICT,

Re: [GIT PULL] Asymmetric keys and module signing

2012-09-27 Thread David Howells
Hi Rusty, Could you pull my tree? David --- The following changes since commit eeea3ac912207dcf759b95b2b4c36f96bce583bf: Merge tag 'fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2012-09-06 10:23:58 -0700) are available in the git repository at: git://

Re: [PATCH 0/3] crypto: talitos fixes for 3.6-rc7

2012-09-27 Thread Horia Geanta
On 9/27/2012 11:14 AM, Herbert Xu wrote: On Thu, Sep 27, 2012 at 11:01:50AM +0300, Horia Geanta wrote: Again, this patch (e46e9a) is not the culprit, it merely exposes the deficiencies in the talitos driver. AFAICT, these cases (zero assoc data, noncontiguous iv and assoc data) have never been

Re: [PATCH 0/3] crypto: talitos fixes for 3.6-rc7

2012-09-27 Thread Herbert Xu
On Thu, Sep 27, 2012 at 11:01:50AM +0300, Horia Geanta wrote: > > Again, this patch (e46e9a) is not the culprit, it merely exposes the > deficiencies in the talitos driver. > AFAICT, these cases (zero assoc data, noncontiguous iv and assoc > data) have never been handled correctly in the driver. O

Re: [PATCH 0/3] crypto: talitos fixes for 3.6-rc7

2012-09-27 Thread Horia Geanta
On 9/27/2012 8:25 AM, Herbert Xu wrote: On Wed, Sep 19, 2012 at 09:53:37PM +0300, Horia Geanta wrote: Hi Herbert, I know these patches come late and might not be included in 3.6. But two of them are already sitting in cryptodev tree for some time. (Don't know where my head was :/). I'm hesita