Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-13 Thread Herbert Xu
On Fri, Sep 13, 2013 at 10:12:36AM -0600, Stephen Warren wrote: > > I'm curious which kernel version it was merged for; it'd be nice to > remove tegra_chip_uid() from the Tegra tree now since it's unused, but > that obviously requires this patch in the history. This is in cryptodev which will be p

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-13 Thread Stephen Warren
On 09/13/2013 06:23 AM, Herbert Xu wrote: > On Mon, Sep 09, 2013 at 10:02:04AM -0600, Stephen Warren wrote: >> On 09/09/2013 01:35 AM, Linus Walleij wrote: >>> The way I read the Tegra AES RNG is that it has a homebrew >>> algorithm for initializing the 128bit RNG using timespec and >>> the unique

[RFC PATCH 2/2] arm64: add support for AES using ARMv8 Crypto Extensions

2013-09-13 Thread Ard Biesheuvel
This adds ARMv8 Crypto Extensions based implemenations of AES in CBC, CTR and XTS mode. Signed-off-by: Ard Biesheuvel --- arch/arm64/Makefile | 8 +- arch/arm64/crypto/Makefile | 12 ++ arch/arm64/crypto/aesce-cbc.S| 58 +++ arch/arm64/crypto/aesce-ctr.S| 83 +

[RFC PATCH 0/2] AES in CBC/CTR/XTS modes using ARMv8 Crypto Extensions

2013-09-13 Thread Ard Biesheuvel
Hello all, This is a first attempt at getting something implemented that uses the ARMv8 crypto extensions for performing AES encryption in CBC, CTR and XTS modes. The first patch moves the ablk helper code out of arch/x86. This code is used to automagically instantiate async blkciphers based on t

[RFC PATCH 1/2] crypto: move ablk_helper out of arch/x86

2013-09-13 Thread Ard Biesheuvel
Move the ablk_helper code out of arch/x86 so it can be reused by other architectures. The only x86 specific dependency was a call to irq_fpu_usable(), this has been factored out and moved to crypto/ablk_helper_x86.c Signed-off-by: Ard Biesheuvel --- arch/x86/crypto/Makefile |

Re: Crypto Fixes for 3.12

2013-09-13 Thread Herbert Xu
On Fri, Sep 13, 2013 at 07:22:55AM -0700, Linus Torvalds wrote: > On Fri, Sep 13, 2013 at 4:30 AM, Herbert Xu > wrote: > > > > Herbert Xu (2): > > crypto: api - Fix race condition in larval lookup > > crypto: crct10dif - Add fallback for broken initrds > > > > crypto/Makefile

Re: Crypto Fixes for 3.12

2013-09-13 Thread Linus Torvalds
On Fri, Sep 13, 2013 at 4:30 AM, Herbert Xu wrote: > > Herbert Xu (2): > crypto: api - Fix race condition in larval lookup > crypto: crct10dif - Add fallback for broken initrds > > crypto/Makefile |2 +- > crypto/api.c|

Re: [3.12-rc1] Dependency on module-init-tools >= 3.11 ?

2013-09-13 Thread Tetsuo Handa
Waiman Long wrote: > I would like to report that I also have the same boot problem on a > RHEL6.4 box with the crypto patch. My workaround is to force kernel > build to have the crc_t10dif code built-in by changing the config file: > > 4889c4889 > < CONFIG_CRYPTO_CRCT10DIF=m > --- > > CONFIG_CR

Re: [PATCH] crypto: tegra: use kernel entropy instead of ad-hoc

2013-09-13 Thread Herbert Xu
On Mon, Sep 09, 2013 at 10:02:04AM -0600, Stephen Warren wrote: > On 09/09/2013 01:35 AM, Linus Walleij wrote: > > The way I read the Tegra AES RNG is that it has a homebrew > > algorithm for initializing the 128bit RNG using timespec and > > the unique chip ID. This looks like reinventing the (squ

Re: [PATCH] crypto: x86: restore avx2_supported check

2013-09-13 Thread Herbert Xu
On Tue, Sep 03, 2013 at 04:49:47PM +0300, Jussi Kivilinna wrote: > Commit 3d387ef08c4 (Revert "crypto: blowfish - add AVX2/x86_64 implementation > of blowfish cipher") reverted too much as it removed the 'assembler supports > AVX2' check and therefore disabled remaining AVX2 implementations of Came

Re: [PATCH 0/7] crypto: caam - RNG4 patches and fixes

2013-09-13 Thread Herbert Xu
On Mon, Sep 09, 2013 at 06:56:27PM +0300, Alex Porosanu wrote: > This patch series attempts to fix some identified issues and add some new > functionalities regarding the RNG4 block in the CAAM driver: > o if the CAAM driver isn't properly instantiated (e.g. RNG4 initialization > fails), then the

Re: [PATCH] crypto: sha256_ssse3 - use correct module alias for sha224

2013-09-13 Thread Herbert Xu
On Tue, Sep 03, 2013 at 04:26:49PM +0300, Jussi Kivilinna wrote: > Commit a710f761f (crypto: sha256_ssse3 - add sha224 support) attempted to add > MODULE_ALIAS for SHA-224, but it ended up being "sha384", probably because > mix-up with previous commit 340991e30 (crypto: sha512_ssse3 - add sha384 >

[PATCH 2/3] crypto: omap-aes - Staticize local symbols

2013-09-13 Thread Sachin Kamat
Local symbols used only in this file are made static. Signed-off-by: Sachin Kamat Cc: Dmitry Kasatkin --- drivers/crypto/omap-aes.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index ce791c2..e1e58d0 100644 ---

[PATCH 1/3] crypto: mv_cesa - Staticize local symbols

2013-09-13 Thread Sachin Kamat
Local symbols used only in this file are made static. Signed-off-by: Sachin Kamat Cc: Sebastian Andrzej Siewior --- drivers/crypto/mv_cesa.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c index 3374a3e..f9b956

[PATCH 3/3] crypto: tegra-aes - Staticize tegra_aes_cra_exit

2013-09-13 Thread Sachin Kamat
'tegra_aes_cra_exit' is used only in this file. Signed-off-by: Sachin Kamat Cc: Stephen Warren --- drivers/crypto/tegra-aes.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c index 2d58da9..4f5f715 100644 --- a/driver

Crypto Fixes for 3.12

2013-09-13 Thread Herbert Xu
Hi Linus: This push fixes a 7+ year race condition in the crypto API that causes sporadic crashes when multiple threads load the same algorithm. It also fixes the crct10dif algorithm again to prevent boot failures on systems where the initramfs tool ignores module softdeps. Please pull from git

Re: question about rfc404 support.

2013-09-13 Thread Herbert Xu
On Wed, Sep 11, 2013 at 07:16:13PM +, Hsieh, Che-Min wrote: > Herbert: > > Can you confirm the following. Thanks. > > Rfc2404 - The Use of HMAC-SHA-1-96 within ESP and AH > > For the support, I can't find any algorithm to be specified in the .craname > of ahash_alg for Rfc2404. > >

Re: [PATCH] crypto_memcmp: add constant-time memcmp

2013-09-13 Thread Daniel Borkmann
On 09/11/2013 07:20 PM, James Yonan wrote: On 10/09/2013 12:57, Daniel Borkmann wrote: There was a similar patch posted some time ago [1] on lkml, where Florian (CC) made a good point in [2] that future compiler optimizations could short circuit on this. This issue should probably be addressed i