Fan Du fan...@windriver.com wrote:
Hi,
I recently bump into a issue, ike daemon got interrupted(EINTR),
after looking at the code, it seems there are places in crypto code
where returning EINTR when current tasks has signal pending.
For example:
crypto_alloc_base and crypto_alloc_tfm
Hi Herbert
On 2014年04月17日 15:44, Herbert Xu wrote:
Fan Dufan...@windriver.com wrote:
Hi,
I recently bump into a issue, ike daemon got interrupted(EINTR),
after looking at the code, it seems there are places in crypto code
where returning EINTR when current tasks has signal pending.
For
On Thu, Apr 17, 2014 at 05:20:34PM +0800, Fan Du wrote:
The signal checking is only to bail out from the infinite loop, it shouldn't
override original err code -EAGAIN with -EINTR.
With -EAGAIN, user space app can try again, what do you think?
EAGAIN makes no sense when we bail out due to
On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote:
Commit 128ea04a9885(lto: Make asmlinkage __visible) restricts
asmlinkage to externally_visible, this causes compilation warnings:
arch/x86/crypto/sha256_ssse3_glue.c:56:1:
warning: ‘externally_visible’ attribute have
On 04/17/2014 08:28 AM, Marek Vasut wrote:
On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote:
Commit 128ea04a9885(lto: Make asmlinkage __visible) restricts
asmlinkage to externally_visible, this causes compilation warnings:
arch/x86/crypto/sha256_ssse3_glue.c:56:1:
On Thu, Apr 17, 2014 at 09:49:56PM -0700, H. Peter Anvin wrote:
On 04/17/2014 08:28 AM, Marek Vasut wrote:
On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote:
Commit 128ea04a9885(lto: Make asmlinkage __visible) restricts
asmlinkage to externally_visible, this causes compilation
On 04/17/2014 09:58 PM, Herbert Xu wrote:
It doesn't make sense, sorry. The right thing to drop here is not
asmlinkage, it is static: this is an external declaration.
It's a function pointer that's static, not the function that
it's pointing to.
{facepalm} Right, function *pointer*.
