Re: [PATCH 00/17] Multiple changes to crypto/ansi_cprng.c

2014-12-05 Thread Neil Horman
On Wed, Dec 03, 2014 at 03:27:53PM -0500, George Spelvin wrote: So, generally speaking I'm ok with most of this I think, One open issue... I thought you had said that the non-determinsitic version was not in the current X9.31 and I had the impression that it wasn't wanted. I've got

Re: [PATCH] staging: crypto: fixed style errors in ablkcipher.c

2014-12-05 Thread Jason Cooper
Joshua, Your subject, [PATCH] staging: crypto: fixed style errors in ablkcipher.c is misleading. 'staging' is a location in the tree, drivers/staging/, not a separate git tree. So your subject for this series should have been [PATCH] crypto: ablkcipher: Cleanup minor checkpatch error. More

Re: [PATCH] staging: crypto: fixed style error in aead.c

2014-12-05 Thread Jason Cooper
Joshua, On Fri, Dec 05, 2014 at 02:24:44PM +0900, Joshua I. James wrote: From: Joshua I. James jos...@cybercrimetech.com Fixed style error identified by checkpatch. ERROR: do not use assignment in if condition + if ((err = crypto_register_instance(tmpl, inst))) { Short comment

Re: [PATCH] staging: crypto: fixed style error in af_alg.c

2014-12-05 Thread Jason Cooper
On Fri, Dec 05, 2014 at 02:38:40PM +0900, Joshua I. James wrote: From: Joshua I. James jos...@cybercrimetech.com Fixed style error identified by checkpatch. ERROR: space required before the open parenthesis '(' + switch(cmsg-cmsg_type) { Signed-off-by: Joshua I. James

Re: [PATCH] staging: crypto: fixed style error in ahash.c

2014-12-05 Thread Jason Cooper
On Fri, Dec 05, 2014 at 02:44:54PM +0900, Joshua I. James wrote: From: Joshua I. James jos...@cybercrimetech.com Fixed style error identified by checkpatch. WARNING: Missing a blank line after declarations + unsigned int unaligned = alignmask + 1 - (offset alignmask); +

Re: [PATCH v4 2/5] crypto: AF_ALG: add AEAD support

2014-12-05 Thread Herbert Xu
On Wed, Dec 03, 2014 at 08:57:24PM +0100, Stephan Mueller wrote: + if (ctx-merge) { + sg = sgl-sg + sgl-cur - 1; + len = min_t(unsigned long, len, + PAGE_SIZE - sg-offset - sg-length); + + err =

Re: [PATCH v4 4/5] crypto: AF_ALG: add random number generator support

2014-12-05 Thread Herbert Xu
On Wed, Dec 03, 2014 at 08:59:01PM +0100, Stephan Mueller wrote: +static int rng_recvmsg(struct kiocb *unused, struct socket *sock, +struct msghdr *msg, size_t len, int flags) +{ + struct sock *sk = sock-sk; + struct alg_sock *ask = alg_sk(sk); + struct

Re: [PATCH v4 1/5] crypto: AF_ALG: add user space interface for AEAD

2014-12-05 Thread Herbert Xu
On Wed, Dec 03, 2014 at 08:55:42PM +0100, Stephan Mueller wrote: AEAD requires the caller to specify the following information separate from the data stream. This information allows the AEAD interface handler to identify the AAD, ciphertext/plaintext and the authentication tag: *

Re: [PATCH v2 0/2] crypto: qat - Fix for invalid dma mapping and numa

2014-12-05 Thread Tadeusz Struk
On 10/13/2014 06:24 PM, Tadeusz Struk wrote: Hi, These two patches fix invalid (zero length) dma mapping and enforce numa configuration for maximum performance. Change log: v2 - Removed numa node calculation based bus number and use predefined functions instead. Signed-off-by: Tadeusz

[RESEND][PATCH] crypto: drbg - panic on continuous self test error

2014-12-05 Thread Stephan Mueller
This patch adds a panic if the FIPS 140-2 self test error failed. Note, that entire code is only executed with fips_enabled (i.e. when the kernel is booted with fips=1. It is therefore not executed for 99.9% of all user base. As mathematically such failure cannot occur, this panic should never be

Re: [PATCH v4 2/5] crypto: AF_ALG: add AEAD support

2014-12-05 Thread Stephan Mueller
Am Freitag, 5. Dezember 2014, 23:46:06 schrieb Herbert Xu: Hi Herbert, On Wed, Dec 03, 2014 at 08:57:24PM +0100, Stephan Mueller wrote: + if (ctx-merge) { + sg = sgl-sg + sgl-cur - 1; + len = min_t(unsigned long, len, + PAGE_SIZE - sg-offset -

Re: [PATCH v4 4/5] crypto: AF_ALG: add random number generator support

2014-12-05 Thread Stephan Mueller
Am Freitag, 5. Dezember 2014, 23:53:59 schrieb Herbert Xu: Hi Herbert, On Wed, Dec 03, 2014 at 08:59:01PM +0100, Stephan Mueller wrote: +static int rng_recvmsg(struct kiocb *unused, struct socket *sock, + struct msghdr *msg, size_t len, int flags) +{ + struct sock *sk

Re: [PATCH v2 0/2] crypto: qat - Fix for invalid dma mapping and numa

2014-12-05 Thread Herbert Xu
On Fri, Dec 05, 2014 at 10:34:33AM -0800, Tadeusz Struk wrote: Looks like these two are not in cryptodev-2.6 yet. Do you plan to merge it sometime soon or should I generate incremental patches based on crypto-2.6 instead of cryptodev-2.6 Just generate them on top of all your existing patches.