The qce driver use two dma_map_sg path according to SG are chained
or not.
Since dma_map_sg can handle both case, clean the code with all
references to sg chained.
Thus removing qce_mapsg, qce_unmapsg and qce_countsg functions.
Signed-off-by: LABBE Corentin
---
drivers/crypto/qce/ablkcipher.c |
Setkey function has been split into set_priv_key and set_pub_key.
Akcipher requests takes sgl for src and dst instead of void *.
Users of the API i.e. two existing RSA implementation and
test mgr code have been updated accordingly.
Signed-off-by: Tadeusz Struk
---
crypto/Makefile
This series updates the asymmetric key API.
The changes include
- setkey function has been split into set_priv_key and set_pub_key.
- akcipher requests takes sgl for src and dst instead of void *.
Users of the API i.e. two existing RSA implementation and
test mgr code have been updated accordingl
Add mpi_read_raw_from_sgl and mpi_write_to_sgl helpers.
Signed-off-by: Tadeusz Struk
---
include/linux/mpi.h |4 +
lib/mpi/mpicoder.c | 191 +++
2 files changed, 195 insertions(+)
diff --git a/include/linux/mpi.h b/include/linux/mpi.h
index
On Thu, Oct 01, 2015 at 09:09:54PM -0700, Tadeusz Struk wrote:
>
> This is used not only in rsa, but also in the new mpi sgl helpers.
> Should I drop all the params checking?
For a start the MPI helpers shouldn't be using sg_len as the length
that they are allowed to read or write. The length sho
On 10/01/2015 09:04 PM, Herbert Xu wrote:
>> I do use src_len for processing. The sg_len() is still useful for
>> > parameter checking to make sure that src_len <= sg_len(req->src)
> I don't see the point. We don't check that anywhere else in the
> crypto API. It's the caller's responsibility to
On Thu, Oct 01, 2015 at 08:40:26PM -0700, Tadeusz Struk wrote:
>
> I do use src_len for processing. The sg_len() is still useful for
> parameter checking to make sure that src_len <= sg_len(req->src)
I don't see the point. We don't check that anywhere else in the
crypto API. It's the caller's r
On 10/01/2015 08:20 PM, Herbert Xu wrote:
>> Changes in v4:
>> > - add back src_len and dst_len
> So why do you still use sg_len? The length of the SG list is
> irrelevant now that you have src_len/dst_len.
I do use src_len for processing. The sg_len() is still useful for
parameter checking to mak
On Thu, Oct 01, 2015 at 01:28:45PM -0700, Tadeusz Struk wrote:
>
> Changes in v4:
> - add back src_len and dst_len
So why do you still use sg_len? The length of the SG list is
irrelevant now that you have src_len/dst_len.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbe
Replace the usage of BUG_ON with WARN_ON and return an error.
Signed-off-by: Tom Lendacky
---
drivers/crypto/ccp/ccp-crypto-aes-cmac.c | 20 +-
drivers/crypto/ccp/ccp-crypto-main.c |6 +-
drivers/crypto/ccp/ccp-crypto-sha.c | 13
drivers/crypto/ccp/ccp-ops.c
The CCP is meant to be more of an offload engine than an accelerator
engine. To avoid any confusion, change references to accelerator to
offload.
Signed-off-by: Tom Lendacky
---
drivers/crypto/Kconfig |2 +-
drivers/crypto/ccp/Kconfig | 13 ++---
2 files changed, 7 insertions(+
The convention is to use the name of the module in the driver structures
that are used for registering the device. The CCP module is currently
using a descriptive name. Replace the descriptive name with module name.
Signed-off-by: Tom Lendacky
---
drivers/crypto/ccp/ccp-pci.c |2 +-
dri
The following patches are included in this driver update series:
- Remove the usage of BUG_ON and replace with WARN_ON and an error
return code
- Remove unused variable
- Change references to accelerator to offload
- Use the module name in the driver structure instead of a
descriptive name
T
With the creation of the device_dma_is_coherent API the "use_acpi" field
is no longer needed, so remove it.
Signed-off-by: Tom Lendacky
---
drivers/crypto/ccp/ccp-platform.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/crypto/ccp/ccp-platform.c
b/drivers/crypto/ccp/ccp-plat
Add mpi_read_raw_from_sgl and mpi_write_to_sgl helpers.
Signed-off-by: Tadeusz Struk
---
include/linux/mpi.h |4 +
lib/mpi/mpicoder.c | 194 +++
2 files changed, 198 insertions(+)
diff --git a/include/linux/mpi.h b/include/linux/mpi.h
index
Setkey function has been split into set_priv_key and set_pub_key.
Akcipher requests takes sgl for src and dst instead of void *.
Users of the API i.e. two existing RSA implementation and
test mgr code have been updated accordingly.
Signed-off-by: Tadeusz Struk
---
crypto/Makefile
This series updates the asymmetric key API.
The changes include
- setkey function has been split into set_priv_key and set_pub_key.
- akcipher requests takes sgl for src and dst instead of void *.
Users of the API i.e. two existing RSA implementation and
test mgr code have been updated accordingl
Add sg_len function which returns the total number of bytes in sg.
Signed-off-by: Tadeusz Struk
---
include/linux/scatterlist.h |1 +
lib/scatterlist.c | 20
2 files changed, 21 insertions(+)
diff --git a/include/linux/scatterlist.h b/include/linux/scatterli
On 10/01/2015 08:15 AM, Herbert Xu wrote:
> On Thu, Oct 01, 2015 at 07:52:32AM -0700, Tadeusz Struk wrote:
>> On 10/01/2015 06:45 AM, Herbert Xu wrote:
>>> On Tue, Sep 22, 2015 at 09:34:03AM -0700, Tadeusz Struk wrote:
struct akcipher_request {
struct crypto_async_request base;
>
On Thu, Oct 01, 2015 at 07:52:32AM -0700, Tadeusz Struk wrote:
> On 10/01/2015 06:45 AM, Herbert Xu wrote:
> > On Tue, Sep 22, 2015 at 09:34:03AM -0700, Tadeusz Struk wrote:
> >>
> >> struct akcipher_request {
> >>struct crypto_async_request base;
> >> - void *src;
> >> - void *dst;
> >> -
On 10/01/2015 06:45 AM, Herbert Xu wrote:
> On Tue, Sep 22, 2015 at 09:34:03AM -0700, Tadeusz Struk wrote:
>>
>> struct akcipher_request {
>> struct crypto_async_request base;
>> -void *src;
>> -void *dst;
>> -unsigned int src_len;
>> -unsigned int dst_len;
>> +struct scat
On Wed, Sep 30, 2015 at 05:38:39AM -0700, Tadeusz Struk wrote:
> Add support for ctr and xts encryption modes.
>
> Signed-off-by: Tadeusz Struk
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
On Wed, Sep 30, 2015 at 05:40:00AM -0700, Tadeusz Struk wrote:
> Remove unneeded variable val_indx.
> Issue found by a static analyzer.
>
> Reported-by: Giovanni Cabiddu
> Signed-off-by: Tadeusz Struk
Patch applied. Thanks!
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
On Sun, Sep 27, 2015 at 10:47:05PM +0800, Geliang Tang wrote:
> Fixes the following sparse warnings:
>
> crypto/skcipher.c:94:5:
> warning: symbol 'crypto_init_skcipher_ops_blkcipher'
> was not declared. Should it be static?
>
> crypto/skcipher.c:185:5:
> warning: symbol 'crypto_init_skciphe
On Fri, Sep 25, 2015 at 07:58:10AM +0200, Stephan Mueller wrote:
> Am Donnerstag, 24. September 2015, 18:24:35 schrieb John Haxby:
>
> Hi John,
>
> >No authenc() ciphers are FIPS approved, nor is ecb(des).
> >After the end of 2015, ansi_cprng will also be non-approved.
> >
> >Signed-off-by: John
On Wed, Sep 23, 2015 at 01:55:24PM +0200, LABBE Corentin wrote:
>
> Hello
>
> Some drivers use two dma_map_sg path according to SG are chained or not.
> Since dma_map_sg can handle both case, this patch series clean all code
> with references to sg chained.
>
> Note that I could only compile tes
On Tue, Sep 22, 2015 at 11:57:47AM -0700, Tadeusz Struk wrote:
> Some code cleanups after crypto API changes:
> - Change qat_algs_unregister to a void function to keep it consistent
> with qat_asym_algs_unregister.
> - Remove empty functions qat_algs_init & qat_algs_exit.
>
> Signed-off-by: Tade
On Wed, Sep 23, 2015 at 01:55:26PM +0200, LABBE Corentin wrote:
> The qce driver use two dma_map_sg path according to SG are chained
> or not.
> Since dma_map_sg can handle both case, clean the code with all
> references to sg chained.
>
> Thus removing qce_mapsg, qce_unmapsg and qce_countsg funct
On Tue, Sep 22, 2015 at 09:34:03AM -0700, Tadeusz Struk wrote:
>
> struct akcipher_request {
> struct crypto_async_request base;
> - void *src;
> - void *dst;
> - unsigned int src_len;
> - unsigned int dst_len;
> + struct scatterlist *src;
> + struct scatterlist *dst;
Hi Lee, Herbert,
On 09/17/2015 03:45 PM, Lee Jones wrote:
Signed-off-by: Lee Jones
---
arch/arm/boot/dts/stih407-family.dtsi | 14 ++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/stih407-family.dtsi
b/arch/arm/boot/dts/stih407-family.dtsi
index 838b812..9452b
30 matches
Mail list logo