[PATCH v2] crypto: af_alg - Disallow bind/setkey/... after accept(2)

2015-12-29 Thread Herbert Xu
On Tue, Dec 29, 2015 at 07:36:14PM +0100, Dmitry Vyukov wrote: > Hello, > > On commit 8513342170278468bac126640a5d2d12ffbff106 > + crypto: algif_skcipher - Use new skcipher interface > + crypto: algif_skcipher - Require setkey before accept(2) > + crypto: af_alg - Disallow bind/setkey/... after ac

Re: crypto: use-after-free in alg_bind

2015-12-29 Thread Herbert Xu
On Tue, Dec 29, 2015 at 09:19:22PM +0100, Dmitry Vyukov wrote: > Hello, > > On commit 8513342170278468bac126640a5d2d12ffbff106 > + crypto: algif_skcipher - Use new skcipher interface > + crypto: algif_skcipher - Require setkey before accept(2) > + crypto: af_alg - Disallow bind/setkey/... after ac

crypto: use-after-free in alg_bind

2015-12-29 Thread Dmitry Vyukov
Hello, On commit 8513342170278468bac126640a5d2d12ffbff106 + crypto: algif_skcipher - Use new skcipher interface + crypto: algif_skcipher - Require setkey before accept(2) + crypto: af_alg - Disallow bind/setkey/... after accept(2) The following program causes use-after-free in alg_bind and later

crypto: deadlock in alg_setsockopt

2015-12-29 Thread Dmitry Vyukov
Hello, On commit 8513342170278468bac126640a5d2d12ffbff106 + crypto: algif_skcipher - Use new skcipher interface + crypto: algif_skcipher - Require setkey before accept(2) + crypto: af_alg - Disallow bind/setkey/... after accept(2) The following program creates an unkillable, deadlocked process:

Re: use-after-free in hash_sock_destruct

2015-12-29 Thread Dmitry Vyukov
On Tue, Dec 29, 2015 at 4:28 PM, Dmitry Vyukov wrote: > On Tue, Dec 29, 2015 at 3:40 PM, Herbert Xu > wrote: >> On Thu, Dec 17, 2015 at 01:59:50PM +0100, Dmitry Vyukov wrote: >>> >>> The following program causes use-after-free in hash_sock_destruct: >> >> This patch should fix the problem. AFAI

Re: use-after-free in hash_sock_destruct

2015-12-29 Thread Dmitry Vyukov
On Tue, Dec 29, 2015 at 3:40 PM, Herbert Xu wrote: > On Thu, Dec 17, 2015 at 01:59:50PM +0100, Dmitry Vyukov wrote: >> >> The following program causes use-after-free in hash_sock_destruct: > > This patch should fix the problem. AFAIK everything that you have > reported should now be fixed. If yo

Re: use-after-free in hash_sock_destruct

2015-12-29 Thread Herbert Xu
On Thu, Dec 17, 2015 at 01:59:50PM +0100, Dmitry Vyukov wrote: > > The following program causes use-after-free in hash_sock_destruct: This patch should fix the problem. AFAIK everything that you have reported should now be fixed. If you still have issues please resubmit them (and please cc me).

Re: [PATCH] crypto: hifn_795x, picoxcell - use ablkcipher_request_cast

2015-12-29 Thread Herbert Xu
On Mon, Dec 28, 2015 at 09:53:07PM +0800, Geliang Tang wrote: > Use ablkcipher_request_cast() instead of open-coding it. > > Signed-off-by: Geliang Tang Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To u

Re: [PATCH v2] crypto: algif_skcipher - Require setkey before accept(2)

2015-12-29 Thread Herbert Xu
Dmitry Vyukov wrote: > > My email client just followed instructions in your email. You've said > to Reply-to: syzkal...@googlegroups.com. I did not set this Reply-To header. It's most likely set by your broken Google Groups setup. So either you should start actually replying to my email address