Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread Tadeusz Struk
On 01/27/2016 02:29 PM, kbuild test robot wrote: > Hi Tadeusz, > > [auto build test ERROR on cryptodev/master] > [also build test ERROR on v4.5-rc1 next-20160127] > [if your patch is applied to the wrong git tree, please drop us a note to > help improving the system] >

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread kbuild test robot
Hi Tadeusz, [auto build test ERROR on cryptodev/master] [also build test ERROR on v4.5-rc1 next-20160127] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Tadeusz-Struk/crypto-af_alg-add-async

[PATCH] crypto: aead - move aead_request_cast helper to aead.h

2016-01-27 Thread Tadeusz Struk
Move the helper function to common header for everybody to use. Signed-off-by: Tadeusz Struk --- drivers/crypto/atmel-aes.c |6 -- include/crypto/aead.h |6 ++ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/crypto/atmel-aes.c

[PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread Tadeusz Struk
Following the async change for algif_skcipher this patch adds similar async read to algif_aead. changes in v2: - change internal data structures from fixed size arrays, limited to RSGL_MAX_ENTRIES, to linked list model with no artificial limitation. - use sock_kmalloc instead of kmalloc for

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Joonsoo Kim
Hello, Herbert. On Wed, Jan 27, 2016 at 04:09:26PM +0800, Herbert Xu wrote: > On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote: > > On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: > > > > > > The acomp is also SG-based, while scomp only accepts flat buffer. > > > > Right,

Re: [PATCH 1/3] crypto: skcipher - return the correct request to the user

2016-01-27 Thread Herbert Xu
On Wed, Jan 27, 2016 at 09:13:56AM -0800, Tadeusz Struk wrote: > > diff --git a/crypto/skcipher.c b/crypto/skcipher.c > index 69230e9..a9d54c0 100644 > --- a/crypto/skcipher.c > +++ b/crypto/skcipher.c > @@ -142,6 +142,15 @@ static int skcipher_setkey_ablkcipher(struct > crypto_skcipher *tfm, >

[cryptodev:master 54/61] net/sctp/sm_make_chunk.c:1688:1: warning: 'sctp_pack_cookie.isra.6' uses dynamic stack allocation

2016-01-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 2f313e029020f1fa5f58f38f48ff6988d67fc3c1 commit: 5821c769706561da81e9fcec4a6ca6dbbb2f30cb [54/61] sctp: Use shash config: s390-allyesconfig (attached as .config) reproduce: wget

Re: [PATCH] crypto: af_alg - add async support to algif_aead

2016-01-27 Thread Stephan Mueller
Am Mittwoch, 27. Januar 2016, 14:10:31 schrieb Tadeusz Struk: Hi Tadeusz, > Following the async change for algif_skcipher > this patch adds similar async read to algif_aead. > > changes in v2: > - change internal data structures from fixed size arrays, limited to > RSGL_MAX_ENTRIES, to linked

NEW ARRIVALS, CISCO,CPU's,Memory, LAPTOP AND AVAYA

2016-01-27 Thread Laison Computech Inc
Dear Sir/Madam, Clean tested working pulls CPUs and QTYs in stock. 115 X X5650 65 X E5410 75 X X5660 145 X E5530 100 X E5645 40 X X5680 75 X X5690 Brand new sealed IP phones and QTYs in stock. 55 x CP-7937G 77 x CP-7942G 54 x CP-7945G 75 x CP-7962G .. 45 x Avaya 9630

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Herbert Xu
On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote: > On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: > > > > The acomp is also SG-based, while scomp only accepts flat buffer. > > Right, but do we need a pointer-based scomp at all? IPComp would > certainly be better off with

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Li, Weigang
On 1/27/2016 4:09 PM, Herbert Xu wrote: On Wed, Jan 27, 2016 at 04:03:55PM +0800, Herbert Xu wrote: On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: The acomp is also SG-based, while scomp only accepts flat buffer. Right, but do we need a pointer-based scomp at all? IPComp would

Re: [PATCH 0/4] crypto: Key Derivation Function (SP800-108)

2016-01-27 Thread Stephan Mueller
Am Mittwoch, 27. Januar 2016, 15:35:41 schrieb Herbert Xu: Hi Herbert, >On Wed, Jan 27, 2016 at 08:33:00AM +0100, Stephan Mueller wrote: >> With the current development of EXT4 encryption we currently have the >> logic that the files are either open (read/writable) or closed (not >> accessible).

Re: [PATCH v2 04/10] crypto/compress: add asynchronous compression support

2016-01-27 Thread Herbert Xu
On Wed, Jan 27, 2016 at 03:59:05PM +0800, Li, Weigang wrote: > > The acomp is also SG-based, while scomp only accepts flat buffer. Right, but do we need a pointer-based scomp at all? IPComp would certainly be better off with an SG-based interface. Any other users of compression are presumably

[PATCH 3/3] crypto: algif_skcipher - increase private contex space for async request

2016-01-27 Thread Tadeusz Struk
The private context space that was allocated for the async request was too small. It accidentally worked fine (at least with the qat driver) because the qat driveri, by mistake, allocated too much. The problem started to show up since the qat driver issue has been fixed in commit: 7768fb2ee. We

[PATCH 1/3] crypto: skcipher - return the correct request to the user

2016-01-27 Thread Tadeusz Struk
A user of the skcipher api may have some private context associated with a request, like for instance the algif_skcipher does, so the api needs to return the original skcipher_request in the callback instead of the ablkcipher_request subtype. Cc: # 4.4.x- Signed-off-by:

[PATCH 0/3] crypto: afalg_skcipher - fixes after skcipher conversion

2016-01-27 Thread Tadeusz Struk
Hi Herbert, While testing the algif_aead async patch, I have rerun the async algif_skcipher tests and I have found some problems. There are three different issues around algif_skcipher and skcipher. Two are skcipher conversion related, and one is a bug in the algif_skcipher, not related to the

[PATCH 2/3] crypto: algif_skcipher - fix async callback after skcipher convertion

2016-01-27 Thread Tadeusz Struk
Before the skcipher conversion the async callback used the crypto_async_request directly as the ablkcipher_request. It wasn't quite correct, but it worked fine since the crypto_async_request *base was the first member of the ablkcipher_request struct. After the skcipher conversion it is not the

Re: [PATCH v2 1/2] crypto: sunxi - don't print confusing data

2016-01-27 Thread Corentin LABBE
Le 26/01/2016 14:44, Arnd Bergmann a écrit : > gcc correctly warns that the printk output contains a variable that > it thinks is not initialized in some cases: > > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c: In function 'sun4i_ss_cipher_poll': > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c:254:76:

Re: [PATCH 2/3] crypto: algif_skcipher - fix async callback after skcipher convertion

2016-01-27 Thread Herbert Xu
On Wed, Jan 27, 2016 at 09:14:01AM -0800, Tadeusz Struk wrote: > Before the skcipher conversion the async callback used the > crypto_async_request directly as the ablkcipher_request. > It wasn't quite correct, but it worked fine since the > crypto_async_request *base was the first member of the

Re: [Linux-ima-user] [RFC] i.MX6 CAAM blob generator for IMA/EVM initialization

2016-01-27 Thread Steffen Trumtrar
Hi! Mimi Zohar writes: > On Mon, 2015-11-09 at 16:18 +0100, Steffen Trumtrar wrote: >> Hi! >> >> The RFC Patch attached after this cover letter is mostly for illustration >> purposes, so please don't waste too much time reviewing the code ;-) >> >> For context I'll try to describe the problem

[PATCH v2 1/4] crypto x86/sha1_mb: Fix load failure

2016-01-27 Thread Rui Wang
modprobe sha1_mb fails with the following message: modprobe: ERROR: could not insert 'sha1_mb': No such device It is because it needs to set its statesize and implement its import() and export() interface. Signed-off-by: Rui Wang --- arch/x86/crypto/sha-mb/sha1_mb.c | 39

[PATCH v2 0/4] Fix sha1_mb failure and testing import()/export()

2016-01-27 Thread Rui Wang
Hi All, This patchset resulted from the failure when loading sha1_mb. It is because ahash drivers are now required to implement import() and export(). Also, now it seems beneficial to add a test case in testmgr to test import()/export(), thus: patch01 - patch03 fix the problems while loading

[PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export()

2016-01-27 Thread Rui Wang
Modify __test_hash() so that hash import/export can be tested from within the kernel by simply adding .partial = 1 to a hash algo's struct hash_testvec where .np > 1. v2: Leverage template[i].np as suggested by Tim Chen Signed-off-by: Rui Wang --- crypto/testmgr.c | 137

[PATCH v2 2/4] crypto: mcryptd - Fix load failure

2016-01-27 Thread Rui Wang
mcryptd_create_hash() fails by returning -EINVAL, causing any driver using mcryptd to fail to load. It is because it needs to set its statesize properly. Signed-off-by: Rui Wang --- crypto/mcryptd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/mcryptd.c

[PATCH v2 3/4] crypto: algif_hash - wait for crypto_ahash_init() to complete

2016-01-27 Thread Rui Wang
hash_sendmsg/sendpage() need to wait for the completion of crypto_ahash_init() otherwise it can cause panic. Signed-off-by: Rui Wang --- crypto/algif_hash.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c

[cryptodev:master 49/61] drivers/block/drbd/drbd_worker.c:304:1: warning: 'drbd_csum_ee' uses dynamic stack allocation

2016-01-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 2f313e029020f1fa5f58f38f48ff6988d67fc3c1 commit: 9534d67195118c39edf2ec0bb74e59993c4c0677 [49/61] drbd: Use shash and ahash config: s390-allyesconfig (attached as .config) reproduce: wget

Re: [PATCH] crypto : sha1-mb : Add missing args_digest offset

2016-01-27 Thread Herbert Xu
On Mon, Jan 25, 2016 at 04:46:09PM -0800, Megha Dey wrote: > From: Megha Dey > > The _args_digest is defined as _args+_digest, both of which are the first > members of 2 separate structures, effectively yielding _args_digest to have > a value of zero. Thus, no errors

Re: [PATCH v2 1/2] crypto: sunxi - don't print confusing data

2016-01-27 Thread Herbert Xu
On Tue, Jan 26, 2016 at 02:44:50PM +0100, Arnd Bergmann wrote: > gcc correctly warns that the printk output contains a variable that > it thinks is not initialized in some cases: > > drivers/crypto/sunxi-ss/sun4i-ss-cipher.c: In function 'sun4i_ss_cipher_poll': >

Re: [PATCH v2 01/10] crypto/compress: remove unused pcomp interface

2016-01-27 Thread Herbert Xu
On Tue, Jan 26, 2016 at 05:15:03PM +0900, Joonsoo Kim wrote: > It is unused now, so remove it. > > Signed-off-by: Joonsoo Kim Applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH v2 2/2] crypto: jitterentropy - always select CRYPTO_RNG

2016-01-27 Thread Herbert Xu
On Tue, Jan 26, 2016 at 02:47:10PM +0100, Arnd Bergmann wrote: > When building the jitterentropy driver by itself, we get a link error > when CRYPTO_RNG is not enabled as well: > > crypto/built-in.o: In function `jent_mod_init': > jitterentropy-kcapi.c:(.init.text+0x98): undefined reference to >

[cryptodev:master 50/61] drivers/nfc/s3fwrn5/firmware.c:501:1: warning: 's3fwrn5_fw_download' uses dynamic stack allocation

2016-01-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 2f313e029020f1fa5f58f38f48ff6988d67fc3c1 commit: 4a31340b36302d46207c6bb54d103d9fb568e916 [50/61] nfc: s3fwrn5: Use shash config: s390-allyesconfig (attached as .config) reproduce: wget

[cryptodev:master 53/61] fs/nfsd/nfs4recover.c:147:1: warning: 'nfs4_make_rec_clidname' uses dynamic stack allocation

2016-01-27 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 2f313e029020f1fa5f58f38f48ff6988d67fc3c1 commit: 1edb82d2021c7bae96509c03c4c5ef789f1e09a3 [53/61] nfsd: Use shash config: s390-allyesconfig (attached as .config) reproduce: wget