Re: [PATCH 5/5] hwrng: exynos - Disable runtime PM on driver unbind

2016-03-11 Thread Krzysztof Kozlowski
W dniu 11.03.2016 o 16:49, Krzysztof Kozlowski pisze: > Driver enabled runtime PM but did not revert this on removal. Re-binding > of a device triggered warning: > exynos-rng 10830400.rng: Unbalanced pm_runtime_enable! > > Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random

Re: [PATCH 1/5] hwrng: exynos - Hide PM functions with __maybe_unused

2016-03-11 Thread Krzysztof Kozlowski
2016-03-11 16:49 GMT+09:00 Krzysztof Kozlowski : > Replace ifdef with __maybe_unused to silence compiler warning on when > SUSPEND=n and PM=y: > > drivers/char/hw_random/exynos-rng.c:166:12: warning: ‘exynos_rng_suspend’ > defined but not used [-Wunused-function] >

Re: [PATCH] crypto: ccp - Use different flag vars for nested locks

2016-03-11 Thread Herbert Xu
On Fri, Mar 11, 2016 at 10:40:11AM -0600, Gary R Hook wrote: > > @@ -128,14 +128,14 @@ static struct ccp_device *ccp_get_device(void) >*/ > read_lock_irqsave(_unit_lock, flags); > if (!list_empty(_units)) { > - write_lock_irqsave(_rr_lock, flags); > +

Re: [PATCH] crypto: ccp - Use different flag vars for nested locks

2016-03-11 Thread Tom Lendacky
On 03/11/2016 10:40 AM, Gary R Hook wrote: > This patch fixes a coccinelle warning about reusing a flags > variable in nested lock acquisition. > > Signed-off-by: Gary R Hook Acked-by: Tom Lendacky > --- > drivers/crypto/ccp/ccp-dev.c |6 +++---

[PATCH v3] crypto: af_alg - add async support to algif_aead

2016-03-11 Thread Tadeusz Struk
Following the async change for algif_skcipher this patch adds similar async read to algif_aead. changes in v3: - add call to aead_reset_ctx directly from aead_put_sgl instead of calling them separatelly one after the other - remove wait from aead_sock_destruct function as it is not needed

[PATCH] crypto: ccp - Use different flag vars for nested locks

2016-03-11 Thread Gary R Hook
This patch fixes a coccinelle warning about reusing a flags variable in nested lock acquisition. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/ccp-dev.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/ccp/ccp-dev.c

Re: [PATCH v2 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-03-11 Thread Vladimir Zapolskiy
On 11.03.2016 16:06, Steffen Trumtrar wrote: > The driver is ported from Freescales Linux git and can be > found in the > > vendor/freescale/imx_2.6.35_maintain > > branch. > > According to that code, the RNGC is found on Freescales i.MX3/5 SoCs. > The i.MX2x actually has an RNGB, which

[cryptodev:master 112/119] drivers/crypto/ccp/ccp-dev.c:120:2-20: ERROR: nested lock+irqsave that reuses flags from line 118.

2016-03-11 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 34074205bb9f04b416efb3cbedcd90f418c86200 commit: 553d2374db0bb3f48bbd29bef7ba2a4d1a3f325d [112/119] crypto: ccp - Support for multiple CCPs coccinelle warnings: (new ones prefixed by >>) >>

[PATCH v2 2/3] ARM: i.MX25: add RNGC node to dtsi

2016-03-11 Thread Steffen Trumtrar
Add a devicetree entry for the Random Number Generator Version C (RNGC). Signed-off-by: Steffen Trumtrar --- Changes in v2: - remove interrupt-names from dtsi arch/arm/boot/dts/imx25.dtsi | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v2 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

2016-03-11 Thread Steffen Trumtrar
The driver is ported from Freescales Linux git and can be found in the vendor/freescale/imx_2.6.35_maintain branch. According to that code, the RNGC is found on Freescales i.MX3/5 SoCs. The i.MX2x actually has an RNGB, which has no driver implementation in Freescales kernel. However as

[PATCH v2 1/3] Documentation: devicetree: add Freescale RNGC binding

2016-03-11 Thread Steffen Trumtrar
Add binding documentation for the Freescale RNGC found on some i.MX2/3/5 SoCs. Signed-off-by: Steffen Trumtrar --- Documentation/devicetree/bindings/rng/mxc_rngc.txt | 16 1 file changed, 16 insertions(+) create mode 100644

Re: [PATCH] crypto: ux500: fix checks of error code returned by devm_ioremap_resource()

2016-03-11 Thread Herbert Xu
On Sun, Mar 06, 2016 at 03:22:04AM +0200, Vladimir Zapolskiy wrote: > The change fixes potential oops while accessing iomem on invalid > address, if devm_ioremap_resource() fails due to some reason. > > The devm_ioremap_resource() function returns ERR_PTR() and never > returns NULL, which makes

Re: [PATCH] crypto: qat - remove redundant arbiter configuration

2016-03-11 Thread Herbert Xu
On Tue, Mar 08, 2016 at 10:37:15AM -0800, Tadeusz Struk wrote: > The default arbiter configuration for ring weights and response ordering > is exactly what we want so we don't need to configure anything more. > This will also fix the problem where number of bundles is different > between different

Re: [PATCH] crypto: qat - Change the definition of icp_qat_uof_regtype

2016-03-11 Thread Herbert Xu
On Thu, Mar 03, 2016 at 02:46:45AM -0500, Yang Pingchao wrote: > The definition of icp_qat_uof_regtype should be coherent with > the definition in firmware compiler. > > Signed-off-by: Yang Pingchao Applied. -- Email: Herbert Xu Home

Re: [PATCH] crypto: atmel: fix checks of error code returned by devm_ioremap_resource()

2016-03-11 Thread Herbert Xu
On Sun, Mar 06, 2016 at 03:21:52AM +0200, Vladimir Zapolskiy wrote: > The change fixes potential oops while accessing iomem on invalid > address, if devm_ioremap_resource() fails due to some reason. > > The devm_ioremap_resource() function returns ERR_PTR() and never > returns NULL, which makes

Re: [PATCH 07/14] hw_random: exynos: use __maybe_unused to hide pm functions

2016-03-11 Thread Herbert Xu
On Wed, Mar 02, 2016 at 04:58:59PM +0100, Arnd Bergmann wrote: > The exynos random driver uses #ifdef to check for CONFIG_PM, but > then uses SIMPLE_DEV_PM_OPS, which leaves the references out when > CONFIG_PM_SLEEP is not defined, so we get a warning with > PM=y && PM_SLEEP=n: > >

Re: [PATCH 0/4] crypto: ccp - CCP driver updates 2016-03-01

2016-03-11 Thread Herbert Xu
On Tue, Mar 01, 2016 at 01:48:43PM -0600, Gary R Hook wrote: > The following patches are includes in this update series: > > - Remove the extraneous family check > - Refactor code to enable support for >1 CCPs in a system > - Add initial support for versioning > - Refactor: move version-specific

Re: [patch] crypto: rsa-pkcs1pad: indent a couple statements

2016-03-11 Thread Herbert Xu
On Tue, Mar 08, 2016 at 03:07:36PM +0300, Dan Carpenter wrote: > These if statements aren't indented far enough and it makes static > checkers complain. > > Signed-off-by: Dan Carpenter Sorry but this doesn't apply against cryptodev. -- Email: Herbert Xu

Re: [PATCH v3 3/3] crypto: add basic driver for the MXC SCC

2016-03-11 Thread Herbert Xu
On Mon, Mar 07, 2016 at 01:00:05PM +0100, Steffen Trumtrar wrote: > > + if (ctx->ctrl & SCC_SCM_CTRL_CBC_MODE && req->info) > + memcpy(scc->base + SCC_SCM_INIT_VECTOR_0, req->info, > +scc->block_size_bytes); Please ensure that the IV is copied back on exit. I