Re: [PATCH v8 6/6] crypto: AF_ALG - add support for key_id

2016-07-05 Thread Tadeusz Struk
Hi Mat, On 06/29/2016 11:43 AM, Mat Martineau wrote: >> +ret = verify_signature(key, ); >> +if (!ret) { >> +req->dst_len = sizeof(digest); > > I think you fixed the BUG_ON() problem but there's still an issue with > the handling of the digest. Check the use of sig->digest in >

Re: AEAD: Having separate underlying cipher handle for each request

2016-07-05 Thread Stephan Mueller
Am Dienstag, 5. Juli 2016, 13:44:05 schrieb Ondrej Mosnáček: Hi Ondrej, > Hi, > > I'm trying to experimentally implement the GCM-SIV AEAD algorithm from > [1] for the Linux crypto API and I've ran into a problem... > > Basically, the encryption/decryption process starts by deriving a >

Re: [PATCH 0/3] Add RSA CRT mode to qat driver

2016-07-05 Thread Herbert Xu
On Mon, Jul 04, 2016 at 05:21:37PM +0100, Salvatore Benedetto wrote: > Hi Herbert, > > this patchset add CRT mode to qat driver. > First patch extend the parsing of the private key so that all required CRT > fields are saved. Second patch add a 4K test key. Third patch extend qat > to use CRT.

Re: [PATCH] crypto: bfin_crc: Simplify use of devm_ioremap_resource

2016-07-05 Thread Herbert Xu
On Mon, Jul 04, 2016 at 06:30:21PM +0530, Amitoj Kaur Chawla wrote: > Remove unneeded error handling on the result of a call to > platform_get_resource when the value is passed to > devm_ioremap_resource. > > The Coccinelle semantic patch that makes this change is as follows: > > // > @@ >

Re: [v10 PATCH] crypto: caam - add support for RSA algorithm

2016-07-05 Thread Herbert Xu
On Mon, Jul 04, 2016 at 01:12:08PM +0300, Tudor Ambarus wrote: > Add RSA support to caam driver. > > Initial author is Yashpal Dutta . > > Signed-off-by: Tudor Ambarus > --- > Changes in v10: > - remove unused asn1 header files Patch

Re: [PATCH] crypto: testmgr - Set err before proceeding

2016-07-05 Thread Herbert Xu
On Mon, Jul 04, 2016 at 10:52:34AM +0100, Salvatore Benedetto wrote: > Report correct error in case of failure > > Signed-off-by: Salvatore Benedetto Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH v2] crypto: qat - Switch to new rsa_helper functions

2016-07-05 Thread Herbert Xu
On Mon, Jul 04, 2016 at 10:49:28AM +0100, Salvatore Benedetto wrote: > Drop all asn1 related code and use the new rsa_helper > functions rsa_parse_[pub|priv]_key for parsing the key > > Signed-off-by: Salvatore Benedetto > --- > > changes from v1: > - Remove

Re: [PATCH 2/2] crypto: powerpc: Add POWER8 optimised crc32c

2016-07-05 Thread Herbert Xu
On Fri, Jul 01, 2016 at 08:19:45AM +1000, Anton Blanchard wrote: > From: Anton Blanchard > > Use the vector polynomial multiply-sum instructions in POWER8 to > speed up crc32c. > > This is just over 41x faster than the slice-by-8 method that it > replaces. Measurements on a 4.1

AEAD: Having separate underlying cipher handle for each request

2016-07-05 Thread Ondrej Mosnáček
Hi, I'm trying to experimentally implement the GCM-SIV AEAD algorithm from [1] for the Linux crypto API and I've ran into a problem... Basically, the encryption/decryption process starts by deriving a so-called "record-encryption key" from the nonce (by encrypting it using another key) and this

RE: [PATCH] Enable slice hang handling for C3X and C6X devices.

2016-07-05 Thread Mcloughlin, Conor
> -Original Message- > From: Mcloughlin, Conor > Sent: Tuesday, July 5, 2016 10:07 AM > To: linux-crypto@vger.kernel.org > Cc: Mcloughlin, Conor > Subject: [PATCH] Enable slice hang handling for C3X and C6X devices. > > If the QAT device fails to respond to

[PATCH] Enable slice hang handling for C3X and C6X devices.

2016-07-05 Thread Conor McLoughlin
If the QAT device fails to respond to a command, a watchdog timer triggers an interrupt. This event is reported and the the interrupt cleared. A separate watchdog register is used for sym and asym crypto. Signed-off-by: Conor McLoughlin ---

RE: [v9 PATCH] crypto: caam - add support for RSA algorithm

2016-07-05 Thread Tudor-Dan Ambarus
> Please look at your patch. It's broken, you're including > > +#include "rsapubkey-asn1.h" > +#include "rsaprivkey-asn1.h" > > which no longer exist. Right, the inclusions, together with: +ccflags-y += -I$(srctree)/crypto are leftovers. I will submit a v10 patch. These files (from crypto/)