Re: [PATCH 00/13] crypto: copy AAD during encrypt for AEAD ciphers

2017-01-20 Thread Stephan Müller
Am Freitag, 20. Januar 2017, 18:07:04 CET schrieb Cyrille Pitchen: Hi Cyrille, > > I've taken Stephan's other comments into account from his review of the > atmel-authenc driver so I'm preparing a new series but I don't know what to > do for the associated data copy. > > Please let me know

Re: [PATCH 2/2] misc: amd-sp: introduce the AMD Secure Processor device

2017-01-20 Thread kbuild test robot
Hi Brijesh, [auto build test ERROR on cryptodev/master] [also build test ERROR on next-20170120] [cannot apply to char-misc/char-misc-testing v4.10-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 0/2] Introduce AMD Secure Processor device

2017-01-20 Thread Greg KH
On Fri, Jan 20, 2017 at 09:40:49AM -0600, Brijesh Singh wrote: > > On 01/20/2017 02:45 AM, Greg KH wrote: > > On Thu, Jan 19, 2017 at 02:03:12PM -0600, Brijesh Singh wrote: > > > Hi Greg, > > > > > > On 01/19/2017 12:21 PM, Greg KH wrote: > > > > On Thu, Jan 19, 2017 at 01:07:50PM -0500, Brijesh

Re: [PATCH 00/13] crypto: copy AAD during encrypt for AEAD ciphers

2017-01-20 Thread Cyrille Pitchen
Hi all, Le 13/01/2017 à 12:39, Herbert Xu a écrit : > On Fri, Jan 13, 2017 at 12:36:56PM +0100, Stephan Müller wrote: >> >> I thought I understood that you would not want to see it in any >> implementation. But, ok, if you want to leave it. > > If you remove it from authenc then authenc will be

Re: [PATCH 1/2] crypto: move CCP device driver to misc

2017-01-20 Thread kbuild test robot
Hi Brijesh, [auto build test ERROR on cryptodev/master] [also build test ERROR on next-20170120] [cannot apply to char-misc/char-misc-testing v4.10-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 2/2] misc: amd-sp: introduce the AMD Secure Processor device

2017-01-20 Thread kbuild test robot
Hi Brijesh, [auto build test WARNING on cryptodev/master] [also build test WARNING on next-20170120] [cannot apply to char-misc/char-misc-testing v4.10-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 0/2] Introduce AMD Secure Processor device

2017-01-20 Thread Brijesh Singh
On 01/20/2017 02:45 AM, Greg KH wrote: On Thu, Jan 19, 2017 at 02:03:12PM -0600, Brijesh Singh wrote: Hi Greg, On 01/19/2017 12:21 PM, Greg KH wrote: On Thu, Jan 19, 2017 at 01:07:50PM -0500, Brijesh Singh wrote: The CCP device (drivers/crypto/ccp/ccp.ko) is part of AMD Secure Processor,

Re: [PATCH 5/6] crypto: testmgr: add ECDSA tests

2017-01-20 Thread Stephan Müller
Am Freitag, 20. Januar 2017, 17:06:00 CET schrieb Nitin Kumbhar: Hi Nitin, > Update crypto test manager to include NIST ECDSA > test vectors and various ECDSA tests. These include > tests for ECDSA signing, ECDSA sign-verification, > ECDSA signing and verifying generated signatures and >

Re: [PATCH 4/6] crypto: ecdsa: add ECDSA SW implementation

2017-01-20 Thread Stephan Müller
Am Freitag, 20. Januar 2017, 17:05:59 CET schrieb Nitin Kumbhar: Hi Nitin, > This adds support for ECDSA algorithm. This implementation supports > sign and verify functions for ECDSA algorithm using akcipher. As ECDSA > is a signing algorithm dummy functions are added for encrypt() and >

[PATCH 2/6] crypto: ecc: add vli and ecc ops

2017-01-20 Thread Nitin Kumbhar
Add functions to copy vli from buffers, to print vli in big endian format, for vli mod and mod multiplication ops and ecc point addition. Signed-off-by: Nitin Kumbhar --- crypto/ecc.c | 168 ++ 1 files changed, 168

[PATCH 5/6] crypto: testmgr: add ECDSA tests

2017-01-20 Thread Nitin Kumbhar
Update crypto test manager to include NIST ECDSA test vectors and various ECDSA tests. These include tests for ECDSA signing, ECDSA sign-verification, ECDSA signing and verifying generated signatures and invalidation of incorrect signatures. Signed-off-by: Nitin Kumbhar ---

[PATCH 6/6] crypto: tcrypt: add ECDSA test modes

2017-01-20 Thread Nitin Kumbhar
Update tcrypt module to include a new ECDSA test modes. It includes: tcrypt.ko mode=560 for ECDSA sign/verify validation. tcrypt.ko mode=561 for ECDSA sign/verify op perf in cycles. tcrypt.ko mode=561 sec= for number of ECDSA sign verify ops in given time. Signed-off-by: Nitin Kumbhar

[PATCH 1/6] crypto: ecc: separate out ecc and ecdh

2017-01-20 Thread Nitin Kumbhar
Add ECC operations i.e. vli and ecc point ops as a separate module under CRYPTO_ECC kconfig. This allows other ECC algorithms like ECDSA & ECIES to reuse these ops even when ECDH is disabled with CRYPTO_ECDH kconfig. With these changes, ECDH specific functions are consolidated as ECDH helper

[PATCH 0/6] Add support for ECDSA algorithm

2017-01-20 Thread Nitin Kumbhar
Hello, This patch series adds support for Elliptic Curve Digital Signature Algorithm (ECDSA). To reuse existing ECC functionality, which is added as part of ECDH, it separates out ECC and ECDH so that only ECC functionality is available for ECDSA even when ECDH is in a disabled state. Patch #1

[PATCH 3/6] crypto: ecc: export vli and ecc ops

2017-01-20 Thread Nitin Kumbhar
Export vli and ECC related functions so that these can be used by all ECC algorithm modules like ECDH, ECDSA and ECIES. Signed-off-by: Nitin Kumbhar --- crypto/ecc.c | 114 +- crypto/ecc.h | 53

[PATCH 4/6] crypto: ecdsa: add ECDSA SW implementation

2017-01-20 Thread Nitin Kumbhar
This adds support for ECDSA algorithm. This implementation supports sign and verify functions for ECDSA algorithm using akcipher. As ECDSA is a signing algorithm dummy functions are added for encrypt() and decrypt(). Helper routines for parsing public and private ECC keys for ECDSA are added as

Re: [PATCH 0/2] Introduce AMD Secure Processor device

2017-01-20 Thread Greg KH
On Thu, Jan 19, 2017 at 02:03:12PM -0600, Brijesh Singh wrote: > Hi Greg, > > On 01/19/2017 12:21 PM, Greg KH wrote: > > On Thu, Jan 19, 2017 at 01:07:50PM -0500, Brijesh Singh wrote: > > > The CCP device (drivers/crypto/ccp/ccp.ko) is part of AMD Secure > > > Processor, > > > which is not

[PATCH] crypto: vmx -- disable preemption to enable vsx in aes_ctr.c

2017-01-20 Thread Li Zhong
Some preemptible check warnings were reported from enable_kernel_vsx(). This patch disables preemption in aes_ctr.c before enabling vsx, and they are now consistent with other files in the same directory. Signed-off-by: Li Zhong --- drivers/crypto/vmx/aes_ctr.c | 6