Re: [PATCH v3 2/4] ARM64: dts: meson-gx: add clock to DT binding documentation for hwrng

2017-02-27 Thread Rob Herring
On Wed, Feb 22, 2017 at 07:59:08AM +0100, Heiner Kallweit wrote: > Add clock to DT binding documentation. > > Signed-off-by: Heiner Kallweit > --- > v2: > - splitted first version of patch into two > - add DT binding documentation > - mention that clock is optional > - replace spaces with tabs in

Re: [PATCH v2 2/3] ARM64: dts: meson-gx: add clock CLKID_RNG0 to hwrng node

2017-02-27 Thread Rob Herring
On Tue, Feb 21, 2017 at 09:18:16PM +0100, Heiner Kallweit wrote: > Add clock CLKID_RNG0 to HW randon number generator node and > extend the DT binding documentation accordingly. > > Signed-off-by: Heiner Kallweit > --- > v2: > - splitted first version of patch into two > - add DT binding document

Re: [PATCH] crypto: ccp - Reference the correct structure member

2017-02-27 Thread Gary R Hook
On 02/27/2017 11:10 AM, Gary R Hook wrote: Fix a build break by referencing the proper structure member name when invoking functions. Remove unneeded akcipher structure. Please ignore. I was mistakenly under the impression that the referenced patchset had been accepted. Signed-off-by: Gary R

Re: [PATCH 0/3] Support new function in the newer CCP

2017-02-27 Thread Gary R Hook
On 02/15/2017 03:55 PM, Gary R Hook wrote: The following series implements new function in a version 5 coprocessor. New features are: - Support for SHA-2 384-bit and 512-bit hashing - Support for AES GCM encryption - Support for 3DES encryption Please ignore. This patchset introduces build

[PATCH] crypto: ccp - Reference the correct structure member

2017-02-27 Thread Gary R Hook
Fix a build break by referencing the proper structure member name when invoking functions. Remove unneeded akcipher structure. Signed-off-by: Gary R Hook --- drivers/crypto/ccp/Makefile |1 - drivers/crypto/ccp/ccp-crypto-main.c |8 drivers/crypto/ccp/ccp-ops.c

Re: [PATCH] crypto: ccm - move cbcmac input off the stack

2017-02-27 Thread Johannes Berg
On Mon, 2017-02-27 at 15:30 +, Ard Biesheuvel wrote: > Commit f15f05b0a5de ("crypto: ccm - switch to separate cbcmac > driver") > refactored the CCM driver to allow separate implementations of the > underlying MAC to be provided by a platform. However, in doing so, it > moved some data from the

[PATCH] crypto: ccm - move cbcmac input off the stack

2017-02-27 Thread Ard Biesheuvel
Commit f15f05b0a5de ("crypto: ccm - switch to separate cbcmac driver") refactored the CCM driver to allow separate implementations of the underlying MAC to be provided by a platform. However, in doing so, it moved some data from the linear region to the stack, which violates the SG constraints when

Re: [PATCH v5 4/4] dt-bindings: Add DT bindings document for Broadcom SBA RAID driver

2017-02-27 Thread Rob Herring
On Thu, Feb 16, 2017 at 12:18:15PM +0530, Anup Patel wrote: > This patch adds the DT bindings document for newly added Broadcom > SBA RAID driver. > > Signed-off-by: Anup Patel > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > --- > .../devicetree/bindings/dma/brcm,iproc-sba.txt | 29

Re: [PATCH v3 1/3] clk: meson-gxbb: expose clock CLKID_RNG0

2017-02-27 Thread Neil Armstrong
On 02/21/2017 10:55 PM, Heiner Kallweit wrote: > Expose clock CLKID_RNG0 which is needed for the HW random number generator. > > Signed-off-by: Heiner Kallweit > --- > v2: > - added clk and DT maintainers > - split exposing the clock and using it in DT into two patches > - comment out clock defin

[PATCH v2 2/2] crypto: ctr - Propagate NEED_FALLBACK bit

2017-02-27 Thread Marcelo Henrique Cerri
When requesting a fallback algorithm, we should propagate the NEED_FALLBACK bit when search for the underlying algorithm. This will prevents drivers from allocating unnecessary fallbacks that are never called. For instance, currently the vmx-crypto driver will use the following chain of calls when

[PATCH v2 0/2] Propagate fallback bit for cbc and ctr

2017-02-27 Thread Marcelo Henrique Cerri
Hi Hebert, For v2: - fixed the memory leakage in cbc. - included crypto/algapi.h in crypto/cbc.c for crypto_requires_off(); - ERR_CAST instead PTR_ERR in ctr. - Also propagated the fallback bit for rfc3686. Marcelo Henrique Cerri (2): crypto: cbc - Propagate NEED_FALLBACK bit crypto: ctr - P

[PATCH v2 1/2] crypto: cbc - Propagate NEED_FALLBACK bit

2017-02-27 Thread Marcelo Henrique Cerri
When requesting a fallback algorithm, we should propagate the NEED_FALLBACK bit when search for the underlying algorithm. This will prevents drivers from allocating unnecessary fallbacks that are never called. For instance, currently the vmx-crypto driver will use the following chain of calls when

Re: [PATCH 1/2] crypto: CRYPTO_DEV_ATMEL_TDES and CRYPTO_DEV_ATMEL_SHA should depend on HAS_DMA

2017-02-27 Thread Herbert Xu
On Fri, Feb 24, 2017 at 11:27:38AM +0100, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "bad_dma_ops" [drivers/crypto/atmel-tdes.ko] undefined! > ERROR: "bad_dma_ops" [drivers/crypto/atmel-sha.ko] undefined! > > Add dependencies on HAS_DMA to fix this. > > Fixes: ceb4afb3086ab08f (

Re: [PATCH 2/2] crypto: CRYPTO_DEV_MEDIATEK should depend on HAS_DMA

2017-02-27 Thread Herbert Xu
On Fri, Feb 24, 2017 at 11:27:39AM +0100, Geert Uytterhoeven wrote: > If NO_DMA=y: > > ERROR: "bad_dma_ops" [drivers/crypto/mediatek/mtk-crypto.ko] undefined! > > Add a dependency on HAS_DMA to fix this. > > Fixes: 7dee9f618790d0b7 ("crypto: mediatek - remove ARM dependencies") > Signed-off-

Re: [PATCH] crypto: cavium: fix leak on curr if curr->head fails to be allocated

2017-02-27 Thread Herbert Xu
On Fri, Feb 17, 2017 at 03:57:43PM +, Colin King wrote: > From: Colin Ian King > > The exit path when curr->head cannot be allocated fails to kfree the > earlier allocated curr. Fix this by kfree'ing it. > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu Home

Re: [PATCH] crypto: cavium/cpt: Fix couple of static checker errors

2017-02-27 Thread Herbert Xu
On Wed, Feb 15, 2017 at 12:42:19PM +, George Cherian wrote: > Fix the following smatch errors > cptvf_reqmanager.c:333 do_post_process() warn: variable dereferenced > before check 'cptvf' > cptvf_main.c:825 cptvf_remove() error: we previously assumed 'cptvf' > could be null > > Reported-by: Da

Re: [PATCH 1/2] crypto: cbc - Propagate NEED_FALLBACK bit

2017-02-27 Thread Herbert Xu
On Sun, Feb 26, 2017 at 10:03:18PM -0300, Marcelo Henrique Cerri wrote: > When requesting a fallback algorithm, we should propagate the > NEED_FALLBACK bit when search for the underlying algorithm. > > This will prevents drivers from allocating unnecessary fallbacks that > are never called. For in