Re: [PATCH 2/4] crypto: stm32 - Support for STM32 CRC32 crypto module

On Tue, Mar 14, 2017 at 05:37:24PM +0100, Fabien Dessenne wrote: > +static int stm32_crc_remove(struct platform_device *pdev) > +{ > + struct stm32_crc *crc = platform_get_drvdata(pdev); > + > + spin_lock(_list.lock); > + list_del(>list); > + spin_unlock(_list.lock); > + > +

Re: [PATCH v6 0/4] Broadcom SBA RAID support

On Tue, Mar 14, 2017 at 09:56:35AM -0700, Dan Williams wrote: > On Mon, Mar 6, 2017 at 1:43 AM, Anup Patel wrote: > > The Broadcom SBA RAID is a stream-based device which provides > > RAID5/6 offload. > > > > It requires a SoC specific ring manager (such as Broadcom

Re: [PATCH v6 0/4] Broadcom SBA RAID support

On Mon, Mar 6, 2017 at 1:43 AM, Anup Patel wrote: > The Broadcom SBA RAID is a stream-based device which provides > RAID5/6 offload. > > It requires a SoC specific ring manager (such as Broadcom FlexRM > ring manager) to provide ring-based programming interface. Due to >

[PATCH 4/4] ARM: dts: stm32: enable CRC on stm32746g-eval board

Enable the CRC (CRC32 crypto) on stm32746g-eval board Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32746g-eval.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/stm32746g-eval.dts b/arch/arm/boot/dts/stm32746g-eval.dts index

[PATCH 1/4] dt-bindings: Document STM32 CRC bindings

Document device tree bindings for the STM32 CRC (crypto CRC32) Signed-off-by: Fabien Dessenne --- .../devicetree/bindings/crypto/st,stm32-crc.txt | 16 1 file changed, 16 insertions(+) create mode 100644

[PATCH 2/4] crypto: stm32 - Support for STM32 CRC32 crypto module

This module registers a CRC32 ("Ethernet") and a CRC32C (Castagnoli) algorithm that make use of the STMicroelectronics STM32 crypto hardware. Theses algorithms are compatible with the little-endian generic ones. Both algorithms use ~0 as default seed (key). With CRC32C the output is xored with

[PATCH 0/4] STM32 CRC crypto driver

This set of patches adds a new crypto driver for STMicroelectronics stm32f746. The drivers uses the crypto API and provides with an HW-enabled CRC32 algorithm. It was developed and tested (tcrypt / testmgr) on evaluation board stm32746g. Fabien Dessenne (4): dt-bindings: Document STM32 CRC

[PATCH 3/4] ARM: dts: stm32: Add CRC support to stm32f746

Add CRC (CRC32 crypto) support to stm32f746. Signed-off-by: Fabien Dessenne --- arch/arm/boot/dts/stm32f746.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32f746.dtsi b/arch/arm/boot/dts/stm32f746.dtsi index f321ffe..755fb92 100644

Re: crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex

On (03/14/17 09:14), Dmitry Vyukov wrote: > Another one now involving rds_tcp_listen_stop : > kworker/u4:1/19 is trying to acquire lock: > (sk_lock-AF_INET){+.+.+.}, at: [] lock_sock > include/net/sock.h:1460 [inline] > (sk_lock-AF_INET){+.+.+.}, at: [] > rds_tcp_listen_stop+0x5c/0x150

Re: [PATCH V2 2/3] crypto: ccp - Enable support for AES GCM on v5 CCPs

Am Dienstag, 14. März 2017, 15:34:00 CET schrieb Gary R Hook: Hi Gary, > On 03/14/2017 02:17 AM, Stephan Müller wrote: > > Am Montag, 13. März 2017, 20:35:07 CET schrieb Gary R Hook: > > > > Hi Gary, > > Is it acceptable to snip stuff out? Most of this code seems irrelevant > to this

Re: [PATCH V2 2/3] crypto: ccp - Enable support for AES GCM on v5 CCPs

On 03/14/2017 02:17 AM, Stephan Müller wrote: Am Montag, 13. März 2017, 20:35:07 CET schrieb Gary R Hook: Hi Gary, Is it acceptable to snip stuff out? Most of this code seems irrelevant to this discussion On 03/03/2017 7:15 AM, Stephan Mueller wrote: > Am Donnerstag, 2. März 2017,

[PATCH 2/2] hwrng: geode - Revert managed API changes

After commit e9afc746299d ("hwrng: geode - Use linux/io.h instead of asm/io.h") the geode-rng driver uses devres with pci_dev->dev to keep track of resources, but does not actually register a PCI driver. This results in the following issues: 1. The driver leaks memory because the driver does

[PATCH 1/2] hwrng: amd - Revert managed API changes

After commit 31b2a73c9c5f ("hwrng: amd - Migrate to managed API"), the amd-rng driver uses devres with pci_dev->dev to keep track of resources, but does not actually register a PCI driver. This results in the following issues: 1. The message WARNING: CPU: 2 PID: 621 at drivers/base/dd.c:349

[PATCH 0/2] hwrng: revert managed API changes for amd and geode

When booting top-of-tree the following WARN_ON triggers in the kernel on a 15h AMD system. WARNING: CPU: 2 PID: 621 at drivers/base/dd.c:349 driver_probe_device+0x38c Modules linked in: i2c_amd756(+) amd_rng sg pcspkr parport_pc(+) parport k8 CPU: 2 PID: 621 Comm: systemd-udevd Not tainted

Re: crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex

On Tue, Mar 14, 2017 at 11:25 AM, Herbert Xu wrote: > On Tue, Mar 14, 2017 at 10:44:10AM +0100, Dmitry Vyukov wrote: >> >> Yes, please. >> Disregarding some reports is not a good way long term. > > Please try this patch. Applied on bots. I should have a conclusion

Re: crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex

On Tue, Mar 14, 2017 at 10:44:10AM +0100, Dmitry Vyukov wrote: > > Yes, please. > Disregarding some reports is not a good way long term. Please try this patch. ---8<--- Subject: netlink: Annotate nlk cb_mutex by protocol Currently all occurences of nlk->cb_mutex are annotated by lockdep as a

Re: crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex

On Tue, Mar 14, 2017 at 10:16 AM, Herbert Xu wrote: > On Sun, Mar 05, 2017 at 04:08:39PM +0100, Dmitry Vyukov wrote: >> >> -> #1 (genl_mutex){+.+.+.}: >>validate_chain kernel/locking/lockdep.c:2267 [inline] >>__lock_acquire+0x2149/0x3430

Re: XTS Crypto Not Found In /proc/crypto Even After Compiled for 4.10.1.

On Mon, Mar 13, 2017 at 07:06:01PM +0200, Krzysztof Kozlowski wrote: > > I bisected this to commit f1c131b45410 ("crypto: xts - Convert to > skcipher"). The s5p-sss driver stays the same... but the xts changes and > as a result we have a NULL pointer dereference (actually of value > 0004): >

Re: crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex

On Sun, Mar 05, 2017 at 06:36:12PM +0100, Dmitry Vyukov wrote: > > > -> #1 (genl_mutex){+.+.+.}: > >validate_chain kernel/locking/lockdep.c:2267 [inline] > >__lock_acquire+0x2149/0x3430 kernel/locking/lockdep.c:3340 > >lock_acquire+0x2a1/0x630 kernel/locking/lockdep.c:3755

Re: crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex

On Sun, Mar 05, 2017 at 04:08:39PM +0100, Dmitry Vyukov wrote: > > -> #1 (genl_mutex){+.+.+.}: >validate_chain kernel/locking/lockdep.c:2267 [inline] >__lock_acquire+0x2149/0x3430 kernel/locking/lockdep.c:3340 >lock_acquire+0x2a1/0x630 kernel/locking/lockdep.c:3755 >

Re: crypto: deadlock between crypto_alg_sem/rtnl_mutex/genl_mutex

On Mon, Mar 6, 2017 at 10:36 AM, Dmitry Vyukov wrote: > On Sun, Mar 5, 2017 at 6:36 PM, Dmitry Vyukov wrote: >> On Sun, Mar 5, 2017 at 4:08 PM, Dmitry Vyukov wrote: >>> Hello, >>> >>> I am getting the following deadlock reports while

Re: [PATCH] crypto: ccp - Assign DMA commands to the channel's CCP

Am Montag, 13. März 2017, 20:35:07 CET schrieb Gary R Hook: Hi Gary, > On 03/03/2017 7:15 AM, Stephan Mueller wrote: > > Am Donnerstag, 2. März 2017, 22:26:54 CET schrieb Gary R Hook: > > > > Hi Gary, > > Thanks for your comments, Stephan. > > > > A version 5 device provides the primitive