On 09/07/2017 05:19 PM, Brijesh Singh wrote:
Hi Boris,
On 09/07/2017 09:27 AM, Borislav Petkov wrote:
...
The commit message above reads better to me as the help text than what
you have here.
Also, in order to make it easier for the user, I think we'll need a
CONFIG_AMD_MEM_ENCRYPT_SEV or s
Hi Boris,
On 09/07/2017 09:27 AM, Borislav Petkov wrote:
...
The commit message above reads better to me as the help text than what
you have here.
Also, in order to make it easier for the user, I think we'll need a
CONFIG_AMD_MEM_ENCRYPT_SEV or so and make that depend on CONFIG_KVM_AMD,
this
* Eric Biggers wrote:
> On Thu, Sep 07, 2017 at 09:15:34AM +0200, Ingo Molnar wrote:
> >
> > * Eric Biggers wrote:
> >
> > > Thanks for fixing these! I don't have time to review these in detail,
> > > but I ran
> > > the crypto self-tests on the affected algorithms, and they all pass. I
>
On Thu, Sep 07, 2017 at 09:15:34AM +0200, Ingo Molnar wrote:
>
> * Eric Biggers wrote:
>
> > Thanks for fixing these! I don't have time to review these in detail, but
> > I ran
> > the crypto self-tests on the affected algorithms, and they all pass. I also
> > benchmarked them before and afte
On Mon, Jul 24, 2017 at 03:02:39PM -0500, Brijesh Singh wrote:
> Platform Security Processor (PSP) is part of AMD Secure Processor (AMD-SP),
> PSP is a dedicated processor that provides the support for key management
> commands in a Secure Encrypted Virtualiztion (SEV) mode, along with
> software-b
Use BIT(x) instead of using (1<
---
Changes in v2:
- Add tab spaces before BIT macro.
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/staging/ccree/ssi_cipher.h
index 296b375..c9a83df
On Thu, Sep 07, 2017 at 07:17:09PM +0530, Srishti Sharma wrote:
> Use BIT(x) instead of (1<
> Signed-off-by: Srishti Sharma
> ---
> drivers/staging/ccree/ssi_cipher.h | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.h
> b/driv
Use BIT(x) instead of (1<
---
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/staging/ccree/ssi_cipher.h
index 296b375..6fbcf9d 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/driv
On Wed, Sep 06, 2017 at 04:26:52PM -0500, Gary R Hook wrote:
> They were included in a pull request (for 4.14) from Herbert, dated Monday.
Right. I rebased the SEV pile ontop of latest upstream and now it applies much
better:
checking file drivers/crypto/ccp/Kconfig
Hunk #1 succeeded at 32 (offse
On 9/6/2017 1:14 PM, Gilad Ben-Yossef wrote:
> On Tue, Sep 5, 2017 at 6:33 PM, Horia Geantă wrote:
>> On 8/14/2017 10:59 AM, Gilad Ben-Yossef wrote:
>>> Hi,
>>>
>>> On Thu, Jun 29, 2017 at 1:19 PM, Horia Geantă wrote:
On 6/28/2017 4:42 PM, Horia Geantă wrote:
> On 6/28/2017 4:27 PM, Davi
On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by: Srishti Sharma
>> ---
>
> I've been meaning to clean that for some time now and never g
From: Suniel Mahesh
It is recommended to use managed function devm_kzalloc, which
simplifies driver cleanup paths and driver code.
This patch does the following:
(a) replace kzalloc with devm_kzalloc.
(b) drop kfree(), because memory allocated with devm_kzalloc() is
automatically freed on driver
From: Suniel Mahesh
It is recommended to use managed function devm_ioremap_resource(),
which simplifies driver cleanup paths and driver code.
This patch does the following:
(a) replace request_mem_region(), ioremap() and corresponding error
handling with devm_ioremap_resource().
(b) remove struct
From: Suniel Mahesh
It is recommended to use managed function devm_request_irq(),
which simplifies driver cleanup paths and driver code.
This patch does the following:
(a) replace platform_get_resource(), request_irq() and corresponding
error handling with platform_get_irq() and devm_request_irq(
icache_setup_completion is no longer used. Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_driver.c | 2 --
drivers/staging/ccree/ssi_driver.h | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_driver.c
b/drivers/staging/ccree/ssi_driver.c
in
The resource release on probe/init error was being handled
in an awkward manner and possibly leaking memory on certain
(unlikely) error path.
Fix it by simplifying the error resource release and making
it easier to track.
Reported-by: Dan Carpenter
Signed-off-by: Gilad Ben-Yossef
---
drivers/s
Use BIT macro for bit definitions where needed.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_cipher.h | 10 +-
drivers/staging/ccree/ssi_driver.c | 3 ++-
drivers/staging/ccree/ssi_driver.h | 6 +++---
3 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/dri
Replace BUG() macro usage that crash the kernel with alternatives
that signal error and/or try to recover.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c | 18 ++
drivers/staging/ccree/ssi_cipher.c | 1 -
drivers/staging/ccree/ssi_pm.c
Replace noop macro with a noop inline function
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_driver.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree/ssi_driver.h
b/drivers/staging/ccree/ssi_driver.h
index 06a3c48..81ba827 100644
---
More cleanup work from Sunil and myself.
I've previously sent some of these as part of a larger patch set.
I've decided to split the patch set to smaller chunks to make it
more manageable.
This patch set applies on top of commit 28eb51f7468a
("staging:rtl8188eu:core Fix remove unneccessary else b
On Wed, Sep 6, 2017 at 10:28 PM, Dan Carpenter wrote:
> On Sun, Sep 03, 2017 at 11:56:50AM +0300, Gilad Ben-Yossef wrote:
>> @@ -1154,7 +1150,8 @@ static inline int ssi_buffer_mgr_aead_chain_data(
>> //if have reached the end of the sgl, then this is unexpected
>> if (!
Hi,
On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma wrote:
> Remove the local variable inflight_counter as it is never used.
>
> Signed-off-by: Srishti Sharma
> ---
I've been meaning to clean that for some time now and never got around to do it.
Thank you! :-)
Acked-by: Gilad Ben-Yossef
> C
On Mon, Aug 21, 2017 at 9:27 AM, Carlo Caione wrote:
> On Mon, Aug 7, 2017 at 10:01 AM, Carlo Caione wrote:
>> From: Carlo Caione
>>
>> We have found some ACER laptops shipping with certificates signed using
>> the 1.3.14.3.2.29 OID. This is causing the message
> /cut
>
> Ping on this (literally
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove the local variable inflight_counter as it is never used.
>
> Signed-off-by: Srishti Sharma
Acked-by: Julia Lawall
> ---
> Changes in v5:
> - Correct the format of the subject.
> drivers/staging/ccree/ssi_cipher.c | 3 ---
> 1 file changed,
Looks good. Thanks!
regards,
dan carpenter
Remove the local variable inflight_counter as it is never used.
Signed-off-by: Srishti Sharma
---
Changes in v5:
- Correct the format of the subject.
drivers/staging/ccree/ssi_cipher.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging/cc
* Eric Biggers wrote:
> Thanks for fixing these! I don't have time to review these in detail, but I
> ran
> the crypto self-tests on the affected algorithms, and they all pass. I also
> benchmarked them before and after; the only noticable performance difference
> was
> that sha256-avx2 and
On Thu, Sep 7, 2017 at 12:24 PM, Julia Lawall wrote:
> One last detail. The subject line above is not in the same format as that
> of all of the other subject lines one commits affecting this file. You
> can use git log --oneline to see what others have done. It is not really
> possible to gues
28 matches
Mail list logo