Re: WARNING: kernel stack regs has bad 'bp' value (2)

[Dmitry Vyukov]

On Wed, Dec 27, 2017 at 7:29 PM, Dmitry Vyukov  wrote:
> On Thu, Nov 30, 2017 at 10:17 AM, Eric Biggers  wrote:
>> On Tue, Nov 28, 2017 at 10:36:01AM -0800, syzbot wrote:
>>> WARNING: kernel stack regs at 8801c1e5f468 in syzkaller196611:6199 has
>>> bad 'bp' value 0001
>>> unwind stack type:0 next_sp:  (null) mask:0x6 graph_idx:0
>>> 8801db4075a8: 8801db407630 (0x8801db407630)
>>> 8801db4075b0: 8128a84e (__save_stack_trace+0x6e/0xd0)
>>> 8801db4075b8:  ...
>>> 8801db4075c0: 8801c1e58000 (0x8801c1e58000)
>>> 8801db4075c8: 8801c1e6 (0x8801c1e6)
>>> 8801db4075d0:  ...
>>> 8801db4075d8: 0006 (0x6)
>>> 8801db4075e0: 8801c1e4e000 (0x8801c1e4e000)
>>> 8801db4075e8: 0101 (0x101)
>>> 8801db4075f0:  ...
>>> 8801db4075f8: 8801db4075a8 (0x8801db4075a8)
>>> 8801db407600: 8134ff7d (__twofish_enc_blk_3way+0x1b1d/0x1b30)
>>
>> Looks like the x86_64 "3 way" version of Twofish 
>> (twofish-x86_64-asm_64-3way.S)
>> needs to be updated to not use %rbp.
>
>
> This is what is supposed to be fixed with "crypto: x86/twofish-3way -
> Fix %rbp usage", right? Was it merged anywhere?
> This is one of top crashers with 15K crashes.


#syz fix: crypto: x86/twofish-3way - Fix %rbp usage

Re: [PATCH v3 0/2] Fix out-of-bounds memory accesses in generic-gcm-aesni

[Herbert Xu]

On Wed, Dec 20, 2017 at 05:08:36PM -0800, Junaid Shahid wrote:
> Changelog:
> v3:
> - Fixed a bug in READ_PARTIAL_BLOCK when used for reading the AAD
> - Some refactoring per CR feedback

All applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: scomp - delete unused comments

[Herbert Xu]

On Wed, Dec 20, 2017 at 04:03:12PM +0800, Zhou Wang wrote:
> There are no init and exit callbacks, so delete its comments.
> 
> Signed-off-by: Zhou Wang 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: stm32 - Use standard CONFIG name

[Herbert Xu]

On Wed, Dec 20, 2017 at 06:19:32PM +, Corentin Labbe wrote:
> All hardware crypto devices have their CONFIG names using the following
> convention:
> CRYPTO_DEV_name_algo
> 
> This patch apply this conventions on STM32 CONFIG names.
> 
> Signed-off-by: Corentin Labbe 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 1/4] crypto: caam - constify key data

[Herbert Xu]

On Tue, Dec 19, 2017 at 12:16:04PM +0200, Horia Geantă wrote:
> Key data is not modified, it is copied in the shared descriptor.
> 
> Signed-off-by: Horia Geantă 

All applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/6] crypto: tcrypt: fix and add multi buf speed tests

[Herbert Xu]

On Sun, Dec 17, 2017 at 08:28:59AM +, Gilad Ben-Yossef wrote:
> The performance of some crypto tfm providers is affected by
> the amount of parallelism possible with the processing.
> 
> We already had some support for speed test of multiple concurrent
> requests, dubbed multi buffer, in ahash speed tests.
>   
>   
> This patch set extends said support and add similar support for skcipher
> and AEAD, as well as fixes some odd bugs discovered along the way.
>   
>   
> It is noted that it is possible to consolidate some of the none multi
> buffer speed test code better, but given that tcrypt as a whole is a
> developer testing harness rather than production code, the value of
> this activity seems questionable. Do let me know if you disagree.
> 
> Signed-off-by: Gilad Ben-Yossef 

All applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: x86/twofish-3way - Fix %rbp usage

[Herbert Xu]

On Mon, Dec 18, 2017 at 04:40:26PM -0800, Eric Biggers wrote:
> From: Eric Biggers 
> 
> Using %rbp as a temporary register breaks frame pointer convention and
> breaks stack traces when unwinding from an interrupt in the crypto code.
> 
> In twofish-3way, we can't simply replace %rbp with another register
> because there are none available.  Instead, we use the stack to hold the
> values that %rbp, %r11, and %r12 were holding previously.  Each of these
> values represents the half of the output from the previous Feistel round
> that is being passed on unchanged to the following round.  They are only
> used once per round, when they are exchanged with %rax, %rbx, and %rcx.
> 
> As a result, we free up 3 registers (one per block) and can reassign
> them so that %rbp is not used, and additionally %r14 and %r15 are not
> used so they do not need to be saved/restored.
> 
> There may be a small overhead caused by replacing 'xchg REG, REG' with
> the needed sequence 'mov MEM, REG; mov REG, MEM; mov REG, REG' once per
> round.  But, counterintuitively, when I tested "ctr-twofish-3way" on a
> Haswell processor, the new version was actually about 2% faster.
> (Perhaps 'xchg' is not as well optimized as plain moves.)
> 
> Reported-by: syzbot 
> Signed-off-by: Eric Biggers 

Patch applied.  Thanks.
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] padata: add SPDX identifier

[Herbert Xu]

Cheah Kok Cheong  wrote:
> Add SPDX license identifier according to the type of license text found
> in the file.
> 
> Cc: Philippe Ombredanne 
> Signed-off-by: Cheah Kok Cheong 
> ---
> kernel/padata.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/padata.c b/kernel/padata.c
> index e265953..eb9a9d9 100644
> --- a/kernel/padata.c
> +++ b/kernel/padata.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
>  * padata.c - generic interface to process data streams in parallel
>  *

Steffen, are you OK with this patch?

Thanks,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

[Philippe Ombredanne]

Łukasz,

On Wed, Dec 27, 2017 at 11:12 AM, Łukasz Stelmach
 wrote:
> It was <2017-12-22 pią 19:30>, when Philippe Ombredanne wrote:
>> On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach  
>> wrote:
>>> It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote:
 Łukasz,

 On Fri, Dec 22, 2017 at 2:23 PM, Łukasz Stelmach  
 wrote:
> Add support for True Random Number Generator found in Samsung Exynos
> 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach 
> Reviewed-by: Krzysztof Kozlowski 

 

> --- /dev/null
> +++ b/drivers/char/hw_random/exynos-trng.c
> @@ -0,0 +1,245 @@
> +/*
> + * RNG driver for Exynos TRNGs
> + *
> + * Author: Łukasz Stelmach 
> + *
> + * Copyright 2017 (c) Samsung Electronics Software, Inc.
> + *
> + * Based on the Exynos PRNG driver drivers/crypto/exynos-rng by
> + * Krzysztof Kozłowski 
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation;
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */


 Would you mind using the new SPDX tags documented in Thomas patch set
 [1] rather than this fine but longer legalese?

 And if you could spread the word to others in your team this would be very 
 nice.
 See also this fine article posted by Mauro on the Samsung Open Source
 Group Blog [2]
 Thank you!
>>>
>>> Cool! We've been using SPDX to tag RPM packages in Tizen for three years or
>>> more. ;-)
>>
>> Very nice! any pubic pointers?
>  ^
>
> I assume you request an URL of a publicly available web-page ;-)
>
> https://wiki.tizen.org/Packaging/Guidelines#License_Tag

Thank you!
I reckon it took me a minute to figure why you were making a somewhat
cryptic URL related comment.
Then I realized that I had made a rather unfortunate typo, or may be
it was a freudian slip of sorts :D

-- 
Cordially
Philippe Ombredanne

Re: WARNING: kernel stack regs has bad 'bp' value (2)

[Dmitry Vyukov]

On Thu, Nov 30, 2017 at 10:17 AM, Eric Biggers  wrote:
> On Tue, Nov 28, 2017 at 10:36:01AM -0800, syzbot wrote:
>> WARNING: kernel stack regs at 8801c1e5f468 in syzkaller196611:6199 has
>> bad 'bp' value 0001
>> unwind stack type:0 next_sp:  (null) mask:0x6 graph_idx:0
>> 8801db4075a8: 8801db407630 (0x8801db407630)
>> 8801db4075b0: 8128a84e (__save_stack_trace+0x6e/0xd0)
>> 8801db4075b8:  ...
>> 8801db4075c0: 8801c1e58000 (0x8801c1e58000)
>> 8801db4075c8: 8801c1e6 (0x8801c1e6)
>> 8801db4075d0:  ...
>> 8801db4075d8: 0006 (0x6)
>> 8801db4075e0: 8801c1e4e000 (0x8801c1e4e000)
>> 8801db4075e8: 0101 (0x101)
>> 8801db4075f0:  ...
>> 8801db4075f8: 8801db4075a8 (0x8801db4075a8)
>> 8801db407600: 8134ff7d (__twofish_enc_blk_3way+0x1b1d/0x1b30)
>
> Looks like the x86_64 "3 way" version of Twofish 
> (twofish-x86_64-asm_64-3way.S)
> needs to be updated to not use %rbp.


This is what is supposed to be fixed with "crypto: x86/twofish-3way -
Fix %rbp usage", right? Was it merged anywhere?
This is one of top crashers with 15K crashes.

Re: You will definetely be interested...

[Sra. Angel Rania]

Hi Dear,

Reading your profile has given me courage in search of a reasponsable
and trust worthy Fellow. The past has treated me so awfully but now I
am ready to move on despite of my health condition. I will like to
have a sincere and important discussion with you that will be in your
favor likewise to you and your environment especially to your close
family. Endeavor to reply me and I have attached my picture in case
you long to know who emailed you. I will be waiting to hear from you
as soon as possble.
Thanks for paying attention to my mail and will appreciate so much if
I receive a reply from you for understable details.

Thanks,

Mrs. Rania Hassan

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

[Łukasz Stelmach]

It was <2017-12-22 pią 19:30>, when Philippe Ombredanne wrote:
> On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach  
> wrote:
>> It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote:
>>> Łukasz,
>>>
>>> On Fri, Dec 22, 2017 at 2:23 PM, Łukasz Stelmach  
>>> wrote:
 Add support for True Random Number Generator found in Samsung Exynos
 5250+ SoCs.

 Signed-off-by: Łukasz Stelmach 
 Reviewed-by: Krzysztof Kozlowski 
>>>
>>> 
>>>
 --- /dev/null
 +++ b/drivers/char/hw_random/exynos-trng.c
 @@ -0,0 +1,245 @@
 +/*
 + * RNG driver for Exynos TRNGs
 + *
 + * Author: Łukasz Stelmach 
 + *
 + * Copyright 2017 (c) Samsung Electronics Software, Inc.
 + *
 + * Based on the Exynos PRNG driver drivers/crypto/exynos-rng by
 + * Krzysztof Kozłowski 
 + *
 + * This program is free software; you can redistribute it and/or modify
 + * it under the terms of the GNU General Public License as published by
 + * the Free Software Foundation;
 + *
 + * This program is distributed in the hope that it will be useful,
 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 + * GNU General Public License for more details.
 + */
>>>
>>>
>>> Would you mind using the new SPDX tags documented in Thomas patch set
>>> [1] rather than this fine but longer legalese?
>>>
>>> And if you could spread the word to others in your team this would be very 
>>> nice.
>>> See also this fine article posted by Mauro on the Samsung Open Source
>>> Group Blog [2]
>>> Thank you!
>>
>> Cool! We've been using SPDX to tag RPM packages in Tizen for three years or
>> more. ;-)
>
> Very nice! any pubic pointers?
 ^

I assume you request an URL of a publicly available web-page ;-)

https://wiki.tizen.org/Packaging/Guidelines#License_Tag

-- 
Łukasz Stelmach
Samsung R Institute Poland
Samsung Electronics


signature.asc
Description: PGP signature