Re: INFO: task hung in aead_recvmsg

On Sat, Dec 30, 2017 at 09:37:44AM +0100, Steffen Klassert wrote: > On Sat, Dec 23, 2017 at 02:29:42PM -0600, Eric Biggers wrote: > > [+Cc Steffen Klassert ] > > > > > > I was able to reproduce this by trying to use 'pcrypt' recursively. I am > > not > > 100% sure it is the exact same bug, but

[PATCH v2 2/3] crypto: salsa20 - export generic helpers

From: Eric Biggers Export the Salsa20 constants, transform context, and initialization functions so that they can be reused by the x86 implementation. Signed-off-by: Eric Biggers --- crypto/salsa20_generic.c | 20 +++- include/crypto/salsa20.h | 27 +++

[PATCH v2 0/3] crypto: salsa20 - cleanup and convert to skcipher API

From: Eric Biggers This series converts the Salsa20 implementations over to the skcipher API, in the process fixing a couple bugs and making them be more similar to the ChaCha20 implementations, rather than doing things slightly differently for no good reason. (Note, however, that Salsa20 still

[PATCH v2 3/3] crypto: x86/salsa20 - cleanup and convert to skcipher API

From: Eric Biggers Convert salsa20-asm from the deprecated "blkcipher" API to the "skcipher" API, in the process fixing it up to use the generic helpers. This allows removing the salsa20_keysetup() and salsa20_ivsetup() assembly functions, which aren't performance critical; the C versions do just

[PATCH v2 1/3] crypto: salsa20-generic - cleanup and convert to skcipher API

From: Eric Biggers Convert salsa20-generic from the deprecated "blkcipher" API to the "skcipher" API, in the process fixing it up to be thread-safe (as the crypto API expects) by maintaining each request's state separately from the transform context. Also remove the unnecessary cra_alignmask and

Re: [PATCH v2] hwrng: Clean up RNG list when last hwrng is unregistered

On 12/15/2017 01:55 PM, Gary R Hook wrote: Commit 142a27f0a731 added support for a "best" RNG, and in doing so introduced a hang from rmmod/modprobe -r when the last RNG on the list was unloaded. When the hwrng list is depleted, return the global variables to their original state and decrement a

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

From: "Yang Shi" Date: Fri, 05 Jan 2018 06:46:48 +0800 > Any more comment on this change? These patches were not really submitted properly. If you post a series, the series goes to one destination and one tree. If they are supposed to go to multiple trees, submit them individually rather than

Re: [PATCH] crypto: algapi - fix NULL dereference in crypto_remove_spawns()

On Fri, Dec 29, 2017 at 02:30:19PM -0600, Eric Biggers wrote: > From: Eric Biggers > > syzkaller triggered a NULL pointer dereference in crypto_remove_spawns() > via a program that repeatedly and concurrently requests AEADs > "authenc(cmac(des3_ede-asm),pcbc-aes-aesni)" and hashes "cmac(des3_ede)

Re: [PATCH 0/3] crypto: poly1305 - get rid of cra_alignmask

On Fri, Dec 29, 2017 at 10:10:23AM -0600, Eric Biggers wrote: > This series gets rid of the cra_alignmask set on poly1305-generic and > poly1305-simd, since it was only actually used when outputting the final > digest. By removing the alignmask, the crypto API will no longer need > to waste time a

Re: [PATCH] crypto: algapi - convert cra_refcnt to refcount_t

On Fri, Dec 29, 2017 at 10:00:46AM -0600, Eric Biggers wrote: > From: Eric Biggers > > Reference counters should use refcount_t rather than atomic_t, since the > refcount_t implementation can prevent overflows, reducing the > exploitability of reference leak bugs. crypto_alg.cra_refcount is a >

Re: [PATCH] crypto: algapi - remove unused notifications

On Fri, Dec 29, 2017 at 10:06:46AM -0600, Eric Biggers wrote: > From: Eric Biggers > > There is a message posted to the crypto notifier chain when an algorithm > is unregistered, and when a template is registered or unregistered. But > nothing is listening for those messages; currently there are

Re: [PATCH 0/2] crypto: inside-secure - 2 extra fixes

On Tue, Dec 26, 2017 at 05:21:15PM +0100, Antoine Tenart wrote: > Hi Herbert, > > This series contains two fixes for the Inside Secure SafeXcel crypto > engine driver. The first one removes a warning when the DMA-API debug is > activated and the second one is fixing an issue with the driver in > c

Re: [v1,1/4] crypto: crypto4xx - shuffle iomap in front of request_irq

On Fri, Dec 22, 2017 at 09:18:35PM +0100, Christian Lamparter wrote: > It is possible to avoid the ce_base null pointer check in the > drivers' interrupt handler routine "crypto4xx_ce_interrupt_handler()" > by simply doing the iomap in front of the IRQ registration. > > This way, the ce_base will

Re: [v1] crypto: crypto4xx - perform aead icv check in the driver

On Sat, Dec 23, 2017 at 07:45:46PM +0100, Christian Lamparter wrote: > The ccm-aes-ppc4xx now fails one of testmgr's expected > failure test cases as such: > > |decryption failed on test 10 for ccm-aes-ppc4xx: > |ret was 0, |expected -EBADMSG > > It doesn't look like the hardware sets the authent

Re: [PATCH v5] hwrng: exynos - add Samsung Exynos True RNG driver

On Fri, Dec 22, 2017 at 05:48:35PM +0100, Łukasz Stelmach wrote: > Add support for True Random Number Generator found in Samsung Exynos > 5250+ SoCs. > > Signed-off-by: Łukasz Stelmach > Reviewed-by: Krzysztof Kozlowski Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apa

Re: padata: add SPDX identifier

On Thu, Dec 21, 2017 at 07:35:30PM +0800, Cheah Kok Cheong wrote: > Add SPDX license identifier according to the type of license text found > in the file. > > Cc: Philippe Ombredanne > Signed-off-by: Cheah Kok Cheong > Acked-by: Steffen Klassert Patch applied. Thanks. -- Email: Herbert Xu H

Re: [PATCH v10 7/8] crypto: caam: cleanup CONFIG_64BIT ifdefs when using io{read|write}64

On 1/4/2018 9:16 PM, Logan Gunthorpe wrote: > Clean up the extra ifdefs which defined the wr_reg64 and rd_reg64 > functions in non-64bit cases in favour of the new common > io-64-nonatomic-lo-hi header. > > To be consistent with CAAM engine HW spec: in case of 64-bit registers, > irrespective of d