Hi Antoine,
I love your patch! Yet something to improve:
[auto build test ERROR on next-20180309]
[cannot apply to v4.16-rc4 v4.16-rc3 v4.16-rc2 v4.16-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Antoine-Tenart/crypto-inside-secure-hmac-sha256-sha224-support/20180318-012349
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/crypto/inside-secure/safexcel_hash.c:481:9: sparse: Variable length
array is used.
drivers/crypto/inside-secure/safexcel_hash.c:979:45: sparse: cast to
restricted __le32
drivers/crypto/inside-secure/safexcel_hash.c:980:45: sparse: cast to
restricted __le32
drivers/crypto/inside-secure/safexcel_hash.c:1166:12: sparse: no member
'digest' in struct safexcel_ahash_ctx
drivers/crypto/inside-secure/safexcel_hash.c:189:12: sparse: context
imbalance in 'safexcel_ahash_send_req' - wrong count at exit
drivers/crypto/inside-secure/safexcel_hash.c:1166:12: sparse: generating
address of non-lvalue (8)
drivers/crypto/inside-secure/safexcel_hash.c: In function
'safexcel_hmac_sha256_init':
>> drivers/crypto/inside-secure/safexcel_hash.c:1166:5: error: 'struct
>> safexcel_ahash_ctx' has no member named 'digest'
ctx->digest = CONTEXT_CONTROL_DIGEST_HMAC;
^~
sparse warnings: (new ones prefixed by >>)
drivers/crypto/inside-secure/safexcel_hash.c:481:9: sparse: Variable length
array is used.
drivers/crypto/inside-secure/safexcel_hash.c:979:45: sparse: cast to
restricted __le32
drivers/crypto/inside-secure/safexcel_hash.c:980:45: sparse: cast to
restricted __le32
drivers/crypto/inside-secure/safexcel_hash.c:1166:12: sparse: no member
'digest' in struct safexcel_ahash_ctx
drivers/crypto/inside-secure/safexcel_hash.c:189:12: sparse: context
imbalance in 'safexcel_ahash_send_req' - wrong count at exit
>> drivers/crypto/inside-secure/safexcel_hash.c:1166:12: sparse: generating
>> address of non-lvalue (8)
drivers/crypto/inside-secure/safexcel_hash.c: In function
'safexcel_hmac_sha256_init':
drivers/crypto/inside-secure/safexcel_hash.c:1166:5: error: 'struct
safexcel_ahash_ctx' has no member named 'digest'
ctx->digest = CONTEXT_CONTROL_DIGEST_HMAC;
^~
vim +1166 drivers/crypto/inside-secure/safexcel_hash.c
1160
1161 static int safexcel_hmac_sha256_init(struct ahash_request *areq)
1162 {
1163 struct safexcel_ahash_ctx *ctx =
crypto_ahash_ctx(crypto_ahash_reqtfm(areq));
1164
1165 safexcel_sha256_init(areq);
> 1166 ctx->digest = CONTEXT_CONTROL_DIGEST_HMAC;
1167 return 0;
1168 }
1169
---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip