Re: [PATCH] crypto: correct obvious misspelling "cypto-controller"

2018-09-04 Thread Herbert Xu 
On Tue, Sep 04, 2018 at 09:18:32AM -0500, Rob Herring wrote:
> On Mon, Sep 3, 2018 at 10:09 PM Herbert Xu  
> wrote:
> >
> > On Mon, Aug 06, 2018 at 07:48:52AM -0400, Robert P. J. Day wrote:
> > >
> > > Signed-off-by: Robert P. J. Day 
> >
> > Adding Rob Herring  to the cc list.
> 
> Please resend to DT list if you want me to take it. Otherwise,
> 
> Acked-by: Rob Herring 

Thanks Rob.  Robert, can you resend this to the DT list?

Thanks,
-- 
Email: Herbert Xu 
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[cryptodev:master 22/24] lib/crc-t10dif.c:23:1: sparse: symbol 'crc_t10dif_mutex' was not declared. Should it be static?

2018-09-04 Thread kbuild test robot 
tree:   
https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
head:   a1b22a5f45fe884147a99e7c381bcc48d9b2acef
commit: b76377543b738a6b58b0a7b0a42dd9e16436fee1 [22/24] crc-t10dif: Pick 
better transform if one becomes available
reproduce:
# apt-get install sparse
git checkout b76377543b738a6b58b0a7b0a42dd9e16436fee1
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> lib/crc-t10dif.c:23:1: sparse: symbol 'crc_t10dif_mutex' was not declared. 
>> Should it be static?
>> lib/crc-t10dif.c:93:23: sparse: incorrect type in assignment (different 
>> address spaces) @@expected struct crypto_shash [noderef] *static 
>> [addressable] [toplevel] crct10dif_tfm @@got ressable] [toplevel] 
>> crct10dif_tfm @@
   lib/crc-t10dif.c:93:23:expected struct crypto_shash [noderef] 
*static [addressable] [toplevel] crct10dif_tfm
   lib/crc-t10dif.c:93:23:got struct crypto_shash *
>> lib/crc-t10dif.c:104:27: sparse: incorrect type in argument 1 (different 
>> address spaces) @@expected struct crypto_shash *tfm @@got struct 
>> crypto_shash [noderef] *static [addressable] [struct crypto_shash 
>> *tfm @@
   lib/crc-t10dif.c:104:27:expected struct crypto_shash *tfm
   lib/crc-t10dif.c:104:27:got struct crypto_shash [noderef] *static 
[addressable] [toplevel] [assigned] crct10dif_tfm

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructureOpen Source Technology Center
https://lists.01.org/pipermail/kbuild-all   Intel Corporation

[RFC PATCH cryptodev] crc-t10dif: crc_t10dif_mutex can be static

2018-09-04 Thread kbuild test robot 


Fixes: b76377543b73 ("crc-t10dif: Pick better transform if one becomes 
available")
Signed-off-by: kbuild test robot 
---
 crc-t10dif.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/crc-t10dif.c b/lib/crc-t10dif.c
index 52f577a3..8e144c3 100644
--- a/lib/crc-t10dif.c
+++ b/lib/crc-t10dif.c
@@ -20,7 +20,7 @@
 
 static struct crypto_shash __rcu *crct10dif_tfm;
 static struct static_key crct10dif_fallback __read_mostly;
-DEFINE_MUTEX(crc_t10dif_mutex);
+static DEFINE_MUTEX(crc_t10dif_mutex);
 
 static int crc_t10dif_rehash(struct notifier_block *self, unsigned long val, 
void *data)
 {

Re: [PATCH] crypto: correct obvious misspelling "cypto-controller"

2018-09-04 Thread Rob Herring 
On Mon, Sep 3, 2018 at 10:09 PM Herbert Xu  wrote:
>
> On Mon, Aug 06, 2018 at 07:48:52AM -0400, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day 
>
> Adding Rob Herring  to the cc list.

Please resend to DT list if you want me to take it. Otherwise,

Acked-by: Rob Herring