Re: [PATCH v5 00/11] crypto: crypto_user_stat: misc enhancement

2018-12-06 Thread Herbert Xu
On Thu, Nov 29, 2018 at 02:42:15PM +, Corentin Labbe wrote: > Hello > > This patchset fixes all reported problem by Eric biggers. > > Regards > > Changes since v4: > - Inlined functions when !CRYPTO_STATS > > Changes since v3: > - Added a crypto_stats_init as asked vy Neil Horman > - Fixed

Re: [crypto chcr 1/2] small packet Tx stalls the queue

2018-12-06 Thread Herbert Xu
On Fri, Nov 30, 2018 at 02:31:48PM +0530, Atul Gupta wrote: > Immediate packets sent to hardware should include the work > request length in calculating the flits. WR occupy one flit and > if not accounted result in invalid request which stalls the HW > queue. > > Cc: sta...@vger.kernel.org > Sign

Re: [PATCH] MAINTAINERS: change NX/VMX maintainers

2018-12-06 Thread Herbert Xu
On Tue, Nov 27, 2018 at 03:27:21PM -0200, Paulo Flabiano Smorigo wrote: > Add Breno and Nayna as NX/VMX crypto driver maintainers. Also change my > email address to my personal account and remove Leonidas since he's not > working with the driver anymore. > > Signed-off-by: Paulo Flabiano Smorigo

Re: [PATCH] crypto: cavium/nitrox convert to DEFINE_SHOW_ATTRIBUTE

2018-12-06 Thread Herbert Xu
On Sat, Dec 01, 2018 at 04:56:30AM -0500, Yangtao Li wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Yangtao Li > --- > drivers/crypto/cavium/nitrox/nitrox_debugfs.c | 48 --- > 1 file changed, 9 insertions(+), 39 deletions(-) Patch applied. Th

Re: [PATCH 0/3] new HW version and co-maintainer

2018-12-06 Thread Herbert Xu
On Tue, Nov 13, 2018 at 09:40:34AM +, Gilad Ben-Yossef wrote: > Add support for CryptoCell 703 HW revision and a new co-maintainer. > > Gilad Ben-Yossef (3): > crypto: ccree: add support for CryptoCell 703 > dt-bindings: crypto: ccree: add dt bindings for ccree 703 > MAINTAINERS: ccree:

Crypto Fixes for 4.20

2018-12-06 Thread Herbert Xu
Hi Linus: This push fixes the following issues: - Disable the new crypto stats interface as it's still being changed. - Fix potential uses-after-free in cbc/cfb/pcbc. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Herbert Xu (1): crypto: us

Re: [PATCH v5 00/11] crypto: crypto_user_stat: misc enhancement

2018-12-06 Thread Herbert Xu
On Thu, Nov 29, 2018 at 10:16:26AM -0800, Eric Biggers wrote: > > Herbert, can you send this series to Linus for v4.20 after reviewing it? > We don't want to be stuck with a bad UAPI, and the use-after-free needs to be > fixed anyway too. On second thought, I'm just going to revert the whole inter

[PATCH] crypto: user - support incremental algorithm dumps

2018-12-06 Thread Eric Biggers
From: Eric Biggers CRYPTO_MSG_GETALG in NLM_F_DUMP mode sometimes doesn't return all registered crypto algorithms, because it doesn't support incremental dumps. crypto_dump_report() only permits itself to be called once, yet the netlink subsystem allocates at most ~64 KiB for the skb being dumpe

[PATCH] crypto: adiantum - adjust some comments to match latest paper

2018-12-06 Thread Eric Biggers
From: Eric Biggers The 2018-11-28 revision of the Adiantum paper has revised some notation: - 'M' was replaced with 'L' (meaning "Left", for the left-hand part of the message) in the definition of Adiantum hashing, to avoid confusion with the full message - ε-almost-∆-universal is now abbrev

[PATCH] crypto: xchacha20 - fix comments for test vectors

2018-12-06 Thread Eric Biggers
From: Eric Biggers The kernel's ChaCha20 uses the RFC7539 convention of the nonce being 12 bytes rather than 8, so actually I only appended 12 random bytes (not 16) to its test vectors to form 24-byte nonces for the XChaCha20 test vectors. The other 4 bytes were just from zero-padding the stream

[PATCH] crypto: xchacha - add test vector from XChaCha20 draft RFC

2018-12-06 Thread Eric Biggers
From: Eric Biggers There is a draft specification for XChaCha20 being worked on. Add the XChaCha20 test vector from the appendix so that we can be extra sure the kernel's implementation is compatible. I also recomputed the ciphertext with XChaCha12 and added it there too, to keep the tests for

Re: [PATCH v3 1/2] crypto: Implement a generic crypto statistics

2018-12-06 Thread LABBE Corentin
On Wed, Dec 05, 2018 at 04:04:59PM -0800, Eric Biggers wrote: > Hi Corentin, > > On Wed, Sep 19, 2018 at 10:10:54AM +, Corentin Labbe wrote: > > +int crypto_dump_reportstat(struct sk_buff *skb, struct netlink_callback > > *cb) > > +{ > > + struct crypto_alg *alg; > > + struct crypto_dump_