[PATCH v14 net-next 02/12] ethtool: enable Inline TLS in HW

2018-03-29 Thread Atul Gupta
Ethtool option enables TLS record offload on HW, user configures the feature for netdev capable of Inline TLS. This allows user to define custom sk_prot for Inline TLS sock Signed-off-by: Atul Gupta --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files

[PATCH v14 net-next 03/12] cxgb4: Inline TLS FW Interface

2018-03-29 Thread Atul Gupta
Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta Reviewed-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 122 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 + drivers

[PATCH v14 net-next 04/12] cxgb4: LLD driver changes to support TLS

2018-03-29 Thread Atul Gupta
Read the Inline TLS capability from firmware. Determine the area reserved for storing the keys Dump the Inline TLS tx and rx records count. Signed-off-by: Atul Gupta Reviewed-by: Michael Werner Reviewed-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32

[PATCH v14 net-next 05/12] crypto: chcr - Inline TLS Key Macros

2018-03-29 Thread Atul Gupta
Define macro for programming the TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1 deletion(-) diff --git a

[PATCH v14 net-next 06/12] crypto: chtls - structure and macro for Inline TLS

2018-03-29 Thread Atul Gupta
Define Inline TLS state, connection management info. Supporting macros definition. Signed-off-by: Atul Gupta Reviewed-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls.h| 483 drivers/crypto/chelsio/chtls/chtls_cm.h | 203 ++ 2 files

[PATCH v14 net-next 07/12] crypto: chtls - Program the TLS session Key

2018-03-29 Thread Atul Gupta
Initialize the space reserved for storing the TLS keys, get and free the location where key is stored for the TLS connection. Program the Tx and Rx key as received from user in struct tls12_crypto_info_aes_gcm_128 and understood by hardware. added socket option TLS_RX Signed-off-by: Atul Gupta

[PATCH v14 net-next 10/12] crypto: chtls - Inline TLS record Rx

2018-03-29 Thread Atul Gupta
handler for record receive. plain text copied to user buffer Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_io.c | 604 +++- 1 file changed, 603 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chtls

[PATCH v14 net-next 12/12] crypto: chtls - Makefile Kconfig

2018-03-29 Thread Atul Gupta
Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16 insertions(+) create mode

[PATCH v14 net-next 11/12] crypto: chtls - Register chtls with net tls

2018-03-29 Thread Atul Gupta
Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta Reviewed-by: Casey Leedom Reviewed-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_main.c

[PATCH v14 net-next 09/12] crypto: chtls - Inline TLS record Tx

2018-03-29 Thread Atul Gupta
TLS handler for record transmit. Create Inline TLS work request and post to FW. Create Inline TLS record CPLs for hardware Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_io.c | 1248 +++ 1 file changed, 1248 insertions

[PATCH v14 net-next 08/12] crypto : chtls - CPL handler definition

2018-03-29 Thread Atul Gupta
Exchange messages with hardware to program the TLS session CPL handlers for messages received from chip. Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2145 +++ net/ipv4/tcp_minisocks.c|1

Re: [PATCH v14 net-next 08/12] crypto : chtls - CPL handler definition

2018-03-29 Thread Atul Gupta
On 3/29/2018 9:56 PM, Sabrina Dubroca wrote: > 2018-03-29, 21:27:50 +0530, Atul Gupta wrote: > ... >> +static void chtls_pass_accept_request(struct sock *sk, >> + struct sk_buff *skb) >> +{ > ... >> +if (chtls_get_module(ne

Re: [PATCH v14 net-next 09/12] crypto: chtls - Inline TLS record Tx

2018-03-29 Thread Atul Gupta
On 3/29/2018 9:56 PM, Sabrina Dubroca wrote: > 2018-03-29, 21:27:51 +0530, Atul Gupta wrote: >> TLS handler for record transmit. >> Create Inline TLS work request and post to FW. >> Create Inline TLS record CPLs for hardware >> >> Signed-off-by: Atul Gupta

[PATCH v15 net-next 03/12] cxgb4: Inline TLS FW Interface

2018-03-31 Thread Atul Gupta
Key area size in hw-config file. CPL struct for TLS request and response. Work request for Inline TLS. Signed-off-by: Atul Gupta Reviewed-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 122 ++- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 + drivers

[PATCH v15 net-next 00/12] Chelsio Inline TLS

2018-03-31 Thread Atul Gupta
an Mueller, Stefano Brivio and Hannes Frederic -Added more details in cover letter -Fixed indentation and formating issues -Using aes instead of aes-generic -memset key info after programing the key on chip -reordered the patch sequence Atul Gupta (12): tls: support for I

[PATCH v15 net-next 01/12] tls: support for Inline tls record

2018-03-31 Thread Atul Gupta
Signed-off-by: Atul Gupta Reviewed-by: Steve Wise --- include/net/tls.h | 32 ++- net/tls/tls_main.c | 114 +++-- 2 files changed, 142 insertions(+), 4 deletions(-) diff --git a/include/net/tls.h b/include/net/tls.h index 437a746

[PATCH v15 net-next 02/12] ethtool: enable Inline TLS in HW

2018-03-31 Thread Atul Gupta
Ethtool option enables TLS record offload on HW, user configures the feature for netdev capable of Inline TLS. This allows user to define custom sk_prot for Inline TLS sock Signed-off-by: Atul Gupta --- include/linux/netdev_features.h | 2 ++ net/core/ethtool.c | 1 + 2 files

[PATCH v15 net-next 05/12] crypto: chcr - Inline TLS Key Macros

2018-03-31 Thread Atul Gupta
Define macro for programming the TLS Key context Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.h | 42 + drivers/crypto/chelsio/chcr_core.h | 55 +- 2 files changed, 96 insertions(+), 1 deletion(-) diff --git a

[PATCH v15 net-next 06/12] crypto: chtls - structure and macro for Inline TLS

2018-03-31 Thread Atul Gupta
Define Inline TLS state, connection management info. Supporting macros definition. Signed-off-by: Atul Gupta Reviewed-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls.h| 482 drivers/crypto/chelsio/chtls/chtls_cm.h | 203 ++ 2 files

[PATCH v15 net-next 08/12] crypto : chtls - CPL handler definition

2018-03-31 Thread Atul Gupta
Exchange messages with hardware to program the TLS session CPL handlers for messages received from chip. Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_cm.c | 2126 +++ net/ipv4/tcp_minisocks.c|1

[PATCH v15 net-next 04/12] cxgb4: LLD driver changes to support TLS

2018-03-31 Thread Atul Gupta
Read the Inline TLS capability from firmware. Determine the area reserved for storing the keys Dump the Inline TLS tx and rx records count. Signed-off-by: Atul Gupta Reviewed-by: Michael Werner Reviewed-by: Casey Leedom --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 32

[PATCH v15 net-next 10/12] crypto: chtls - Inline TLS record Rx

2018-03-31 Thread Atul Gupta
handler for record receive. plain text copied to user buffer Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_io.c | 602 +- drivers/crypto/chelsio/chtls/chtls_main.c | 1 + 2 files changed, 602 insertions(+), 1

[PATCH v15 net-next 07/12] crypto: chtls - Register chtls with net tls

2018-03-31 Thread Atul Gupta
Register chtls as Inline TLS driver, chtls is ULD to cxgb4. Setsockopt to program (tx/rx) keys on chip. Support AES GCM of key size 128. Support both Inline Rx and Tx. Signed-off-by: Atul Gupta Reviewed-by: Casey Leedom Reviewed-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_main.c

[PATCH v15 net-next 11/12] crypto: chtls - Program the TLS session Key

2018-03-31 Thread Atul Gupta
Initialize the space reserved for storing the TLS keys, get and free the location where key is stored for the TLS connection. Program the Tx and Rx key as received from user in struct tls12_crypto_info_aes_gcm_128 and understood by hardware. added socket option TLS_RX Signed-off-by: Atul Gupta

[PATCH v15 net-next 12/12] crypto: chtls - Makefile Kconfig

2018-03-31 Thread Atul Gupta
Entry for Inline TLS as another driver dependent on cxgb4 and chcr Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/Kconfig| 11 +++ drivers/crypto/chelsio/Makefile | 1 + drivers/crypto/chelsio/chtls/Makefile | 4 3 files changed, 16 insertions(+) create mode

[PATCH v15 net-next 09/12] crypto: chtls - Inline TLS record Tx

2018-03-31 Thread Atul Gupta
TLS handler for record transmit. Create Inline TLS work request and post to FW. Create Inline TLS record CPLs for hardware Signed-off-by: Atul Gupta Signed-off-by: Michael Werner --- drivers/crypto/chelsio/chtls/chtls_io.c | 1222 + drivers/crypto/chelsio/chtls

Re: [crypto-chtls] Supicious code in chtls_io

2018-04-04 Thread Atul Gupta
On 4/4/2018 3:16 AM, Gustavo A. R. Silva wrote: > Hi all, > > While doing some static analysis I came across the following piece of code at > drivers/crypto/chelsio/chtls/chtls_io.c:1203: > > 1203 if (!size) > 1204 break; > 1205 > 1206 if

[PATCH 1/7] chtls: wait for memory in Tx path

2018-04-25 Thread Atul Gupta
wait for memory in sendmsg and sendpage Reported-by: Gustavo A. R. Silva Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 1 + drivers/crypto/chelsio/chtls/chtls_io.c | 90 +-- drivers/crypto/chelsio/chtls/chtls_main.c | 1 + 3 files

[PATCH 2/7] chtls: support only 128b key length

2018-04-25 Thread Atul Gupta
corrected the key length to copy 128b key. Removed 192b and 256b key as user input supports key of size 128b in gcm_ctx Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

[PATCH 3/7] chtls: variable dereferenced before null check

2018-04-25 Thread Atul Gupta
skb dereferenced before check in sendpage Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c

[PATCH 4/7] chtls: kbuild warnings

2018-04-25 Thread Atul Gupta
- unindented continue - check for null page - signed return Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto

[PATCH 5/7] chtls: free beyond end of array rspq_skb_cache

2018-04-25 Thread Atul Gupta
Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c index e9ffc3d..4dc3d0e 100644 --- a

[PATCH 6/7] chtls: generic handling for data and header

2018-04-25 Thread Atul Gupta
removed redundant check and made TLS PDU and header recv handling common as received from HW Signed-off-by: Atul Gupta Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chtls/chtls.h| 10 ++ drivers/crypto/chelsio/chtls/chtls_cm.c | 12 +--- drivers/crypto/chelsio/chtls

[PATCH 7/7] chtls: handling HW supported sockopt

2018-04-25 Thread Atul Gupta
some of the supported socket options are sent to HW while rest are handled by SW Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 10 ++ drivers/crypto/chelsio/chtls/chtls_cm.h | 12 ++ drivers/crypto/chelsio/chtls/chtls_hw.c | 2 +- drivers/crypto/chelsio/chtls

[PATCH v2 2/7] crypto:chtls: key len correction

2018-05-01 Thread Atul Gupta
corrected the key length to copy 128b key. Removed 192b and 256b key as user input supports key of size 128b in gcm_ctx Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

[PATCH v2 4/7] crypto: chtls: kbuild warnings

2018-05-01 Thread Atul Gupta
- unindented continue - check for null page - signed return Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto

[PATCH v2 1/7] crypto: chtls: wait for memory sendmsg, sendpage

2018-05-01 Thread Atul Gupta
Reported-by: Gustavo A. R. Silva Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 1 + drivers/crypto/chelsio/chtls/chtls_io.c | 90 +-- drivers/crypto/chelsio/chtls/chtls_main.c | 1 + 3 files changed, 89 insertions(+), 3 deletions

[PATCH v2 3/7] crypto: chtls: dereference null variable

2018-05-01 Thread Atul Gupta
skb dereferenced before check in sendpage Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c

[PATCH v2 5/7] crypto: chtls: free beyond end rspq_skb_cache

2018-05-01 Thread Atul Gupta
Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c index e9ffc3d..1ef56d6 100644 --- a

[PATCH v2 6/7] crypto: chtls: generic handling of data and hdr

2018-05-01 Thread Atul Gupta
removed redundant check and made TLS PDU and header recv handling common as received from HW Signed-off-by: Atul Gupta Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chtls/chtls.h| 10 ++ drivers/crypto/chelsio/chtls/chtls_cm.c | 12 +--- drivers/crypto/chelsio/chtls

[PATCH v2 7/7] crypto: chtls: HW supported socket opt

2018-05-01 Thread Atul Gupta
HW supported socket options are handled by HW while rest are handled by SW Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 10 ++ drivers/crypto/chelsio/chtls/chtls_cm.h | 12 ++ drivers/crypto/chelsio/chtls/chtls_hw.c | 2 +- drivers/crypto/chelsio/chtls

Re: [PATCH v15 net-next 00/12] Chelsio Inline TLS

2018-05-09 Thread Atul Gupta
On 4/1/2018 6:27 PM, Boris Pismenny wrote: > Hi, > > On 4/1/2018 6:37 AM, David Miller wrote: >> From: Atul Gupta >> Date: Sat, 31 Mar 2018 21:41:51 +0530 >> >>> Series for Chelsio Inline TLS driver (chtls) >> >> Series applied, thank you. >

[PATCH] crypto: chelsio: request to HW should wrap

2018-05-09 Thread Atul Gupta
-Tx request and data is copied to HW Q in 64B desc, check for end of queue and adjust the current position to start from beginning before passing the additional request info. -key context copy should check key length only -Few reverse christmas tree correction Signed-off-by: Atul Gupta

RE: [PATCH v2 1/7] crypto: chtls: wait for memory sendmsg, sendpage

2018-05-11 Thread Atul Gupta
To: Atul Gupta Cc: linux-crypto@vger.kernel.org; gust...@embeddedor.com Subject: Re: [PATCH v2 1/7] crypto: chtls: wait for memory sendmsg, sendpage On Wed, May 02, 2018 at 12:25:33AM +0530, Atul Gupta wrote: > Reported-by: Gustavo A. R. Silva > Signed-off-by: Atul Gupta These patches

[PATCH 3/5] crypto: chtls: dereference null variable

2018-05-14 Thread Atul Gupta
skb dereferenced before check in sendpage Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c

[PATCH 2/5] crypto: chtls: wait for memory sendmsg, sendpage

2018-05-14 Thread Atul Gupta
Reported-by: Gustavo A. R. Silva Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 1 + drivers/crypto/chelsio/chtls/chtls_io.c | 90 +-- drivers/crypto/chelsio/chtls/chtls_main.c | 1 + 3 files changed, 89 insertions(+), 3 deletions

[PATCH 1/5] crypto:chtls: key len correction

2018-05-14 Thread Atul Gupta
corrected the key length to copy 128b key. Removed 192b and 256b key as user input supports key of size 128b in gcm_ctx Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

[PATCH 4/5] crypto: chtls: kbuild warnings

2018-05-14 Thread Atul Gupta
- unindented continue - check for null page - signed return Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto

[PATCH 0/5] build warnings cleanup

2018-05-14 Thread Atul Gupta
Build warnings cleanup reported for - using only 128b key - wait for buffer in sendmsg/sendpage - check for null before using skb - free rspq_skb_cache in error path - indentation Atul Gupta (5): crypto:chtls: key len correction crypto: chtls: wait for memory sendmsg, sendpage crypto: chtls

[PATCH 5/5] crypto: chtls: free beyond end rspq_skb_cache

2018-05-14 Thread Atul Gupta
Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c index e9ffc3d..1ef56d6 100644 --- a

[PATCH] crypto: chtls: generic handling of data and hdr

2018-05-14 Thread Atul Gupta
removed redundant check and made TLS PDU and header recv handling common as received from HW. Ensure that only tls header is read in cpl_rx_tls_cmp read-ahead and skb is freed when entire data is processed. Signed-off-by: Atul Gupta Signed-off-by: Harsh Jain --- drivers/crypto/chelsio/chtls

[PATCH v2 4/5] crypto: chtls: kbuild warnings

2018-05-27 Thread Atul Gupta
- unindented continue - check for null page - signed return Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto

[PATCH v2 2/5] crypto: chtls: wait for memory sendmsg, sendpage

2018-05-27 Thread Atul Gupta
do_rm_wq Reported-by: Gustavo A. R. Silva Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 1 + drivers/crypto/chelsio/chtls/chtls_io.c | 90 +-- drivers/crypto/chelsio/chtls/chtls_main.c | 1 + 3 files changed,

[PATCH v2 3/5] crypto: chtls: dereference null variable

2018-05-27 Thread Atul Gupta
skb dereferenced before check in sendpage Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_io.c b/drivers/crypto/chelsio/chtls/chtls_io.c

[PATCH v2 5/5] crypto: chtls: free beyond end rspq_skb_cache

2018-05-27 Thread Atul Gupta
Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_main.c b/drivers/crypto/chelsio/chtls/chtls_main.c index 273afd3..9b07f91 100644 --- a

[PATCH v2 1/5] crypto:chtls: key len correction

2018-05-27 Thread Atul Gupta
corrected the key length to copy 128b key. Removed 192b and 256b key as user input supports key of size 128b in gcm_ctx Reported-by: Dan Carpenter Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_hw.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a

[PATCH v2 0/5] build warnings cleanup

2018-05-27 Thread Atul Gupta
Build warnings cleanup reported for - using only 128b key - wait for buffer in sendmsg/sendpage - check for null before using skb - free rspq_skb_cache in error path - indentation v2: Added bug report description for 0002 Incorported comments from Dan Carpenter Atul Gupta (5): crypto:chtls

[PATCH 1/4] crypto:chelsio Fix NULL pointer dereference

2019-05-02 Thread Atul Gupta
Do not request FW to generate cidx update if there is less space in tx queue to post new request. SGE DBP 1 pidx increment too large BUG: unable to handle kernel NULL pointer dereference at 0124 SGE error for queue 101 Signed-off-by: Atul Gupta --- drivers/crypto/chelsio

[PATCH 2/4] crypto:chelsio Fix softlockup with heavy I/O

2019-05-02 Thread Atul Gupta
removed un-necessary lock_chcr_dev to protect device state DETACH. lock is not required to protect I/O count Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c | 13 +++-- drivers/crypto/chelsio/chcr_core.c | 4 2 files changed, 3 insertions(+), 14 deletions(-) diff

[PATCH 3/4] crypto:chelsio count incomplete block in IV

2019-05-02 Thread Atul Gupta
The partial block should count as one and appropriately appended to IV. eg 499B for AES CTR should count 32 block than 31 and correct count value is updated in iv out. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_algo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 4/4] MAINTAINERS: Maintainer for Chelsio crypto driver

2019-05-02 Thread Atul Gupta
Modified the maintainer name Signed-off-by: Atul Gupta --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e17ebf7..0d0dda5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4254,7 +4254,7 @@ F:drivers/infiniband/hw/cxgb3/ F

[crypto chcr 1/2] small packet Tx stalls the queue

2018-11-30 Thread Atul Gupta
Immediate packets sent to hardware should include the work request length in calculating the flits. WR occupy one flit and if not accounted result in invalid request which stalls the HW queue. Cc: sta...@vger.kernel.org Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_ipsec.c | 5

[crypto chcr 2/2] ESN for Inline IPSec Tx

2018-11-30 Thread Atul Gupta
Send SPI, 64b seq nos and 64b IV with aadiv drop for inline crypto. This information is added in outgoing packet after the CPL TX PKT XT and removed by hardware. The aad, auth and cipher offsets are then adjusted for ESN enabled tunnel. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio

[tls 1/5] net/tls: Init routines in create_ctx

2018-12-11 Thread Atul Gupta
create_ctx is called from tls_init and tls_hw_prot hence initialize function pointers in common routine. Signed-off-by: Atul Gupta --- net/tls/tls_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c index 311cec8..4920803

[tls 3/5] crypto/chelsio/chtls: listen fails with multiadapt

2018-12-11 Thread Atul Gupta
listen fails when more than one tls capable device is registered. tls_hw_hash is called for each dev which loops again for each cdev_list causing listen failure. Hence call chtls_listen_start/stop for specific device than loop over all devices. Signed-off-by: Atul Gupta --- drivers/crypto

[tls 4/5] crypto/chelsio/chtls: macro correction in tx path

2018-12-11 Thread Atul Gupta
corrected macro used in tx path. removed redundant hdrlen and check for !page in chtls_sendmsg Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_io.c | 20 drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 3 +++ 2 files changed, 11 insertions(+), 12

[tls 5/5] crypto/chelsio/chtls: send/recv window update

2018-12-11 Thread Atul Gupta
recalculated send and receive window using linkspeed. Determine correct value of eck_ok from SYN received and option configured on local system. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h| 2 + drivers/crypto/chelsio/chtls/chtls_cm.c | 78

[tls 2/5] net/tls: sleeping function from invalid context

2018-12-11 Thread Atul Gupta
/0x1e0 Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_main.c | 55 ++- include/net/tls.h | 6 net/tls/tls_main.c| 36 3 files changed, 61 insertions(+), 36 deletions(-) diff

[PATCH 2/2] crypto/chelsio: Inline single pdu only

2019-01-17 Thread Atul Gupta
Inline single pdu else take co-pro path Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_ipsec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/crypto/chelsio/chcr_ipsec.c b/drivers/crypto/chelsio/chcr_ipsec.c index 4f24646..0c826d0 100644 --- a/drivers/crypto/chelsio

[PATCH 1/2] crypto/chelsio: avoid using sa_entry imm

2019-01-17 Thread Atul Gupta
use is_eth_imm to determine immediate data than use sa_entry field which is common for tunnel and not per skb. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_core.h | 2 +- drivers/crypto/chelsio/chcr_ipsec.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff

[net-next 2/3] net/tls: free ctx in sock destruct

2019-01-17 Thread Atul Gupta
] tcp_v4_do_rcv+0xaf/0x1e0 Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 4 net/tls/tls_main.c | 19 +-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/chelsio/chtls/chtls_cm.c b/drivers/crypto

[net-next 1/3] net/tls: build_protos moved to common routine

2019-01-17 Thread Atul Gupta
build protos is required for tls_hw_prot also hence moved to 'tls_build_proto' and called as required from tls_init and tls_hw_proto. This is required since build_protos for v4 is moved from tls_register to tls_init in commit <28cb6f1eaffdc5a6a9707cac55f4a43aa3fd7895> Signed-of

[net-next 3/3] cxgb4: TLS record offload enable

2019-01-17 Thread Atul Gupta
Enable Inline TLS record by default Signed-off-by: Atul Gupta --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c index

[RFC patch 0/4] Inline TLS client and v6

2019-01-17 Thread Atul Gupta
TLS offload. [0004] Adds IPv6 support to Inline TLS server and client. Atul Gupta (4): net/tls: connect routine for Inline TLS client crypto/chelsio/chtls: hardware connect API crypto/chelsio/chtls: CPL for TLS client crypto/chelsio/chtls: IPv6 for Inline TLS drivers/crypto/chelsio/chtls

[RFC patch 1/4] net/tls: connect routine for Inline TLS client

2019-01-17 Thread Atul Gupta
Define tls_hw_connect to setup Inline TLS client before TLS handshake and key program Signed-off-by: Atul Gupta --- include/net/tls.h | 5 + net/tls/tls_main.c | 23 +++ 2 files changed, 28 insertions(+) diff --git a/include/net/tls.h b/include/net/tls.h index 90bf52d

[RFC patch 2/4] crypto/chelsio/chtls: hardware connect API

2019-01-17 Thread Atul Gupta
Hardware specific implementation for TLS client processing. Added connect routine to prepare hardware for TLS client handshake. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 6 +- drivers/crypto/chelsio/chtls/chtls_cm.c | 533

[RFC patch 2/4] crypto/chelsio/chtls: hardware connect API

2019-01-17 Thread Atul Gupta
Hardware specific implementation for TLS client processing. Added connect routine to prepare hardware for TLS client handshake. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h | 6 +- drivers/crypto/chelsio/chtls/chtls_cm.c | 533

[RFC patch 3/4] crypto/chelsio/chtls: CPL for TLS client

2019-01-17 Thread Atul Gupta
CPL processing for Inline TLS client. Exchange messages with hardware to setup connection. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls.h| 12 +- drivers/crypto/chelsio/chtls/chtls_cm.c | 308 +++- drivers/crypto/chelsio/chtls/chtls_cm.h

[RFC patch 4/4] crypto/chelsio/chtls: IPv6 for Inline TLS

2019-01-17 Thread Atul Gupta
Extends support to IPv6 for Inline TLS server and client. Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chtls/chtls_cm.c | 473 +++--- drivers/crypto/chelsio/chtls/chtls_cm.h | 3 + drivers/crypto/chelsio/chtls/chtls_main.c | 27 +- include/net/transp_v6.h

[PATCH] crypto/chelsio/chcr: Fixed Traffic Stall

2019-02-18 Thread Atul Gupta
Fixed Traffic Stall caused by - Subcommands except last should have more bit set - For esn case subcommand is required for linear skb only - Also Optimized is_eth_imm usage Signed-off-by: Atul Gupta --- drivers/crypto/chelsio/chcr_ipsec.c | 33 - 1 file changed

<    1   2   3