Re: [PATCH 2/2] crypto: marvell - Don't break chain for computable last ahash requests

2016-08-20 Thread Boris Brezillon
On Thu, 18 Aug 2016 14:12:14 +0200 Romain Perier wrote: > Currently, the driver breaks chain for all kind of hash requests in order > to don't override intermediate states of partial ahash updates. However, > some final ahash requests can be directly processed

Re: [PATCH] crypto: mv_cesa: remove NO_IRQ reference

2016-09-03 Thread Boris Brezillon
orm_get_irq() does the same thing) > > This removes the call to irq_of_parse_and_map() and checks for > the error code correctly. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > driver

Re: [PATCH v3 1/2] crypto: marvell - Use an unique pool to copy results of requests

2016-10-04 Thread Boris Brezillon
, gfp_flags); > if (IS_ERR(tdma)) > return PTR_ERR(tdma); > > - iv = dma_pool_alloc(cesa_dev->dma->iv_pool, gfp_flags, _handle); > - if (!iv) > - return -ENOMEM; Can you add a comment explaining what you're doing here? /* We

Re: [PATCH v3 2/2] crypto: marvell - Don't break chain for computable last ahash requests

2016-10-04 Thread Boris Brezillon
On Tue, 4 Oct 2016 14:57:20 +0200 Romain Perier wrote: > Currently, the driver breaks chain for all kind of hash requests in order to > don't override intermediate states of partial ahash updates. However, some > final > ahash requests can be directly

Re: [PATCH 2/2] crypto: marvell - Don't corrupt state of an STD req for re-stepped ahash

2016-12-02 Thread Boris Brezillon
On Fri, 2 Dec 2016 17:05:51 +0100 Romain Perier wrote: > mv_cesa_hash_std_step always copies creq->state into the SRAM. If an IRQ > is triggered while the current STD request is not finished, this request > will be stepped again and the initial state will be

Re: [PATCH 1/2] crypto: marvell - Don't copy hash operation twice into the SRAM

2016-12-02 Thread Boris Brezillon
On Fri, 2 Dec 2016 17:05:50 +0100 Romain Perier wrote: > No need to copy the template of an hash operation twice into the SRAM > from the step function. > > Fixes: commit 85030c5168f1 ("crypto: marvell - Add support for chai...") > Signed-off-by: Romain Perier

Re: [PATCH 1/2] crypto: marvell - Don't copy hash operation twice into the SRAM

2016-12-02 Thread Boris Brezillon
t; Signed-off-by: Romain Perier <romain.per...@free-electrons.com> Acked-by: Boris Brezillon <boris.brezil...@free-electron.com> > --- > drivers/crypto/marvell/hash.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/crypto/marvell/hash.c b/dri

Re: [PATCH v5 04/19] crypto: marvell/cesa: remove redundant backlog checks on EBUSY

2017-08-15 Thread Boris Brezillon
-by: Gilad Ben-Yossef <gi...@benyossef.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > drivers/crypto/marvell/cesa.c | 3 +-- > drivers/crypto/marvell/cesa.h | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/dri

Re: [PATCH v2 4/9] crypto: marvell - Use IPAD/OPAD constant

2017-05-19 Thread Boris Brezillon
On Fri, 19 May 2017 08:53:26 +0200 Corentin Labbe <clabbe.montj...@gmail.com> wrote: > This patch simply replace all occurrence of HMAC IPAD/OPAD value by their > define. > > Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> Acked-by: Boris Brezillon <boris.b

Re: [PATCH] crypto: atmel-aes - properly set IV after {en,de}crypt

2017-10-10 Thread Boris Brezillon
Hi Romain, May I ask why you're sending this patch to the MTD ML? While I'm here, can you have a look at this patch [1] and add you Reviewed-by/Tested-by? Thanks, Boris [1]http://patchwork.ozlabs.org/patch/821959/ On Fri, 6 Oct 2017 17:51:08 +0200 Romain Izard

[PATCH] crypto: marvell - Switch cipher algs to the skcipher interface

2017-10-13 Thread Boris Brezillon
in internal struct or function names. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/crypto/marvell/cesa.c | 10 +- drivers/crypto/marvell/cesa.h | 25 ++- drivers/crypto/marvell/cipher.c | 476 3 files change

Re: [PATCH] crypto: marvell - Switch cipher algs to the skcipher interface

2017-10-13 Thread Boris Brezillon
On Fri, 13 Oct 2017 15:30:32 +0200 Boris Brezillon <boris.brezil...@free-electrons.com> wrote: > crypto_alg is not supposed to be directly implemented by crypto engine > driver. Drivers should instead implement specialized interfaces like *drivers. > ahash_alg or skcipher_al

[PATCH 3/3] crypto: marvell - Remove the old mv_cesa driver

2017-10-11 Thread Boris Brezillon
-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/crypto/Kconfig| 22 +- drivers/crypto/Makefile |1 - drivers/crypto/marvell/cesa.c |7 - drivers/crypto/mv_cesa.c | 1216 - drivers/crypto/mv_cesa.h

[PATCH 0/3] crypto: marvell - Remove the old CESA driver

2017-10-11 Thread Boris Brezillon
, if this series is accepted it will have to go through a single tree (either ARM or crypto). Regards, Boris Boris Brezillon (3): crypto: marvell - Add a platform_device_id table ARM: configs: Stop selecting the old CESA driver crypto: marvell - Remove the old mv_cesa driver arch/arm/configs

[PATCH 1/3] crypto: marvell - Add a platform_device_id table

2017-10-11 Thread Boris Brezillon
Add a platform_device_id table to allow using this driver on orion platforms that have not been converted to DT. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- drivers/crypto/marvell/cesa.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/m

[PATCH 2/3] ARM: configs: Stop selecting the old CESA driver

2017-10-11 Thread Boris Brezillon
A new driver has been developed to support the CESA IP. Switch remaining users of the old driver to the new driver in order to remove the old one. Signed-off-by: Boris Brezillon <boris.brezil...@free-electrons.com> --- arch/arm/configs/dove_defconfig | 2 +- arch/arm/c

Re: [cryptodev:master 125/166] FATAL: drivers/crypto/marvell/marvell-cesa: struct platform_device_id is not terminated with a NULL entry!

2017-11-03 Thread Boris Brezillon
Hi Herbert, On Sat, 4 Nov 2017 00:38:26 +0800 kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git > master > head: 7a373fd74a8d1c4882e0236cc38345cec1393505 > commit: 7b0c3d693ce65900dd3c79766185f539fa37a29a

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Boris Brezillon
() - admittedly that > didn't exist when the offending code was first merged, but it does now. > > Signed-off-by: Robin Murphy <robin.mur...@arm.com> Acked-by: Boris Brezillon <boris.brezil...@free-electrons.com> > --- > > Found by inspection and compile-tested

Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse

2018-01-10 Thread Boris Brezillon
Hi Christoph, On Wed, 10 Jan 2018 16:48:17 +0100 Christoph Hellwig <h...@lst.de> wrote: > On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote: > > On Wed, 10 Jan 2018 15:15:43 + > > Robin Murphy <robin.mur...@arm.com> wrote: > > > >

[PATCH] Update Boris Brezillon email address

2018-02-16 Thread Boris Brezillon
Free Electrons is now Bootlin. Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> --- Note that I'm planning to take this patch through the MTD tree. --- .mailmap| 7 --- MAINTAINERS | 10 +- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.mai

Re: [PATCH] Update Boris Brezillon email address

2018-02-22 Thread Boris Brezillon
On Fri, 16 Feb 2018 11:44:49 +0100 Boris Brezillon <boris.brezil...@bootlin.com> wrote: > Free Electrons is now Bootlin. > > Signed-off-by: Boris Brezillon <boris.brezil...@bootlin.com> > --- > Note that I'm planning to take this patch through the MTD tree. Appl

Re: [PATCH] Update Boris Brezillon email address

2018-02-16 Thread Boris Brezillon
On Fri, 16 Feb 2018 16:35:27 +0100 Kamil Konieczny <k.koniec...@partner.samsung.com> wrote: > On 16.02.2018 15:54, Boris Brezillon wrote: > > Adding back all the people that were Cc-ed on the initial email. > > > > On Fri, 16 Feb 2018 15:18:21 +0100 &g

Re: [PATCH] Update Boris Brezillon email address

2018-02-16 Thread Boris Brezillon
Adding back all the people that were Cc-ed on the initial email. On Fri, 16 Feb 2018 15:18:21 +0100 Kamil Konieczny <k.koniec...@partner.samsung.com> wrote: > On 16.02.2018 15:00, Boris Brezillon wrote: > > On Fri, 16 Feb 2018 12:21:53 +0100 > > Kamil Konieczny <k.konie

Re: [PATCH 00/47] arch-removal: device drivers

2018-03-14 Thread Boris Brezillon
the mtd patches through the MTD tree. As you've probably noticed, nand code has been moved around and it's easier for me to carry those 2 simple changes in my tree than creating an immutable branch. Let me know if this is a problem. Regards, Boris -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com

<    1   2   3