Re: [PATCH] crypto/nx/nx-842: dev_set_drvdata can no longer fail

2014-05-28 Thread Greg Kroah-Hartman
On Wed, May 28, 2014 at 02:02:24PM +0200, Jean Delvare wrote: > Don't check if dev_set_drvdata() failed, it can't, and it returns void > now. > > Signed-off-by: Jean Delvare > Cc: Greg Kroah-Hartman > Cc: Robert Jennings > Cc: Marcelo Henrique Cerri > Cc: F

[PATCH 3.16 054/125] crypto: ux500 - make interrupt mode plausible

2014-09-03 Thread Greg Kroah-Hartman
el.org Cc: Fabio Baltieri Cc: Linus Walleij Cc: Herbert Xu Cc: "David S. Miller" Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/ux500/cryp/cryp_core.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) --- a/drivers/cry

[PATCH 3.14 38/88] crypto: ux500 - make interrupt mode plausible

2014-09-03 Thread Greg Kroah-Hartman
el.org Cc: Fabio Baltieri Cc: Linus Walleij Cc: Herbert Xu Cc: "David S. Miller" Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/ux500/cryp/cryp_core.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) --- a/drivers/cry

[PATCH 3.10 27/55] crypto: ux500 - make interrupt mode plausible

2014-09-03 Thread Greg Kroah-Hartman
el.org Cc: Fabio Baltieri Cc: Linus Walleij Cc: Herbert Xu Cc: "David S. Miller" Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/ux500/cryp/cryp_core.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) --- a/drivers/cry

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-08 Thread Greg Kroah-Hartman
On Thu, Dec 08, 2016 at 06:38:11AM +, Bart Van Assche wrote: > On 12/07/16 21:54, Michael S. Tsirkin wrote: > > On Thu, Dec 08, 2016 at 05:21:47AM +, Bart Van Assche wrote: > >> Additionally, there are notable exceptions to the rule that most drivers > >> are endian-clean, e.g. drivers/scsi

Re: [PATCH] random: Don't overwrite CRNG state in crng_initialize()

2017-02-08 Thread Greg Kroah-Hartman
On Wed, Feb 08, 2017 at 08:31:26PM -0700, Alden Tondettar wrote: > In short, the situation is: > > A) No usable hardware RNG or arch_get_random() (or we don't trust it...) Wait, why would you not trust arch_get_random()? Is it broken somehow on some arches? If so, why not fix that as well? tha

Re: [PATCH] random: Don't overwrite CRNG state in crng_initialize()

2017-02-09 Thread Greg Kroah-Hartman
On Thu, Feb 09, 2017 at 02:04:32AM -0700, Alden Tondettar wrote: > On Thu, Feb 09, 2017 at 07:47:25AM +0100, Greg Kroah-Hartman wrote: > > On Wed, Feb 08, 2017 at 08:31:26PM -0700, Alden Tondettar wrote: > > > In short, the situation is: > > > > > > A) No us

Re: [PATCH 0/4] staging: ccree: coding style clean ups

2017-07-27 Thread Greg Kroah-Hartman
On Thu, Jul 27, 2017 at 01:43:14PM +0300, Gilad Ben-Yossef wrote: > Misc. coding style fixes for ccree driver. > > These are the missing patches that failed to apply two weeks ago, > rebased onto latest staging-next. > > By the way, I still do not understand why they failed to apply, > as they ap

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-27 Thread Greg Kroah-Hartman
On Thu, Jul 27, 2017 at 05:27:32PM +0300, Gilad Ben-Yossef wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with devm_kzalloc. > (b) drop kfree()

Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:39AM +0300, Gilad Ben-Yossef wrote: > Fix wrong indentation and line breaks, including missing tabs, > breaking lines longer then 80 char or wrongly broken. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/ssi_driver.c | 107 > +

Re: [PATCH v3 00/22] staging: ccree: fixes and simplifications

2017-08-16 Thread Greg Kroah-Hartman
On Tue, Aug 15, 2017 at 09:26:28AM +0300, Gilad Ben-Yossef wrote: > The series includes various bug fixes, code simplification and style > cleanups. > > Changer from v2: > - Drop M32R as supported architecture, which resolve the kbuild bot > warnings on Joe Perches patch. > - Bug fix that prope

Re: [PATCH] staging: ccree: Add missing newlines

2017-09-11 Thread Greg Kroah-Hartman
On Sat, Sep 09, 2017 at 11:18:02PM -0700, Joe Perches wrote: > Logging without newlines are still prone to interleaving. > Add newlines where necessary. Doesn't apply to my staging-testing branch, due to other changes in this driver. Can you rebase it onto that branch and resend? thanks, greg k

[PATCH 4.13 034/109] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller Acked-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/algif_skcipher.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/crypto/algif_skc

[PATCH 4.9 27/77] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller Acked-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/algif_skcipher.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/crypto/algif_skc

[PATCH 4.4 27/66] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller Acked-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/algif_skcipher.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/crypto/algif_skc

[PATCH 3.18 11/42] [PATCH - RESEND] crypto: AF_ALG - remove SGL terminator indicator when chaining

2017-09-24 Thread Greg Kroah-Hartman
590903d5fc ("crypto: algif_skcipher - User-space interface for skcipher operations") Signed-off-by: Stephan Mueller Acked-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- crypto/algif_skcipher.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/crypto/algif_skc

Re: [PATCH 0/3] More code cleanups

2017-11-05 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 06:55:49AM +, Gilad Ben-Yossef wrote: > Additional code readability and simplification patches. > These goes on top the previous patch set sent to the list. Please label your 0/X patches the same way your patches are, with the prefix of the subsystem, otherwise they get

Re: [PATCH 0/3] More code cleanups

2017-11-05 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 09:41:09AM +0200, Gilad Ben-Yossef wrote: > On Mon, Nov 6, 2017 at 9:38 AM, Greg Kroah-Hartman > wrote: > > On Mon, Nov 06, 2017 at 06:55:49AM +, Gilad Ben-Yossef wrote: > >> Additional code readability and simplification patches. > >>

Re: [PATCH 3/3] staging: ccree: simplify ioread/iowrite

2017-11-06 Thread Greg Kroah-Hartman
On Mon, Nov 06, 2017 at 10:59:47AM +0200, Gilad Ben-Yossef wrote: > On Mon, Nov 6, 2017 at 10:37 AM, Tobin C. Harding wrote: > > On Mon, Nov 06, 2017 at 06:55:52AM +, Gilad Ben-Yossef wrote: > >> Registers ioread/iowrite operations were done via macros, > >> sometime using a "magical" implicit

Re: [PATCH] staging: ccree: use size_t consistently

2017-12-19 Thread Greg Kroah-Hartman
On Wed, Dec 20, 2017 at 07:23:31AM +, Gilad Ben-Yossef wrote: > Fix declaration, implementation and wrapper function to use > the same size_t type we actually define the parameter to be. > > Fixes: 3f268f5d6669 ("staging: ccree: turn compile time debug log to params") > Signed-off-by: Gilad Be

Re: [PATCH RESEND] checkpatch: add *_ON_STACK to declaration_macros

2017-12-20 Thread Greg Kroah-Hartman
SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm); > > Signed-off-by: Gilad Ben-Yossef Acked-by: Greg Kroah-Hartman

Re: [PATCH] staging: ccree: fix type mismatch warning

2017-12-21 Thread Greg Kroah-Hartman
On Thu, Dec 21, 2017 at 02:31:20PM +0100, Arnd Bergmann wrote: > __dump_byte_array used to be hidden, but is now visible to the compiler > and causes a harmless warning: > > drivers/staging/ccree/ssi_driver.c:82:6: error: conflicting types for > '__dump_byte_array' > drivers/staging/ccree/ssi_dri

Re: [PATCH 03/13] serial: 8250_dma: Support for deferred probing when requesting DMA channels

2015-05-26 Thread Greg Kroah-Hartman
On Tue, May 26, 2015 at 04:25:58PM +0300, Peter Ujfalusi wrote: > Switch to use ma_request_slave_channel_compat_reason() to request the DMA > channels. In case of error, return the error code we received including > -EPROBE_DEFER I think you typed the function name wrong here :( -- To unsubscribe

[PATCH 4.9 62/88] hwrng: geode - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
nstead of asm/io.h"). Signed-off-by: Prarit Bhargava Fixes: 6e9b5e76882c ("hwrng: geode - Migrate to managed API") Cc: Matt Mackall Cc: Corentin LABBE Cc: PrasannaKumar Muralidharan Cc: Wei Yongjun Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by: Herb

[PATCH 4.9 61/88] hwrng: amd - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
managed API"). Signed-off-by: Prarit Bhargava Fixes: 31b2a73c9c5f ("hwrng: amd - Migrate to managed API"). Cc: Matt Mackall Cc: Corentin LABBE Cc: PrasannaKumar Muralidharan Cc: Wei Yongjun Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by:

[PATCH 4.10 075/111] hwrng: amd - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
managed API"). Signed-off-by: Prarit Bhargava Fixes: 31b2a73c9c5f ("hwrng: amd - Migrate to managed API"). Cc: Matt Mackall Cc: Corentin LABBE Cc: PrasannaKumar Muralidharan Cc: Wei Yongjun Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by:

[PATCH 4.10 076/111] hwrng: geode - Revert managed API changes

2017-03-28 Thread Greg Kroah-Hartman
nstead of asm/io.h"). Signed-off-by: Prarit Bhargava Fixes: 6e9b5e76882c ("hwrng: geode - Migrate to managed API") Cc: Matt Mackall Cc: Corentin LABBE Cc: PrasannaKumar Muralidharan Cc: Wei Yongjun Cc: linux-crypto@vger.kernel.org Cc: linux-ge...@lists.infradead.org Signed-off-by: Herb

Re: [PATCH] crypto: vmx: Remove dubiously licensed crypto code

2017-03-29 Thread Greg Kroah-Hartman
On Wed, Mar 29, 2017 at 02:56:39PM +0200, Michal Suchanek wrote: > While reviewing commit 11c6e16ee13a ("crypto: vmx - Adding asm > subroutines for XTS") which adds the OpenSSL license header to > drivers/crypto/vmx/aesp8-ppc.pl licensing of this driver came into > qestion. The whole license reads:

Re: [PATCH 0/4] staging: add ccree crypto driver

2017-04-18 Thread Greg Kroah-Hartman
On Tue, Apr 18, 2017 at 05:07:50PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the first drop

Re: [PATCH v2 0/9] staging: ccree: add Arm TrustZone CryptoCell REE driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:54PM +0300, Gilad Ben-Yossef wrote: > Arm TrustZone CryptoCell 700 is a family of cryptographic hardware > accelerators. It is supported by a long lived series of out of tree > drivers, which I am now in the process of unifying and upstreaming. > This is the first drop

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > +++ b/drivers/staging/ccree/bsp.h > @@ -0,0 +1,21 @@ > +/* > + * Copyright (C) 2012-2016 ARM Limited or its affiliates. > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms of t

Re: [PATCH v2 1/9] staging: ccree: introduce CryptoCell HW driver

2017-04-20 Thread Greg Kroah-Hartman
On Thu, Apr 20, 2017 at 04:40:56PM +0300, Gilad Ben-Yossef wrote: > On Thu, Apr 20, 2017 at 4:33 PM, Greg Kroah-Hartman > wrote: > > On Thu, Apr 20, 2017 at 04:12:55PM +0300, Gilad Ben-Yossef wrote: > >> +++ b/drivers/staging/ccree/bsp.h > >> @@ -0,0 +1,21 @@ > &

Re: [PATCH] drivers/staging/ccree: Fixing coding guideline errors

2017-05-16 Thread Greg Kroah-Hartman
On Tue, May 16, 2017 at 01:35:52PM +0530, Pushkar Jambhlekar wrote: > Fixing coding guideline errors reported by 'checkpatch.pl' That is very "vague", you are going to have to be specific here. Also remember you can only do "one type of thing" per patch, and no, "fix all warnings" is not one type

Re: [PATCH 02/12] staging: ccree: move to kernel bitfields/bitops

2017-05-29 Thread Greg Kroah-Hartman
On Sun, May 28, 2017 at 05:40:27PM +0300, Gilad Ben-Yossef wrote: > ccree had a lot of boilerplate code for dealing with bitops > and bitfield register access. Move it over to the generic kernel > infrastructure used for doing the same. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging

Re: [PATCH 04/12] staging: ccree: cleanup lli access macro

2017-05-29 Thread Greg Kroah-Hartman
On Sun, May 28, 2017 at 05:40:29PM +0300, Gilad Ben-Yossef wrote: > The Linked List Item descriptors were being accessed via > a baroque set of defines and macro. Re-factor for structs > and inline function for readability and sanity. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/c

Re: [PATCH 01/12] staging: ccree: correct coding style violations

2017-05-29 Thread Greg Kroah-Hartman
On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote: > cc_crypto_ctx.h had multiple coding style violations reported by > checkpatch. Fix them all. Sorry, no. You need to do only one-thing-per-patch, and "fix all coding style issues is not "one thing". I wouldn't take this kind of p

Re: [PATCH v2 02/20] staging: ccree: replace bit shift with BIT macro

2017-06-03 Thread Greg Kroah-Hartman
On Thu, Jun 01, 2017 at 02:02:52PM +0300, Gilad Ben-Yossef wrote: > CC_CTX_SIZE was being defined using a hand rolled bit shift operation. > Replace with use of BIT macro. > > Signed-off-by: Gilad Ben-Yossef > --- > drivers/staging/ccree/cc_crypto_ctx.h | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH RFC v2 0/8] get_random_bytes_wait family of APIs

2017-06-06 Thread Greg Kroah-Hartman
On Tue, Jun 06, 2017 at 01:47:25AM +0200, Jason A. Donenfeld wrote: > As this RFC series matures, all the changes are in this branch here, to look > at: > > https://git.zx2c4.com/linux-dev/log/?h=jd/rng-blocker > > Ted -- there's one, in particular, that should probably be picked up > regardless

Re: [PATCH v2 2/7] staging: ccree: register setkey for none hash macs

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:56PM +0300, Gilad Ben-Yossef wrote: > Fix a bug where the transformation init code did > not register a setkey method for none hash based MACs. "none hash based MACs"? Is that the correct language, I don't understand it, sorry, can you expand on it a bit in your v3 s

Re: [PATCH v2 5/7] staging: ccree: add clock management support

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:59PM +0300, Gilad Ben-Yossef wrote: > Some SoC which implement CryptoCell have a dedicated clock > tied to it, some do not. Implement clock support if exists > based on device tree data and tie power management to it. > > Signed-off-by: Gilad Ben-Yossef > --- > driv

Re: [PATCH v2 3/7] staging: ccree: add support for older HW revisions

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:57PM +0300, Gilad Ben-Yossef wrote: > Add support for the older CryptoCell 710 and 630P hardware revisions. No, I do not want to add new features to staging drivers where ever possible. I want you to spend your time fixing up the code to be good enough to get it out

Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings

2017-06-29 Thread Greg Kroah-Hartman
On Thu, Jun 29, 2017 at 04:13:38PM +0530, karthik wrote: > On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote: > > Thank you Karthik, > > > > On Wed, Jun 28, 2017 at 12:37 PM, wrote: > > > From: Karthik Tummala > > > > > > This patch series fixes coding style and removes the following

Re: [PATCH 00/12] staging: ccree: coding style fixes

2017-07-14 Thread Greg Kroah-Hartman
On Thu, Jul 13, 2017 at 11:19:50AM +0300, Gilad Ben-Yossef wrote: > Another batch of ccree coding style fixes. > > These goes on top of commit a8c4ae12 ("staging: ccree: Fix alignment issues > in ssi_sysfs.c") > in staging-testing. Odd, some of these did not apply, but others did. Please rebase

Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 09:57:55AM +0200, Stephan Müller wrote: > --- /dev/null > +++ b/include/crypto/jitterentropy.h > @@ -0,0 +1,80 @@ > +/* > + * Copyright (C) 2017, Stephan Mueller > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 09:59:09AM +0200, Stephan Müller wrote: > The LRNG with the following properties: > > * noise source: interrupts timing with fast boot time seeding > > * lockless LFSR to collect raw entropy > > * use of standalone ChaCha20 based RNG with the option to use a > different

Re: [RFC PATCH v12 1/4] crypto: make Jitter RNG directly accessible

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 10:40:07AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:30:14 CEST schrieb Greg Kroah-Hartman: > > Hi Greg, > > > > +typedef unsigned long long __u64; > > > +typedef long long __s64; > > > >

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 10:45:12AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:32:10 CEST schrieb Greg Kroah-Hartman: > > Hi Greg, > > > external references do not last as long as the kernel change log does :( > > What would be the best way to cite a 50

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Greg Kroah-Hartman
On Tue, Jul 18, 2017 at 10:45:12AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 10:32:10 CEST schrieb Greg Kroah-Hartman: > > Hi Greg, > > > external references do not last as long as the kernel change log does :( > > What would be the best way to cite a 50

Re: [RFC PATCH v12 3/4] Linux Random Number Generator

2017-07-18 Thread Greg Kroah-Hartman
On Wed, Jul 19, 2017 at 08:22:18AM +0200, Stephan Müller wrote: > Am Dienstag, 18. Juli 2017, 23:08:16 CEST schrieb Theodore Ts'o: > > Hi Theodore, > > > > I've been trying to take the best features and suggestions from your > > proposal and integrating them into /dev/random already. Things that

Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-19 Thread Greg Kroah-Hartman
On Fri, Jul 19, 2013 at 11:38:04PM +0200, Rafael J. Wysocki wrote: > Alas, this is not the one I'd like to apply. > > With that patch applied, new device objects are created to avoid binding the > processor driver directly to the cpu system device objects, because that > apparently confuses udev a

Re: [PATCH 3.11-rc1] crypto: Fix boot failure due to module dependency.

2013-07-19 Thread Greg Kroah-Hartman
On Fri, Jul 19, 2013 at 04:21:09PM -0700, H. Peter Anvin wrote: > On 07/19/2013 04:16 PM, Greg Kroah-Hartman wrote: > > > > udev isn't doing any module loading, 'modprobe' is just being called for > > any new module alias that shows up in the system, and all o

Re: [PATCH] Fix late crypto work queue initialization

2014-03-25 Thread Greg Kroah-Hartman
On Tue, Mar 25, 2014 at 04:40:56PM -0700, Tim Chen wrote: > On Fri, 2014-03-21 at 22:40 +0800, Herbert Xu wrote: > > On Mon, Mar 17, 2014 at 04:52:26PM -0700, Tim Chen wrote: > > > The crypto algorithm modules utilizing the crypto daemon could > > > be used early when the system start up. Using mo

Re: [RFC PATCH 1/7] staging/rtl8192e: switch to RC4 library interface

2020-07-02 Thread Greg Kroah-Hartman
On Thu, Jul 02, 2020 at 12:19:41PM +0200, Ard Biesheuvel wrote: > Switch to the ARC4 library interface, to remove the pointless > dependency on the skcipher API, from which we will hopefully be > able to drop ecb(arc4) skcipher support. > > Signed-off-by: Ard Biesheuvel Acked

Re: [RFC PATCH 2/7] staging/rtl8192u: switch to RC4 library interface

2020-07-02 Thread Greg Kroah-Hartman
On Thu, Jul 02, 2020 at 12:19:42PM +0200, Ard Biesheuvel wrote: > Switch to the ARC4 library interface, to remove the pointless > dependency on the skcipher API, from which we will hopefully be > able to drop ecb(arc4) skcipher support. > > Signed-off-by: Ard Biesheuvel Acked

[PATCH 5.8 037/177] padata: fix possible padata_works_lock deadlock

2020-09-15 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 1b0df11fde0f14a269a181b3b7f5122415bc5ed7 ] syzbot reports, WARNING: inconsistent lock state 5.9.0-rc2-syzkaller #0 Not tainted inconsistent {IN-SOFTIRQ-W} -> {SOFTIRQ-ON-W} usage. syz-executor.0/26715 takes: (pad

Re: [DISCUSSION PATCH 00/41] random: possible ways towards NIST SP800-90B compliance

2020-09-22 Thread Greg Kroah-Hartman
On Tue, Sep 22, 2020 at 03:23:44PM +0200, Torsten Duwe wrote: > On Mon, Sep 21, 2020 at 10:40:37AM +0200, Stephan Mueller wrote: > > Am Montag, 21. September 2020, 09:58:16 CEST schrieb Nicolai Stange: > > > > > - people dislike the approach of having two competing implementations for > > > what

Re: [DISCUSSION PATCH 00/41] random: possible ways towards NIST SP800-90B compliance

2020-10-02 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 03:15:55PM +0200, Willy Tarreau wrote: > On Fri, Oct 02, 2020 at 02:38:36PM +0200, Torsten Duwe wrote: > > Almost two weeks passed and these are the "relevant" replies: > > > > Jason personally does not like FIPS, and is afraid of > > "subpar crypto". Albeit this patch set

Re: [DISCUSSION PATCH 00/41] random: possible ways towards NIST SP800-90B compliance

2020-10-02 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 01:35:18PM +, Van Leeuwen, Pascal wrote: > ** This message and any attachments are for the sole use of the intended > recipient(s). It may contain information that is confidential and privileged. > If you are not the intended recipient of this message, you are prohibit

Re: [DISCUSSION PATCH 00/41] random: possible ways towards NIST SP800-90B compliance

2020-10-02 Thread Greg Kroah-Hartman
On Fri, Oct 02, 2020 at 02:34:44PM +, Van Leeuwen, Pascal wrote: > > > > > -Original Message- > > From: Greg Kroah-Hartman > > Sent: Friday, October 2, 2020 4:04 PM > > To: Van Leeuwen, Pascal > > Cc: Torsten Duwe ; Theodore Y. Ts'o

Re: [PATCH v36 00/13] /dev/random - a new approach

2020-10-28 Thread Greg Kroah-Hartman
On Wed, Oct 28, 2020 at 06:51:17PM +0100, Torsten Duwe wrote: > On Mon, 19 Oct 2020 21:28:50 +0200 > Stephan Müller wrote: > [...] > > * Sole use of crypto for data processing: > [...] > > - The LRNG uses only properly defined and implemented cryptographic > >algorithms unlike the use of the

Re: Backporting "padata: Remove broken queue flushing"

2020-05-21 Thread Greg Kroah-Hartman
On Wed, May 20, 2020 at 03:33:44PM +0100, Ben Hutchings wrote: > On Tue, 2020-05-19 at 16:00 -0400, Daniel Jordan wrote: > > Hello Ben, > > > > On Tue, May 19, 2020 at 02:53:05PM +0100, Ben Hutchings wrote: > > > I noticed that commit 07928d9bfc81 "padata: Remove broken queue > > > flushing" has b

[PATCH 4.4 29/65] padata: purge get_cpu and reorder_via_wq from padata_do_serial

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 065cf577135a4977931c7a1e1edf442bfd9773dd] With the removal of the padata timer, padata_do_serial no longer needs special CPU handling, so remove it. Signed-off-by: Daniel Jordan Cc: Herbert Xu Cc: Steffen Klassert Cc: linux-crypto@vger.kernel.org Cc: lin

[PATCH 4.19 37/81] padata: purge get_cpu and reorder_via_wq from padata_do_serial

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 065cf577135a4977931c7a1e1edf442bfd9773dd ] With the removal of the padata timer, padata_do_serial no longer needs special CPU handling, so remove it. Signed-off-by: Daniel Jordan Cc: Herbert Xu Cc: Steffen Klassert Cc: linux-crypto@vger.kernel.org Cc: li

[PATCH 4.19 36/81] padata: initialize pd->cpu with effective cpumask

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit ec9c7d19336ee98ecba8de80128aa405c45feebb ] Exercising CPU hotplug on a 5.2 kernel with recent padata fixes from cryptodev-2.6.git in an 8-CPU kvm guest... # modprobe tcrypt alg="pcrypt(rfc4106(gcm(aes)))" type=3 # echo 0 > /sys/devices/system/cpu/cp

[PATCH 4.14 29/59] padata: purge get_cpu and reorder_via_wq from padata_do_serial

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 065cf577135a4977931c7a1e1edf442bfd9773dd ] With the removal of the padata timer, padata_do_serial no longer needs special CPU handling, so remove it. Signed-off-by: Daniel Jordan Cc: Herbert Xu Cc: Steffen Klassert Cc: linux-crypto@vger.kernel.org Cc: li

[PATCH 4.14 28/59] padata: initialize pd->cpu with effective cpumask

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit ec9c7d19336ee98ecba8de80128aa405c45feebb ] Exercising CPU hotplug on a 5.2 kernel with recent padata fixes from cryptodev-2.6.git in an 8-CPU kvm guest... # modprobe tcrypt alg="pcrypt(rfc4106(gcm(aes)))" type=3 # echo 0 > /sys/devices/system/cpu/cp

[PATCH 4.9 23/64] padata: initialize pd->cpu with effective cpumask

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit ec9c7d19336ee98ecba8de80128aa405c45feebb ] Exercising CPU hotplug on a 5.2 kernel with recent padata fixes from cryptodev-2.6.git in an 8-CPU kvm guest... # modprobe tcrypt alg="pcrypt(rfc4106(gcm(aes)))" type=3 # echo 0 > /sys/devices/system/cpu/cp

[PATCH 4.9 24/64] padata: purge get_cpu and reorder_via_wq from padata_do_serial

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 065cf577135a4977931c7a1e1edf442bfd9773dd ] With the removal of the padata timer, padata_do_serial no longer needs special CPU handling, so remove it. Signed-off-by: Daniel Jordan Cc: Herbert Xu Cc: Steffen Klassert Cc: linux-crypto@vger.kernel.org Cc: li

[PATCH 4.4 28/65] padata: initialize pd->cpu with effective cpumask

2020-05-26 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit ec9c7d19336ee98ecba8de80128aa405c45feebb ] Exercising CPU hotplug on a 5.2 kernel with recent padata fixes from cryptodev-2.6.git in an 8-CPU kvm guest... # modprobe tcrypt alg="pcrypt(rfc4106(gcm(aes)))" type=3 # echo 0 > /sys/devices/system/cpu/cp

Re: [PATCH 0/2] Introduce PCI_FIXUP_IOMMU

2020-05-27 Thread Greg Kroah-Hartman
On Tue, May 26, 2020 at 07:49:07PM +0800, Zhangfei Gao wrote: > Some platform devices appear as PCI but are actually on the AMBA bus, Why would these devices not just show up on the AMBA bus and use all of that logic instead of being a PCI device and having to go through odd fixes like this? than

Re: [PATCH 1/2] PCI: Introduce PCI_FIXUP_IOMMU

2020-05-27 Thread Greg Kroah-Hartman
On Tue, May 26, 2020 at 11:09:57PM +0800, Zhangfei Gao wrote: > Hi, Christoph > > On 2020/5/26 下午10:46, Christoph Hellwig wrote: > > On Tue, May 26, 2020 at 07:49:08PM +0800, Zhangfei Gao wrote: > > > Some platform devices appear as PCI but are actually on the AMBA bus, > > > and they need fixup i

Re: [PATCH 2/2] iommu: calling pci_fixup_iommu in iommu_fwspec_init

2020-05-27 Thread Greg Kroah-Hartman
On Tue, May 26, 2020 at 07:49:09PM +0800, Zhangfei Gao wrote: > Calling pci_fixup_iommu in iommu_fwspec_init, which alloc > iommu_fwnode. Some platform devices appear as PCI but are > actually on the AMBA bus, and they need fixup in > drivers/pci/quirks.c handling iommu_fwnode. > So calling pci_fix

Re: [PATCH v6 2/2] hwrng: add sec-rng driver

2020-06-02 Thread Greg Kroah-Hartman
On Tue, Jun 02, 2020 at 04:14:38PM +0800, Neal Liu wrote: > For security awareness SoCs on ARMv8 with TrustZone enabled, > peripherals like entropy sources is not accessible from normal world > (linux) and rather accessible from secure world (HYP/ATF/TEE) only. > This driver aims to provide a gener

Re: [PATCH net] esp: select CRYPTO_SEQIV

2020-06-05 Thread Greg Kroah-Hartman
eds CRYPTO_SEQIV") > Cc: Corentin Labbe > Cc: Greg Kroah-Hartman > Cc: Herbert Xu > Cc: Steffen Klassert > Signed-off-by: Eric Biggers Tested-by: Greg Kroah-Hartman

[PATCH 5.6 036/161] padata: add separate cpuhp node for CPUHP_PADATA_DEAD

2020-06-16 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 3c2214b6027ff37945799de717c417212e1a8c54 ] Removing the pcrypt module triggers this: general protection fault, probably for non-canonical address 0xdead0122 CPU: 5 PID: 264 Comm: modprobe Not tainted 5.6.0+ #2 Hardware name: QEMU Standard

[PATCH 5.7 030/163] padata: add separate cpuhp node for CPUHP_PADATA_DEAD

2020-06-16 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 3c2214b6027ff37945799de717c417212e1a8c54 ] Removing the pcrypt module triggers this: general protection fault, probably for non-canonical address 0xdead0122 CPU: 5 PID: 264 Comm: modprobe Not tainted 5.6.0+ #2 Hardware name: QEMU Standard

[PATCH 5.4 023/134] padata: add separate cpuhp node for CPUHP_PADATA_DEAD

2020-06-16 Thread Greg Kroah-Hartman
From: Daniel Jordan [ Upstream commit 3c2214b6027ff37945799de717c417212e1a8c54 ] Removing the pcrypt module triggers this: general protection fault, probably for non-canonical address 0xdead0122 CPU: 5 PID: 264 Comm: modprobe Not tainted 5.6.0+ #2 Hardware name: QEMU Standard

Re: [PATCH v3 24/27] staging: ccree: use a consistent file naming convention

2018-01-08 Thread Greg Kroah-Hartman
On Sun, Jan 07, 2018 at 12:14:35PM +, Gilad Ben-Yossef wrote: > The ccree driver source files were using an inconsistent > naming convention stemming from what the company was called > when they were added. > > Move to a single consistent naming convention for better > code readability. > > S

Re: Getting the ccree driver out of staging

2018-01-10 Thread Greg Kroah-Hartman
On Wed, Jan 10, 2018 at 08:54:55AM +0200, Gilad Ben-Yossef wrote: > Hi folks, > > With the enormous help of people in the to and CCed lists I've gotten > the ccree driver to a point I believe it is ready to graduate out of > the staging tree: > > - The code base has been reduced by something by 3

Re: [PATCH 1/7] staging: ccree: remove ccree from staging tree

2018-01-13 Thread Greg Kroah-Hartman
On Thu, Jan 11, 2018 at 09:17:08AM +, Gilad Ben-Yossef wrote: > Remove the ccree driver from the staging tree in preparation to > introducing it in the crypto tree. > > Signed-off-by: Gilad Ben-Yossef Heh, no, just make a patch series that adds the driver to the correct location in the crypt

[PATCH 4.4 43/87] hwrng: core - sleep interruptible in read

2018-01-15 Thread Greg Kroah-Hartman
possibly return already read data, if any (as POSIX allows). v2: use ERESTARTSYS instead of EINTR Signed-off-by: Jiri Slaby Cc: Matt Mackall Cc: Herbert Xu Cc: Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/char/hw_random/core.c |6 +- 1 file changed, 5

Re: [PATCH 1/7] staging: ccree: remove ccree from staging tree

2018-01-18 Thread Greg Kroah-Hartman
On Thu, Jan 18, 2018 at 10:39:11AM +0200, Gilad Ben-Yossef wrote: > On Sat, Jan 13, 2018 at 3:21 PM, Greg Kroah-Hartman > wrote: > > On Thu, Jan 11, 2018 at 09:17:08AM +, Gilad Ben-Yossef wrote: > >> Remove the ccree driver from the staging tree in preparation to >

Re: [PATCH -stable 1/2] crypto: hash - annotate algorithms taking optional key

2018-02-22 Thread Greg Kroah-Hartman
On Thu, Feb 22, 2018 at 02:50:10PM -0800, Eric Biggers wrote: > From: Eric Biggers > > commit a208fa8f33031b9e0aba44c7d1b7e68eb0cbd29e upstream. > [Please apply to 4.9-stable.] Both now applied, thanks for the backports. greg k-h

Re: Can a driver->probe be called for two devices at the same time (WAS: Re: [PATCH] crypto/ccp: don't disable interrupts while setting up debugfs)

2018-02-27 Thread Greg Kroah-Hartman
On Tue, Feb 27, 2018 at 06:33:14PM +0100, Sebastian Andrzej Siewior wrote: > On 2018-02-27 11:08:56 [-0600], Gary R Hook wrote: > > That issue remains unclear to me: Are probes of PCI devices guaranteed to be > > serialized? Observations on my CCPs says that they occur in order, but I > > don't kno

[PATCH 4.14 050/115] lib/mpi: Fix umul_ppmm() for MIPS64r6

2018-03-02 Thread Greg Kroah-Hartman
s Hogan Cc: Ralf Baechle Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-m...@linux-mips.org Cc: linux-crypto@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- lib/mpi/longlong.h | 18 +- 1 file change

[PATCH 4.9 24/56] lib/mpi: Fix umul_ppmm() for MIPS64r6

2018-03-02 Thread Greg Kroah-Hartman
s Hogan Cc: Ralf Baechle Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-m...@linux-mips.org Cc: linux-crypto@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- lib/mpi/longlong.h | 18 +- 1 file change

[PATCH 4.4 12/34] lib/mpi: Fix umul_ppmm() for MIPS64r6

2018-03-02 Thread Greg Kroah-Hartman
s Hogan Cc: Ralf Baechle Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-m...@linux-mips.org Cc: linux-crypto@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- lib/mpi/longlong.h | 18 +- 1 file change

Re: [PATCH v11 7/7] ntb: ntb_hw_switchtec: Cleanup 64bit IO defines to use the common header

2018-03-06 Thread Greg Kroah-Hartman
On Tue, Mar 06, 2018 at 12:48:29PM +0200, Andy Shevchenko wrote: > On Mon, Mar 5, 2018 at 9:08 PM, Logan Gunthorpe wrote: > > Clean up the ifdefs which conditionally defined the io{read|write}64 > > functions in favour of the new common io-64-nonatomic-lo-hi header. > > > #include > > #include

Re: [PATCH 03/18] docs: */index.rst: Add newer documents to their respective index.rst

2018-05-07 Thread Greg Kroah-Hartman
alho Chehab Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 4.14] crypto: arm64/aes-neonbs - fix returning final keystream block

2019-03-20 Thread Greg Kroah-Hartman
On Wed, Mar 20, 2019 at 05:27:25PM -0700, Eric Biggers wrote: > From: Eric Biggers > > commit 12455e320e19e9cc7ad97f4ab89c280fe297387c upstream. > > The arm64 NEON bit-sliced implementation of AES-CTR fails the improved > skcipher tests because it sometimes produces the wrong ciphertext. The >

Re: [v2 PATCH] crypto: caam - fix DKP detection logic

2019-06-03 Thread Greg Kroah-Hartman
On Thu, May 30, 2019 at 11:36:25AM +, Horia Geanta wrote: > On 5/6/2019 11:06 AM, Horia Geanta wrote: > > On 5/6/2019 9:40 AM, Herbert Xu wrote: > >> On Fri, May 03, 2019 at 03:05:48PM +0300, Horia Geantă wrote: > >>> The detection whether DKP (Derived Key Protocol) is used relies on > >>> the

Re: [v2 PATCH] crypto: caam - fix DKP detection logic

2019-06-03 Thread Greg Kroah-Hartman
On Mon, Jun 03, 2019 at 08:10:15AM +, Horia Geanta wrote: > On 6/3/2019 10:52 AM, Greg Kroah-Hartman wrote: > > On Thu, May 30, 2019 at 11:36:25AM +, Horia Geanta wrote: > >> On 5/6/2019 11:06 AM, Horia Geanta wrote: > >>> On 5/6/2019 9:40 AM, Herbert Xu wrot

[PATCH] crypto: nx: no need to check return value of debugfs_create functions

2019-06-14 Thread Greg Kroah-Hartman
zlabs.org Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/nx/nx.c | 4 +- drivers/crypto/nx/nx.h | 12 +- drivers/crypto/nx/nx_debugfs.c | 71 +++--- 3 files changed, 26 insertions(+), 61 deletions(-) diff --git a/drivers/crypto/nx/nx.c b/dr

[PATCH v2] crypto: nx: no need to check return value of debugfs_create functions

2019-06-14 Thread Greg Kroah-Hartman
zlabs.org Signed-off-by: Greg Kroah-Hartman --- v2: fixed build error found by kbuild drivers/crypto/nx/nx.c | 4 +- drivers/crypto/nx/nx.h | 12 +- drivers/crypto/nx/nx_debugfs.c | 71 +++--- 3 files changed, 26 insertions(+), 61 deletions(-)

[PATCH 5.2 274/413] crypto: crypto4xx - fix a potential double free in ppc4xx_trng_probe

2019-07-24 Thread Greg Kroah-Hartman
d-off-by: Wen Yang Cc: Cc: "David S. Miller" Cc: Thomas Gleixner Cc: Greg Kroah-Hartman Cc: Allison Randal Cc: Armijn Hemel Cc: Julia Lawall Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Acked-by: Julia Lawall Signed-off-by: Herbert Xu Signed-off-by: Greg Kro

[PATCH 5.1 315/371] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs

2019-07-24 Thread Greg Kroah-Hartman
-off-by: Daniel Jordan Cc: Cc: Andrea Parri Cc: Boqun Feng Cc: Herbert Xu Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Steffen Klassert Cc: linux-a...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman

[PATCH 5.1 250/371] crypto: crypto4xx - fix a potential double free in ppc4xx_trng_probe

2019-07-24 Thread Greg Kroah-Hartman
d-off-by: Wen Yang Cc: Cc: "David S. Miller" Cc: Thomas Gleixner Cc: Greg Kroah-Hartman Cc: Allison Randal Cc: Armijn Hemel Cc: Julia Lawall Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Acked-by: Julia Lawall Signed-off-by: Herbert Xu Signed-off-by: Greg Kro

[PATCH 5.2 346/413] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs

2019-07-24 Thread Greg Kroah-Hartman
-off-by: Daniel Jordan Cc: Cc: Andrea Parri Cc: Boqun Feng Cc: Herbert Xu Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Steffen Klassert Cc: linux-a...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman

[PATCH 4.19 182/271] crypto: crypto4xx - fix a potential double free in ppc4xx_trng_probe

2019-07-24 Thread Greg Kroah-Hartman
d-off-by: Wen Yang Cc: Cc: "David S. Miller" Cc: Thomas Gleixner Cc: Greg Kroah-Hartman Cc: Allison Randal Cc: Armijn Hemel Cc: Julia Lawall Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Acked-by: Julia Lawall Signed-off-by: Herbert Xu Signed-off-by: Greg Kro

[PATCH 4.19 218/271] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs

2019-07-24 Thread Greg Kroah-Hartman
-off-by: Daniel Jordan Cc: Cc: Andrea Parri Cc: Boqun Feng Cc: Herbert Xu Cc: Paul E. McKenney Cc: Peter Zijlstra Cc: Steffen Klassert Cc: linux-a...@vger.kernel.org Cc: linux-crypto@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman

  1   2   >