Re: crypto: caam/qi - simplify error path for context allocation

On Fri, Nov 13, 2020 at 02:39:24PM +1100, Herbert Xu wrote: > Horia Geantă wrote: > > > > -- >8 -- > > > > Subject: [PATCH] crypto: caam/qi - simplify error path for context > > allocation > > You can't do this. Patchwork takes any replies with

Re: crypto: caam/qi - simplify error path for context allocation

Horia Geantă wrote: > > -- >8 -- > > Subject: [PATCH] crypto: caam/qi - simplify error path for context allocation You can't do this. Patchwork takes any replies with the same Subject line as a comment. You need to resend this patch with a different subject. Thanks, -

Re: [PATCH v9,net-next,12/12] crypto: octeontx2: register with linux crypto framework

512),ecb(cipher_null)), > > rfc4106(gcm(aes)). > > Herbert, could someone who knows about crypto take a look at this, > if the intention is to merge this via net-next? This patch seems to be quite large but it is self-contained. How about waiting a release cycle and then resubmit

Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH resend] hwrng: imx-rngc - irq already prints an error

Nigel Christian > --- > drivers/char/hw_random/imx-rngc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: caam - fix printing on xts fallback allocation error path

fdcf1 ("crypto: caam/qi2 - add fallback for XTS with more than > 8B IV") > Signed-off-by: Horia Geantă > --- > drivers/crypto/caam/caamalg.c | 4 ++-- > drivers/crypto/caam/caamalg_qi.c | 4 ++-- > drivers/crypto/caam/caamalg_qi2.c | 3 ++- > 3 files chang

Re: [PATCH 0/8] crypto: hisilicon/qm - misc clean up

t; +++--- > drivers/crypto/hisilicon/qm.h | 2 +- > drivers/crypto/hisilicon/sec2/sec_main.c | 4 +- > drivers/crypto/hisilicon/zip/zip_main.c | 4 +- > 5 files changed, 134 insertions(+), 87 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat: remove unneeded semicolon

algs.c | 8 > 2 files changed, 5 insertions(+), 5 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: cavium/nitrox: remove unneeded semicolon

Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm64/poly1305-neon - reorder PAC authentication with SP update

d Biesheuvel > --- > arch/arm64/crypto/poly1305-armv8.pl | 2 +- > arch/arm64/crypto/poly1305-core.S_shipped | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: af_alg - avoid undefined behavior accessing salg_name

26d4...@syzkaller.appspotmail.com > Fixes: 3f69cc60768b ("crypto: af_alg - Allow arbitrarily long algorithm > names") > Cc: # v4.12+ > Signed-off-by: Eric Biggers > --- > crypto/af_alg.c | 10 +++--- > include/uapi/linux/if_alg.h | 16 +++

Re: [PATCH 0/4] crypto: testmgr - always print the actual driver name

) > > > base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: caam - enable crypto-engine retry mechanism

mment for THRESHOLD define; > - update max size for crypto-engine queue. > > drivers/crypto/caam/intern.h | 8 > drivers/crypto/caam/jr.c | 4 +++- > 2 files changed, 11 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gon

Re: [PATCH] crypto: testmgr - WARN on test failure

xisting test systems already know to look for them in dmesg or via > /proc/sys/kernel/tainted. > > Therefore, call WARN() when an algorithm fails its self-tests. > > Signed-off-by: Eric Biggers > --- > crypto/testmgr.c | 20 +--- > 1 file changed, 13 insertions

Re: [PATCH] crypto: atmel-sha: remove unneeded break

On Mon, Oct 19, 2020 at 12:36:53PM -0700, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return > > Signed-off-by: Tom Rix > --- > drivers/crypto/atmel-sha.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks. --

[PATCH] crypto: cavium/nitrox - Fix sparse warnings

This patch fixes all the sparse warnings in cavium/nitrox: - Fix endianness warnings by adding the correct markers to unions. - Add missing header inclusions for prototypes. - Move nitrox_sriov_configure prototype into the isr header file. Signed-off-by: Herbert Xu diff --git a/drivers/crypto

Re: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device

drivers/crypto/omap-aes.c | 1 + > 1 file changed, 1 insertion(+) Your patch has already been applied: commit 383e8a823014532ffd81c787ef9009f1c2bd3b79 Author: Zhang Qilong Date: Fri Oct 16 17:05:36 2020 +0800 crypto: omap-aes - fix the reference count leak of omap device Cheers, --

Re: [PATCH v4 0/6] crypto: lib/sha256 - cleanup/optimization

pto/sm3_base.h | 3 +- > lib/crypto/sha256.c | 212 +- > 9 files changed, 76 insertions(+), 156 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/2] crypto: hisilicon - misc fixes

ec2/sec.h| 2 -- > drivers/crypto/hisilicon/sec2/sec_crypto.c | 17 ++--- > drivers/crypto/hisilicon/sec2/sec_main.c | 30 > -- > 3 files changed, 18 insertions(+), 31 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: ht

Re: [PATCH] crypto: x86 - remove unused file aes_glue.c

> Signed-off-by: Eric Biggers > --- > arch/x86/crypto/aes_glue.c | 1 - > 1 file changed, 1 deletion(-) > delete mode 100644 arch/x86/crypto/aes_glue.c Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: sm2 - remove unnecessary reset operations

more in line with the Linux code style. > > Signed-off-by: Tianjia Zhang > --- > crypto/sm2.c | 75 > 1 file changed, 29 insertions(+), 46 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apa

Re: [PATCH -next] crypto: omap-aes - fix the reference count leak of omap device

drivers/crypto/omap-aes.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/1] crypto: hisilicon: Fix doc warnings in sgl.c and qm.c

m_set_vft' > drivers/crypto/hisilicon/qm.c:2620: warning: Function parameter or member > 'qm' not described in 'qm_clear_queues' > > Signed-off-by: Shiju Jose > Reviewed-by: Zhou Wang > --- > drivers/crypto/hisilicon/qm.c | 13 + > drivers/crypto/hisilicon/sgl.c | 2 -- > 2 files changed, 13 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/31] crypto: qat - rework in preparation for qat_4xxx driver

rs/crypto/qat/qat_dh895xcc/adf_drv.c | 9 +- > .../qat_dh895xccvf/adf_dh895xccvf_hw_data.c | 7 +- > drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 4 +- > 36 files changed, 1024 insertions(+), 448 deletions(-) > create mode 100644 drivers/crypto/qat/qat_common/adf_gen2_hw_data.c > create mode 100644 drivers/crypto/qat/qat_common/adf_gen2_hw_data.h All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: inside-secure: Fix sizeof() mismatch

ide-secure/safexcel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - Fix return type of current_desc_hdr()

3e721aeb3df3 ("crypto: talitos - handle descriptor not found in error > path") > Signed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http

Re: [PATCH] crypto: talitos - Endianess in current_desc_hdr()

ed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat - remove unused function

sed > function 'qat_dh_get_params' [-Wunused-function] > > Signed-off-by: Giovanni Cabiddu > Reviewed-by: Fiona Trahe > Reviewed-by: Andy Shevchenko > --- > drivers/crypto/qat/qat_common/qat_asym_algs.c | 5 - > 1 file changed, 5 deletions(-) Patch applied

Re: [PATCH] crypto: arm/aes-neonbs - fix usage of cbc(aes) fallback

> recursion. > > Herbert? It works only if everything is built in. If cbc is built as a module then you need Horia's patch to prevent a loop. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 3/4] dm crypt: switch to EBOIV crypto API template

BOIV > default to dm-crypto Kconfig option value does solves the problem, or > have I missed something? Oh I'm mistaken then. I thought it was an existing option. If it's a new option then a default depending on dm-crypt should be sufficient. Thanks, -- Email: Herbert Xu Home Pag

Re: [PATCH v2 1/6] crypto: Use memzero_explicit() for clearing state

that there were more instances of memset in crypto/ that needed converting, but a quick grep seems to indicate that most are not sensitive. So I'm OK with this patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 3/4] dm crypt: switch to EBOIV crypto API template

On Tue, Oct 27, 2020 at 05:41:55AM +1100, Herbert Xu wrote: > > The point is that people rebuilding their kernel can end up with a > broken system. Just set a default on EBOIV if dm-crypt is on. That's not enough as it's an existing option. So we need to add a new Kconfig op

Re: [PATCH 3/4] dm crypt: switch to EBOIV crypto API template

nk a lot of dm-crypt users don't want to bloat their kernels with > random > legacy algorithms. The point is that people rebuilding their kernel can end up with a broken system. Just set a default on EBOIV if dm-crypt is on. Cheers, -- Email: Herbert Xu Home Page: http://gondor.a

[GIT PULL] Crypto Fixes for 5.10

- add back a needed assignment arch/x86/crypto/poly1305_glue.c | 1 + 1 file changed, 1 insertion(+) Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: x86/poly1305 - add back a needed assignment

fect") > Signed-off-by: Eric Biggers > --- > > Note, this is a regression in mainline, so please include this in a pull > request for 5.10. > > arch/x86/crypto/poly1305_glue.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu

Re: [PATCH v3 1/5] crypto: Use memzero_explicit() for clearing state

function can get inlined into sha256(), in which case the memset is > optimized away. Please only convert sha256 and not everything. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 1/6] crypto: Use memzero_explicit() for clearing state

t we only use memzero_explicit for stack variables. At this point please don't convert anything else as it will cause too much churn. If LTO did arrive we should do a global conversion. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 4/6] crypto: lib/sha256 - Unroll SHA256 loop 8 times intead of 64

to 4 columns. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: gssapi, crypto and afs/rxrpc

27;d make sense. Otherwise a library helper would be more appropriate. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ecrdsa - use subsys_initcall instead of module_init

ations of the algorithms, which is not the case here. Please explain the real reason why this is needed. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[RESEND PATCH] crypto: sa2ul - Reduce stack usage

uth. 4. Use async skcipher fallback and remove on-stack request from sa_cipher_run. Reported-by: kernel test robot Fixes: d2c8ac187fc9 ("crypto: sa2ul - Add AEAD algorithm support") Signed-off-by: Herbert Xu diff --git a/drivers/crypto/sa2ul.c b/drivers/crypto/sa2ul.c index

[GIT PULL] Crypto Update for 5.10

nction parameters descriptions crypto: qat - drop input parameter from adf_enable_aer() Hao Fang (1): crypto: hisilicon/zip - fix the uncleared debug registers Herbert Xu (32): crypto: algapi - Move crypto_yield into internal.h crypto: algapi - Remove skbuff.h inclusion crypto:

Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from device/AES-NI

you request MAY_BACKLOG. However, you must then ensure that when you get EBUSY that you stop issuing new requests until the Crypto API signals through the callback that you can start again. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org

[PATCH] lib/mpi: Remove unused scalar_copied

("lib/mpi: Introduce ec implementation to...") Reported-by: Gustavo A. R. Silva Signed-off-by: Herbert Xu diff --git a/lib/mpi/ec.c b/lib/mpi/ec.c index c21470122dfc..40f5908e57a4 100644 --- a/lib/mpi/ec.c +++ b/lib/mpi/ec.c @@ -1252,7 +1252,6 @@ void mpi_ec_mul_point(MPI_

Re: [v2 PATCH] crypto: sun4i-ss - Fix sparse endianness markers

; priority : 100 > refcnt : 1 > selftest : passed > internal : no > type : shash > blocksize: 64 > digestsize : 20 Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: xor - Remove unused variable count in do_xor_speed

crypto/xor.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat - fix function parameters descriptions

gt; drivers/crypto/qat/qat_common/adf_sriov.c | 6 +- > 2 files changed, 6 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: qat - drop input parameter from adf_enable_aer()

2 +- > drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 2 +- > 5 files changed, 7 insertions(+), 7 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] X.509: fix error return value on the failed path

; --- > crypto/asymmetric_keys/public_key_sm2.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC 1/1] net/tls(TLS_SW): Handle -ENOSPC error return from device/AES-NI

mode you wish to use. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - Fix sparse warnings

On Sat, Oct 03, 2020 at 07:15:53PM +0200, Christophe Leroy wrote: > > The following changes fix the sparse warnings with less churn: Yes that works too. Can you please submit this patch? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

[PATCH] X.509: Fix modular build of public_key_sm2

s patch moves the code back into the same file as the original motivation was to minimise ifdefs and that has nothing to do with splitting the code out. Fixes: 215525639631 ("X.509: support OSCCA SM2-with-SM3...") Reported-by: kernel test robot Signed-off-by: Herbert Xu diff --git a/c

Re: [PATCH] crypto: talitos - Fix sparse warnings

On Fri, Oct 02, 2020 at 10:42:23PM +1000, Herbert Xu wrote: > > I don't think that's a valid optimisation unless it's backed up > with real numbers. Also it only matters on little-endian as they're no-ops on big-endian. If I'm right then this driver never eve

Re: [PATCH] crypto: talitos - Fix sparse warnings

timisation unless it's backed up with real numbers. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 17/18] crypto: atmel-tdes - use semicolons rather than commas to separate statements

... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/crypto/atmel-tdes.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 13/18] crypto: use semicolons rather than commas to separate statements

... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/crypto/amcc/crypto4xx_alg.c |2 +- > drivers/crypto/hifn_795x.c |4 ++-- > drivers/crypto/talitos.c|8 > 3 files changed, 7 insertions(+), 7 deletions(-)

Re: [PATCH 04/18] hwrng: stm32 - use semicolons rather than commas to separate statements

... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/char/hw_random/stm32-rng.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 06/18] hwrng: iproc-rng200 - use semicolons rather than commas to separate statements

... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/char/hw_random/iproc-rng200.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 07/18] hwrng: mxc-rnga - use semicolons rather than commas to separate statements

... when any > // > > Signed-off-by: Julia Lawall > > --- > drivers/char/hw_random/mxc-rnga.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/2] crypto: xor - defer and optimize boot time benchmark

-- > 1 file changed, 44 insertions(+), 23 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1] hw_random: npcm: modify readl to readb

| 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 00/10] crypto: caam - xts(aes) updates

am/caamalg_desc.c | 27 --- > drivers/crypto/caam/caamalg_qi.c | 94 +--- > drivers/crypto/caam/caamalg_qi2.c | 111 ++--- > drivers/crypto/caam/caamalg_qi2.h | 2 + > 6 files changed, 293 insertions(+), 38 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: sa2ul: Fix DMA mapping API usage

ged, 117 insertions(+), 98 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH RESEND 0/4] crypto: hisilicon/zip - misc clean up

; Zhou Wang (1): > crypto: hisilicon/zip - fix zero length input in GZIP decompress > > drivers/crypto/hisilicon/zip/zip_crypto.c | 26 +++--- > drivers/crypto/hisilicon/zip/zip_main.c | 19 +++ > 2 files changed, 38 insertions(+), 7

Re: [PATCH -next] crypto: marvell/octeontx - simplify the return expression of create_sysfs_eng_grps_info()

On Mon, Sep 21, 2020 at 09:10:07PM +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- > drivers/crypto/marvell/octeontx/otx_cptpf_ucode.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) Patch applied. Thanks.

Re: [PATCH -next] crypto: mediatek - simplify the return expression of mtk_dfe_dse_reset()

On Mon, Sep 21, 2020 at 09:10:09PM +0800, Qinglang Miao wrote: > Simplify the return expression. > > Signed-off-by: Qinglang Miao > --- > drivers/crypto/mediatek/mtk-platform.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) Patch applied. Thanks. -- Email

Re: [PATCH] crypto: ccp - fix error handling

On Mon, Sep 21, 2020 at 01:34:35PM +0200, Pavel Machek wrote: > Fix resource leak in error handling. > > Signed-off-by: Pavel Machek (CIP) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: cpt - simplify the return expression of cav_register_algs

On Mon, Sep 21, 2020 at 04:24:28PM +0800, Liu Shixin wrote: > Simplify the return expression. > > Signed-off-by: Liu Shixin > --- > drivers/crypto/cavium/cpt/cptvf_algs.c | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) Patch applied. Thanks. -- Email: Her

[PATCH] crypto: talitos - Fix sparse warnings

: Herbert Xu diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index 66773892f665..fc134aa534af 100644 --- a/drivers/crypto/talitos.c +++ b/drivers/crypto/talitos.c @@ -350,13 +350,13 @@ static void flush_channel(struct device *dev, int ch, int error, int reset_ch) tail = priv

[PATCH] crypto: bcm - Verify GCM/CCM key length in setkey

ong as the salt. Fixes: 9d12ba86f818 ("crypto: brcm - Add Broadcom SPU driver") Cc: Reported-by: kiyin(尹亮) Signed-off-by: Herbert Xu diff --git a/drivers/crypto/bcm/cipher.c b/drivers/crypto/bcm/cipher.c index 5d38b87b9d77..50d169e61b41 100644 --- a/drivers/crypto/bcm/cipher.c +++

Re: [PATCH][next] crypto: sun8i-ss@: fix memory leak on pointer d

hanged, 3 insertions(+), 1 deletion(-) This patch is already in the queue: https://patchwork.kernel.org/patch/11804435/ Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] lib/mpi: Fix unused variable warnings

: Tianjia Zhang > Tested-by: Xufeng Zhang This creates some compiler warnings. ---8<--- This patch removes a number of unused variables and marks others as unused in order to silence compiler warnings about them. Fixes: a8ea8bdd9df9 ("lib/mpi: Extend the MPI library") Signed-off-by: He

Re: [PATCH v7 00/10] crpyto: introduce OSCCA certificate and SM2 asymmetric algorithm

| 204 +++ > security/integrity/digsig_asymmetric.c| 14 +- > 32 files changed, 4435 insertions(+), 26 deletions(-) > create mode 100644 crypto/asymmetric_keys/public_key_sm2.c > create mode 100644 crypto/sm2.c > create mode 100644 crypto/sm2signature.asn1 &

Re: [PATCH] crypto/chcr: fix minor indentation issue

_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/3] crypto: hisilicon/hpre - misc clean up and fixes

code > crypto: hisilicon/hpre - adjust some coding style > crypto: hisilicon/hpre - fix a bug in dh algorithm > > drivers/crypto/hisilicon/hpre/hpre.h| 1 - > drivers/crypto/hisilicon/hpre/hpre_crypto.c | 23 +++ > 2 files changed, 11 insertions(+)

Re: [PATCH 0/2] crypto: hisilicon/qm - misc fixes

| 1 - > drivers/crypto/hisilicon/sec2/sec_main.c | 3 +-- > drivers/crypto/hisilicon/zip/zip_main.c | 3 +-- > 4 files changed, 3 insertions(+), 7 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v9] crypto: af_alg - add extra parameters for DRBG interface

| 175 ++++++++-- > include/crypto/if_alg.h | 1 + > include/uapi/linux/if_alg.h | 1 + > 6 files changed, 205 insertions(+), 15 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next v2] crypto: cavium/zip - Convert to DEFINE_SHOW_ATTRIBUTE

vium/zip/zip_main.c | 44 > 1 file changed, 6 insertions(+), 38 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next v2] crypto: hisilicon/qm - Convert to DEFINE_SHOW_ATTRIBUTE

ypto/hisilicon/qm.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next v2] crypto: caam: Convert to DEFINE_SHOW_ATTRIBUTE

am/dpseci-debugfs.c | 23 ++- > 1 file changed, 2 insertions(+), 21 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v7 00/17] crypto: allwinner: add xRNG and hashes

ce/sun8i-ce-prng.c > create mode 100644 drivers/crypto/allwinner/sun8i-ce/sun8i-ce-trng.c > create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c > create mode 100644 drivers/crypto/allwinner/sun8i-ss/sun8i-ss-prng.c All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next v2] crypto: amlogic: Convert to DEFINE_SHOW_ATTRIBUTE

logic/amlogic-gxl-core.c | 16 ++-- > 1 file changed, 2 insertions(+), 14 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next v2] crypto: allwinner - Convert to DEFINE_SHOW_ATTRIBUTE

winner/sun8i-ce/sun8i-ce-core.c | 15 ++- > drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 15 ++- > 2 files changed, 4 insertions(+), 26 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http:

Re: [PATCH v2] crypto: stm32/crc32 - Avoid lock if hardware is already used

m32/stm32-crc32.c | 15 --- > 2 files changed, 13 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: procfs: Removing some useless only space lines

On Thu, Sep 17, 2020 at 06:59:36PM +, Corentin Labbe wrote: > Some line got only spaces, remove them > > Signed-off-by: Corentin Labbe > --- > crypto/proc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert X

Re: [PATCH 0/3] crypto: arm/aes-neonbs - some polish

(+), 35 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: marvell/cesa - use devm_platform_ioremap_resource_byname

t; --- > drivers/crypto/marvell/cesa/cesa.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: qat - convert to use DEFINE_SEQ_ATTRIBUTE macro

ntee that I'll spot the problem every time. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: atmel-aes - convert to use be32_add_cpu()

On Mon, Sep 14, 2020 at 12:17:46PM +0800, Liu Shixin wrote: > Convert cpu_to_be32(be32_to_cpu(E1) + E2) to use be32_add_cpu(). > > Signed-off-by: Liu Shixin > --- > drivers/crypto/atmel-aes.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. --

Re: [PATCH 0/2] Add support for the TRNG in Ingenic X1830.

ingenic-trng.c | 161 > + > 4 files changed, 219 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rng/ingenic,trng.yaml > create mode 100644 drivers/char/hw_random/ingenic-trng.c All applied. Thanks. -- Email: Herbert Xu Home Page: http:

Re: [PATCH v6] cypto: mediatek - fix leaks in mtk_desc_ring_alloc

emory leaks > > Fixes: 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some > MediaTek chips") > Cc: Ryder Lee > Signed-off-by: Xiaoliang Pang > --- > drivers/crypto/mediatek/mtk-platform.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 del

Re: [PATCH -next] crypto: qat - convert to use DEFINE_SEQ_ATTRIBUTE macro

- > 2 files changed, 5 insertions(+), 56 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: qat - remove unnecessary mutex_init()

changed, 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/2] crypto: arm/sha-neon - avoid ADRL instructions

4.pl | 4 ++-- > arch/arm/crypto/sha256-core.S_shipped | 4 ++-- > arch/arm/crypto/sha512-armv4.pl | 4 ++-- > arch/arm/crypto/sha512-core.S_shipped | 4 ++-- > 4 files changed, 8 insertions(+), 8 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.a

Re: [PATCH v2 6/7] crypto: sun4i-ss: enabled stats via debugfs

@ -152,6 +153,10 @@ struct sun4i_ss_ctx { > #ifdef CONFIG_CRYPTO_DEV_SUN4I_SS_PRNG > u32 seed[SS_SEED_LEN / BITS_PER_LONG]; > #endif > +#ifdef CONFIG_CRYPTO_DEV_SUN4I_SS_DEBUG > + struct dentry *dbgfs_dir; > + struct dentry *dbgfs_stats; > +#endif You just need to add forward declarations for struct dentry. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 1/7] crypto: sun4i-ss: linearize buffers content must be kept

onder if the stack usage would be an issue again? How about moving this code into another function so that it sits at the same level as the fallback function, which would mean that the buffers do not double up with the one for the fallback? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: inside-secure - Fix corruption on not fully coherent systems

iddle, up to 128 bytes. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: inside-secure - Fix corruption on not fully coherent systems

need a couple of fairly small buffers. Those small buffers are embedded in a structure that's already aligned by kmalloc. So just put your buffers at the start of the struct to minimise holes. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://

[PATCH] crypto: x86/poly1305 - Remove assignments with no effect

ch removes a few ineffectual assignments from the function crypto_poly1305_setdctxkey. Reported-by: kernel test robot Signed-off-by: Herbert Xu diff --git a/arch/x86/crypto/poly1305_glue.c b/arch/x86/crypto/poly1305_glue.c index f85885d6ccd8..e508dbd91813 100644 --- a/arch/x86/cryp

Re: [PATCH] crypto: inside-secure - Fix corruption on not fully coherent systems

mean > you end up wasting a lot of space on a system with a much smaller cacheline. It won't waste any memory because kmalloc is already using it as a minimum. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<    1   2   3   4   5   6   7   8   9   10   >