Re: [PATCH] crypto: mediatek - drop .owner field in mtk_crypto_driver

2017-06-19 Thread Herbert Xu
On Sat, May 06, 2017 at 11:35:29PM +0800, Geliang Tang wrote: > Drop .owner field in mtk_crypto_driver, since platform_driver_register() > will set it automatically. > > Signed-off-by: Geliang Tang <geliangt...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb..

Re: [PATCH] crypto: aes_ti - fix comment for MixColumns step

2017-06-19 Thread Herbert Xu
match the code, which is correct. Fix the comment. > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/3] Add more algorithms and some misc cleanups

2017-06-19 Thread Herbert Xu
m: Downgrade the annoying misc interrupt print from > dev_err to dev_dbg > crypto: cavium: Remove the individual encrypt/decrypt function for > each algorithm > crypto: cavium: Add more algorithms All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au>

Re: [PATCH] drivers/crypto/ccp: return NULL instead of 0

2017-06-19 Thread Herbert Xu
om> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V2] crypto: ccp - Add debugfs entries for CCP information

2017-06-19 Thread Herbert Xu
ting (any value) > to the 'stats' file. This can be done per queue or per device. > > Changes from V1: > - Correct polarity of test when destroying devices at module unload > > Signed-off-by: Gary R Hook <gary.h...@amd.com> Patch applied. Thanks. -- Email: Herbert Xu <he

Re: [-next] crypto: 842 propagate PTR_ERR value instead of -ENOMEM

2017-06-19 Thread Herbert Xu
return PTR_ERR(ctx-wmem); Please test your patches before submission. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] hwrng: do not warn when there are no devices

2017-06-19 Thread Herbert Xu
> driver is *extremely* simple -- it's 3 funcs, each of which are 1 > line. It's simple and it's broken, as far as the way it hooks into the hwrng is concerned. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 2/2] crypto: engine - Permit to enqueue skcipher request

2017-06-18 Thread Herbert Xu
are the same, so > only one cipher type is usable on the same crypto engine. > > Signed-off-by: Corentin Labbe <clabbe.montj...@gmail.com> I think this should be done as part of the skcipher conversion rather than as a standalone patch. Thanks, -- Email: Herbert Xu <herb...@gondor

Re: [PATCH] hwrng: do not warn when there are no devices

2017-06-18 Thread Herbert Xu
. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH 0/2] crypto: caam - fix cts(cbc(aes)) with CAAM driver

2017-06-16 Thread Herbert Xu
FP_KERNEL to allocate memory. However, this is incorrect, since > driver runs in atomic context (softirq). This is wrong. Whether you can sleep or not is determined by MAY_SLEEP, not MAY_BACKLOG. MAY_BACKLOG only indicates that this request must be queued, even if the queue is full. Cheers, -- Email:

Crypto Fixes for 4.12

2017-06-14 Thread Herbert Xu
/infiniband/sw/rxe/rxe.h |5 - fs/btrfs/hash.c |5 - fs/f2fs/f2fs.h |5 - lib/libcrc32c.c |6 -- 4 files changed, 16 insertions(+), 5 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page

Re: [PATCH v2 01/11] crypto: introduce crypto wait for async op

2017-06-10 Thread Herbert Xu
d of the ambiguity. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v8 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-06-10 Thread Herbert Xu
we hold > the socket. Indeed, we should just kill the wait or perhaps convert it to a WARN_ON. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: rng - move __crypto_rng_cast to the rng header

2017-06-09 Thread Herbert Xu
tion altogether, I think I'll just leave it in place. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: rng: Remove unused function __crypto_rng_cast()

2017-06-09 Thread Herbert Xu
@chromium.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/1] crypto:drbg- Fixes panic in wait_for_completion call.

2017-06-09 Thread Herbert Xu
sen function is wrong. When we have an HMAC or Hash DRBG, > this completion function does not need to be initialized. > > May I ask you to check this patch? Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/

Re: [PATCH v3 0/2] crypto: ecdh - add privkey generation support

2017-06-09 Thread Herbert Xu
-term key. > > There are crypto accelerators that are capable of generating and retaining > ecdh private keys without revealing them to software. This patch set is a > prerequisite for hardware ecdh with private key generation support. > > Changes in v3: All applied. Thanks. --

Re: [PATCH v2 0/3] Add support for Cavium CNN55XX crypto adapters.

2017-06-09 Thread Herbert Xu
tions. > > Changes from v1 to v2: All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1 0/2] remove mediatek ethif clock in crypto driver

2017-06-09 Thread Herbert Xu
On Thu, Jun 01, 2017 at 10:30:20AM +0800, Ryder Lee wrote: > This patch series only remove redundant clock setting in mediatek crypto > driver. > > Changes since v1: > -rework the commit message. All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.a

Re: [PATCH v6 4/5] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver

2017-06-09 Thread Herbert Xu
antoine.ten...@free-electrons.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 00/14] fixes for kpp and akcipher

2017-06-09 Thread Herbert Xu
ch 4/14 taken from v5. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 00/13] crypto: omap fixes / changes for 4.13

2017-06-09 Thread Herbert Xu
sed for both AES/DES. Addition > of SHA to this is still pending as it requires certain things > to be done slightly differently (need a couple of new flags for > the API I believe.) All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:

Re: [PATCH v6 5/5] MAINTAINERS: add a maintainer for the Inside Secure crypto driver

2017-06-09 Thread Herbert Xu
d. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] X.509: Fix error code in x509_cert_parse()

2017-06-09 Thread Herbert Xu
r api") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > --- > v2: Style change Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 01/11] crypto: introduce crypto wait for async op

2017-06-09 Thread Herbert Xu
s a fatal error. So this API can't be used without backlog. We could introduce a flag to indicate whether we want backlog or not, or maybe we should change our API so that in the non-backlog case we return something other than EBUSY. Opinions? Thanks, -- Email: Herbert Xu <herb...@gond

Re: [PATCH v8 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-06-09 Thread Herbert Xu
xisting code is crap too. We should not be waiting in the destructor in the first place. The proper way to do it is to hold a reference count on the socket. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Crypto Fixes for 4.12

2017-06-08 Thread Herbert Xu
On Thu, Jun 08, 2017 at 10:05:02AM -0400, David Miller wrote: > From: Herbert Xu <herb...@gondor.apana.org.au> > Date: Thu, 8 Jun 2017 17:23:21 +0800 > > > This push fixes a couple of places in the crypto code that were > > doing interruptible sleeps dangerously

Crypto Fixes for 4.12

2017-06-08 Thread Herbert Xu
op not signal safe crypto/asymmetric_keys/public_key.c |2 +- crypto/drbg.c |5 ++--- crypto/gcm.c|6 ++ 3 files changed, 5 insertions(+), 8 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page

Re: crypto: Work around deallocated stack frame reference gcc bug on sparc.

2017-06-06 Thread Herbert Xu
on them has the same bug :-) > > > > With crucial insight from Eric Sandeen. > > > > Reported-by: Anatoly Pugachev <mator...@gmail.com> > > Signed-off-by: David S. Miller <da...@davemloft.net> > > Herbert, please take a look at this and push vi

Re: [PATCH v2 1/2] dt-bindings: timeriomem_rng: Add entropy quality property

2017-05-31 Thread Herbert Xu
On Mon, May 22, 2017 at 02:12:23PM -0700, Rick Altherr wrote: > Signed-off-by: Rick Altherr <ralth...@google.com> Both patches applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.

Re: [PATCH 0/5] crypto: arm - enable module autoloading

2017-05-31 Thread Herbert Xu
t boot. All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/9] crypto: add HMAC IPAD/OPAD constant

2017-05-22 Thread Herbert Xu
t > crypto: omap-sham - Use IPAD/OPAD constant > crypto: qat - Use IPAD/OPAD constant > crypto: mediatek - Use IPAD/OPAD constant > crypto: ccp - Use IPAD/OPAD constant All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.a

Re: [PATCH v2 0/4] crypto: async crypto op fixes

2017-05-22 Thread Herbert Xu
Biggers <ebigge...@gmail.com> Patches 1-3 applied. Please fix patch 4 and resubmit. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: x86/aes - Don't use %rbp as temporary register

2017-05-22 Thread Herbert Xu
essentially unchanged --- actually about 0.2% faster than > before. Interestingly, I also measured aes-generic as being nearly 7% > faster than aes-asm, so perhaps aes-asm has outlived its usefulness... > > Signed-off-by: Eric Biggers <ebigg...@google.com> Patch applied. Thanks. --

Re: [PATCH v1] crypto: img-hash - Handle return value of clk_prepare_enable

2017-05-22 Thread Herbert Xu
On Tue, May 16, 2017 at 01:57:41PM +0530, Arvind Yadav wrote: > Here, Clock enable can failed. So adding an error check for > clk_prepare_enable. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.ap

Re: [PATCH] crypto: qat: use pcie_flr instead of duplicating it

2017-05-22 Thread Herbert Xu
On Tue, May 16, 2017 at 04:21:05PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <h...@lst.de> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v1] hw_random : omap3-rom-rng:- Handle return value of clk_prepare_enable

2017-05-22 Thread Herbert Xu
On Mon, May 15, 2017 at 01:52:03PM +0530, Arvind Yadav wrote: > Here, Clock enable can failed. So adding an error check for > clk_prepare_enable. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.ap

Re: [PATCH v2 08/11] crypto: testmgr - check err on akcipher maxsize

2017-05-22 Thread Herbert Xu
, > > err = -ENOMEM; > out_len_max = crypto_akcipher_maxsize(tfm); Can this call be reached without a setkey or with a failed setkey? If not we should not check for errors. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 04/11] crypto: dh - fix dh_max_size

2017-05-22 Thread Herbert Xu
> - return mpi_get_size(ctx->p); > + return ctx->p ? mpi_get_size(ctx->p) : -EINVAL; How about ENOKEY? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 6/8] crypto: dh - fix dh_max_size

2017-05-22 Thread Herbert Xu
> - return mpi_get_size(ctx->p); > + return ctx->p ? mpi_get_size(ctx->p) : -EINVAL; > } How about ENOKEY? Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: ecdh: generation and retention of ecc privkey in kernel/hardware

2017-05-22 Thread Herbert Xu
What's your feeling on this? It sounds sane to me. It does raise the question though whether we need the ability to set the secret at all. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.12

2017-05-22 Thread Herbert Xu
Hi Linus: This push fixes a regression in the skcipher interface that allows bogus key parameters to hit underlying implementations which can cause crashes. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git linus Herbert Xu (1): crypto: skcipher

Re: [PATCH 0/7] crypto: aesni: provide generic gcm(aes)

2017-05-17 Thread Herbert Xu
algorithm to the crypto API. > > With these patches, performance of MACsec on a single core increases > by 40% (from 4.5Gbps to around 6.3Gbps). All patches applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: arm64/sha - avoid non-standard inline asm tricks

2017-05-17 Thread Herbert Xu
t;) > constraints in the same way as GCC. > > Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/5] crypto: caampkc - extend RSA private key representation

2017-05-17 Thread Herbert Xu
tcrypt test has been added. Patches 2-5 applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: ccp - Add a module author

2017-05-17 Thread Herbert Xu
On Tue, Apr 25, 2017 at 08:59:44AM -0500, Gary R Hook wrote: > CC: <sta...@vger.kernel.org> # 4.9.x+ > > Signed-off-by: Gary R Hook <gary.h...@amd.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org

Re: [PATCH] crypto: sha512-mb - add some missing unlock on error

2017-05-17 Thread Herbert Xu
Dan Carpenter <dan.carpen...@oracle.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: tcrypt: don't disable irqs and wait

2017-05-17 Thread Herbert Xu
other (i.e. hash) cycle > speed tests do. > > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> > Reported-by: Ofir Drang <ofir.dr...@arm.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/4] crypto: drbg wait for crypto op not signal safe

2017-05-17 Thread Herbert Xu
utput buffer. > > Resolve this by using wait_for_completion() instead. > > Reported-by: Eric Biggers <ebigge...@gmail.com> > Signed-off-by: Gilad Ben-Yossef <gi...@benyossef.com> > CC: sta...@vger.kernel.org This patch doesn't even compile. Please test your work f

Re: [PATCH 1/9] crypto: add hmac IPAD/OPAD constant

2017-05-17 Thread Herbert Xu
/ I think this should go into a header file specific to hmac. Since I don't see an existing hmac header file you should create one for it. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/5] crypto: tcrypt - include rsa test

2017-05-17 Thread Herbert Xu
@nxp.com> I think it's time to stop adding new algorithms to tcrypt as you should be able to test any algorithm using name/type/mask. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye

2017-05-17 Thread Herbert Xu
On Thu, May 18, 2017 at 11:25:06AM +0800, Herbert Xu wrote: > On Fri, Apr 28, 2017 at 11:02:40AM -0600, Logan Gunthorpe wrote: > > * Cleaned up the formatting of ablkcipher_get arguments so it complies > > with kernel style > > * The offset in ablkcipher_get sould b

Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye

2017-05-17 Thread Herbert Xu
hardware? This is an old driver so it's probably best to just let it be. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: crypto: al_alg: alg_setkey does not check key's size is zero or not, causing a Null-ptr-dereference

2017-05-09 Thread Herbert Xu
On Fri, May 05, 2017 at 03:59:28PM +0300, Dan Carpenter wrote: > Thanks for the Report. I've fowarded it to Herbert Xu. Thanks. This is a bug in the new skcipher interface. ---8<--- Subject: crypto: skcipher - Add missing API setkey checks The API setkey checks for key sizes and ali

Crypto Update for 4.12

2017-05-01 Thread Herbert Xu
Kallweit (4): clk: meson-gxbb: expose clock CLKID_RNG0 dt-bindings: rng: add clock to DT binding documentation for hwrng ARM64: dts: meson-gx: add clock CLKID_RNG0 to hwrng node hwrng: meson - add clock handling to driver Herbert Xu (7): Merge git://git.kernel.org/p

Re: [PATCH] crypto: stm32 - fix building as a module

2017-04-29 Thread Herbert Xu
k.kernel.org/patch/9698299/ Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: stm32 - Fix OF module alias information

2017-04-29 Thread Herbert Xu
m32 - Support for STM32 CRC32 crypto module") > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-28 Thread Herbert Xu
On Fri, Apr 28, 2017 at 10:53:45AM -0600, Logan Gunthorpe wrote: > > > On 28/04/17 12:30 AM, Herbert Xu wrote: > > You are right. Indeed the existing code looks buggy as they > > don't take sg->offset into account when doing the kmap. Could > > you send me some p

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-28 Thread Herbert Xu
On Thu, Apr 27, 2017 at 09:45:57AM -0600, Logan Gunthorpe wrote: > > > On 26/04/17 09:56 PM, Herbert Xu wrote: > > On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > >> Very straightforward conversion to the new function in the caam driver > >> an

Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

2017-04-26 Thread Herbert Xu
On Tue, Apr 25, 2017 at 12:20:54PM -0600, Logan Gunthorpe wrote: > Very straightforward conversion to the new function in the caam driver > and shash library. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Herbert Xu <herb...@gondor.apana.org.au>

Re: [PATCH v2] crypto: algif_aead - Require setkey before accept(2)

2017-04-25 Thread Herbert Xu
On Mon, Apr 24, 2017 at 12:26:15PM +0200, Stephan Müller wrote: > Am Montag, 24. April 2017, 12:22:39 CEST schrieb Herbert Xu: > > Hi Herbert, > > > Patch applied. Thanks. > > Thank you. > > The patch regarding the memory management of algif_aead is affected by t

Re: [PATCH 2/3] crypto: cavium: Remove the individual encrypt/decrypt function for each algorithm

2017-04-24 Thread Herbert Xu
cipher++; > + } > + > + return cipher->value; > } That's rather unwieldy. It's usually easier to embed the cipher type into the algo structure and then get to it via the alg object. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http:/

Re: [PATCH] crypto: Allow ecb(cipher_null) in FIPS mode

2017-04-24 Thread Herbert Xu
tsetup-reencrypt tool. > > Problem is easily reproducible with > cryptsetup benchmark -c null > > Signed-off-by: Milan Broz <gmazyl...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 1/2] crypto: scomp - allow registration of multiple scomps

2017-04-24 Thread Herbert Xu
Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: crypto4xx: rename ce_ring_contol to ce_ring_control

2017-04-24 Thread Herbert Xu
On Fri, Apr 21, 2017 at 12:13:49PM +0100, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > trivial spelling mistake, missing r, rename to ce_ring_control > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Patch applied. Thanks.

Re: [PATCH v2] crypto: algif_aead - Require setkey before accept(2)

2017-04-24 Thread Herbert Xu
On Mon, Apr 24, 2017 at 11:15:23AM +0200, Stephan Müller wrote: > Am Montag, 24. April 2017, 11:03:13 CEST schrieb Herbert Xu: > > Hi Herbert, > > > On Mon, Apr 24, 2017 at 11:01:50AM +0200, Stephan Müller wrote: > > > Shall I send an updated patch with aead_sock_des

Re: [PATCH] crypto: algif_aead - Require setkey before accept(2)

2017-04-24 Thread Herbert Xu
On Mon, Apr 24, 2017 at 11:01:50AM +0200, Stephan Müller wrote: > > Shall I send an updated patch with aead_sock_destruct cleared? Yes please. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org

Re: [Patch V5 1/7] crypto: Multi-buffer encryption infrastructure support

2017-04-24 Thread Herbert Xu
t carry the normal alg name (e.g., ecb(aes)) and driver name, while the mcryptd wrapped version will have the same algorithm name but carry a prefix on the driver name (which is simd- for simd.c, but you should probably used mcryptd-). Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au

Re: [PATCH] crypto: algif_aead - Require setkey before accept(2)

2017-04-24 Thread Herbert Xu
ain the tfm from ctx->aead_req? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Herbert Xu
On Mon, Apr 24, 2017 at 09:04:19AM +0100, Ard Biesheuvel wrote: > > Yes please. OK, patch reverted. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-24 Thread Herbert Xu
arch/arm64/crypto/sha1-ce-glue.c:21:2: error: invalid 'asm': invalid > > > operand prefix '%c' > > > asm(".globl " #sym "; .set " #sym ", %c0" :: "i"(val)); > > Sorry about that :( So what's the consensus? Should I revert this patch? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] n2rng: Use devm_kcalloc() in n2rng_probe()

2017-04-21 Thread Herbert Xu
tion. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/2] hwrng: mtk: add support for hardware random generator on MT7623 SoC

2017-04-21 Thread Herbert Xu
t; SoC. And it should also be workable on other similar Mediatek SoCs. > > Changes since v1: All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH V3 0/2] Interrupt management fixes

2017-04-21 Thread Herbert Xu
Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v5 0/2] crypto: hw_random - Add new Exynos RNG driver

2017-04-21 Thread Herbert Xu
Add Bartlomiej's reviewed-by. All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] powerpc/crypto/crct10dif-vpmsum: Fix missing preempt_disable()

2017-04-21 Thread Herbert Xu
eration") > Acked-by: Daniel Axtens <d...@axtens.net> > Signed-off-by: Michael Ellerman <m...@ellerman.id.au> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: acomp - replace compression known answer test

2017-04-21 Thread Herbert Xu
if the data produced > by the compressor is correct. > This implements a decompress-and-verify test for acomp > compression tests rather than a known answer test. > > Signed-off-by: Giovanni Cabiddu <giovanni.cabi...@intel.com> Patch applied. Thanks. -- Email: Herbert Xu <he

Re: [PATCH] crypto: acomp - allow registration of multiple acomps

2017-04-21 Thread Herbert Xu
Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: chcr - Fix error handling related to 'chcr_alloc_shash'

2017-04-21 Thread Herbert Xu
;christophe.jail...@wanadoo.fr> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/4] Bug fixes and fallback for AEAD

2017-04-21 Thread Herbert Xu
56]. > chcr: Add fallback for AEAD algos > Atul Gupta (1): > chcr: Fix txq ids All applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: caam - fix error return code in caam_qi_init()

2017-04-21 Thread Herbert Xu
ixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend > support") > Signed-off-by: Wei Yongjun <weiyongj...@huawei.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: Allow ecb(cipher_null) in FIPS mode

2017-04-21 Thread Herbert Xu
tsetup-reencrypt tool. > > Problem is easily reproducible with > cryptsetup benchmark -c null > > Signed-off-by: Milan Broz <gmazyl...@gmail.com> Stephan? -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/2] crypto: acomp - add support for deflate rfc1950 (zlib)

2017-04-21 Thread Herbert Xu
eflate_sdecompress, > + .base = { > + .cra_name = "zlib(deflate)", Please avoid using parentheses as they are used for templates. Perhaps zlib-deflate or deflate-rfc1950. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page:

Re: [PATCH] crypto: acomp - report scomp implementations

2017-04-21 Thread Herbert Xu
; type &= ~CRYPTO_ALG_TYPE_MASK; > type |= CRYPTO_ALG_TYPE_ACOMPRESS; > + type |= CRYPTO_ALG_TYPE_SCOMPRESS; > mask |= CRYPTO_ALG_TYPE_MASK; > > return crypto_has_alg(alg_name, type, mask); Are you sure this works? I think you should modify the mas

Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()

2017-04-21 Thread Herbert Xu
g split across lines > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> This patch doesn't seem to add any value so I'm not taking it. Please don't send patches based purely on a checkpatch complaint. Thanks, --

Re: [PATCH] crypto: algif_aead - Require setkey before accept(2)

2017-04-21 Thread Herbert Xu
> af_alg_complete, >completion); > Please don't mix unrelated cleanups like this with the real change. It makes reviewing harder than necessary. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH v1 0/1] *** crypto: AF_ALG: add compression support ***

2017-04-20 Thread Herbert Xu
export it to user-space. > > Would it be acceptable if we export an algif interface using > alg_type_compress, > which is being used by ipcomp currently? We would like to use our zip > device from > userspace through this interface. No we're not going to export an obsolete inter

Re: [PATCH] padata: allow caller to control queue length

2017-04-18 Thread Herbert Xu
t; > My [not-yet-mainlined] code wants it. Well then you should submit this along with your code that uses it. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.11

2017-04-18 Thread Herbert Xu
/kernel/git/herbert/crypto-2.6.git linus Herbert Xu (4): crypto: xts - Fix use-after-free on EINPROGRESS crypto: lrw - Fix use-after-free on EINPROGRESS crypto: ahash - Fix EINPROGRESS notification callback crypto: algif_aead - Fix bogus request dereference in completion

Re: [RFC PATCH v1 0/1] *** crypto: AF_ALG: add compression support ***

2017-04-14 Thread Herbert Xu
convert ipcomp over to the new interface first in order to make sure that we don't need to change the interface which would be hard to do once we export it to user-space. Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [patch 13/13] crypto: n2 - Replace racy task affinity logic

2017-04-12 Thread Herbert Xu
requested CPU or to fail in case the CPU is offline. > > Signed-off-by: Thomas Gleixner <t...@linutronix.de> > Cc: Herbert Xu <herb...@gondor.apana.org.au> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: linux-crypto@vger.kernel.org Ac

Re: [PATCH 0/7] arm64: marvell: add cryptographic engine support for 7k/8k

2017-04-12 Thread Herbert Xu
On Tue, Apr 11, 2017 at 06:12:25PM +0200, Gregory CLEMENT wrote: > > > I have no problems with the crypto bits. > > Does it means that you agree that I apply the arm-soc related patches > (from 4 to 7) to my mvebu trees? Yes sure. Thanks, -- Email: Herbert Xu <herb...@gond

Re: Fwd: [linux-next:master 7274/8070] undefined reference to `crypto_alloc_shash'

2017-04-11 Thread Herbert Xu
On Mon, Apr 10, 2017 at 12:46:22PM +0200, Stephan Müller wrote: > Am Montag, 10. April 2017, 12:22:23 CEST schrieb Herbert Xu: > > Hi Herbert, > > > Hmm that's weird because CRYPTO_HASH selects CRYPTO_HASH2. Do > > you have a kconfig file that reproduces this? > &g

Re: [PATCH] padata: free correct variable

2017-04-10 Thread Herbert Xu
gt; Cc: sta...@vger.kernel.org Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: What should be the algo priority

2017-04-10 Thread Herbert Xu
t it the other way. The priority of your hardware authenc should be greater than (aes * 10 + hmac) where aes is the priority of your hardware aes and hmac is the priority of your hardware hmac. Cheers, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au

Re: [PATCH v2 0/3] hw_random: timeriomem_rng: Migrate to new API and improve performance

2017-04-10 Thread Herbert Xu
mproves read performance of /dev/hwrng to 13Mb/s. > > Changes in v2: > - Split API migration into separate patch > - Split type and variable renames into separate patch > - Split performance improvements into separate patch All applied. Thanks. -- Email: Herbert Xu <herb...@gondor

Re: [PATCH] crypto: lz4: fixed decompress function to return error code

2017-04-10 Thread Herbert Xu
y: Myungho Jung <mhju...@gmail.com> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: arm64/sha: Add constant operand modifier to ASM_EXPORT

2017-04-10 Thread Herbert Xu
.com> > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Crypto Fixes for 4.11

2017-04-10 Thread Herbert Xu
+ drivers/crypto/caam/intern.h |1 - 3 files changed, 22 insertions(+), 47 deletions(-) Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v6 1/2] crypto: skcipher AF_ALG - overhaul memory management

2017-04-10 Thread Herbert Xu
On Mon, Apr 10, 2017 at 12:54:58PM +0200, Stephan Müller wrote: > Am Montag, 10. April 2017, 12:43:33 CEST schrieb Herbert Xu: > > Hi Herbert, > > > On Sat, Apr 01, 2017 at 10:52:30PM +0200, Stephan Müller wrote: > > > lock_sock(sk); > > &g

<    4   5   6   7   8   9   10   11   12   13   >