Re: [PATCH 2/2] salsa20_i586: Salsa20 stream cipher algorithm (i586 version)

2007-12-07 Thread Herbert Xu
On Sat, Dec 08, 2007 at 11:21:55AM +0800, Tan Swee Heng wrote: If I post the x86-64 version of Bernstein's code, can you help to test it? :P I don't have an x86-64. Of course :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: [PATCH] [crypto] Geode: use correct encrypt/decrypt function in fallback

2007-12-09 Thread Herbert Xu
On Sat, Dec 08, 2007 at 01:41:22PM +0100, Sebastian Siewior wrote: crypto_blkcipher_decrypt is wrong because it does not care about the IV. Signed-off-by: Sebastian Siewior [EMAIL PROTECTED] Patch applied. Thanks Sebastian. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [PATCH 1/2]: salsa20_i586: Corrected order of source and destination buffers.

2007-12-09 Thread Herbert Xu
that I've combined them with the original patch to form a single commit. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from

[PATCH 1/8] [CRYPTO] authenc: Fix typo in ivsize

2007-12-10 Thread Herbert Xu
[CRYPTO] authenc: Fix typo in ivsize The ivsize should be fetched from ablkcipher, not blkcipher. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/authenc.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/authenc.c b/crypto/authenc.c index fbbc2b5..80d9d0b

[PATCH 2/8] [CRYPTO] authenc: Use RTA_OK to check length

2007-12-10 Thread Herbert Xu
[CRYPTO] authenc: Use RTA_OK to check length This patch changes setkey to use RTA_OK to check the validity of the setkey request. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/authenc.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/crypto/authenc.c b/crypto

[PATCH 5/8] [CRYPTO] ctr: Refactor into ctr and rfc3686

2007-12-10 Thread Herbert Xu
the IPsec variant will be called rfc3686(ctr(aes)). This patch also adjusts gcm accordingly. This is necessary before we can get gcm to use the cipher-level IV generator. eigned-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/ctr.c| 334

[PATCH 8/8] [CRYPTO] gcm: Allow block cipher parameter

2007-12-10 Thread Herbert Xu
. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/gcm.c | 122 ++- 1 files changed, 96 insertions(+), 26 deletions(-) diff --git a/crypto/gcm.c b/crypto/gcm.c index 1624301..9c29765 100644 --- a/crypto/gcm.c +++ b/crypto/gcm.c

[PATCH 9/19] [CRYPTO] skcipher: Add skcipher_geniv_alloc/skcipher_geniv_free

2007-12-10 Thread Herbert Xu
[CRYPTO] skcipher: Add skcipher_geniv_alloc/skcipher_geniv_free This patch creates the infrastructure to help the construction of givcipher templates that wrap around existing blkcipher/ablkcipher algorithms by adding an IV generator to them. Signed-off-by: Herbert Xu [EMAIL PROTECTED

[PATCH 10/19] [CRYPTO] chainiv: Add chain IV generator

2007-12-10 Thread Herbert Xu
we have to make sure that we don't start the encryption of the next packet until the last one has completed. It does have the advantage of using very little CPU time since it doesn't have to generate anything at all. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/Makefile |1 crypto

[PATCH 11/19] [CRYPTO] skcipher: Added skcipher_givcrypt_complete

2007-12-10 Thread Herbert Xu
[CRYPTO] skcipher: Added skcipher_givcrypt_complete This patch adds the helper skcipher_givcrypt_complete which should be called when an ablkcipher algorithm has completed a givcrypt request. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- include/crypto/internal/skcipher.h | 12

[PATCH 12/19] [CRYPTO] eseqiv: Add Encrypted Sequence Number IV Generator

2007-12-10 Thread Herbert Xu
. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/Makefile |1 crypto/eseqiv.c | 264 2 files changed, 265 insertions(+) diff --git a/crypto/Makefile b/crypto/Makefile index 4b2e0c3..968b796 100644 --- a/crypto/Makefile +++ b/crypto

[PATCH 14/19] [CRYPTO] seqiv: Add Sequence Number IV Generator

2007-12-10 Thread Herbert Xu
[CRYPTO] seqiv: Add Sequence Number IV Generator This generator generates an IV based on a sequence number by xoring it with a salt. This algorithm is mainly useful for CTR and similar modes. This patch also sets it as the default IV generator for ctr. Signed-off-by: Herbert Xu [EMAIL

[PATCH 15/19] [CRYPTO] skcipher: Add top-level givencrypt/givdecrypt calls

2007-12-10 Thread Herbert Xu
-by: Herbert Xu [EMAIL PROTECTED] --- include/crypto/skcipher.h | 72 ++ 1 files changed, 72 insertions(+) diff --git a/include/crypto/skcipher.h b/include/crypto/skcipher.h index c283fab..25fd612 100644 --- a/include/crypto/skcipher.h +++ b/include

[PATCH 16/19] [CRYPTO] aead: Add givcrypt operations

2007-12-10 Thread Herbert Xu
. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/aead.c |7 +++ include/crypto/aead.h | 38 ++ include/linux/crypto.h |5 + 3 files changed, 50 insertions(+) diff --git a/crypto/aead.c b/crypto/aead.c index f23c2b0..0402b60

[PATCH 19/19] [CRYPTO] aead: Add top-level givencrypt/givdecrypt calls

2007-12-10 Thread Herbert Xu
[CRYPTO] aead: Add top-level givencrypt/givdecrypt calls This patch finally makes the givencrypt/givdecrypt operations available to users by adding crypto_aead_givencrypt and crypto_aead_givdecrypt. A suite of helpers to allocate and fill in the request is also available. Signed-off-by: Herbert

[PATCH 18/19] [CRYPTO] gcm: Add givcrypt operations

2007-12-10 Thread Herbert Xu
[CRYPTO] gcm: Add givcrypt operations This patch implements the givcrypt functions for gcm. It simply calls the givcrypt operations on the underlying cipher instead of encrypt or decrypt. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/gcm.c | 75

Re: PATCH[1/2]: CCM Mode

2007-12-11 Thread Herbert Xu
that it works with the current cryptodev tree. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [2.6 patch] crypto/geode-aes.c: add __dev{init,exit} annotations

2007-12-11 Thread Herbert Xu
On Tue, Dec 11, 2007 at 11:19:50PM +0100, Adrian Bunk wrote: This patch adds __dev{init,exit} annotations. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied to cryptodev. Thanks Adrian. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: PATCH[1/2]: CCM Mode

2007-12-12 Thread Herbert Xu
On Tue, Dec 11, 2007 at 12:18:10PM -0600, Joy Latten wrote: Ok, thanks! Please let me know if there is anything I can help with. OK, took me a while but here it is finally. Please let me know if you see any problems. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

[PATCH 1/10] [CRYPTO] skcipher: Fix mask on skcipher spawns

2007-12-12 Thread Herbert Xu
[CRYPTO] skcipher: Fix mask on skcipher spawns The mask set on spawns should match the mask used to locate the algorithm originally. This patch fixes the mask used on skcipher spawns so that it includes the proper type mask and GENIV where applicable. Signed-off-by: Herbert Xu [EMAIL PROTECTED

[PATCH 10/10] [CRYPTO] tcrypt: Add CCM vectors

2007-12-12 Thread Herbert Xu
. Signed-off-by: Joy Latten [EMAIL PROTECTED] Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/tcrypt.c | 31 ++ crypto/tcrypt.h | 260 2 files changed, 289 insertions(+), 2 deletions(-) diff --git a/crypto/tcrypt.c b/crypto

[PATCH 2/10] [CRYPTO] ctr: Set seqiv on rfc3686 only

2007-12-12 Thread Herbert Xu
[CRYPTO] ctr: Set seqiv on rfc3686 only Only RFC 3686 requires the seqiv generator. The generic CTR is better off using the standard chainiv method. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/ctr.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/crypto

[PATCH 3/10] [CRYPTO] gcm: Fix request context alignment

2007-12-12 Thread Herbert Xu
[CRYPTO] gcm: Fix request context alignment This patch fixes the request context alignment so that it is actually aligned to the value required by the algorithm. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/gcm.c | 31 +++ 1 files changed, 19 insertions

[PATCH 4/10] [CRYPTO] skcipher: Return EINVAL on zero IV when making givcipher

2007-12-12 Thread Herbert Xu
to return EINVAL. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/blkcipher.c |3 ++- 1 files changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/blkcipher.c b/crypto/blkcipher.c index 10c2229..6f84481 100644 --- a/crypto/blkcipher.c +++ b/crypto/blkcipher.c @@ -604,7 +604,7

[PATCH 5/10] [CRYPTO] aead: Allow algorithms with no givcrypt support

2007-12-12 Thread Herbert Xu
generators and do not need IV generation by per se. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/aead.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/crypto/aead.c b/crypto/aead.c index 0402b60..15335ed 100644 --- a/crypto/aead.c +++ b/crypto/aead.c

[PATCH 6/10] [CRYPTO] aead: Add aead_geniv_alloc/aead_geniv_free

2007-12-12 Thread Herbert Xu
their built-in generator. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/aead.c | 202 +++-- include/crypto/internal/aead.h | 77 +++ include/linux/crypto.h |7 + 3 files changed, 280 insertions(+), 6 deletions

[PATCH 8/10] [CRYPTO] aead: Create default givcipher instances

2007-12-12 Thread Herbert Xu
generator with the geniv field. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/aead.c | 147 + include/crypto/internal/aead.h |3 include/linux/crypto.h | 10 -- 3 files changed, 151 insertions(+), 9 deletions(-) diff

[PATCH 9/10] [CRYPTO] ccm: Added CCM mode

2007-12-12 Thread Herbert Xu
[CRYPTO] ccm: Added CCM mode This patch adds Counter with CBC-MAC (CCM) support. RFC 3610 and NIST Special Publication 800-38C were referenced. Signed-off-by: Joy Latten [EMAIL PROTECTED] Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/Kconfig |7 crypto/Makefile |1 crypto

Re: (was Re: 2.6.24-rc5-mm1) crypto/authenc.c select symbol in Kconfig

2007-12-14 Thread Herbert Xu
2007-12-13 18:44:19.0 +0100 +++ crypto/Kconfig2007-12-13 18:39:00.0 +0100 BTW please generate patch -p1 patches in future. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP

[PATCH 3/4] [CRYPTO] skcipher: Fix givcrypt on zero IV ciphers

2007-12-14 Thread Herbert Xu
[CRYPTO] skcipher: Fix givcrypt on zero IV ciphers We need to set the givencrypt/givdecrypt on zero IV ciphers to the encrypt/decrypt functions. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/ablkcipher.c| 14 ++ crypto/aead.c | 14

[PATCH 1/4] [CRYPTO] null: Add null blkcipher algorithm

2007-12-14 Thread Herbert Xu
measure inherent overheads in our IPsec code. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/crypto_null.c | 69 +++-- include/crypto/internal/skcipher.h |5 ++ 2 files changed, 64 insertions(+), 10 deletions(-) diff --git a/crypto

[0/4] Fix null algorithm with IPsec

2007-12-14 Thread Herbert Xu
, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message

[PATCH 4/4] [CRYPTO] scatterwalk: Handle zero nbytes in scatterwalk_map_and_copy

2007-12-14 Thread Herbert Xu
[CRYPTO] scatterwalk: Handle zero nbytes in scatterwalk_map_and_copy It's better to return silently than crash and burn when someone feeds us a zero length. In particular the null digest algorithm when used as part of authenc will do that to us. Signed-off-by: Herbert Xu [EMAIL PROTECTED

[0/3] Avoid spinning in chainiv if allowed

2007-12-14 Thread Herbert Xu
Hi: Now that things have settled down I've picked up the old async chainiv patch and updated it for the current tree. Here is the result. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

[PATCH 2/3] [CRYPTO] api: Show async type

2007-12-14 Thread Herbert Xu
[CRYPTO] api: Show async type This patch adds an async field to /proc/crypto for ablkcipher and aead algorithms. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/ablkcipher.c |4 crypto/aead.c |4 2 files changed, 8 insertions(+) diff --git a/crypto/ablkcipher.c

[PATCH 1/3] [CRYPTO] chainiv: Avoid lock spinning where possible

2007-12-14 Thread Herbert Xu
the request synchronously as before. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/chainiv.c | 209 +++-- include/crypto/internal/skcipher.h | 13 ++ 2 files changed, 214 insertions(+), 8 deletions(-) diff --git a/crypto/chainiv.c b

[0/8] Fix AEAD bugs when tested with IPsec

2007-12-17 Thread Herbert Xu
Hi: Further testing using IPsec revealed a number of bugs with the AEAD API and the algorithms. These patches fix those problems. I'll recombine them with previous patches where appropriate. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED

[PATCH 1/8] [CRYPTO] ccm: Fix construction of rfc4309 algorithm

2007-12-17 Thread Herbert Xu
function. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/ccm.c |6 +- 1 files changed, 1 insertion(+), 5 deletions(-) diff --git a/crypto/ccm.c b/crypto/ccm.c index 7ca2519..8c7d3b7 100644 --- a/crypto/ccm.c +++ b/crypto/ccm.c @@ -728,10 +728,6 @@ static struct crypto_instance

[PATCH 3/8] [CRYPTO] aead/skcipher: Fix larval leak

2007-12-17 Thread Herbert Xu
[CRYPTO] aead/skcipher: Fix larval leak When we get a non-larval from crypto_larval_lookup we need to drop its reference count before leaving the default geniv construction. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/ablkcipher.c |5 +++-- crypto/aead.c |5 +++-- 2

[PATCH 2/8] [CRYPTO] aead: Fix mask in crypto_alloc_aead

2007-12-17 Thread Herbert Xu
[CRYPTO] aead: Fix mask in crypto_alloc_aead There is a silly typo in crypto_alloc_aead and crypto_grab_aead where we set the GENIV bit in the mask when we were supposed to clear it instead. This broke the construction of AEAD geniv wrappers. Signed-off-by: Herbert Xu [EMAIL PROTECTED

[PATCH 5/8] [CRYPTO] aead: Fix crypto_aead_setkey on geniv algorithms

2007-12-17 Thread Herbert Xu
[CRYPTO] aead: Fix crypto_aead_setkey on geniv algorithms We need to call the setkey function with the base pointer. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- include/linux/crypto.h |4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/linux/crypto.h b

[PATCH 7/8] [CRYPTO] gcm: Fix givencrypt/givdecrypt

2007-12-17 Thread Herbert Xu
[CRYPTO] gcm: Fix givencrypt/givdecrypt This patch makes givencrypt and givdecrypt call skcipher_givcrypt_set_tfm to set the correct tfm for the sub-request. Without this we may try to call givencrypt and givdecrypt on an skcipher that does not have these operations. Signed-off-by: Herbert Xu

[PATCH 8/8] [CRYPTO] gcm: Introduce rfc4106

2007-12-17 Thread Herbert Xu
[CRYPTO] gcm: Introduce rfc4106 This patch introduces the rfc4106 wrapper for GCM just as we have an rfc4309 wrapper for CCM. The purpose of the wrapper is to include part of the IV in the key so that it can be negotiated by IPsec. Signed-off-by: Herbert Xu [EMAIL PROTECTED] --- crypto/gcm.c

Re: [PATCH 1/2] Renamed salsa20_32.c to salsa20_glue.c

2007-12-17 Thread Herbert Xu
); here as well. I've added that too. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line

Re: [PATCH 2/2] Salsa20 stream cipher algorithm (x86-64 version)

2007-12-17 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] [crypto] tcrypt depends on AEAD

2007-12-17 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2/2] Salsa20 stream cipher algorithm (x86-64 version)

2007-12-18 Thread Herbert Xu
On Tue, Dec 18, 2007 at 01:51:27AM +0800, Tan Swee Heng wrote: Subject: [PATCH] Removed dependency on CRYPTO_SALSA20 Signed-off-by: Tan Swee Heng [EMAIL PROTECTED] Patch applied. Thanks. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page

Re: New Crypto Hardware

2007-12-24 Thread Herbert Xu
into this. What I'd like to see is to have the hash context moved into the request. This is necessary for us to support simultanenous hash operations on the same tfm. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: OOPS: 2.6.23.11 in PadLock-AES when used in LRW-Mode

2007-12-26 Thread Herbert Xu
. Please let me know if the following patch fixes the problem for you. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/drivers

Re: [PATCH 1/2] Add GCM/GMAC support to cryptoapi

2007-12-29 Thread Herbert Xu
(axbuf, 0, XBUFSIZE); I was just looking over this code and this line seems to be in the wrong function. I presume it's meant to be in test_aead, right? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert

[CRYPTO] xcbc: Fix algorithm leak when block size check fails

2007-12-31 Thread Herbert Xu
and makes it return -EINVAL instead. Signed-off-by: Herbert Xu [EMAIL PROTECTED] diff --git a/crypto/xcbc.c b/crypto/xcbc.c index 789cdee..e3d9503 100644 --- a/crypto/xcbc.c +++ b/crypto/xcbc.c @@ -307,7 +307,8 @@ static struct crypto_instance *xcbc_alloc(struct rtattr **tb) case 16

Re: [CRYPTO] xcbc: Fix algorithm leak when block size check fails

2007-12-31 Thread Herbert Xu
On Tue, Jan 01, 2008 at 03:46:07PM +1100, Herbert Xu wrote: While back-porting xcbc I found this little buglet. And here's another one: [CRYPTO] xcbc: Remove bogus hash/cipher test When setting the digest size xcbc tests to see if the underlying algorithm is a hash. This is silly because we

Re: [CRYPTO] xcbc: Fix algorithm leak when block size check fails

2007-12-31 Thread Herbert Xu
On Tue, Jan 01, 2008 at 03:50:04PM +1100, Herbert Xu wrote: And here's another one: In order to see if it still works: [CRYPTO] tcrypt: Make xcbc available as a standalone test Currently the gcm(aes) tests have to be taken together with all other algorithms. This patch makes it available

Re: [CRYPTO] xcbc: Fix algorithm leak when block size check fails

2007-12-31 Thread Herbert Xu
On Tue, Jan 01, 2008 at 03:58:21PM +1100, Herbert Xu wrote: In order to see if it still works: [CRYPTO] tcrypt: Make xcbc available as a standalone test It helps to have a break: [CRYPTO] tcrypt: Make xcbc available as a standalone test Currently the gcm(aes) tests have to be taken

[CRYPTO] api: Set default CRYPTO_MINALIGN to unsigned long long

2008-01-07 Thread Herbert Xu
are not defined. This patch changes the CRYPTO_MINALIGN so that it uses the same default value. Signed-off-by: Herbert Xu [EMAIL PROTECTED] diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 0aba104..6a20fc9 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -90,6

Re: [CRYPTO] api: Set default CRYPTO_MINALIGN to unsigned long long

2008-01-07 Thread Herbert Xu
On Tue, Jan 08, 2008 at 05:15:48PM +1100, Herbert Xu wrote: Good point. I'll get rid of that too. I've replaced that patch with this: [CRYPTO] api: Set default CRYPTO_MINALIGN to unsigned long long Thanks to David Miller for pointing out that the SLAB (or SLOB/SLUB) cache uses the alignment

Re: [PATCH] [CRYPTO] cast6: inline bloat--

2008-01-07 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: LRW/XTS + Via Padlock Bug in 2.6.24-rc7?

2008-01-09 Thread Herbert Xu
. It would appear that your CPU goes one step further than the other report and insists on having two blocks in the destination too. Please let me know whether this patch fixes the problem. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home

Re: LRW/XTS + Via Padlock Bug in 2.6.24-rc7?

2008-01-10 Thread Herbert Xu
. As such you won't see it until someone tries to use it or you instantiate it explicitly (which isn't possible yet :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: [PATCH] [CRYPTO] cast6: inline bloat--

2008-01-11 Thread Herbert Xu
? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message

Re: [PATCH] [CRYPTO] cast6: inline bloat--

2008-01-11 Thread Herbert Xu
. using ramfs or just some direct test client) He tested with tcrypt which is definitely not IO bound. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert

Re: [PATCH] [crypto] twofish-asm: fix module description

2008-01-13 Thread Herbert Xu
On Sun, Jan 13, 2008 at 03:01:53PM +0100, Sebastian Siewior wrote: Signed-off-by: Sebastian Siewior [EMAIL PROTECTED] --- * Herbert Xu | 2008-01-13 11:35:14 [+1100]: Applied to cryptodev-2.6. Thanks Sebastian. could you please squash this one into :) I've added this fix. Thanks

Re: AES with CTS Mode

2008-01-16 Thread Herbert Xu
). If you can put the entire plain text into one SG list then it would be best. If not then just do as you described and feed whole blocks to plain CBC until you reach the last two and give them to CTS. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

Re: New Crypto Hardware

2008-01-17 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [build bug] ./drivers/crypto/hifn_795x.c

2008-01-25 Thread Herbert Xu
': hifn_795x.c:(.text+0x17df70): undefined reference to `hwrng_register' config attached. Thanks for the report. This is casued by CONFIG_HW_RANDOM=m CONFIG_CRYPTO_DEV_HIFN_795X=y I'll fix it with the following patch. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: Trouble with non modular ciphers

2008-01-31 Thread Herbert Xu
unhappy when CONFIG_KMOD is not defined. Perhaps it should Kconfig select it? Good point. Yes we should do that. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: Async Linux NETKEY (IPSec Stack)

2008-02-06 Thread Herbert Xu
. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message

Re: [HIFN]: Fix invalid config ifdefs for RNG support

2008-02-07 Thread Herbert Xu
ifdefs are missing the CONFIG_ prefix. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Patch applied. Thanks Patrick! I'll push this for 2.6.25. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: Async Linux NETKEY (IPSec Stack)

2008-02-08 Thread Herbert Xu
On Thu, Feb 07, 2008 at 01:49:24PM +1100, Herbert Xu wrote: Actually it isn't in Linus's tree yet so it might be pushed back to 2.6.26. Doh I'm obviously clueless. It is already in Linus's tree at changeset 1a6509d991225ad210de54c63314fd9542922095. Cheers, -- Visit Openswan at http

Re: [patch] crypto test build failure

2008-02-15 Thread Herbert Xu
is not. The following patch fixes the problem for me. Patch applied. Thanks a lot! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe

Re: HIFN+IPsec crashes in current -git

2008-02-18 Thread Herbert Xu
familiar with the code does a proper fix. The usual ICV is 12 bytes long so that could be where it's coming from. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au

Re: HIFN+IPsec crashes in current -git

2008-02-20 Thread Herbert Xu
for the request includes the ICV. By the time the request gets to hifn it no longer has the ICV so it would be 12 bytes elss. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: HIFN+IPsec crashes in current -git

2008-02-20 Thread Herbert Xu
to contain an IV generator template that takes a block cipher which may lack a givencrypt function and produce a new block cipher with a givencrypt function. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: HIFN+IPsec crashes in current -git

2008-02-21 Thread Herbert Xu
the exact amount of data that needs to be encrypted. However, if you follow the scatterlist then you will see more data available which is normal. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP

Re: Test AES-CCM mode via IPSec (NETKEY)

2008-02-21 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h index 51aa042..b0c4cc8 100644 --- a/include/linux/xfrm.h +++ b

Re: build #373 issue for v2.6.25-rc2-477-g1a4c6be in ./crypto/authenc.c

2008-02-22 Thread Herbert Xu
/built-in.o: In function `crypto_authenc_alloc': authenc.c:(.text+0x10f4f): undefined reference to `crypto_grab_skcipher' make: *** [.tmp_vmlinux1] Error 1 This patch should fix the problem. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home

Re: [PATCH] crypto: Correct kzalloc error test

2008-04-29 Thread Herbert Xu
, this function is expected to return an ERR_PTR so you'll need set it to ENOMEM first. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe

Re: [RFC XFRM]: esp: fix scatterlist of out bounds access with crypto_eseqiv

2008-04-29 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More

Re: [revised PATCH] crypto: Correct kzalloc error test

2008-04-29 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED

Crypto Fixes for 2.6.26

2008-05-01 Thread Herbert Xu
Hi Linus: This push fixes three bugs in the recently added async crypto path as well as a minor kzalloc error-path bug. Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git or master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git Herbert Xu (2

Re: tcrypt: hmac test with keys blocksize fail

2008-05-06 Thread Herbert Xu
to be in identity-mapped memory which has never been guaranteed. This patch fixes the problem for me. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [HIFN 05/n]: Fix data alignment checks

2008-05-07 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 1/1] CryptoAPI: Add Async Hash Support

2008-05-07 Thread Herbert Xu
that are reentrant. So we won't need to hold a spin lock around hash operations in IPsec anymore. Well, once we convert all the algorithms across that is :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

[CRYPTO] cryptd: Fix EINPROGRESS notification context

2008-05-07 Thread Herbert Xu
Hi: While merging the ahash patch I found this buglet in cryptd. commit 34fe02eec1cf26f67070588a63252ca7a38c55c2 Author: Herbert Xu [EMAIL PROTECTED] Date: Wed May 7 21:10:13 2008 +0800 [CRYPTO] cryptd: Fix EINPROGRESS notification context The EINPROGRESS notifications should

[CRYPTO] tcrpyt: Get rid of change log in source

2008-05-07 Thread Herbert Xu
Hi: Before tcrypt drowns in change logs, let's get rid of them once and for all. commit 4e96a5d13beb851e6e00baec5c3a9eddcc03a2ac Author: Herbert Xu [EMAIL PROTECTED] Date: Wed May 7 22:19:38 2008 +0800 [CRYPTO] tcrpyt: Get rid of change log in source Change logs should be kept

Re: [HIFN 01/n]: Endianess fixes

2008-05-07 Thread Herbert Xu
by one. All 11 patches applied. Thanks a lot Patrick! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: [RFC, TCRYPT]: Catch cipher destination memory corruption

2008-05-07 Thread Herbert Xu
at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED

Re: [RFC, TCRYPT]: Catch cipher destination memory corruption

2008-05-08 Thread Herbert Xu
On Thu, May 08, 2008 at 12:27:55PM +0200, Patrick McHardy wrote: Would you like me to do any changes? Otherwise, please feel free to apply :) Duly applied :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au

Re: [PATCH 1/5][CRYPTO] RIPEMD: fix Makefile entry for rmd128.o

2008-05-08 Thread Herbert Xu
On Wed, May 07, 2008 at 11:58:35PM +0200, Adrian-Ken Rueegsegger wrote: This patch fixes module building for rmd128.o. I'll combine this with the original patch. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http

Re: Crypto Fixes for 2.6.26

2008-05-09 Thread Herbert Xu
or master.kernel.org:/pub/scm/linux/kernel/git/herbert/crypto-2.6.git Herbert Xu (1): [CRYPTO] hmac: Avoid calling virt_to_page on key crypto/hmac.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) Thanks, -- Visit Openswan at http://www.openswan.org/ Email

Re: [RESEND][PATCH 0/4][CRYPTO] add support for extended RIPEMD hash algorithms

2008-05-09 Thread Herbert Xu
On Thu, May 08, 2008 at 08:06:52PM +0200, Adrian-Ken Rueegsegger wrote: Resending because of missing sign-off. These patches add RIPEMD-256/320 support to the cryptoapi. All applied. Thank you. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home

Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support

2008-05-14 Thread Herbert Xu
functions. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body

Re: [PATCH 1/1] RFC: Add CryptoAPI User Space Interface Support

2008-05-14 Thread Herbert Xu
algorithms rather than hard-coded integer IDs. Compatibility with an interface that was never part of the Linux kernel is simply not an issue. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http

Re: [HIFN 1/1] Remove duplicated include

2008-05-15 Thread Herbert Xu
: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH v2] crypto: rmd128: make it work on my prefered architecture

2008-05-17 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH v2] crypto: rmd128: make it work on my prefered architecture

2008-05-17 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] [CRYPTO] rmd128: Fix endian problems

2008-05-19 Thread Herbert Xu
://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body of a message to [EMAIL PROTECTED] More majordomo

Re: Linux CryptoAPI Userspace API proposal

2008-05-19 Thread Herbert Xu
an interface that allowed in-place operations. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line

Re: linux-next 20080519 build failure

2008-05-20 Thread Herbert Xu
need CONFIG_CRYPTO_HASH=y since you've got CONFIG_CRYPTD=y. This is alerady fixed in my tree but I forgot to push :) Sorry. It's pushed now. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: [BUILD_FAILURE] linux-next: Tree for May 19 - build fails on cryptd_alloc_hash ()

2008-05-20 Thread Herbert Xu
tomorrow. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line unsubscribe linux-crypto in the body

<    1   2   3   4   5   6   7   8   9   10   >