On Tue, 2007-11-27 at 01:28 +0800, Denis Cheng wrote:
-static void hexdump(unsigned char *buf, unsigned int len)
-{
- while (len--)
- printk(%02x, *buf++);
-
- printk(\n);
-}
#define hexdump(buf, len) \
print_hex_dump(KERN_CONT, , DUMP_PREFIX_NONE, 16, 1, \
On Mon, 2009-02-16 at 14:56 +0100, Johannes Weiner wrote:
One problem is that zeroing ksize()
bytes can have an overhead of nearly twice the actual allocation size.
A possible good thing is when linux has a
mechanism to use known zeroed memory in
kzalloc or kcalloc, it's already good to go.
--
Added #define pr_fmt(fmt) KBUILD_MODNAME : fmt
Converted pr( to pr_info(
Removed #define pr pr_info(raid6test:
Signed-off-by: Joe Perches j...@perches.com
---
crypto/async_tx/raid6test.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git
, kernel, and a few drivers.
It also converts printk(KERN_level to pr_level in a few files
that already had some pr_level uses.
The conversion also generally used long length format strings
in the place of multiple short strings to ease any grep/search.
Joe Perches (21):
include/linux
On Wed, 2010-02-10 at 01:37 +0100, Richard Hartmann wrote:
- warn $P: file '${file}' doesn't appear to be a patch.
+ warn $P: file '${file}' doesn't appear to be a patch.
One space not two after periods? Horrors.
Well if you like, but that's not what I like.
Signed-off-by: Joe Perches j...@perches.com
---
crypto/deflate.c |3 +--
crypto/zlib.c|3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/crypto/deflate.c b/crypto/deflate.c
index 463dc85..cbc7a33 100644
--- a/crypto/deflate.c
+++ b/crypto/deflate.c
@@ -48,12 +48,11
On Wed, 2011-05-25 at 23:34 -0400, David Miller wrote:
From: Mandeep Singh Baines m...@chromium.org
Date: Wed, 25 May 2011 20:11:17 -0700
Plus some other minor cleanup.
Signed-off-by: Mandeep Singh Baines m...@chromium.org
The temp[] buffer is explicitly places inside the inner most
basic
While not connected to ARM's implementation of sha_transform,
maybe this might make code a bit clearer.
Remove need to know the size and type of SHA_WORKSPACE_WORDS.
Introduce and use opaque struct sha_workspace instead.
Add #include linux/cryptohash.h to lib/sha1.c
Signed-off-by: Joe Perches j
On Mon, 2011-08-08 at 16:07 -0700, Mandeep Singh Baines wrote:
The previous implementation required the workspace to be passed in as
a parameter. This prevents the compiler from being able to store the
workspace in registers. I've also removed the memset since that also
prevents the compiler
__u32 array if necessary.
Add sha_transform wipe argument to force workspace clearing if desired.
A little macro neatening.
This should speed network syncookies a trivial bit.
Add #include linux/cryptohash.h to lib/sha1.c
Compiled/untested.
Signed-off-by: Joe Perches j...@perches.com
---
On Mon
On Tue, 2011-12-13 at 00:06 +0100, roel wrote:
The test not [val1] or not [val2] always evaluates to true
Hey Jamie and Roel
Looking at drivers with:
$ grep -rP --include=*.[ch]
(\b[\w\[\]\\._\-]+)\s*\!\=\s*[\w\[\]\\._\-]+\s*\|\|\s*\1\s*\!\= drivers
drivers/crypto/picoxcell_crypto.c: if
On Tue, 2011-12-13 at 00:06 +0100, roel wrote:
The test not [val1] or not [val2] always evaluates to true
Hello
Looking at drivers with:
$ grep -rP --include=*.[ch]
(\b[\w\[\]\\._\-]+)\s*\!\=\s*[\w\[\]\\._\-]+\s*\|\|\s*\1\s*\!\= drivers
drivers/media/video/s5p-fimc/fimc-capture.c:
PFX is not a good #define to have in a system #include.
Use pr_fmt and pr_level instead.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/char/hw_random/via-rng.c | 12 ++--
drivers/crypto/padlock-aes.c | 10 ++
drivers/crypto/padlock-sha.c | 14
unnecessary OOM messages as dump_stack is already done
Remove unnecessary cast of void *
Change kzalloc(sizeof(struct)...) to kzalloc(sizeof(*var), ...)
Reduce indents in struct definitions
Signed-off-by: Joe Perches j...@perches.com
---
On top of Masanari Iida's patch:
https://patchwork.kernel.org
On Tue, 2013-07-23 at 00:35 +0200, Linus Walleij wrote:
Have you tested this on hardware or is it compile-tested only?
Hi Linus.
Compile tested only. Not tested on real devices. -ENOHARDWARE.
cheers, Joe
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of
On Sat, 2013-08-10 at 17:40 +0200, Julia Lawall wrote:
Replace a comma between expression statements by a semicolon.
[]
This patch is separate from the others because the code appears to be
machine-generated.
It may have once been machine generated, but it's not now.
It's been modified several
On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote:
When DEBUG is enabled, these macros can be used to print variables
in integer and hex format, and clearly display which registers,
offsets and values are being read/written , including printing the
names of the offsets and their values.
On Wed, 2013-08-14 at 18:40 -0500, Joel Fernandes wrote:
On 08/14/2013 06:29 PM, Joe Perches wrote:
On Wed, 2013-08-14 at 18:12 -0500, Joel Fernandes wrote:
When DEBUG is enabled, these macros can be used to print variables
in integer and hex format, and clearly display which registers
On Sat, 2013-08-17 at 21:42 -0500, Joel Fernandes wrote:
When DEBUG is enabled, these macros can be used to print variables in integer
and hex format, and clearly display which registers, offsets and values are
being read/written , including printing the names of the offsets and their
values.
On Fri, 2014-04-11 at 20:07 +0200, Stephan Mueller wrote:
Changes v4:
* change return codes of generate functions to signed int to convey error
codes and to match the kernel crypto API expecations on the generate
function.
* add BUG_ON throughout drbg_healthcheck_sanity() since any
On Tue, 2014-04-15 at 07:35 +0200, Stephan Mueller wrote:
diff --git a/crypto/drbg.c b/crypto/drbg.c
[]
@@ -0,0 +1,1997 @@
[]
+/***
+ * Backend cipher definitions available to DRBG
+
On Mon, 2014-06-09 at 15:08 +0300, Stanimir Varbanov wrote:
The driver is separated by functional parts. The core part
implements a platform driver probe and remove callbaks.
The probe enables clocks, checks crypto version, initialize
and request dma channels, create done tasklet and init
Use the zeroing function instead of dma_alloc_coherent memset(,0,)
Signed-off-by: Joe Perches j...@perches.com
---
drivers/crypto/amcc/crypto4xx_core.c | 8 +++-
drivers/crypto/ixp4xx_crypto.c | 8
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto
Use the zeroing function instead of dma_alloc_coherent memset(,0,)
Joe Perches (26):
powerpc: Use dma_zalloc_coherent
sh: Use dma_zalloc_coherent
ata: Use dma_zalloc_coherent
block: Use dma_zalloc_coherent
crypto: Use dma_zalloc_coherent
dma: Use dma_zalloc_coherent
gpu: Use
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel.
Done with a simple cocci script and some typing.
Joe Perches (22):
pci-dma-compat: Add pci_zalloc_consistent helper
atm: Use
Remove the now unnecessary memset too.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/crypto/hifn_795x.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index 12fea3e..8d2a772 100644
--- a/drivers/crypto
On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote:
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote:
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel
On Sun, 2014-06-29 at 05:46 +0200, Stephan Mueller wrote:
Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell:
Hi Stephen,
Hi Stephan,
On Sat, 28 Jun 2014 22:01:46 +0200 Stephan Mueller smuel...@chronox.de
wrote:
@@ -1987,8 +1987,9 @@ static int __init drbg_init(void)
On Fri, 2014-07-04 at 14:21 +0300, Dan Carpenter wrote:
On Sat, Jun 28, 2014 at 08:53:19PM -0700, Joe Perches wrote:
On Sun, 2014-06-29 at 05:46 +0200, Stephan Mueller wrote:
Am Sonntag, 29. Juni 2014, 12:24:02 schrieb Stephen Rothwell:
Hi Stephen,
Hi Stephan,
On Sat
On Sat, 2014-07-05 at 01:57 +0200, Stephan Mueller wrote:
And I also get the same output. Yet I am not sure how that code can be
compared to the code in the kernel.
What that code shows is that the ARRAY_SIZE
type is size_t.
The difference is ARRAY_SIZE in the kernel
should be output with
On Sat, 2014-07-05 at 02:15 +0200, Stephan Mueller wrote:
Am Freitag, 4. Juli 2014, 17:09:33 schrieb Joe Perches:
On Sat, 2014-07-05 at 01:57 +0200, Stephan Mueller wrote:
And I also get the same output. Yet I am not sure how that code can be
compared to the code in the kernel.
What
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote:
Instead of custom approach let's use recently introduced seq_hex_dump()
helper.
Doesn't this also change the output from
to
On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote:
This introduces a new helper and switches current users to use it.
While seq_print_hex_dump seems useful, I'm not sure
existing forms can be changed to use it if any output
content changes.
seq_ is supposed to be a stable API.
--
To
On Wed, 2014-07-09 at 22:39 +0200, Marek Vasut wrote:
The above function looks like almost verbatim copy of print_hex_dump(). The
only
difference I can spot is that it's calling seq_printf() instead of printk().
Can
you not instead generalize print_hex_dump() and based on it's invocation,
On Thu, 2014-07-10 at 12:50 +0300, Andy Shevchenko wrote:
I have considered to modify hex_dump_to_buffer() to return how many
bytes it actually proceed to the buffer. In that case we can directly
print to m-buf like other seq_foo calls do.
But I still have doubts about it. Any opinion?
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote:
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote:
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote:
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style
On Sun, 2014-10-12 at 21:49 +0100, Mike Roocroft wrote:
Fixed a coding style issue.
[]
diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c
[]
@@ -97,7 +97,7 @@
the table above
*/
-#define xx(p, q) 0x##p##q
+#define xx(p, q) (0x##p##q)
#define xda_bbe(i) ( \
(i
On Mon, 2014-10-13 at 21:12 +0100, Michael Roocroft wrote:
On 10/13/14 00:01, Joe Perches wrote:
On Sun, 2014-10-12 at 21:49 +0100, Mike Roocroft wrote:
Fixed a coding style issue.
[]
diff --git a/crypto/gf128mul.c b/crypto/gf128mul.c
[]
@@ -97,7 +97,7 @@
the table above
On Mon, 2014-10-13 at 21:52 +0100, Michael Roocroft wrote:
I fully intend to making more meaningful contributions
when my confidence in writing C is better than it is at the moment. I'll
concentrate
on making any changes to staging whilst I learn and get to grips with git, and
continue to
On Tue, 2014-10-21 at 02:28 +0300, Vladimir Zapolskiy wrote:
On 19.10.2014 17:16, LABBE Corentin wrote:
Add support for the Security System included in Allwinner SoC A20.
The Security System is a hardware cryptographic accelerator that support
AES/MD5/SHA1/DES/3DES/PRNG algorithms.
[]
On Mon, 2015-03-16 at 20:01 +0100, LABBE Corentin wrote:
[]
diff --git a/MAINTAINERS b/MAINTAINERS
[]
@@ -10923,6 +10923,12 @@ L: linux...@kvack.org
S: Maintained
F: mm/zswap.c
+ALLWINNER SECURITY SYSTEM
+M: Corentin Labbe clabbe.montj...@gmail.com
+L:
On Sun, 2016-04-24 at 12:40 +0200, Stephan Mueller wrote:
> The LRNG with all its properties is documented in [1]. This
> documentation covers the functional discussion as well as testing of all
> aspects of entropy processing. In addition, the documentation explains
> the conducted regression
On Mon, 2016-07-11 at 11:28 -0700, Yeshaswi M R Gowda wrote:
> The Chelsio's Crypto Hardware can perform the following operations:
> SHA1, SHA224, SHA256, SHA384 and SHA512, HMAC(SHA1), HMAC(SHA224),
> HMAC(SHA256), HMAC(SHA384), HAMC(SHA512), AES-128-CBC, AES-192-CBC,
> AES-256-CBC, AES-128-XTS,
On Thu, 2016-06-30 at 10:50 +0300, Dan Carpenter wrote:
> On Wed, Jun 29, 2016 at 10:05:53AM -0700, H. Peter Anvin wrote:
> > On 06/29/16 07:42, Dan Carpenter wrote:
> > > > > and | behave basically the same here but || is intended. It causes a
> > > static checker warning to mix up bitwise and
On Thu, 2017-02-23 at 17:41 +, Emil Velikov wrote:
> On 23 February 2017 at 17:18, Joe Perches <j...@perches.com> wrote:
> > On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> > > On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <j...@perches.com> wrote
On Thu, 2017-02-23 at 09:28 -0600, Rob Herring wrote:
> On Fri, Feb 17, 2017 at 1:11 AM, Joe Perches <j...@perches.com> wrote:
> > There are ~4300 uses of pr_warn and ~250 uses of the older
> > pr_warning in the kernel source tree.
> >
> > Make the use of pr_
with 'sed s/\bpr_warning\b/pr_warn/' and some emacsing.
Miscellanea:
o Coalesce formats and realign arguments
Some files not compiled - no cross-compilers
Joe Perches (35):
alpha: Convert remaining uses of pr_warning to pr_warn
ARM: ep93xx: Convert remaining uses of pr_warning to pr_warn
To enable eventual removal of pr_warning
This makes pr_warn use consistent for drivers/crypto
Prior to this patch, there were 3 uses of pr_warning and
12 uses of pr_warn in drivers/crypto
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/crypto/n2_core.c | 12 ++--
On Wed, 2016-09-14 at 11:10 +0900, Masahiro Yamada wrote:
> 2016-09-13 4:44 GMT+09:00 Joe Perches <j...@perches.com>:
> > On Tue, 2016-09-13 at 04:27 +0900, Masahiro Yamada wrote:
> > > Remove unneeded variables and assignments.
> > Was this found by visual inspection
On Mon, 2016-10-10 at 10:37 -0700, Eric Biggers wrote:
> On Mon, Oct 10, 2016 at 10:29:55AM -0700, Joe Perches wrote:
> > On Mon, 2016-10-10 at 10:15 -0700, Eric Biggers wrote:
> > > The per-transform 'consts' array is accessed as __be64 in
> > > crypto_cmac_digest_setke
On Mon, 2016-10-10 at 10:15 -0700, Eric Biggers wrote:
> The per-transform 'consts' array is accessed as __be64 in
> crypto_cmac_digest_setkey() but was only guaranteed to be aligned to
> __alignof__(long). Fix this by aligning it to __alignof__(__be64).
[]
> diff --git a/crypto/cmac.c
On Fri, 2017-04-21 at 19:36 +0800, Herbert Xu wrote:
> On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Wed, 19 Apr 2017 10:50:04 +0200
> >
> > The script "checkpatch.pl" pointed information out like the
By default, debug logging is disabled by CC_DEBUG not being defined.
Convert SSI_LOG_DEBUG to use no_printk instead of an empty define
to validate formats and arguments.
Fix fallout.
Miscellanea:
o One of the conversions now uses %pR instead of multiple uses of %pad
Signed-off-by: Joe Perches
On Mon, 2017-07-31 at 09:39 +0300, Gilad Ben-Yossef wrote:
> On Sun, Jul 30, 2017 at 7:45 PM, Joe Perches <j...@perches.com> wrote:
> > By default, debug logging is disabled by CC_DEBUG not being defined.
> >
> > Convert SSI_LOG_DEBUG to use no_printk instead of an e
to
> help improve the system]
Pretty odd that m32r has ioread32 as _readl and so unsigned long
Seems silly to have to cast it.
Gilad, is this actually a supported platform for ccree?
> url:
> https://github.com/0day-ci/linux/commits/Joe-Perches/staging-ccree-Fix-format-argument-mismatch
On Tue, 2017-08-15 at 09:26 +0300, Gilad Ben-Yossef wrote:
> Fix wrong indentation and line breaks, including missing tabs,
> breaking lines longer then 80 char or wrongly broken.
[]
> diff --git a/drivers/staging/ccree/ssi_driver.c
> b/drivers/staging/ccree/ssi_driver.c
[]
> -
By default, debug logging is disabled by CC_DEBUG not being defined.
Convert SSI_LOG_DEBUG to use no_printk instead of an empty define
to validate formats and arguments.
Fix fallout.
Miscellanea:
o One of the conversions now uses %pR instead of multiple uses of %pad
Signed-off-by: Joe Perches
On Tue, 2017-06-20 at 11:20 +0300, Dan Carpenter wrote:
> On Tue, Jun 20, 2017 at 01:19:44PM +0800, Jhih-Ming Huang wrote:
[]
> > In this series patches, I fix all of the coding style error in
> > driver/staging/ccree/ssi_aead.c from 54 errors to 0 error.
>
> You could put this into the cover
On Tue, 2017-05-23 at 14:09 +0200, Corentin Labbe wrote:
> By adding a struct device *dev to struct engine, we could store the
> device used at register time and so use all dev_xxx functions instead of
> pr_xxx.
trivia:
> diff --git a/include/crypto/engine.h b/include/crypto/engine.h
[]
> @@
On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote:
> On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote:
> > cc_crypto_ctx.h had multiple coding style violations reported by
> > checkpatch. Fix them all.
>
> Sorry, no. You need to do only one-thing-per-patch, and "fix all
On Mon, 2017-05-29 at 20:11 +0300, Gilad Ben-Yossef wrote:
> On Mon, May 29, 2017 at 7:57 PM, Joe Perches <j...@perches.com> wrote:
> > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote:
> > > On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote:
>
On Thu, 2017-06-01 at 14:02 +0300, Gilad Ben-Yossef wrote:
> Remove spurious blanks lines from cc_crypto_ctx.h file
unrelated trivia:
> diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
> b/drivers/staging/ccree/cc_crypto_ctx.h
[]
> @@ -208,7 +204,6 @@ struct drv_ctx_generic {
> enum
On Thu, 2017-06-01 at 04:20 -0700, Joe Perches wrote:
> On Thu, 2017-06-01 at 14:02 +0300, Gilad Ben-Yossef wrote:
> > Remove spurious blanks lines from cc_crypto_ctx.h file
>
> unrelated trivia:
>
> > diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
>
On Tue, 2017-06-13 at 11:40 +0100, Colin Ian King wrote:
> On 13/06/17 11:36, Joe Perches wrote:
> > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> > > From: Colin Ian King <colin.k...@canonical.com>
> > >
> > > Trivial fix to spelling mistake
On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in seq_printf message
Hey Colin.
Fixing spelling typos is a good thing, but is it a
good thing to change possibly API dependent output
in seq_ calls?
>
On Thu, 2017-10-05 at 10:07 +0300, Gilad Ben-Yossef wrote:
> On Wed, Oct 4, 2017 at 10:12 PM, wrote:
> > There is no need to create a local pointer variable "dev" and
> > pass it various API's, instead use plat_dev which is enumerated
> > by platform core on successful
Logging without newlines are still prone to interleaving.
Add newlines where necessary.
Miscellanea:
o Coalesce formats
o Realign arguments
o Fix a couple misindented lines with the above logging changes
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/staging/ccree/ssi_
On Thu, 2017-09-07 at 00:32 +0300, Dan Carpenter wrote:
> Always compile your patches.
>
> CC [M] drivers/staging/ccree/ssi_cipher.o
> drivers/staging/ccree/ssi_cipher.c: In function ‘ssi_blkcipher_complete’:
> drivers/staging/ccree/ssi_cipher.c:700:6: warning: unused variable
>
On Mon, 2017-10-02 at 10:03 +0100, Gilad Ben-Yossef wrote:
> Introduce a DEV macro to retrieve struct device from private
> data structure in preparation to replacing custom logging
> macros with proper dev_dbg and friends which require struct
> device.
[]
> diff --git
On Mon, 2017-12-04 at 03:19 +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
Can you list the duplicates that were not removed as well please?
On Tue, 2017-06-27 at 10:55 +0300, Gilad Ben-Yossef wrote:
> Add the crypto API *_ON_STACK to $declaration_macros.
>
> Resolves the following false warning:
>
> WARNING: Missing a blank line after declarations
> + int err;
> + SHASH_DESC_ON_STACK(desc,
On Mon, 2017-11-13 at 14:45 +, Gilad Ben-Yossef wrote:
> Remove uneeded cast from writel_relaxed parameter.
[]
> diff --git a/drivers/staging/ccree/ssi_request_mgr.c
> b/drivers/staging/ccree/ssi_request_mgr.c
[]
> @@ -167,13 +167,13 @@ static inline void enqueue_seq(
> int i;
>
>
On Wed, 2017-12-06 at 15:05 +0100, Krzysztof Kozlowski wrote:
> On Wed, Dec 6, 2017 at 2:42 PM, Łukasz Stelmach
> wrote:
> > It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote:
> > > On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach
> >
ries is applied.
The above script output diff is currently:
1198 files changed, 70 insertions(+), 2241 deletions(-)
Joe Perches (18):
kernel: Use pr_fmt
lib: Use pr_fmt
printk: Convert pr_fmt from blank define to KBUILD_MODNAME
x86: Remove pr_fmt duplicate logging prefixes
x86/mtrr: Rename
Converting pr_fmt from a simple define to use KBUILD_MODNAME added
some duplicate logging prefixes to existing uses.
Remove them.
Signed-off-by: Joe Perches <j...@perches.com>
---
drivers/char/hw_random/via-rng.c | 10 +-
drivers/char/random.c| 16 +++-
2
On Fri, 2017-10-27 at 11:32 +0300, Dan Carpenter wrote:
> On Thu, Oct 26, 2017 at 06:53:42PM -0700, Stephen Brennan wrote:
> > In particular, fixes some over-indented if statement bodies as well as a
> > couple lines indented with spaces. checkpatch.pl now reports no warnings
> > on this file
On Sun, 2017-12-31 at 17:54 +0530, Himanshu Jha wrote:
> Use dma_zalloc_coherent for allocating zeroed
> memory and remove unnecessary memset function.
>
> Done using Coccinelle.
> Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci
I thought you were going to change this tag to
not
On Sat, 2018-01-06 at 15:47 +, George Edward Bulmer wrote:
> This fixes five instances of checkpatch warning:
> WARNING: line over 80 characters
[]
> diff --git a/drivers/staging/ccree/ssi_sysfs.c
> b/drivers/staging/ccree/ssi_sysfs.c
[]
> @@ -32,15 +32,26 @@ static ssize_t
On Mon, 2018-01-01 at 00:33 -1000, Joey Pabalinas wrote:
> When char is signed, storing the values 0xba (186) and 0xad (173) in the
> `guard` array produces signed overflow. Change the type of `guard` to
> unsigned char to remove undefined behavior.
[]
> diff --git a/crypto/testmgr.c
On Wed, 2018-07-25 at 15:12 +0200, Arnd Bergmann wrote:
> tools/perf/tests/.gitignore:
> LLVM byte-codes, uncompressed
> On Wed, Jul 25, 2018 at 2:55 AM, Andrew Morton
> wrote:
> > On Tue, 24 Jul 2018 17:13:20 -0700 Joe Perches wrote:
> >
On Fri, 2018-03-09 at 22:29 +0800, Herbert Xu wrote:
> On Tue, Feb 27, 2018 at 07:01:27PM -0300, Hernán Gonzalez wrote:
> > Note: This is compile only tested.
> > No gain from this except some self-documenting.
[]
> > diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c
[]
> > @@ -23,8
On Thu, 2018-03-29 at 21:03 +0530, Varsha Rao wrote:
> On Wed, Mar 28, 2018 at 11:41 PM, Joe Perches wrote:
> >
> > On Wed, 2018-03-28 at 23:27, Varsha Rao wrote:
> > > This patch fixes the clang warning of extraneous parentheses, with the
> >
On Wed, 2018-03-28 at 23:27 +0530, Varsha Rao wrote:
> This patch fixes the clang warning of extraneous parentheses, with the
> following coccinelle script.
>
> @@
> identifier i;
> constant c;
> @@
> (
> -((i == c))
> +i == c
> >
>
> -((i <= c))
> +i <= c
Why just the "==" and "<=" cases?
Why
83 matches
Mail list logo