Hi,
allyesconfig and multi_v7_defconfig fail to build on recent linux-next
on GCC 6.2.0.
Errors:
../arch/arm/crypto/aes-cipher-core.S: Assembler messages:
../arch/arm/crypto/aes-cipher-core.S:21: Error: selected processor does not
support `tt .req ip' in ARM mode
../arch/arm/crypto/aes-cipher-co
On Sat, Jan 14, 2017 at 06:20:12PM +, Russell King - ARM Linux wrote:
> On Sat, Jan 14, 2017 at 04:24:35PM +0200, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > allyesconfig and multi_v7_defconfig fail to build on recent linux-next
> > on GCC 6.2.0.
> >
>
PID: 0 at crypto/skcipher.c:430
skcipher_walk_first+0x13c/0x14c
The interrupt is marked shared but in fact there are no other users
sharing it. Thus the simplest solution seems to be to just use a
threaded interrupt handler, after converting it to oneshot.
Signed-off-by: Krzysztof Kozlowski
---
On Fri, Mar 03, 2017 at 12:02:10PM +0800, Herbert Xu wrote:
> On Thu, Mar 02, 2017 at 05:35:30PM -0600, Nathan Royce wrote:
> > ARM ODroid XU4
> >
> > $ cat /proc/config.gz | gunzip | grep XTS
> > CONFIG_CRYPTO_XTS=y
> >
> > $ grep xts /proc/crypto
> > //4.9.13
> > name : xts(aes)
> > dri
ntry+0x18/0x1c)
> [ 22.095258] [] (cpu_startup_entry) from []
> (start_kernel+0x374/0x394)
> [ 22.103389] handlers:
> [ 22.105635] [] irq_default_primary_handler threaded
> [] s5p_aes_interrupt
> [ 22.114046] Disabling IRQ #69
> [ 23.496638] Btrfs loaded, crc32c=
On Mon, Mar 06, 2017 at 03:29:48PM -0600, Nathan Royce wrote:
> OK, I just tried 4.10.0 and the output is looking the same.
>
> I can't say my setup is all that odd. The cryptographic use is only
> with the swap partition found in my original email (seen in Herbert's
> reply).
You have quite spec
putting the
s5p_aes_complete() only within ISR level.
Reported-by: Nathan Royce
Cc: # v4.10.x: 07de4bc88c crypto: s5p-sss - Fix
completing
Cc: # v4.10.x
Signed-off-by: Krzysztof Kozlowski
---
I think, along with 07de4bc88c this should be backported to v4.10 as it
happens there.
Signed-off-by: Krzyszto
On Wed, Mar 08, 2017 at 07:45:42PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Mar 06, 2017 at 03:29:48PM -0600, Nathan Royce wrote:
> > OK, I just tried 4.10.0 and the output is looking the same.
> >
> > I can't say my setup is all that odd. The cryptographic use
rename Documentation/devicetree/bindings/{rng =>
> crypto}/samsung,exynos-rng4.txt (100%)
>
Patch is okay but CC list is still incomplete. I do not know how you
could get Mauro for this patch... just use get_maintainers.pl.
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Wed, Aug 23, 2017 at 10:14:29PM +0530, PrasannaKumar Muralidharan wrote:
> Hi Krzysztof,
>
> On 23 August 2017 at 21:42, Krzysztof Kozlowski wrote:
> > On Wed, Aug 23, 2017 at 08:34:43PM +0530, PrasannaKumar Muralidharan wrote:
> >> Samsung exynos PRNG driver is using
On Wed, Sep 13, 2017 at 2:44 PM, Kamil Konieczny
wrote:
> Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW.
> It uses the crypto framework asynchronous hash api.
> It is based on omap-sham.c driver.
> S5P has some HW differencies and is not implemented.
>
> Modifications in s5p-sss:
On Wed, Sep 13, 2017 at 4:24 PM, Kamil Konieczny
wrote:
> Hi Krzysztof,
>
> On 13.09.2017 15:18, Krzysztof Kozlowski wrote:
>> On Wed, Sep 13, 2017 at 2:44 PM, Kamil Konieczny
>> wrote:
>>> Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW.
&g
On Fri, Sep 15, 2017 at 8:10 AM, Krzysztof Kozlowski wrote:
> On Wed, Sep 13, 2017 at 4:24 PM, Kamil Konieczny
> wrote:
>> Hi Krzysztof,
>>
>> On 13.09.2017 15:18, Krzysztof Kozlowski wrote:
>>> On Wed, Sep 13, 2017 at 2:44 PM, Kamil Konieczny
>>> wro
new CRYPTO_DEV_EXYNOS_HASH, depend on !EXYNOS_RNG
> and CRYPTO_DEV_S5P
>
> - Select sw algorithms MD5, SHA1 and SHA256 in EXYNOS_HASH
> as they are nedded for fallback.
>
> Signed-off-by: Kamil Konieczny
> ---
> version 2:
> - change patch format so number of lines
On Fri, Sep 22, 2017 at 08:00:17PM +0200, Kamil Konieczny wrote:
> On 19.09.2017 21:03, Krzysztof Kozlowski wrote:
> > On Fri, Sep 15, 2017 at 07:50:06PM +0200, Kamil Konieczny wrote:
(...)
> >> +
> >> +/* HASH flags */
> >
> > All defines below have &q
On Tue, Sep 26, 2017 at 05:54:42PM +0200, Kamil Konieczny wrote:
> On 25.09.2017 20:27, Krzysztof Kozlowski wrote:
> [...]
> >>>> +struct tasklet_struct hash_tasklet;
> >>>> +u8 xmit_buf[BUFLEN] SSS_ALIGNE
new CRYPTO_DEV_EXYNOS_HASH, depend on !EXYNOS_RNG
> and CRYPTO_DEV_S5P
>
> - Select sw algorithms MD5, SHA1 and SHA256 in EXYNOS_HASH
> as they are nedded for fallback.
>
> Signed-off-by: Kamil Konieczny
> ---
> version 3:
> - many fixes suggested by Krzysztof Kozlo
On Tue, Oct 03, 2017 at 04:57:43PM +0200, Kamil Konieczny wrote:
> >> [...]
> >> +static struct ahash_alg algs_sha256[] = {
> >> +{
> >> + .init = s5p_hash_init,
> >> + .update = s5p_hash_update,
> >> + .final = s5p_hash_final,
> >> + .finup = s5p_hash_finu
new CRYPTO_DEV_EXYNOS_HASH, depend on !EXYNOS_RNG
> and CRYPTO_DEV_S5P
>
> - Select sw algorithms MD5, SHA1 and SHA256 in EXYNOS_HASH
> as they are nedded for fallback.
>
> Signed-off-by: Kamil Konieczny
> ---
> version 4:
> - fixes suggested by Krzysztof Kozlowsk
new CRYPTO_DEV_EXYNOS_HASH, depend on !EXYNOS_RNG
> and CRYPTO_DEV_S5P
>
> - Select sw algorithms MD5, SHA1 and SHA256 in EXYNOS_HASH
> as they are nedded for fallback.
>
> Signed-off-by: Kamil Konieczny
> ---
> version 5:
> - fix suggested by Krzysztof Kozlowski:
ons(-)
>
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Mon, Oct 16, 2017 at 7:43 PM, Kamil Konieczny
wrote:
> Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW.
> It uses the crypto framework asynchronous hash api.
> It is based on omap-sham.c driver.
> S5P has some HW differencies and is not implemented.
>
> Modifications in s5p-sss:
On Tue, Oct 17, 2017 at 1:28 PM, Kamil Konieczny
wrote:
> change spaces into tabs in defines
>
> Signed-off-by: Kamil Konieczny
> ---
> drivers/crypto/s5p-sss.c | 190
> +++
> 1 file changed, 95 insertions(+), 95 deletions(-)
>
I reviewed this alread
t; +++++-
> 2 files changed, 1411 insertions(+), 10 deletions(-)
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Sun, Oct 22, 2017 at 03:05:05PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 22 Oct 2017 15:00:27 +0200
>
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function.
>
> This issue was detected by using the Coccinelle soft
On Thu, Nov 9, 2017 at 10:26 PM, Dan Carpenter wrote:
> This code seems correct, but the goto was indented too far.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
+++
> 1 file changed, 17 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach wrote:
> Add support for True Random Number Generator found in Samsung Exynos
> 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> MAINTAINERS | 7 +
> drivers/char/hw_random/Kconfig | 12 ++
> drivers/char/hw
On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach wrote:
> Add nodes for the True Random Number Generator found in Samsung Exynos
> 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> arch/arm/boot/dts/exynos5.dtsi| 5 +
> arch/arm/boot/dts/exynos5250.dtsi | 5 +
> arch/arm/boot/dt
On Thu, Nov 23, 2017 at 7:46 PM, Łukasz Stelmach wrote:
> It was <2017-11-23 czw 17:31>, when Krzysztof Kozlowski wrote:
>> On Thu, Nov 23, 2017 at 4:09 PM, Łukasz Stelmach
>> wrote:
>>> Add support for True Random Number Generator found in Samsung Exynos
>>
On Fri, Nov 24, 2017 at 2:05 PM, Stephan Müller wrote:
> Am Freitag, 24. November 2017, 13:09:06 CET schrieb Krzysztof Kozlowski:
>
> Hi Krzysztof,
>> >>
>> >> 1. I was rather thinking about extending existing exynos-rng.c [1] so
>> >> it would be
On Mon, Nov 27, 2017 at 10:58 AM, Łukasz Stelmach
wrote:
> Add binding documentation for the True Random Number Generator
> found on Samsung Exynos 5250+ SoCs.
>
> Acked-by: Rob Herring
> Reviewed-by: Krzysztof Kozlowski
> Signed-off-by: Łukasz Stelmach
A minor nit: add n
On Mon, Nov 27, 2017 at 10:58 AM, Łukasz Stelmach
wrote:
> Add support for True Random Number Generator found in Samsung Exynos
> 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> MAINTAINERS | 7 +
> drivers/char/hw_random/Kconfig | 12 ++
> drivers/char/h
On Mon, Dec 4, 2017 at 1:53 PM, Łukasz Stelmach wrote:
> Add binding documentation for the True Random Number Generator
> found on Samsung Exynos 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17
> +
> 1 file cha
12 ++
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/exynos-trng.c | 245
> +++
> 4 files changed, 265 insertions(+)
> create mode 100644 drivers/char/hw_random/exynos-trng.c
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Tue, Dec 5, 2017 at 10:30 AM, Łukasz Stelmach wrote:
> It was <2017-12-04 pon 14:13>, when Krzysztof Kozlowski wrote:
>> On Mon, Dec 4, 2017 at 1:53 PM, Łukasz Stelmach
>> wrote:
>>> Add binding documentation for the True Random Number Generator
>>
On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach wrote:
> Add support for PRNG in Exynos5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> .../bindings/crypto/samsung,exynos-rng4.txt| 4 ++-
> drivers/crypto/exynos-rng.c| 36
> --
> 2 file
On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach wrote:
> Use memcpy_fromio() instead of custom exynos_rng_copy_random() function
> to retrieve generated numbers from the registers of PRNG.
>
> Remove unnecessary invocation of cpu_relax().
>
> Signed-off-by: Łukasz Stelmach
> ---
> drivers/crypto
On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach wrote:
> Reseed PRNG after reading 65 kB of randomness. Although this may reduce
> performance, in most casese the loss is not noticable.
s/casese/cases/
s/noticable/noticeable/
Please explain why you want to reseed after 65 kB (as opposite to
curre
On Tue, Dec 05, 2017 at 05:43:10PM +0100, Łukasz Stelmach wrote:
> It was <2017-12-05 wto 14:54>, when Stephan Mueller wrote:
> > Am Dienstag, 5. Dezember 2017, 13:35:57 CET schrieb Łukasz Stelmach:
> >
> > Hi Łukasz,
> >
> >> Use memcpy_fromio() instead of custom exynos_rng_copy_random() function
ore
> software implementations, but allow them to be selected in FIPS-mode
> (fips=1 in the kernel command line).
Typo in subject ("Increase").
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
On Tue, Dec 5, 2017 at 6:53 PM, Krzysztof Kozlowski wrote:
> On Tue, Dec 05, 2017 at 05:43:10PM +0100, Łukasz Stelmach wrote:
>> It was <2017-12-05 wto 14:54>, when Stephan Mueller wrote:
>> > Am Dienstag, 5. Dezember 2017, 13:35:57 CET schrieb Łukasz Stelmach:
>> &g
On Wed, Dec 6, 2017 at 12:32 PM, Łukasz Stelmach wrote:
> It was <2017-12-05 wto 19:06>, when Krzysztof Kozlowski wrote:
>> On Tue, Dec 5, 2017 at 6:53 PM, Krzysztof Kozlowski wrote:
>>> On Tue, Dec 05, 2017 at 05:43:10PM +0100, Łukasz Stelmach wrote:
>>>>
On Wed, Dec 6, 2017 at 2:42 PM, Łukasz Stelmach wrote:
> It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote:
>> On Tue, Dec 5, 2017 at 1:35 PM, Łukasz Stelmach
>> wrote:
>>> Add support for PRNG in Exynos5250+ SoCs.
>>>
>>> Signed-of
On Wed, Dec 6, 2017 at 3:53 PM, Łukasz Stelmach wrote:
> It was <2017-12-06 śro 15:05>, when Krzysztof Kozlowski wrote:
>> On Wed, Dec 6, 2017 at 2:42 PM, Łukasz Stelmach
>> wrote:
>>> It was <2017-12-05 wto 14:34>, when Krzysztof Kozlowski wrote:
>>
On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach wrote:
> Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz
>
>
> Add support for PRNG in Exynos5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> .../bindings/crypto/samsung,exynos-rng4.txt| 4 ++-
> drivers/crypto/exynos-rng.c
On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach wrote:
> Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz
>
This should not appear here.
>
> Use memcpy_fromio() instead of custom exynos_rng_copy_random() function
> to retrieve generated numbers from the registers of PRNG.
>
> Rearrange the lo
On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach wrote:
> Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz
>
Same as in 1/4 and 2/4.
>
> Reseed PRNG after reading 65 kB of randomness. Although this may reduce
> performance, in most cases the loss is not noticeable.
You missed the comment abou
On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach wrote:
> Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz
>
>
> Hardware operations like reading random numbers and setting a seed need
> to be conducted in a single thread. Therefore a mutex is required to
> prevent multiple threads (processes) f
On Mon, Dec 04, 2017 at 01:53:51PM +0100, Łukasz Stelmach wrote:
> Add nodes for the True Random Number Generator found in Samsung Exynos
> 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> arch/arm/boot/dts/exynos5.dtsi| 5 +
> arch/arm/boot/dts/exynos5250.dtsi | 5 +
> arch/ar
On Tue, Dec 12, 2017 at 11:35 AM, Łukasz Stelmach
wrote:
> It was <2017-12-11 pon 19:49>, when Krzysztof Kozlowski wrote:
>> On Mon, Dec 04, 2017 at 01:53:51PM +0100, Łukasz Stelmach wrote:
>>> Add nodes for the True Random Number Generator found in Samsung Exynos
>&g
On Tue, Dec 12, 2017 at 11:30 AM, Łukasz Stelmach
wrote:
> It was <2017-12-11 pon 16:03>, when Krzysztof Kozlowski wrote:
>> On Mon, Dec 11, 2017 at 3:06 PM, Łukasz Stelmach
>> wrote:
>>> Cc: Marek Szyprowski , Bartlomiej Zolnierkiewicz
>>>
>>
On Tue, Dec 12, 2017 at 01:09:02PM +0100, Łukasz Stelmach wrote:
> Add nodes for the True Random Number Generator found in Samsung Exynos
> 5250+ SoCs.
>
> Signed-off-by: Łukasz Stelmach
> ---
> Changes since v3:
>
> - Rebased accroding to Krzysztof Kozłowski's request
>
> arch/arm/boot/dts/ex
++--
> 2 files changed, 28 insertions(+), 3 deletions(-)
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
ice to mention some numbers here.
Anyway it is fine with me:
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
>
> Signed-off-by: Łukasz Stelmach
> ---
> drivers/crypto/exynos-rng.c | 31 ++-
> 1 file changed, 2 insertions(+), 29 deletions(-)
>
t; Signed-off-by: Łukasz Stelmach
> Reviewed-by: Stephan Mueller
> ---
> drivers/crypto/exynos-rng.c | 15 +++
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski
Best regards,
Krzysztof
rect #ifdef and instead uses a __maybe_unused
> annotation to let the compiler know it can silently drop
> the function definition.
>
> Signed-off-by: Arnd Bergmann
> ---
> drivers/char/hw_random/exynos-rng.c | 10 --
> 1 file changed, 4 insertions(+), 6 deletions(-)
Remove unneeded inclusion of delay.h and get rid of indentation from
labels.
Signed-off-by: Krzysztof Kozlowski
---
drivers/crypto/s5p-sss.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 5f161a9777e3
space.
Signed-off-by: Krzysztof Kozlowski
---
drivers/crypto/s5p-sss.c | 149 +++
1 file changed, 137 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 60f835455a41..bac1f4593f98 100644
--- a/drivers
On 07.03.2016 10:28, Vladimir Zapolskiy wrote:
> Hi Krzysztof,
>
> On 06.03.2016 12:17, Krzysztof Kozlowski wrote:
>> During crypto selftests on Odroid XU3 (Exynos5422) some of the
>> algorithms failed because of passing AES-block unaligned source and
>> destinat
On 07.03.2016 10:01, Vladimir Zapolskiy wrote:
> Hi Krzysztof,
>
> On 06.03.2016 12:17, Krzysztof Kozlowski wrote:
>> Remove unneeded inclusion of delay.h and get rid of indentation from
>> labels.
>
> just in case are you aware of this discussion regarding goto
From: Krzysztof Kozlowski
Remove unneeded inclusion of delay.h and get rid of indentation from
labels.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Vladimir Zapolskiy
---
Changes since v1:
1. Add Vladimir's acked-by.
---
drivers/crypto/s5p-sss.c | 15 +++
1 file chang
Sort the headers alphabetically to improve readability and to spot
duplications easier.
Suggested-by: Vladimir Zapolskiy
Signed-off-by: Krzysztof Kozlowski
---
Changes since v1:
1. New patch.
My email differs from one used in previous patches because this time I
am sending this from work
From: Krzysztof Kozlowski
During crypto selftests on Odroid XU3 (Exynos5422) some of the
algorithms failed because of passing AES-block unaligned source and
destination buffers:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
Handle such case by copying the buffers to
/exynos-rng.c:171:12: warning: ‘exynos_rng_resume’
defined but not used [-Wunused-function]
static int exynos_rng_resume(struct device *dev)
Signed-off-by: Krzysztof Kozlowski
---
drivers/char/hw_random/exynos-rng.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a
Add proper error path (for disabling runtime PM) when registering of
hwrng fails.
Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number
generator")
Signed-off-by: Krzysztof Kozlowski
---
drivers/char/hw_random/exynos-rng.c | 7 ++-
1 file changed, 6 insert
In case of timeout during read operation, the exit path lacked PM
runtime put. This could lead to unbalanced runtime PM usage counter thus
leaving the device in an active state.
Fixes: d7fd6075a205 ("hwrng: exynos - Add timeout for waiting on init done")
Cc: # v4.4+
Signed-off-by:
Driver enabled runtime PM but did not revert this on removal. Re-binding
of a device triggered warning:
exynos-rng 10830400.rng: Unbalanced pm_runtime_enable!
Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number
generator")
Signed-off-by: Krzysztof
.
However for this purpose autosuspend is enabled so it is safe to runtime
put just after the initialization.
Signed-off-by: Krzysztof Kozlowski
---
drivers/char/hw_random/exynos-rng.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/exynos-rng.c
b/drivers
2016-03-11 16:49 GMT+09:00 Krzysztof Kozlowski :
> Replace ifdef with __maybe_unused to silence compiler warning on when
> SUSPEND=n and PM=y:
>
> drivers/char/hw_random/exynos-rng.c:166:12: warning: ‘exynos_rng_suspend’
> defined but not used [-Wunused-function]
> static int
W dniu 11.03.2016 o 16:49, Krzysztof Kozlowski pisze:
> Driver enabled runtime PM but did not revert this on removal. Re-binding
> of a device triggered warning:
> exynos-rng 10830400.rng: Unbalanced pm_runtime_enable!
>
> Fixes: b329669ea0b5 ("hwrng: exynos - Add suppo
.
However for this purpose autosuspend is enabled so it is safe to runtime
put just after the initialization.
Signed-off-by: Krzysztof Kozlowski
---
Changes since v1:
1. None.
---
drivers/char/hw_random/exynos-rng.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/char
Add proper error path (for disabling runtime PM) when registering of
hwrng fails.
Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number
generator")
Signed-off-by: Krzysztof Kozlowski
---
Changes since v1:
1. Call also pm_runtime_dont_use_autosuspend() to revert
In case of timeout during read operation, the exit path lacked PM
runtime put. This could lead to unbalanced runtime PM usage counter thus
leaving the device in an active state.
Fixes: d7fd6075a205 ("hwrng: exynos - Add timeout for waiting on init done")
Cc: # v4.4+
Signed-off-by:
Driver enabled runtime PM but did not revert this on removal. Re-binding
of a device triggered warning:
exynos-rng 10830400.rng: Unbalanced pm_runtime_enable!
Fixes: b329669ea0b5 ("hwrng: exynos - Add support for Exynos random number
generator")
Signed-off-by: Krzysztof
Get some build coverage of Exynos H/W random number generator
driver. Driver uses devm_ioremap_resource() so add IOMEM dependency for
the compile testing.
Signed-off-by: Krzysztof Kozlowski
---
Compile-tested on x86, x86_64, ppc64, arm, arm64 and mips.
---
drivers/char/hw_random/Kconfig | 3
Get some build coverage of S5P/Exynos AES H/W acceleration driver.
Driver uses DMA and devm_ioremap_resource() so add DMA and IOMEM
dependencies for the compile testing.
Signed-off-by: Krzysztof Kozlowski
---
Compile-tested on x86, x86_64, ppc64, arm, arm64 and mips.
---
drivers/crypto
From: Krzysztof Kozlowski
During crypto selftests on Odroid XU3 (Exynos5422) some of the
algorithms failed because of passing AES-block unaligned source and
destination buffers:
alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
Handle such case by copying the buffers to
From: Krzysztof Kozlowski
Remove unneeded inclusion of delay.h and get rid of indentation from
labels.
Signed-off-by: Krzysztof Kozlowski
Acked-by: Vladimir Zapolskiy
---
Changes since v2:
1. None.
Changes since v1:
1. Add Vladimir's acked-by.
---
drivers/crypto/s5p-sss.c
Sort the headers alphabetically to improve readability and to spot
duplications easier.
Suggested-by: Vladimir Zapolskiy
Signed-off-by: Krzysztof Kozlowski
Acked-by: Vladimir Zapolskiy
---
Changes since v2:
1. Add Vladimir's acked-by.
Changes since v1:
1. New patch.
My email differs
Correct smasung.com into samsung.com.
Signed-off-by: Krzysztof Kozlowski
---
drivers/char/hw_random/exynos-rng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/exynos-rng.c
b/drivers/char/hw_random/exynos-rng.c
index ada081232528..3443fdda44fa 100644
freed by s5p_aes_complete().
Fixes: 9e4a1100a445 ("crypto: s5p-sss - Handle unaligned buffers")
Signed-off-by: Krzysztof Kozlowski
---
drivers/crypto/s5p-sss.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 4f6d5b3ec418..b0
fe to remove the hash
interrupt related code and to not require the interrupt in Device Tree.
Signed-off-by: Krzysztof Kozlowski
---
.../devicetree/bindings/crypto/samsung-sss.txt | 6 ++--
drivers/crypto/s5p-sss.c | 34 --
2 files chang
The BIT() macro is obvious and well known, so prefer to use it instead
of crafted own macro.
Signed-off-by: Krzysztof Kozlowski
---
drivers/crypto/s5p-sss.c | 95
1 file changed, 47 insertions(+), 48 deletions(-)
diff --git a/drivers/crypto/s5p
e) from [] (load_module+0x1a30/0x1d08)
[] (load_module) from [] (SyS_finit_module+0x8c/0x98)
[] (SyS_finit_module) from [] (ret_fast_syscall+0x0/0x3c)
Fixes: a49e490c7a8a ("crypto: s5p-sss - add S5PV210 advanced crypto engine
support")
Cc:
Signed-off-by: Krzysztof Kozlowski
---
Issue was e
5p-sss - add S5PV210 advanced crypto engine
> support")
> Fixes: 9e4a1100a445 ("crypto: s5p-sss - Handle unaligned buffers")
> Cc:
> Signed-off-by: Marek Szyprowski
> ---
> drivers/crypto/s5p-sss.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Re
reversed-christmas-tree order with first variables being initialized
ones.
Signed-off-by: Krzysztof Kozlowski
---
drivers/crypto/s5p-sss.c | 80
1 file changed, 40 insertions(+), 40 deletions(-)
diff --git a/drivers/crypto/s5p-sss.c b/drivers
quot;)
Cc: # 3.16+
Signed-off-by: Krzysztof Kozlowski
Tested-by: Marek Szyprowski
Signed-off-by: Herbert Xu
[k.kozlowski: Backport to v3.16]
---
Backporting to earlier kernels does not make much sense as the driver
differs and the testing won't be possible probab
gcc 4.7.3 for ARM on Ubuntu couldn't link tcrypt module because of
division of s64:
ERROR: "__aeabi_ldivmod" [crypto/tcrypt.ko] undefined!
Fixes: 087bcd225c56 ("crypto: tcrypt - Add speed tests for SHA multibuffer
algorithms")
Signed-off-by: Krzysztof Kozlowski
first argument;
Signed-off-by: Krzysztof Kozlowski
---
crypto/tcrypt.c | 33 ++---
1 file changed, 14 insertions(+), 19 deletions(-)
diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index 6ef78157a0ab..3788a607921e 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@
On 06/28/2016 10:41 AM, Herbert Xu wrote:
> On Tue, Jun 28, 2016 at 09:23:07AM +0200, Krzysztof Kozlowski wrote:
>> gcc 4.7.3 for ARM on Ubuntu couldn't link tcrypt module because of
>> division of s64:
>> ERROR: "__aeabi_ldivmod" [crypto/tcrypt.ko]
On Tue, Jun 28, 2016 at 11:55 AM, Herbert Xu
wrote:
> This patch resolves a number of issues with the mb speed test
> function:
>
> * The tfm is never freed.
> * Memory is allocated even when we're not using mb.
> * When an error occurs we don't wait for completion for other requests.
> * When an
On 06/28/2016 02:33 PM, Herbert Xu wrote:
> On Tue, Jun 28, 2016 at 12:15:43PM +0200, Krzysztof Kozlowski wrote:
>> Oops:
>
> Thanks, there was a typo where it said k instead of j in the second
> loop.
>
> ---8<---
> This patch resolves a number of issues wit
On 06/29/2016 10:19 AM, Herbert Xu wrote:
> On Wed, Jun 29, 2016 at 10:16:10AM +0200, Krzysztof Kozlowski wrote:
>>
>> Seems to work fine except:
>> 1. The updates are always 1.
>
> Yes the test function only does digest so it's always one update.
>
>> 2.
platform_driver does not need to set an owner because
platform_driver_register() will set it.
Signed-off-by: Krzysztof Kozlowski
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/crypto/marvell/cesa.c | 1 -
1
2015-08-16 20:18 GMT+09:00 Heiner Kallweit :
> Am 15.08.2015 um 13:19 schrieb Heiner Kallweit:
>> I'm having issues making the hardware RNG work on a Samsung Exynos 5422
>> (Odroid XU4) with kernel 4.2rc6.
>> No random number generation is started if I write the appropriate value
>> (0x18) to the
On 17.08.2015 15:10, Heiner Kallweit wrote:
> Am 17.08.2015 um 02:19 schrieb Krzysztof Kozlowski:
>> 2015-08-16 20:18 GMT+09:00 Heiner Kallweit :
>>> Am 15.08.2015 um 13:19 schrieb Heiner Kallweit:
>>>> I'm having issues making the hardware RNG work on a Samsung
On 18.08.2015 15:02, Heiner Kallweit wrote:
> Am 17.08.2015 um 08:30 schrieb Krzysztof Kozlowski:
>> On 17.08.2015 15:10, Heiner Kallweit wrote:
>>> Am 17.08.2015 um 02:19 schrieb Krzysztof Kozlowski:
>>>> 2015-08-16 20:18 GMT+09:00 Heiner Kallweit :
>>>&
2015-08-16 20:18 GMT+09:00 Heiner Kallweit :
> Am 15.08.2015 um 13:19 schrieb Heiner Kallweit:
>> I'm having issues making the hardware RNG work on a Samsung Exynos 5422
>> (Odroid XU4) with kernel 4.2rc6.
>> No random number generation is started if I write the appropriate value
>> (0x18) to the
s way.
>
> Signed-off-by: Daniel Thompson
> Cc: Kukjin Kim
> Cc: Krzysztof Kozlowski
> ---
>
> Notes:
> Compile tested only (CONFIG_PM=y, CONFIG_HW_RANDOM_EXYNOS=m); I spotted
> this whilst reviewing the code and don't have an exynos platform to
> t
1 - 100 of 265 matches
Mail list logo
