Was a first nice draft of a desirable userspace API for various crypto/hash
acceleration.
Has there been some/any progress on the userspace API since, or
is this up for grabs?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord
with care. Arguably parts of
this can be cleaned-up later but it'd be nice to make some initial attempts
at unifying the math infrastructure.
Overall, thanks for working on this.
Yours,
Linus Walleij (et al)
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body
Herbert!
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
is debated elsewhere I
think. The day we know how to pass DMA channels to any platform/amba
device this device should be trivial to fully support with DT.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
On Wed, May 9, 2012 at 2:17 PM, Arnd Bergmann a...@arndb.de wrote:
On Wednesday 09 May 2012, Andreas WESTIN wrote:
On 2012-05-09 10:36, Linus Walleij wrote:
This needs an explanation! Why do you export an internal data structure
to non-GPL modules?
This does not look like it's needed
to allocate all devices dynamically at
one point, but there was no real infrastructure for it and some local
implementations to meet that requirement, that's why these
functions pop up and down. We're working on it with device tree
etc, mea culpa...
Yours,
Linus Walleij
--
To unsubscribe from
On Fri, Aug 24, 2012 at 10:33 AM, Devendra Naga
develkernel412...@gmail.com wrote:
Signed-off-by: Devendra Naga develkernel412...@gmail.com
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body
From: Linus Walleij linus.wall...@linaro.org
Commit 4f31f5b19eb0418a847b989abc9ac22af1991fe2
PM / crypto / ux500: Use struct dev_pm_ops for power management
add a new line to the driver struct but missed to add a
trailing comma, causing build errors when crypto is
selected. This adds the missing
...@linaro.org
Pls include Ulf Hansson ulf.hans...@linaro.org on this patch.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, but generally:
phys_addr_t = in the address space as the memory controller sees it.
dma_addr_t = in the address space as the DMA controller sees it.
Often the same. Not always. So use dma_addr_t.
Apart from this a real nice patch!
Yours,
Linus Walleij
--
To unsubscribe from this list: send
...@stericsson.com
Cc: linux-crypto@vger.kernel.org
Acked-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Lee Jones lee.jo...@linaro.org
Same formatting problems as the other prepare/enable
patch. Include Ulf Hansson.
(Apart from this it looks OK.)
Yours,
Linus Walleij
--
To unsubscribe from this list: send
...@gondor.apana.org.au
Cc: David S. Miller da...@davemloft.net
Cc: Andreas Westin andreas.wes...@stericsson.com
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
NAK. I already fixed this. It is in v3.9-rc7.
Yours,
Linus Walleij
--
To unsubscribe from this list: send
: David S. Miller da...@davemloft.net
Cc: Andreas Westin andreas.wes...@stericsson.com
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Reviewed-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe
On Thu, Apr 25, 2013 at 3:44 PM, Lee Jones lee.jo...@linaro.org wrote:
On Thu, 25 Apr 2013, Linus Walleij wrote:
On Thu, Apr 18, 2013 at 12:27 PM, Lee Jones lee.jo...@linaro.org wrote:
The DMA controller currently takes configuration information from
information passed though
if the dma engine resides behind an IOMMU.
The best assumption we can make is that the dma engine driver knows
how to convert between the two. Interestingly the documentation for
dma_slave_config talks about physical address, while the structure
itself uses a dma_addr_t. Linus Walleij introduced
phys_addr_t :)
OK! Sent a patch for this, check it out.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-off-by: Lee Jones lee.jo...@linaro.org
Tentatively applied to my ux500-dma40 branch.
This lacks an ACK from Vinod...
I cannot get any of this stack of patches up to ARM SoC
before I have Vinod's ACK on all hitting drivers/dma/*
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line
...@linaro.org
I still need Vinod's ACK on this before I send it anywhere.
Patch applied!
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, sdi1, mop500_sdi1_data),
OK dma_request_slave_channel() is upstream in the PL011 driver,
so applied!
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
indicating there may just be a window in the merge period
where it falls back to IRQ mode, but I don't want to disable
DMA on DT boots for an entire kernel cycle just like that.
Not applied as of yet.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body
, as it
elevates a large burden from platform data in the way of a look-up
table.
Signed-off-by: Lee Jones lee.jo...@linaro.org
This should be the case even without patch 5 6 so patch tentatively
applied.
Waiting for Vinod's ACK on this though.
Yours,
Linus Walleij
--
To unsubscribe from this list: send
applied, waiting for Vinod's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
() call to do device name matching, which will fail due to the
fact that Device Tree naming differs somewhat do the more traditional
conventions.
Reviewed-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Cannot be applied due to dependency on 5/39.
Yours
in well using Device Tree either.
Signed-off-by: Lee Jones lee.jo...@linaro.org
Good riddance. Patch tentatively applied.
Awaiting Vinod's ACK for include/platform_data/*.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message
ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
seems like an -rc fix to me
(I don't think the crypto device works without this).
This should go into the crypto tree?
Else please convince Herbert to give his ACK on this
before I apply it.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body
, but these
pieces of information are subsequently ignored by the driver, so we may
as well remove them.
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord
and will aid us when we come to enable the driver for Device Tree.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
I guess this stuff
On Wed, May 15, 2013 at 10:14 PM, Fabio Baltieri
fabio.balti...@linaro.org wrote:
On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote:
On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote:
For all ux500 based platforms the maximum number of end-points are used
, or was this in the MAINTAINERS file?
Certainly not in MAINTAINERS file :)
My bad then, sorry.
Linus,
Would you be kind enough to fix it please, as it's in your tree now.
I've fixed it up!
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message
Westin andreas.wes...@stericsson.com
Cc: linux-crypto@vger.kernel.org
Acked-by: Arnd Bergmann a...@arndb.de
Acked-by: Ulf Hansson ulf.hans...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied to my dma40 branch with Herbert's ACK.
Yours,
Linus Walleij
--
To unsubscribe from
with Herbert's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
lee.jo...@linaro.org
Patch applied now that the deps are in!
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Westin andreas.wes...@stericsson.com
Cc: linux-crypto@vger.kernel.org
Acked-by: Ulf Hansson ulf.hans...@linaro.org
Acked-by: Arnd Bergmann a...@arndb.de
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied with Herbert's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send
() call.
Cc: Herbert Xu herb...@gondor.apana.org.au
Cc: David S. Miller da...@davemloft.net
Cc: Andreas Westin andreas.wes...@stericsson.com
Cc: linux-crypto@vger.kernel.org
Acked-by: Arnd Bergmann a...@arndb.de
Acked-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Lee Jones lee.jo
: David S. Miller da...@davemloft.net
Cc: Andreas Westin andreas.wes...@stericsson.com
Cc: linux-crypto@vger.kernel.org
Acked-by: Arnd Bergmann a...@arndb.de
Reviewed-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied with Herbert's ACK.
Thanks
On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote:
These drivers are now operational and even use the latest common clk
and DMA APIs. There's no reason why we shouldn't start them up now.
Reviewed-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Lee Jones lee.jo
and will aid us when we come to enable the driver for Device Tree.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
I have now gone over
...@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Herbert, can I have your ACK on patch 5 6 in this series to take it
through the ARM SoC tree?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body
...@gondor.apana.org.au
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
---
drivers/crypto/ux500/cryp/cryp_core.c |6 ++
W00t! No binding document?
OK I guess it's just reg, irq ... but still it's compulsory,
right?
Yours,
Linus Walleij
--
To unsubscribe from this list
On Fri, May 24, 2013 at 10:32 AM, Lee Jones lee.jo...@linaro.org wrote:
On Fri, 24 May 2013, Linus Walleij wrote:
On Thu, May 16, 2013 at 1:27 PM, Lee Jones lee.jo...@linaro.org wrote:
By providing an OF match table with a suitable compatible string, we
can ensure the ux500-crypt driver
On Tue, May 28, 2013 at 6:27 PM, Felipe Balbi ba...@ti.com wrote:
On Wed, May 15, 2013 at 07:18:01PM +0200, Linus Walleij wrote:
I can't merge any of this without Felipes ACKs in any
case.
Do you want to take this yourself ? I haven't fully read the series yet,
but seems like this depends
and will aid us when we come to enable the driver for Device Tree.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied to my
. This also removes quite a bit of complexity from the driver
and will aid us when we come to enable the driver for Device Tree.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off
with either ATAGs or Device Tree.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Tentatively applied with Felipe's ACK.
Yours,
Linus
this driver for Device Tree.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Tentatively applied with Felipe's ACK.
Yours,
Linus Walleij
are present prior to using them.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Tentatively applied with Felipe's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send
step towards this. The next step will be to enable Device Tree
complete with name-event_line mapping.
Cc: Felipe Balbi ba...@ti.com
Cc: linux-...@vger.kernel.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo
: devicetree-disc...@lists.ozlabs.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: Fabio Baltieri fabio.balti...@linaro.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Tentatively applied with Felipe's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line
On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote:
The recently DT:ed MUSB driver will require clock-name by device-name
look-up capability, until common clk has is properly supported by the
ux500 platform.
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked
Patch applied to my ux500-dma40 branch on top of the musb
stuff.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@linaro.org
Applied on my ux500-dma40 branch.
And this is looking real good now!
Thanks!
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote:
The aim is to make the code that little more readable.
Acked-by: Vinod Koul vnod.k...@intel.com
Acked-by: Arnd Bergmann a...@arndb.de
Reviewed-by: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Lee Jones lee.jo
, I'm lacking your ACK on this patch, but have tentatively
queued it anyway. Maybe you missed it?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
d...@fb.com
Cc: Per Forlin per.for...@stericsson.com
Cc: Rabin Vincent ra...@rab.in
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied to my dma40 branch with Vinod's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body
on this, but it seems
it was implicitly ACKed in the discussion on patch 31.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
lee.jo...@linaro.org
Patch applied with Vinod's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Koul vinod.k...@intel.com
Cc: Dan Williams d...@fb.com
Cc: Per Forlin per.for...@stericsson.com
Cc: Rabin Vincent ra...@rab.in
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied with what I interpret as Vinod's ACK
(okay... statement on last reply.)
Yours,
Linus Walleij
Williams d...@fb.com
Cc: Per Forlin per.for...@stericsson.com
Cc: Rabin Vincent ra...@rab.in
Signed-off-by: Lee Jones lee.jo...@linaro.org
Tentatively applied. Missing Vinod's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message
a...@arndb.de
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied with Vinod's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to dma40 branch, hm now I may get a conflict with all
the AUXDATA changes in the devicetree branch. Oh well, I'll
figure it out...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info
, so we may as well add the infrastructure.
Cc: Vinod Koul vinod.k...@intel.com
Cc: Dan Williams d...@fb.com
Cc: Per Forlin per.for...@stericsson.com
Cc: Rabin Vincent ra...@rab.in
Signed-off-by: Lee Jones lee.jo...@linaro.org
Patch applied with Vinod's ACK.
Yours,
Linus Walleij
with Vinod's ACK.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-crypto in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 10, 2013 at 11:15 AM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 15 May 2013, Linus Walleij wrote:
On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote:
It was required to pass DMA channel configuration information to the
MMC driver before the new DMA API
On Mon, Jun 10, 2013 at 11:17 AM, Lee Jones lee.jo...@linaro.org wrote:
On Wed, 15 May 2013, Linus Walleij wrote:
On Wed, May 15, 2013 at 11:51 AM, Lee Jones lee.jo...@linaro.org wrote:
Now DMA DT bindings exist and are in use by he MMC and UART drivers, it
should be possible to remove
On Tue, Jun 25, 2013 at 10:54 AM, Fabio Baltieri
fabio.balti...@linaro.org wrote:
these are some fixes to issue pointed out by sparse and dmaengine API
udpates on the recently enabled ux500 hw crypto drivers.
The series:
Acked-by: Linus Walleij linus.wall...@linaro.org
These are based
On Tue, Jun 25, 2013 at 1:17 PM, Herbert Xu herb...@gondor.apana.org.au wrote:
On Tue, Jun 25, 2013 at 11:20:50AM +0200, Linus Walleij wrote:
On Tue, Jun 25, 2013 at 10:54 AM, Fabio Baltieri
fabio.balti...@linaro.org wrote:
these are some fixes to issue pointed out by sparse and dmaengine
-by: Linus Walleij linus.wall...@linaro.org
---
Only compile-tested as I don't have this platform.
---
drivers/crypto/tegra-aes.c | 15 +++
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c
index 2d58da9..7f42bfe 100644
tform and unlikely to be targeted
> by any "grown up" defconfigs.
>
> Signed-off-by: Daniel Thompson <daniel.thomp...@linaro.org>
This is a fine driver, love the performance boost you reported
and stand corrected on the likeness of the other Nomadik driver.
Reviewed-by: Linus Wallei
autosuspend_delay(>dev, 50);
pm_runtime_use_autosuspend(>dev);pm_runtime_put_autosuspend().
For a primecell check the usage in drivers/mmc/host/mmci.c
for a complex usecase or e.g. drivers/hwtracing/coresight/coresight-tpiu.c
for a simpler usecase.
For the performance hints I guess you can even tes
The hash buffer is really HASH_BLOCK_SIZE bytes, someone
must have thought that memmove takes n*u32 words by mistake.
Tests work as good/bad as before after this patch.
Cc: Joakim Bech <joakim.b...@linaro.org>
Reported-by: David Binderman <linuxdev.baldr...@gmail.com>
Signed-off-by: L
6a 15 6a dc b5 e0 3d
[4.170501] cryp1 cryp1: successfully registered
The simple tests always work, it's those stressful ones that create
problems.
Joakim: did you have a memory of this code working? Should
I check the vendor tree for fixes?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
This is a pure I2C driver, and this device appears on the
96boards Secure96 mezzanine card, so we want to enable the
driver on other devices. Cut the Kconfig limitations to
Atmel SoC only.
Signed-off-by: Linus Walleij
---
drivers/crypto/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git
The config zone has 0x16 words of 4 bytes each, so provide
some basic defines so that we can address these individually.
Rename the last word to "footer", this is where we currently
look to see if the configuration is locked.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel-
Instead of just providing a broad error message about the
chip being unlocked provide details on what is unlocked,
one line per thing that can be locked: data and OTP and
configuration are locked independently. Loose the
overzealous defines.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel
sense to provide the length
of the data buffer used with the command.
This avoids the hazzle to try to keep the command
structure in the device endianness, we fix up the
endianness when marshalling the command instead.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel-ecc.c | 71
This reads out the serial number of the crypto chip and prints it,
also toss this into the entropy pool as it is device-unique data.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel-ecc.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/drivers
Rewrite the function atmel_ecc_init_read_cmd() into a more
general atmel_ecc_init_read_config_word() function to read
any word from the configuration zone, and use this
parameterized with what we want to read out.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel-ecc.c | 11 ---
1
the probe continue silently if
no clock frequency can be found, assuming all is safe.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel-ecc.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel-ecc.c
index
This breaks out a lock status checker to be used with further
refactorings.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel-ecc.c | 38 ++
1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/atmel-ecc.c b/drivers/crypto/atmel
Report errors once when they happen on the I2C bus so we
get good information in cases such as when the wrong I2C
address is used.
Signed-off-by: Linus Walleij
---
drivers/crypto/atmel-ecc.c | 27 +--
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/drivers
On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny
<k.koniec...@partner.samsung.com> wrote:
> Crypto framework will require async hash export/import, so add empty
> functions to prevent OOPS.
>
> Signed-off-by: Kamil Konieczny <k.koniec...@partner.samsung.com>
Acked-by: L
On Tue, Jun 12, 2018 at 3:25 PM Tudor Ambarus
wrote:
> On 06/05/2018 04:49 PM, Linus Walleij wrote:
> > Instead of just providing a broad error message about the
> > chip being unlocked provide details on what is unlocked,
> > one line per thing that can be
This breaks out a lock status checker to be used with further
refactorings.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Rebased
---
drivers/crypto/atmel-ecc.c | 38 ++
1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/drivers/cry
This is a pure I2C driver, and this device appears on the
96boards Secure96 mezzanine card, so we want to enable the
driver on other devices. Cut the Kconfig limitations to
Atmel SoC only.
Reviewed-by: Tudor Ambarus
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Collect Tudor's review
On Mon, Jun 11, 2018 at 11:46 AM Tudor Ambarus
wrote:
> On 06/05/2018 04:49 PM, Linus Walleij wrote:
> > The Atmel ECC driver contains a check for the I2C bus clock
> > frequency, so as to check that the I2C adapter in use
> > satisfies the device specs.
> >
>
erial[3], serial[4],
> > + serial[5], serial[6], serial[7], serial[8]);
>
> Why do you need the serial number printed out?
Cuddly feeling I guess. If there is a problem with the device the
user might want to report the serial number to the
manufacturer?
Yours,
Linus Walleij
Rewrite the function atmel_ecc_init_read_cmd() into a more
general atmel_ecc_init_read_config_word() function to read
any word from the configuration zone, and use this
parameterized with what we want to read out.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Rebased
---
drivers/cry
On Tue, Jun 12, 2018 at 2:59 PM Tudor Ambarus
wrote:
> On 06/05/2018 04:49 PM, Linus Walleij wrote:
> > The config zone has 0x16 words of 4 bytes each, so provide
> > some basic defines so that we can address these individually.
>
> Are you going to use all these defi
Instead of just providing a broad error message about the
chip being unlocked provide details on what is unlocked,
one line per thing that can be locked: data and OTP and
configuration are locked independently. Loose the
overzealous defines.
Signed-off-by: Linus Walleij
---
ChangeLog v1->
sense to provide the length
of the data buffer used with the command.
This avoids the hazzle to try to keep the command
structure in the device endianness, we fix up the
endianness when marshalling the command instead.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Rebase on other chan
This reads out the serial number of the crypto chip and prints it,
also toss this into the entropy pool as it is device-unique data.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- kfree(cmd) was missed. Fix it with a goto construction.
- Coding style fixes.
---
drivers/crypto/atmel-ec
Report errors once when they happen on the I2C bus so we
get good information in cases such as when the wrong I2C
address is used.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Strip some comments that are now obvious from the context
with the error messages.
- Do not print the exc
The config zone has 0x16 words of 4 bytes each, so provide
some basic defines so that we can address these individually.
Rename the last word to "footer", this is where we currently
look to see if the configuration is locked.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Die
the probe continue with a warning
if no clock frequency can be found, assuming it is safe.
Signed-off-by: Linus Walleij
---
ChangeLog v1->v2:
- Instead of silently ignoring the missing clock frequency,
issue a warning and continue.
---
drivers/crypto/atmel-ecc.c | 9 +++--
1 file changed
On Tue, Jun 12, 2018 at 2:36 PM Tudor Ambarus
wrote:
> On 06/05/2018 04:49 PM, Linus Walleij wrote:
> > /* send the command */
>
> I guess that this comment will become superfluous if you're going to add
> an error message.
OK stripped obvious comments.
> > -
he command. This is code duplication.
Second problem: we have two instances of inlined
cmd->param2 = cpu_to_le16(keyid); dealing with endianness
instead of doing this as part of marshalling the command.
This is also code duplication.
Yours,
Linus Walleij
97 matches
Mail list logo
