Martin Kepplinger <mart...@posteo.de>
>
> Patch applied. Thanks.
Herbert,
You may have missed the thread on the similar "samples" patch [1]
before applying this as-is?
[1] https://lkml.org/lkml/2017/11/14/135
--
Cordially
Philippe Ombredanne
mments made on the list by Linus.
If you could spread the word out in your team too, this would be much welcomed!
Thanks!
[1] https://lkml.org/lkml/2017/12/4/934
--
Cordially
Philippe Ombredanne
On Thu, Dec 7, 2017 at 9:21 PM, Brijesh Singh <brijesh.si...@amd.com> wrote:
>
>
> On 12/06/2017 03:10 PM, Philippe Ombredanne wrote:>> diff --git
> a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c
>>>
>>> new file mode 100644
>>>
icense-Identifier: GPL-2.0
> +/*
> + * AMD Platform Security Processor (PSP) interface
> + *
> + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc.
> + *
> + * Author: Brijesh Singh <brijesh.si...@amd.com>
> + */
It is much cleaner and simpler, right?
For the C++ comment style and first line placement, please see Thomas
(tlgx) doc patches and Linus posts explaining his rationale of why he
wants it this way.
It would be awesome if this could be applied to all AMD contributions btw!
--
Cordially
Philippe Ombredanne
Dear CheahKC,
On Wed, Dec 20, 2017 at 10:17 PM, Cheah Kok Cheong <thrus...@gmail.com> wrote:
> On Wed, Dec 20, 2017 at 09:20:48PM +0100, Philippe Ombredanne wrote:
>> On Wed, Dec 20, 2017 at 9:15 PM, Cheah Kok Cheong <thrus...@gmail.com> wrote:
>> > Remove FS
Gilad,
On Sun, Jan 7, 2018 at 11:13 AM, Gilad Ben-Yossef <gi...@benyossef.com> wrote:
> On Wed, Jan 3, 2018 at 5:01 PM, Philippe Ombredanne
> <pombreda...@nexb.com> wrote:
>> Gilad,
>>
>> On Wed, Jan 3, 2018 at 2:35 PM, Gilad Ben-Yossef <gi...@benyossef.
. This cannot happen any other way or this would defeat the
whole purpose to have clear licensing kernel-wide: using the latest
and greatest introduces variations and creates a mess that we want to
avoid in the first place.
CC: Thomas Gleixner <t...@linutronix.de>
[1] https://lkml.org/lkml/2017/12/28/323
--
Cordially
Philippe Ombredanne
sure your MODULE_LICENSE is consistent with the top level
license.
Was it this way in the code from Krzysztof?
[1] https://lkml.org/lkml/2017/12/4/934
[2] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/
--
Cordially
Philippe Ombredanne
.
> */
>
> #include
> --
> 2.7.4
>
Why not use instead the simpler SPDX ids?
--
Cordially
Philippe Ombredanne
On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach <l.stelm...@samsung.com> wrote:
> It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote:
>> Łukasz,
>>
>> On Fri, Dec 22, 2017 at 2:23 PM, Łukasz Stelmach <l.stelm...@samsung.com>
>> wrote:
>
Kozlowski <k...@kernel.org>
> ---
> Changes since v4:
>
> - SPDX license header instead of the traditional blurb.
>
> - MODULE_LICENSE("GPL v2") instead of "GPL"
>
> Thank you, Philippe Ombredanne.
You have my cheerful ack for these changes:
Acked-by: Philippe Ombredanne <pombreda...@nexb.com>
--
Cordially
Philippe Ombredanne
Łukasz,
On Wed, Dec 27, 2017 at 11:12 AM, Łukasz Stelmach
<l.stelm...@samsung.com> wrote:
> It was <2017-12-22 pią 19:30>, when Philippe Ombredanne wrote:
>> On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach <l.stelm...@samsung.com>
>> wrote:
>>> It
file the style should be C comments as explained in Thomas
doc patches. .e.g.
> +/* SPDX-License-Identifier: GPL-2.0 */
And then it might makes sense there too:
> +/* Copyright (C) 2012-2017 ARM Limited or its affiliates. */
--
Cordially
Philippe Ombredanne
d mean GPL-2.0+ (e.g. or any
later version) and this would not match your top level license tag.
I know this may seem confusing, but there is little hope we can change
the MODULE_LICENSE tags that are used by many external module loaders.
Comments in module.h explain it all.
--
Cordially
Philippe Ombredanne
ame thing in the
MODULE_LICENSE and your SPDX tags.
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175
--
Cordially
Philippe Ombredanne
15 matches
Mail list logo
