Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array

2017-03-17 Thread Alexander Potapenko
On Fri, Mar 17, 2017 at 1:31 PM, Alexander Potapenko <gli...@google.com> wrote: > On Fri, Mar 17, 2017 at 1:08 PM, Peter Zijlstra <pet...@infradead.org> wrote: >> On Thu, Mar 16, 2017 at 05:15:19PM -0700, Michael Davidson wrote: >>> Replace a variable length a

Re: [PATCH 6/7] md/raid10, LLVM: get rid of variable length array

2017-03-17 Thread Alexander Potapenko
int idx = 0; >> struct bio_vec *bvec = r10_bio->master_bio->bi_io_vec; > > > That's disgusting. Why not fix LLVM to support this? IIUC there's only a handful of VLAIS instances in LLVM code, why not just drop them for the sake of better code portability? (To quote Lin