Re: [PATCH 17/18] crypto: marvell: fix first-fragment handling in mv_cesa_ahash_dma_last_req()

Hi Russell, Russell King writes: > When adding the software padding, this must be done using the first/mid > fragment mode, and any subsequent operation needs to be a mid-fragment. > Fix this. > > Signed-off-by: Russell King > --- >

Re: [PATCH 00/18] crypto: further fixes for Marvell CESA hash

the driver unfortunately >> needs this level of bug fixing to work properly. > > Thanks for spending some time fixing those bugs and > simplifying/factorizing/documenting the hash logic. +1 > To the whole series: > > Acked-by: Boris Brezillon <boris.brezil...@free-el

Re: [PATCH 0/6] Sparse related fixes

. A number of places are left >> unfixed, as we temporarily store CPU native endian values at these >> locations; these warnings should not be fixed (basically, only >> appropriate sparse warnings should be fixed without penalising code.) > > To the whole series: > > A

Re: [PATCH 4/6] crypto: marvell: use memcpy_fromio()/memcpy_toio()

Hi Russell, Russell King writes: > Use the IO memcpy() functions when copying from/to MMIO memory. > These locations were found via sparse. On recent MVEBU hardware, *_std_* function are not expected to be used because we will instead use the TDMA-based versions.

Re: [PATCH 00/18] crypto: further fixes for Marvell CESA hash

Hi, Boris Brezillon writes: > On Sun, 18 Oct 2015 17:16:49 +0100 > Russell King - ARM Linux wrote: > >> Following on from the previous series, this series addresses further >> problems with the Marvell CESA hash driver found while

Re: [PATCH v3b 5/5] crypto: marvell: factor out common import/export functions

Hi Russel, Russell King - ARM Linux <li...@arm.linux.org.uk> writes: > On Sat, Oct 10, 2015 at 12:37:33AM +0200, Arnaud Ebalard wrote: >> Hi Russel, >> >> Russell King <rmk+ker...@arm.linux.org.uk> writes: >> >> > As all the import functions a

Re: [PATCH v3b 5/5] crypto: marvell: factor out common import/export functions

Hi Russel, Russell King writes: > As all the import functions and export functions are virtually > identical, factor out their common parts into a generic > mv_cesa_ahash_import() and mv_cesa_ahash_export() respectively. This > performs the actual import or export,

Re: [PATCH] MAINTAINERS: add maintainers for the Marvell Crypto driver

t; >> S: Maintained >> F: drivers/net/dsa/mv88e6352.c >> >> +MARVELL CRYPTO DRIVER >> +M: Boris Brezillon <boris.brezil...@free-electrons.com> >> +M: Arnaud Ebalard <a...@natisbad.org> Acked-by: Arnaud Ebalard <a...@natisbad.org> >>