Re: [RFT PATCH] crypto: ahash.c: Require export/import in ahash

2018-01-16 Thread Bartlomiej Zolnierkiewicz
ash_ops_async(tfm); > @@ -467,10 +457,6 @@ static int crypto_ahash_init_tfm(struct crypto_tfm *tfm) > hash->setkey = alg->setkey; > hash->has_setkey = true; > } > - if (alg->export) > - hash->export = alg->export; > - if (alg->import) > - hash->import = alg->import; > > return 0; > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH v4 2/2] crypto: hw_random - Add new Exynos RNG driver

2017-04-10 Thread Bartlomiej Zolnierkiewicz
t; Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Bartlomiej Zolnierkiewicz
On Friday, March 24, 2017 07:19:34 PM Krzysztof Kozlowski wrote: > On Fri, Mar 24, 2017 at 05:11:25PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Friday, March 24, 2017 06:46:00 PM Krzysztof Kozlowski wrote: > > > I really do not like global or file-scope variables. I do not

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Bartlomiej Zolnierkiewicz
On Friday, March 24, 2017 06:46:00 PM Krzysztof Kozlowski wrote: > On Fri, Mar 24, 2017 at 04:26:47PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > Firstly, thanks for working on this. > > > > The patch looks fine overall for me, some re

Re: [PATCH 1/3] crypto: hw_random - Add new Exynos RNG driver

2017-03-24 Thread Bartlomiej Zolnierkiewicz
gt; +{ > + struct exynos_rng_dev *rng; > + struct resource *res; > + int ret; > + > + if (exynos_rng_dev) > + return -EEXIST; How this condition could ever happen? The probe function will never be called twice. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [PATCH 1/4] crypto: s5p-sss - Close possible race for completed requests

2017-03-17 Thread Bartlomiej Zolnierkiewicz
etion might try to operate on new crypto request. > > Cc: <sta...@vger.kernel.org> # v4.10.x > Fixes: 28b62b145868 ("crypto: s5p-sss - Fix spinlock recursion on LRW(AES)") > Signed-off-by: Krzysztof Kozlowski <k...@kernel.org> Reviewed-by: Bartlomiej Zoln

Re: [PATCH 4/4] crypto: s5p-sss - Use mutex instead of spinlock

2017-03-17 Thread Bartlomiej Zolnierkiewicz
if (!async_req) { > dev->busy = false; > - spin_unlock_irqrestore(>lock, flags); > + mutex_unlock(>lock); > return; > } > - spin_unlock_irqrestore(>lock, flags); > + mutex_unlock(>lock); Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics