Re: [PATCH v2 0/3] Add Support for Marvell OcteonTX2 Cryptographic

2020-08-07 Thread David Miller
From: Srujana Challa Date: Fri, 7 Aug 2020 19:39:17 +0530 > The following series adds support for Marvell Cryptographic Acceleration > Unit(CPT) on OcteonTX2 CN96XX SoC. > This series is tested with CRYPTO_EXTRA_TESTS enabled and > CRYPTO_DISABLE_TESTS disabled. net-next is closed, please do not

Re: [PATCH 2/4] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-07-27 Thread David Miller
From: Srujana Challa Date: Mon, 27 Jul 2020 14:12:46 + > On our test setup, the build is always successful, as we are adding > "af/" subdirectory in ccflags list ([PATCH 4/4] crypto: marvell: > enable OcteonTX2 cpt options for build). A patch series must be fully bisectable, the tree must bu

Re: get rid of the address_space override in setsockopt v2

2020-07-26 Thread David Miller
From: Christoph Hellwig Date: Sun, 26 Jul 2020 09:03:11 +0200 > On Fri, Jul 24, 2020 at 03:43:42PM -0700, David Miller wrote: >> > Changes since v1: >> > - check that users don't pass in kernel addresses >> > - more bpfilter cleanups >> > - cosme

Re: [PATCH 2/4] drivers: crypto: add support for OCTEONTX2 CPT engine

2020-07-24 Thread David Miller
From: Srujana Challa Date: Fri, 24 Jul 2020 18:38:02 +0530 > diff --git a/drivers/crypto/marvell/octeontx2/otx2_cpt_common.h > b/drivers/crypto/marvell/octeontx2/otx2_cpt_common.h > new file mode 100644 > index 000..00cd534 > --- /dev/null > +++ b/drivers/crypto/marvell/octeontx2/otx2_cpt_co

Re: get rid of the address_space override in setsockopt v2

2020-07-24 Thread David Miller
From: Christoph Hellwig Date: Thu, 23 Jul 2020 08:08:42 +0200 > setsockopt is the last place in architecture-independ code that still > uses set_fs to force the uaccess routines to operate on kernel pointers. > > This series adds a new sockptr_t type that can contained either a kernel > or user

Re: [PATCH 24/24] net: pass a sockptr_t into ->setsockopt

2020-07-20 Thread David Miller
From: Stefan Schmidt Date: Mon, 20 Jul 2020 16:19:38 +0200 > For the ieee802154 part: > > Acked-by: Stefan Schmidt Please do not quote an entire patch just to add an ACK, trim it just to the commit message, or even less. Thank you.

Re: [PATCH] crypto: hash.h: drop duplicated word in a comment

2020-07-17 Thread David Miller
From: Randy Dunlap Date: Fri, 17 Jul 2020 16:35:33 -0700 > From: Randy Dunlap > > Drop the doubled word "in" in a comment. > > Signed-off-by: Randy Dunlap Acked-by: David S. Miller

Re: [PATCH] crypto: skcipher.h: drop duplicated word in kernel-doc

2020-07-17 Thread David Miller
From: Randy Dunlap Date: Fri, 17 Jul 2020 16:35:49 -0700 > From: Randy Dunlap > > Drop the doubled word "request" in a kernel-doc comment. > > Signed-off-by: Randy Dunlap Acked-by: David S. Miller

Re: [PATCH v2] net: phy: mscc: avoid skcipher API for single block AES encryption

2020-06-25 Thread David Miller
From: Ard Biesheuvel Date: Thu, 25 Jun 2020 09:18:16 +0200 > The skcipher API dynamically instantiates the transformation object > on request that implements the requested algorithm optimally on the > given platform. This notion of optimality only matters for cases like > bulk network or disk enc

Re: [PATCH net] net/tls(TLS_SW): Add selftest for 'chunked' sendfile test

2020-06-08 Thread David Miller
From: Pooja Trivedi Date: Fri, 5 Jun 2020 16:01:18 + > This selftest tests for cases where sendfile's 'count' > parameter is provided with a size greater than the intended > file size. > > Motivation: When sendfile is provided with 'count' parameter > value that is greater than the size of

Re: [PATCH net-next 1/2] Crypto/chcr: Fixes compilations warnings

2020-05-14 Thread David Miller
From: Ayush Sawal Date: Thu, 14 May 2020 13:23:29 +0530 > @@ -256,7 +256,7 @@ static void get_aes_decrypt_key(unsigned char *dec_key, > return; > } > for (i = 0; i < nk; i++) > - w_ring[i] = be32_to_cpu(*(u32 *)&key[4 * i]); > + w_ring[i] = be32_t

Re: [PATCH net-next 0/5] Crypto/chcr: Fix issues regarding algorithm implementation in driver

2020-05-06 Thread David Miller
From: Devulapally Shiva Krishna Date: Tue, 5 May 2020 08:42:52 +0530 > The following series of patches fixes the issues which came during > self-tests with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS enabled. > > Patch 1: Fixes gcm(aes) hang issue and rfc4106-gcm encryption issue. > Patch 2: Fixes ctr, c

Re: [PATCH net-next] Revert "crypto: chelsio - Inline single pdu only"

2020-05-06 Thread David Miller
From: Ayush Sawal Date: Wed, 6 May 2020 20:17:19 +0530 > This reverts commit 27c6feb0fb33a665a746346e76714826a5be5d10. > > For ipsec offload the chelsio's ethernet driver expects a single mtu > sized packet. > > But when ipsec traffic is running using iperf, most of the packets in > that traff

Re: [PATCH] cxgb4/chcr: avoid -Wreturn-local-addr warning

2020-05-04 Thread David Miller
From: Arnd Bergmann Date: Thu, 30 Apr 2020 12:39:02 +0200 > gcc-10 warns about functions that return a pointer to a stack > variable. In chcr_write_cpl_set_tcb_ulp(), this does not actually > happen, but it's too hard to see for the compiler: > > drivers/crypto/chelsio/chcr_ktls.c: In function

Re: [PATCH 23/25] crypto: niagara2 - switch to skcipher API

2019-10-14 Thread David Miller
From: Ard Biesheuvel Date: Mon, 14 Oct 2019 14:19:08 +0200 > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface") > dated 20 august 2015 introduced the new skcipher API which is supposed to > replace both blkcipher and ablkcipher. While all consumers of the API have > been

Re: [RFT PATCH 0/3] crypto: sparc - convert to skcipher API

2019-10-11 Thread David Miller
From: Eric Biggers Date: Fri, 11 Oct 2019 21:38:47 -0700 > I've compiled this patchset, and the conversion is very similar to that > which has been done for many other crypto drivers. But I don't have the > hardware to test it, nor are SPARC64 crypto opcodes supported by QEMU. > So I really need

Re: [PATCH net] ppp: mppe: Revert "ppp: mppe: Add softdep to arc4"

2019-07-12 Thread David Miller
From: Eric Biggers Date: Fri, 12 Jul 2019 16:39:31 -0700 > From: Eric Biggers > > Commit 0e5a610b5ca5 ("ppp: mppe: switch to RC4 library interface"), > which was merged through the crypto tree for v5.3, changed ppp_mppe.c to > use the new arc4_crypt() library function rather than access RC4 thr

Re: [PATCH] crypto: cavium remove casting dma_alloc

2019-06-23 Thread David Miller
From: Vasyl Gomonovych Date: Sun, 23 Jun 2019 22:48:49 +0200 > @@ -233,7 +233,7 @@ static int alloc_command_queues(struct cpt_vf *cptvf, > > c_size = (rem_q_size > qcsize_bytes) ? qcsize_bytes : > rem_q_size; > - cu

Re: [PATCH v4 1/1] net: fastopen: robustness and endianness fixes for SipHash

2019-06-22 Thread David Miller
From: Ard Biesheuvel Date: Wed, 19 Jun 2019 23:46:28 +0200 > Some changes to the TCP fastopen code to make it more robust > against future changes in the choice of key/cookie size, etc. > > - Instead of keeping the SipHash key in an untyped u8[] buffer > and casting it to the right type upon u

Re: [PATCH net-next v2 1/1] net: fastopen: robustness and endianness fixes for SipHash

2019-06-19 Thread David Miller
From: Ard Biesheuvel Date: Wed, 19 Jun 2019 08:55:10 +0200 > + ctx->key[0] = (siphash_key_t){ > + get_unaligned_le64(primary_key), > + get_unaligned_le64(primary_key + 8) > + }; Please just use normal assignment(s), because not only does this warn it looks not so

Re: [PATCH 2/2] net: fastopen: use endianness agnostic representation of the cookie

2019-06-18 Thread David Miller
From: Ard Biesheuvel Date: Tue, 18 Jun 2019 20:40:18 +0200 > Can we first agree on whether we care about this or not? If so, i > can spin a v2. Well, how can it possibly work otherwise in deployment scenerios involving both big and little endian hosts?

Re: [PATCH v3] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-17 Thread David Miller
From: Eric Dumazet Date: Mon, 17 Jun 2019 10:00:28 -0700 > All our fastopen packetdrill tests pass (after I changed all the cookie > values in them) > > Signed-off-by: Eric Dumazet I'm going to apply this to net-next, I want it to sit there for a while. Thanks.

Re: [PATCH v2] net: ipv4: move tcp_fastopen server side code to SipHash library

2019-06-16 Thread David Miller
From: Ard Biesheuvel Date: Fri, 14 Jun 2019 16:01:22 +0200 > Using a bare block cipher in non-crypto code is almost always a bad idea, > not only for security reasons (and we've seen some examples of this in > the kernel in the past), but also for performance reasons. > > In the TCP fastopen cas

Re: [net-next 1/3] net/tls: build_protos moved to common routine

2019-01-22 Thread David Miller
From: Atul Gupta Date: Thu, 17 Jan 2019 20:55:53 -0800 > build protos is required for tls_hw_prot also hence moved to > 'tls_build_proto' and called as required from tls_init > and tls_hw_proto. This is required since build_protos > for v4 is moved from tls_register to tls_init in > commit <28cb6

Re: [net-next 3/3] cxgb4: TLS record offload enable

2019-01-22 Thread David Miller
From: Atul Gupta Date: Thu, 17 Jan 2019 20:56:39 -0800 > Enable Inline TLS record by default > > Signed-off-by: Atul Gupta Applied.

Re: [net-next 2/3] net/tls: free ctx in sock destruct

2019-01-22 Thread David Miller
From: Atul Gupta Date: Thu, 17 Jan 2019 20:56:21 -0800 > free tls context in sock destruct. close may not be the last > call to free sock but force releasing the ctx in close > will result in GPF when ctx referred again in tcp_done > > [ 515.330477] general protection fault: [#1] SMP PTI >

Re: [tls 3/5] crypto/chelsio/chtls: listen fails with multiadapt

2018-12-14 Thread David Miller
From: Atul Gupta Date: Tue, 11 Dec 2018 02:20:26 -0800 > listen fails when more than one tls capable device is > registered. tls_hw_hash is called for each dev which loops > again for each cdev_list causing listen failure. Hence > call chtls_listen_start/stop for specific device than loop over al

Re: [tls 4/5] crypto/chelsio/chtls: macro correction in tx path

2018-12-14 Thread David Miller
From: Atul Gupta Date: Tue, 11 Dec 2018 02:20:40 -0800 > corrected macro used in tx path. removed redundant hdrlen > and check for !page in chtls_sendmsg > > Signed-off-by: Atul Gupta Applied.

Re: [tls 2/5] net/tls: sleeping function from invalid context

2018-12-14 Thread David Miller
From: Atul Gupta Date: Tue, 11 Dec 2018 02:20:09 -0800 > HW unhash within mutex for registered tls devices cause sleep > when called from tcp_set_state for TCP_CLOSE. Release lock and > re-acquire after function call with ref count incr/dec. > defined kref and fp release for tls_device to ensure

Re: [tls 5/5] crypto/chelsio/chtls: send/recv window update

2018-12-14 Thread David Miller
From: Atul Gupta Date: Tue, 11 Dec 2018 02:20:53 -0800 > recalculated send and receive window using linkspeed. > Determine correct value of eck_ok from SYN received and > option configured on local system. > > Signed-off-by: Atul Gupta Applied.

Re: [tls 1/5] net/tls: Init routines in create_ctx

2018-12-14 Thread David Miller
From: Atul Gupta Date: Tue, 11 Dec 2018 02:19:40 -0800 > create_ctx is called from tls_init and tls_hw_prot > hence initialize function pointers in common routine. > > Signed-off-by: Atul Gupta Applied.

Re: [PATCH] scatterlist: Update size type to support greater then 4GB size.

2018-12-11 Thread David Miller
From: Ashish Mhetre Date: Wed, 12 Dec 2018 11:54:13 +0530 > diff --git a/include/linux/nvme.h b/include/linux/nvme.h > index 68e91ef..0a07a29 100644 > --- a/include/linux/nvme.h > +++ b/include/linux/nvme.h > @@ -587,7 +587,7 @@ enum { > > struct nvme_sgl_desc { > __le64 addr; > - _

Re: [PATCH net-next] cxgb4: use new fw interface to get the VIN and smt index

2018-11-23 Thread David Miller
From: Ganesh Goudar Date: Wed, 21 Nov 2018 13:40:24 +0530 > From: Santosh Rastapur > > If the fw supports returning VIN/VIVLD in FW_VI_CMD save it > in port_info structure else retrieve these from viid and save > them in port_info structure. Do the same for smt_idx from > FW_VI_MAC_CMD > > Si

Re: [PATCH net-next] cxgb4: use new fw interface to get the VIN and smt index

2018-11-22 Thread David Miller
From: Jason Gunthorpe Date: Wed, 21 Nov 2018 19:46:24 -0700 > On Wed, Nov 21, 2018 at 01:40:24PM +0530, Ganesh Goudar wrote: >> From: Santosh Rastapur >> >> If the fw supports returning VIN/VIVLD in FW_VI_CMD save it >> in port_info structure else retrieve these from viid and save >> them in p

Re: [PATCH net-next] cxgb4: fix the error path of cxgb4_uld_register()

2018-10-18 Thread David Miller
From: Ganesh Goudar Date: Thu, 18 Oct 2018 19:34:19 +0530 > On multi adapter setup if the uld registration fails even on > one adapter, the allocated resources for the uld on all the > adapters are freed, rendering the functioning adapters unusable. > > This commit fixes the issue by freeing the

Re: [PATCH net-next v6 00/23] WireGuard: Secure Network Tunnel

2018-10-05 Thread David Miller
From: Richard Weinberger Date: Fri, 5 Oct 2018 15:37:57 +0200 > And I strongly vote that Herbert Xu shall remain the maintainer of > the whole crypto system (including zinc!) in the kernel. I 100% agree with this.

Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

2018-09-16 Thread David Miller
From: Andy Lutomirski Date: Sun, 16 Sep 2018 21:09:11 -0700 > CRYPTO API > M: Herbert Xu > M: "David S. Miller" > L: linux-crypto@vger.kernel.org > > Herbert hasn't replied to any of these submissions. You're the other > maintainer :) Herbert is the primary crypto maintainer,

Re: [PATCH net-next v3 02/17] zinc: introduce minimal cryptography library

2018-09-11 Thread David Miller
From: Andrew Lunn Date: Wed, 12 Sep 2018 01:30:15 +0200 > Just as an FYI: > > 1) I don't think anybody in netdev has taken a serious look at the > network code yet. There is little point until the controversial part > of the code, Zinc, has been sorted out. > > 2) I personally would be surprise

Re: [PATCH v2 net-next 0/2] virtio_net: Expand affinity to arbitrary numbers of cpu and vq

2018-08-11 Thread David Miller
From: Caleb Raitto Date: Thu, 9 Aug 2018 18:18:27 -0700 > Virtio-net tries to pin each virtual queue rx and tx interrupt to a cpu if > there are as many queues as cpus. > > Expand this heuristic to configure a reasonable affinity setting also > when the number of cpus != the number of virtual q

Re: [PATCH] [RESEND, net-next, v2] tcp: use monotonic timestamps for PAWS

2018-07-12 Thread David Miller
From: Arnd Bergmann Date: Wed, 11 Jul 2018 12:16:12 +0200 > Using get_seconds() for timestamps is deprecated since it can lead > to overflows on 32-bit systems. While the interface generally doesn't > overflow until year 2106, the specific implementation of the TCP PAWS > algorithm breaks in 2038

Re: [PATCH net] ipv6: sr: fix passing wrong flags to crypto_alloc_shash()

2018-07-02 Thread David Miller
From: Eric Biggers Date: Sat, 30 Jun 2018 15:26:56 -0700 > From: Eric Biggers > > The 'mask' argument to crypto_alloc_shash() uses the CRYPTO_ALG_* flags, > not 'gfp_t'. So don't pass GFP_KERNEL to it. > > Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support") > Signed-off-by: E

Re: [PATCH v15 net-next 00/12] Chelsio Inline TLS

2018-03-31 Thread David Miller
From: Atul Gupta Date: Sat, 31 Mar 2018 21:41:51 +0530 > Series for Chelsio Inline TLS driver (chtls) Series applied, thank you.

Re: [PATCH v2 net-next 0/6] TLS Rx

2018-03-23 Thread David Miller
From: Dave Watson Date: Thu, 22 Mar 2018 10:09:44 -0700 > TLS tcp socket RX implementation, to match existing TX code. Looks great Dave. Applied, and once my build tests finish I'll push this out to net-next. In some of the new functions, reverse christmas tree ordering of local variables was

Re: [PATCH v11 crypto 00/12] Chelsio Inline TLS

2018-03-18 Thread David Miller
From: Atul Gupta Date: Sun, 18 Mar 2018 14:30:30 + > Hi Dave/Herbert, > > This series is against crypto tree, should I submit two patch series: > 1. netdev specific changes against net-next tree? > 2. crypto changes against crypto tree? Herbert, is it OK for this entire series to go via net

Re: [PATCH v11 crypto 00/12] Chelsio Inline TLS

2018-03-17 Thread David Miller
From: Atul Gupta Date: Fri, 16 Mar 2018 21:06:22 +0530 > Series for Chelsio Inline TLS driver (chtls) This series doesn't even come close to applying to the net-next tree, please respin. Thank you.

Re: [crypto v8 04/12] chtls: structure and macro definiton

2018-03-04 Thread David Miller
From: Atul Gupta Date: Thu, 1 Mar 2018 11:19:35 +0530 > + __u8 reneg_to_write_rx; > + __u8 protocol; You should use "u8" rather than "__u8" except in UAPI headers which this file is not. Please audit your entire patch series for this issue. Thank you.

Re: [Crypto v7 00/12] Chelsio Inline TLS

2018-02-23 Thread David Miller
If nobody is going to actually review these changes for substance and give real feedback, I will just keep picking the patch series apart with coding style nitpicks until somebody does. You have been warned :-)

Re: [Crypto v6 03/12] tls: support for inline tls

2018-02-20 Thread David Miller
From: Atul Gupta Date: Mon, 19 Feb 2018 12:19:41 +0530 > + struct net_device *netdev = NULL; > + > + netdev = dev_get_by_index(sock_net(sk), inet->cork.fl.flowi_oif); No need for an assignment in the variable declaration here. You immediately set it to something else unconditionally. >

Re: [Crypto v4 03/12] support for inline tls

2018-02-12 Thread David Miller
From: Atul Gupta Date: Mon, 12 Feb 2018 17:34:28 +0530 > +static int get_tls_prot(struct sock *sk) > +{ > + struct tls_context *ctx = tls_get_ctx(sk); > + struct net_device *netdev; > + struct tls_device *dev; > + > + /* Device bound to specific IP */ > + if (inet_sk(sk)->inet

Re: [Crypto v4 01/12] tls: tls_device struct to register TLS drivers

2018-02-12 Thread David Miller
From: Atul Gupta Date: Mon, 12 Feb 2018 17:33:48 +0530 > + /* When calling get_netdev, the HW vendor's driver should return the > + * net device of device @device at port @port_num or NULL if such > + * a net device doesn't exist > + */ > + struct net_device *(*netdev)(stru

Re: [PATCHv2] tls: Add support for encryption using async offload accelerator

2018-01-31 Thread David Miller
From: Vakul Garg Date: Wed, 31 Jan 2018 21:34:37 +0530 > Async crypto accelerators (e.g. drivers/crypto/caam) support offloading > GCM operation. If they are enabled, crypto_aead_encrypt() return error > code -EINPROGRESS. In this case tls_do_encryption() needs to wait on a > completion till the

Re: [PATCH] sparc64: fix typo in CONFIG_CRYPTO_DES_SPARC64 => CONFIG_CRYPTO_CAMELLIA_SPARC64

2018-01-24 Thread David Miller
From: Corentin Labbe Date: Tue, 23 Jan 2018 14:33:14 + > This patch fixes the typo CONFIG_CRYPTO_DES_SPARC64 => > CONFIG_CRYPTO_CAMELLIA_SPARC64 > > Fixes: 81658ad0d923 ("sparc64: Add CAMELLIA driver making use of the new > camellia opcodes.") > Signed-off-by: Corentin Labbe Applied, tha

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

2018-01-05 Thread David Miller
From: "Yang Shi" Date: Fri, 05 Jan 2018 06:46:48 +0800 > Any more comment on this change? These patches were not really submitted properly. If you post a series, the series goes to one destination and one tree. If they are supposed to go to multiple trees, submit them individually rather than

Re: [PATCH] crypto: n2 - cure use after free

2017-12-19 Thread David Miller
From: Jan Engelhardt Date: Tue, 19 Dec 2017 19:09:07 +0100 > queue_cache_init is first called for the Control Word Queue > (n2_crypto_probe). At that time, queue_cache[0] is NULL and a new > kmem_cache will be allocated. If the subsequent n2_register_algs call > fails, the kmem_cache will be rele

Re: [PATCH] crypto: n2 - cure use after free

2017-12-19 Thread David Miller
From: Jan Engelhardt Date: Tue, 19 Dec 2017 16:42:39 +0100 (CET) > Nevertheless, I think that the error pathing in n2_core.c should be made > robust as well. I completely agree. > Should I resubmit with a new commit message? Yes.

Re: [PATCH v2 2/2] chcr: Add support for Inline IPSec

2017-11-13 Thread David Miller
From: Atul Gupta Date: Thu, 9 Nov 2017 16:59:01 +0530 > register xfrmdev_ops callbacks, Send IPsec tunneled data > to HW for inline processing. > The driver use hardware crypto accelerator to encrypt and > generate ICV for the transmitted packet in Inline mode. > > Signed-off-by: Atul Gupta >

Re: [PATCH V2] Fix a sleep-in-atomic bug in shash_setkey_unaligned

2017-10-04 Thread David Miller
From: Herbert Xu Date: Thu, 5 Oct 2017 11:40:54 +0800 > On Tue, Oct 03, 2017 at 07:45:06PM -0300, Marcelo Ricardo Leitner wrote: >> >> > Usually if you're invoking setkey from a non-sleeping code-path >> > you're probably doing something wrong. >> >> Usually but not always. There are 3 calls to

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-13 Thread David Miller
From: Allen Pais Date: Wed, 13 Sep 2017 13:02:15 +0530 > Signed-off-by: Allen Pais This is quite pointless as the caller doesn't do anything with the value, it just tests whether a negative value is returned or not.

Re: [PATCH 1/2] crypto: n2 - remove null check before kfree

2017-08-26 Thread David Miller
From: Himanshu Jha Date: Sun, 27 Aug 2017 02:45:29 +0530 > kfree on NULL pointer is a no-op and therefore checking it is redundant. > > Signed-off-by: Himanshu Jha Acked-by: David S. Miller

Re: [PATCH] crypto: n2_core: Convert to using %pOF instead of full_name

2017-07-18 Thread David Miller
From: Rob Herring Date: Tue, 18 Jul 2017 16:42:56 -0500 > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring Acked-by: David S. Miller

Re: [GIT] Networking

2017-07-11 Thread David Miller
From: Herbert Xu Date: Mon, 10 Jul 2017 22:00:48 +0800 > crypto: af_alg - Avoid sock_graft call warning > > The newly added sock_graft warning triggers in af_alg_accept. > It's harmless as we're essentially doing sock->sk = sock->sk. > > The sock_graft call is actually redundant because all the

Re: [PATCH] crypto: cavium: make several functions static

2017-06-20 Thread David Miller
From: Colin King Date: Tue, 20 Jun 2017 11:35:50 +0100 > From: Colin Ian King > > The functions cvm_encrypt, cvm_decrypt, cvm_xts_setkey and > cvm_enc_dec_init does not need to be in global scope, so make > them static. > > Signed-off-by: Colin Ian King Acked-by: David S. Miller

Re: Crypto Fixes for 4.12

2017-06-16 Thread David Miller
From: Theodore Ts'o Date: Fri, 16 Jun 2017 08:50:07 -0400 > On Thu, Jun 15, 2017 at 11:01:18AM -0400, David Miller wrote: >> As a side note, ext4 does something similar with a private >> implementation, but it doesn't use something the evaluates to an >> alloca.

Re: [PATCH v3 net-next 0/4] kernel TLS

2017-06-15 Thread David Miller
From: Dave Watson Date: Wed, 14 Jun 2017 11:36:54 -0700 > This series adds support for kernel TLS encryption over TCP sockets. > A standard TCP socket is converted to a TLS socket using a setsockopt. > Only symmetric crypto is done in the kernel, as well as TLS record > framing. The handshake re

Re: [PATCH] crypto: n2: make of_device_ids const

2017-06-15 Thread David Miller
From: Arvind Yadav Date: Thu, 15 Jun 2017 17:28:10 +0530 > of_device_ids are not supposed to change at runtime. All functions > working with of_device_ids provided by work with const > of_device_ids. So mark the non-const structs as const. > > File size before: >text data bss

Re: Crypto Fixes for 4.12

2017-06-15 Thread David Miller
From: Linus Torvalds Date: Thu, 15 Jun 2017 18:04:44 +0900 > There's a fair number of SHASH_DESC_ON_STACK users, are all the others > safe for some random reason that just happens to be about code > generation? Did people actually verify that? I looked at the code generated in every case. As a

Re: Crypto Fixes for 4.12

2017-06-15 Thread David Miller
From: Herbert Xu Date: Thu, 15 Jun 2017 17:42:10 +0800 > On Thu, Jun 15, 2017 at 06:04:44PM +0900, Linus Torvalds wrote: >> There's a fair number of SHASH_DESC_ON_STACK users, are all the others >> safe for some random reason that just happens to be about code >> generation? Did people actually v

Re: [PATCH v3 net-next 0/4] kernel TLS

2017-06-14 Thread David Miller
From: Dave Watson Date: Wed, 14 Jun 2017 11:36:54 -0700 > This series adds support for kernel TLS encryption over TCP sockets. > A standard TCP socket is converted to a TLS socket using a setsockopt. > Only symmetric crypto is done in the kernel, as well as TLS record > framing. The handshake re

Re: Crypto Fixes for 4.12

2017-06-08 Thread David Miller
From: Herbert Xu Date: Thu, 8 Jun 2017 17:23:21 +0800 > This push fixes a couple of places in the crypto code that were > doing interruptible sleeps dangerously. They have been converted > to use non-interruptible sleeps. This push also fixes a bug in > asymmetric_keys where it would trigger a

Re: [PATCH v2 net-next 1/4] tcp: ULP infrastructure

2017-06-07 Thread David Miller
From: Dave Watson Date: Tue, 6 Jun 2017 10:00:20 -0700 > +EXPORT_SYMBOL(tcp_register_ulp); EXPORT_SYMBOL_GPL() please. > +EXPORT_SYMBOL(tcp_unregister_ulp); Likewise.

Re: crypto: Work around deallocated stack frame reference gcc bug on sparc.

2017-06-06 Thread David Miller
From: David Miller Date: Fri, 02 Jun 2017 11:28:54 -0400 (EDT) > > On sparc, if we have an alloca() like situation, as is the case with > SHASH_DESC_ON_STACK(), we can end up referencing deallocated stack > memory. The result can be that the value is clobbered if a trap > or in

Re: crypto: Work around deallocated stack frame reference gcc bug on sparc.

2017-06-02 Thread David Miller
From: David Miller Date: Fri, 02 Jun 2017 14:39:06 -0400 (EDT) > From: "Darrick J. Wong" > Date: Fri, 2 Jun 2017 11:08:08 -0700 > >> ext4/jbd2's crc32c implementations will also need a fix like this for >> {ext4,jbd2}_chksum. Note that both of these module

Re: crypto: Work around deallocated stack frame reference gcc bug on sparc.

2017-06-02 Thread David Miller
From: "Darrick J. Wong" Date: Fri, 2 Jun 2017 11:08:08 -0700 > ext4/jbd2's crc32c implementations will also need a fix like this for > {ext4,jbd2}_chksum. Note that both of these modules call the crypto api > directly to avoid a static dependence on libcrc32c; this was done to > reduce kernel fo

crypto: Work around deallocated stack frame reference gcc bug on sparc.

2017-06-02 Thread David Miller
On sparc, if we have an alloca() like situation, as is the case with SHASH_DESC_ON_STACK(), we can end up referencing deallocated stack memory. The result can be that the value is clobbered if a trap or interrupt arrives at just the right instruction. It only occurs if the function ends returnin

Re: [sparc64] crc32c misbehave

2017-05-31 Thread David Miller
From: David Miller Date: Wed, 31 May 2017 11:53:35 -0400 (EDT) > Can you try something like disabling cpu IRQs around the crc32c() function > in lib/libcrc32c.c? Something like: > > u32 retval; > > local_irq_disable(); > > shash->tfm = tf

Re: [sparc64] crc32c misbehave

2017-05-31 Thread David Miller
From: Anatoly Pugachev Date: Wed, 31 May 2017 14:56:52 +0300 > While debugging occasional crc32c checksum errors with xfs disk reads on > sparc64 (T5 [sun4v] 3.6 GHz CPU ldom, debian unstable/sid), Eric have found > that crc32c sometimes returns wrong checksum for data. Eric made a simple > test

Re: [PATCH net-next 3/4] tls: kernel TLS support

2017-05-26 Thread David Miller
From: Eric Dumazet Date: Fri, 26 May 2017 07:16:59 -0700 > On Wed, 2017-05-24 at 09:27 -0700, Dave Watson wrote: >> Software implementation of transport layer security, implemented using ULP >> infrastructure. tcp proto_ops are replaced with tls equivalents of sendmsg >> and >> sendpage. > > .

Re: [PATCH net-next 0/4] kernel TLS

2017-05-25 Thread David Miller
From: Dave Watson Date: Wed, 24 May 2017 09:26:33 -0700 > This series adds support for kernel TLS encryption over TCP sockets. > A standard TCP socket is converted to a TLS socket using a setsockopt. > Only symmetric crypto is done in the kernel, as well as TLS record > framing. The handshake re

Re: [PATCH net-next 2/4] tcp: export do_tcp_sendpages and tcp_rate_check_app_limited functions

2017-05-25 Thread David Miller
From: Dave Watson Date: Wed, 24 May 2017 09:26:57 -0700 > Export do_tcp_sendpages and tcp_rate_check_app_limited, since tls will need to > sendpages while the socket is already locked. > > tcp_sendpage is exported, but requires the socket lock to not be held already. > > Signed-off-by: Aviad Ye

Re: [PATCH] crypto: hifn_795x: Fix a handful of minor bugs spotted by eye

2017-05-17 Thread David Miller
From: Logan Gunthorpe Date: Wed, 17 May 2017 21:33:22 -0600 > > > On 17/05/17 09:26 PM, Herbert Xu wrote: >> On Thu, May 18, 2017 at 11:25:06AM +0800, Herbert Xu wrote: >>> On Fri, Apr 28, 2017 at 11:02:40AM -0600, Logan Gunthorpe wrote: * Cleaned up the formatting of ablkcipher_get argume

Re: [PATCH 2/2] n2rng: Combine substrings for two messages in n2rng_probe()

2017-04-21 Thread David Miller
From: Herbert Xu Date: Fri, 21 Apr 2017 19:36:41 +0800 > On Wed, Apr 19, 2017 at 11:11:35AM +0200, SF Markus Elfring wrote: >> From: Markus Elfring >> Date: Wed, 19 Apr 2017 10:50:04 +0200 >> >> The script "checkpatch.pl" pointed information out like the following. >> >> WARNING: quoted string

Re: [patch V2 13/13] crypto: n2 - Replace racy task affinity logic

2017-04-13 Thread David Miller
From: Thomas Gleixner Date: Thu, 13 Apr 2017 10:20:23 +0200 (CEST) > spu_queue_register() needs to invoke setup functions on a particular > CPU. This is achieved by temporarily setting the affinity of the > calling user space thread to the requested CPU and reset it to the original > affinity aft

Re: [PATCH 0/4] crypto: CRYPTO_MAX_ALG_NAME is too low

2017-04-06 Thread David Miller
From: Herbert Xu Date: Thu, 6 Apr 2017 16:15:09 +0800 > As the final patch depends on all three it would be easiest if > we pushed the xfrm patch through the crypto tree. Steffen/David? No objections from me for this going through the crypto tree.

Re: [RFC TLS Offload Support 00/15] cover letter

2017-03-29 Thread David Miller
From: Aviad Yehezkel Date: Tue, 28 Mar 2017 16:26:17 +0300 > TLS Tx crypto offload is a new feature of network devices. It > enables the kernel TLS socket to skip encryption and authentication > operations on the transmit side of the data path, delegating those > to the NIC. In turn, the NIC encr

Re: [PATCH] padata: avoid race in reordering

2017-03-25 Thread David Miller
From: Steffen Klassert Date: Fri, 24 Mar 2017 10:41:59 +0100 > On Thu, Mar 23, 2017 at 12:24:43PM +0100, Jason A. Donenfeld wrote: >> Under extremely heavy uses of padata, crashes occur, and with list >> debugging turned on, this happens instead: ... >> Signed-off-by: Jason A. Donenfeld > > Ac

Re: [PATCH] crypto: xts,lrw - fix out-of-bounds write after kmalloc failure

2017-03-23 Thread David Miller
From: Eric Biggers Date: Thu, 23 Mar 2017 13:39:46 -0700 > From: Eric Biggers > > In the generic XTS and LRW algorithms, for input data > 128 bytes, a > temporary buffer is allocated to hold the values to be XOR'ed with the > data before and after encryption or decryption. If the allocation >

Re: [PATCH] crypto: ixp4xx - Use sg_virt()

2017-03-23 Thread David Miller
From: Geliang Tang Date: Thu, 23 Mar 2017 21:16:30 +0800 > Use sg_virt() instead of open-coding it. > > Signed-off-by: Geliang Tang Acked-by: David S. Miller

Re: [PATCH v7 0/5] Update LZ4 compressor module

2017-02-09 Thread David Miller
that? Since in linux-kernel the patch >> seems to get delivered. >> I could otherwise CC you if you wish. >> > > If I'm not mistaken, David Miller is the admin of the mail server on > vger.kernel.org, and he already happens to be Cc'ed on this thread, so ma

Re: [sparc64] cryptomgr_test OOPS kernel 4.9.0+

2016-12-26 Thread David Miller
From: Anatoly Pugachev Date: Sun, 25 Dec 2016 20:56:08 +0300 > Disabling kernel config option > CRYPTO_MANAGER_DISABLE_TESTS > i.e. enable run-time self tests, makes kernel unbootable: > > tested with git kernels v4.9-8648-g5cc60aeedf31 and v4.9-12259-g7c0f6ba682b9 I think the testing code for

Re: [sparc64] cryptomgr_test OOPS kernel 4.9.0+

2016-12-26 Thread David Miller
From: Anatoly Pugachev Date: Sun, 25 Dec 2016 20:56:08 +0300 > Disabling kernel config option > CRYPTO_MANAGER_DISABLE_TESTS > i.e. enable run-time self tests, makes kernel unbootable: > > tested with git kernels v4.9-8648-g5cc60aeedf31 and v4.9-12259-g7c0f6ba682b9 I'm getting this with the cur

Re: [PATCH v2 3/4] secure_seq: use siphash24 instead of md5_transform

2016-12-14 Thread David Miller
From: "Jason A. Donenfeld" Date: Wed, 14 Dec 2016 13:53:10 +0100 > In all current uses of __packed in the code, I think the impact is > precisely zero, because all structures have members in descending > order of size, with each member being a perfect multiple of the one > below it. The __packed

Re: [PATCH net-next] cxgb4: Allocate Tx queues dynamically

2016-11-18 Thread David Miller
From: Atul Gupta Date: Fri, 18 Nov 2016 16:37:40 +0530 > From: Hariprasad Shenai > > Allocate resources dynamically for Upper layer driver's (ULD) like > cxgbit, iw_cxgb4, cxgb4i and chcr. The resources allocated include Tx > queues which are allocated when ULD register with cxgb4 driver and fr

Re: [PATCH] poly1305: generic C can be faster on chips with slow unaligned access

2016-11-03 Thread David Miller
From: "Jason A. Donenfeld" Date: Thu, 3 Nov 2016 08:24:57 +0100 > Hi Herbert, > > On Thu, Nov 3, 2016 at 1:49 AM, Herbert Xu > wrote: >> FWIW I'd rather live with a 6% slowdown than having two different >> code paths in the generic code. Anyone who cares about 6% would >> be much better off w

Re: [PATCH net-next] chcr/cxgb4i/cxgbit/RDMA/cxgb4: Allocate resources dynamically for all cxgb4 ULD's

2016-09-18 Thread David Miller
From: Hariprasad Shenai Date: Sat, 17 Sep 2016 08:12:39 +0530 > Allocate resources dynamically to cxgb4's Upper layer driver's(ULD) like > cxgbit, iw_cxgb4 and cxgb4i. Allocate resources when they register with > cxgb4 driver and free them while unregistering. All the queues and the > interrupts

Re: [PATCHv3 net-next 0/4] crypto/chcr: Add support for Chelsio Crypto Driver

2016-08-19 Thread David Miller
From: Herbert Xu Date: Fri, 19 Aug 2016 14:15:43 +0800 > On Thu, Aug 18, 2016 at 11:11:01PM -0700, David Miller wrote: >> From: Hariprasad Shenai >> Date: Wed, 17 Aug 2016 12:33:02 +0530 >> >> > This patch series adds support for Chelsio Crypto driver. >>

Re: [PATCHv3 net-next 0/4] crypto/chcr: Add support for Chelsio Crypto Driver

2016-08-18 Thread David Miller
From: Hariprasad Shenai Date: Wed, 17 Aug 2016 12:33:02 +0530 > This patch series adds support for Chelsio Crypto driver. Herbert, what do you want to do with this? I can push it via net-next if you like. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of

Re: AF_ALG broken?

2016-08-08 Thread David Miller
From: Russell King - ARM Linux Date: Mon, 8 Aug 2016 23:58:51 +0100 > I don't know, but this seems to go completely against Linus' no > userspace regressions, which seems to be an absolute requirement of > all kernel development... Linus flames people for arguing against > that rule! Reading the

Re: [Patch-V2 2/3] chcr: Support for Chelsio's Crypto Hardware

2016-07-19 Thread David Miller
From: Yeshaswi M R Gowda Date: Mon, 18 Jul 2016 22:42:14 -0700 > +config CRYPTO_DEV_CHELSIO > + tristate "Chelsio Crypto Co-processor Driver" > + depends on PCI && NETDEVICES && ETHERNET > + select CRYPTO_SHA1 > + select CRYPTO_SHA256 > + select CRYPTO_SHA512 > + select NE

Re: [sparc] niagara2 cpu, opcodes not available message?

2016-06-08 Thread David Miller
From: Anatoly Pugachev Date: Wed, 8 Jun 2016 20:30:40 +0300 > Can someone please tell, why do we get a bunch of the following > messages on niagara2 cpu hardware (SPARC Enterprise T5120, T5220, > T5140, and T5240 servers) > > Asking, because I see the following lines on kernel boot (removing > f

Re: [crypto / sparc64] cryptomgr_test OOPS

2016-05-06 Thread David Miller
From: Herbert Xu Date: Thu, 5 May 2016 16:42:49 +0800 > Subject: crypto: testmgr - Use kmalloc memory for RSA input > > As akcipher uses an SG interface, you must not use vmalloc memory > as input for it. This patch fixes testmgr to copy the vmalloc > test vectors to kmalloc memory before runni

  1   2   3   4   >