Re: [PATCH 0/3] crypto: marvell - Remove the old CESA driver

ho originally requested this transitioning time, Acked-by: Jason Cooper <ja...@lakedaemon.net> For the series. thx, Jason.

Re: [PATCH 0/4] hwrng: omap - fixes and improvements

P76 > hwrng: omap - move clock related code to omap_rng_probe() > > drivers/char/hw_random/omap-rng.c | 36 +--- > 1 file changed, 25 insertions(+), 11 deletions(-) For the whole series, Acked-by: Jason Cooper <ja...@lakedaemon.net> thx, Jason.

Re: [PATCH v3 6/8] hwrng: amd: Replace global variable with private struct

On Sat, Aug 27, 2016 at 02:43:31PM +, Jason Cooper wrote: > Hi Corentin, > > On Fri, Aug 26, 2016 at 01:11:34PM +0200, LABBE Corentin wrote: > > Instead of having two global variable, it's better to use a > > private struct. This will permit to remove amd_pdev variabl

Re: [PATCH v3 0/8] hwrng: amd: rework of the amd hwrng driver

32/iowrite32 > hwrng: amd: Convert to new hwrng read() API > > drivers/char/hw_random/amd-rng.c | 150 > +-- > 1 file changed, 96 insertions(+), 54 deletions(-) Once you've fixed up the casting in #6, you can add my Reviewed-by:

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

Hi Corentin, On Fri, Aug 26, 2016 at 10:38:02AM +0200, LABBE Corentin wrote: > On Thu, Aug 25, 2016 at 02:56:38PM +0000, Jason Cooper wrote: > > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > > > This patch convert the hwrng interface used by amd768-

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

Hi Corentin, On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > This patch convert the hwrng interface used by amd768-rng to its new API > by replacing data_read()/data_present() by read(). > > Furthermore, Instead of having two global variable, it's better to use a > private

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hey Ted, On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 02:04:44PM +0000, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > > disasterous because despite most drivers having a default quality of 0, &

Re: [PATCH 2/2] ath9k: disable RNG by default

On Thu, Aug 11, 2016 at 10:54:11AM +0800, miaoq...@codeaurora.org wrote: > On 2016-08-10 21:24, Jason Cooper wrote: > >The fact is, barring userspace expectations of /dev/hwrng, hw_random is > >the appropriate place for it. It's not a devicetree blob, mac address, > >or pci

Re: [PATCH 2/2] ath9k: disable RNG by default

Hi Miaoqing Pan, Stephen, *gentle reminder: others are reading which may not be directly included in the conversation. Including the archives. Please avoid top posting. :) On Wed, Aug 10, 2016 at 07:43:45AM +, Pan, Miaoqing wrote: > The problem with using the add_device_randomness is that

Re: [PATCH] hwrng: core - Allow for multiple simultaneous active hwrng devices

Hi Keith, On Tue, Aug 09, 2016 at 10:58:05AM -0700, Keith Packard wrote: > Jason Cooper <ja...@lakedaemon.net> writes: > > Perhaps a /dev/hwrng[0-9] per rng? That would lend itself nicely to a > > sysfs interface for per device quality, rate, and enabled attributes. > >

Re: [PATCH 2/2] ath9k: disable RNG by default

Hi Henrique, On Tue, Aug 09, 2016 at 07:24:58AM -0300, Henrique de Moraes Holschuh wrote: > On Tue, 09 Aug 2016, Stephan Mueller wrote: > > RHEL 7 and Fedora do not adjust it. So, shall we consider those rng-tools > > then > > broken (at least in those large distros)? > > Might I humbly

Re: [PATCH 2/2] ath9k: disable RNG by default

system without HW RNG, especially on embedded systems. > > Signed-off-by: Miaoqing Pan <miaoq...@codeaurora.org> Until we get the hw_random/get_device_randomness question sorted... Reviewed-by: Jason Cooper <ja...@lakedaemon.net> thx, Jason. -- To unsubscribe from this list:

Re: [PATCH] hwrng: core - Allow for multiple simultaneous active hwrng devices

Hi Keith, Herbert, On Tue, Aug 09, 2016 at 05:50:58PM +0800, Herbert Xu wrote: > On Mon, Jul 25, 2016 at 01:07:35PM -0700, Keith Packard wrote: > > Instead of having only one hwrng feeding /dev/random at a time, maintain > > a list of devices and cycle between them when filling the entropy pool.

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Ted, On Tue, Aug 09, 2016 at 07:56:22AM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > > Agree with Jason's point, also understand Stephan's concern. The > > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > > 1000', the

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Stephan, On Mon, Aug 08, 2016 at 05:29:30PM +, Jason Cooper wrote: > On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: ... > > If you think that this patch is a challenge because your driver starts to > > spin, please help and offer another solution. > &

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > The entropy was evaluated by crypto expert, the analysis report show the > > ADC with at least 10bits and up to 22 bits of min-entropy

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

Hi Stephan, On Sat, Aug 06, 2016 at 10:03:58PM +0200, Stephan Mueller wrote: > Am Samstag, 6. August 2016, 19:45:51 CEST schrieb Jason Cooper: > > On Fri, Aug 05, 2016 at 05:08:14PM +0200, Stephan Mueller wrote: ... > > > diff --git a/drivers/net/wireless/ath/ath9k/rng.c &

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

domness((void *)rng_buf, bytes_read, > -ATH9K_RNG_ENTROPY(bytes_read)); This is the only use of this macro. I'd remove the #define on line 25 as well. > + add_hwgenerator_randomness((void *)rng_buf, bytes_read, 0); > } > >

Re: [PATCH 1/7] A couple of generated files

Hey Sandy, I know we talked about this series offlist, but we need to fill in folks who are seeing it for the first time. Usually, this is done with a coverletter (--coverletter for git format-patch). No need to resend before receiving feedback, but would you mind replying with a description

Re: [PATCH 3/7] Initialise pools randomly if CONFIG_RANDOM_INIT=y

On Sat, Nov 07, 2015 at 09:30:38AM -0500, Sandy Harris wrote: > Signed-off-by: Sandy Harris > --- > drivers/char/random.c | 50 ++ > 1 file changed, 46 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/random.c

Re: [PATCH 1/7] A couple of generated files

On Sat, Nov 07, 2015 at 09:30:36AM -0500, Sandy Harris wrote: > Signed-off-by: Sandy Harris > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.gitignore b/.gitignore > index fd3a355..dd80bfd 100644 > --- a/.gitignore > +++ b/.gitignore > @@

Re: [PATCH 03/18] crypto: marvell: add flag to determine algorithm endianness

Hey Russell, On Sun, Oct 18, 2015 at 05:23:40PM +0100, Russell King wrote: > Rather than determining whether we're using a MD5 hash by looking at > the digest size, switch to a cleaner solution using a per-request flag > initialised by the method type. > > Signed-off-by: Russell King

Re: [PATCH 03/18] crypto: marvell: add flag to determine algorithm endianness

On Mon, Oct 19, 2015 at 04:25:07PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 03:04:51PM +0000, Jason Cooper wrote: > > Hey Russell, > > > > On Sun, Oct 18, 2015 at 05:23:40PM +0100, Russell King wrote: > > > static int mv_cesa_ahash_

Re: [PATCH v3 16/16] ARM: marvell/dt: add crypto node to kirkwood dtsi

On Tue, May 26, 2015 at 11:10:51AM +0200, Boris Brezillon wrote: On Tue, 26 May 2015 09:06:29 + Jason Cooper ja...@lakedaemon.net wrote: On Mon, May 25, 2015 at 08:43:02PM +0200, Boris Brezillon wrote: Jason, Gregory, On Mon, 25 May 2015 16:46:51 + Jason Cooper ja

Re: [PATCH v3 16/16] ARM: marvell/dt: add crypto node to kirkwood dtsi

On Mon, May 25, 2015 at 08:43:02PM +0200, Boris Brezillon wrote: Jason, Gregory, On Mon, 25 May 2015 16:46:51 + Jason Cooper ja...@lakedaemon.net wrote: On Mon, May 25, 2015 at 05:39:13PM +0200, Gregory CLEMENT wrote: Hi Boris, Arnaud, On 22/05/2015 15:34, Boris Brezillon

Re: [PATCH v3 16/16] ARM: marvell/dt: add crypto node to kirkwood dtsi

On Mon, May 25, 2015 at 05:39:13PM +0200, Gregory CLEMENT wrote: Hi Boris, Arnaud, On 22/05/2015 15:34, Boris Brezillon wrote: From: Arnaud Ebalard a...@natisbad.org Add crypto related nodes to kirkwood.dtsi. Here you use a new compatible string but with an old binding to let the

Re: [PATCH v3 0/2] crypto: add a new driver for Marvell's CESA

+ Jason Gunthorpe, he may be interested in this. On Fri, May 22, 2015 at 03:33:46PM +0200, Boris Brezillon wrote: Hello, This patch series adds a new driver supporting Marvell's CESA IP. This driver addresses some limitations of the existing one. From a performance and CPU load point of

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

Hey Boris, On Fri, Apr 17, 2015 at 10:39:46AM +0200, Boris Brezillon wrote: On Fri, 17 Apr 2015 10:33:56 +0200 Boris Brezillon boris.brezil...@free-electrons.com wrote: On Mon, 13 Apr 2015 20:11:46 + Jason Cooper ja...@lakedaemon.net wrote: I'd appreciate if we'd look

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

Hey Gregory, On Mon, Apr 13, 2015 at 11:39:16AM +0200, Gregory CLEMENT wrote: Hi Jason, Boris, On 11/04/2015 00:30, Jason Cooper wrote: Hey Boris, On Fri, Apr 10, 2015 at 05:11:48PM +0200, Boris Brezillon wrote: On Fri, 10 Apr 2015 13:50:56 + Jason Cooper ja...@lakedaemon.net

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

Hey Boris, On Fri, Apr 10, 2015 at 05:11:48PM +0200, Boris Brezillon wrote: On Fri, 10 Apr 2015 13:50:56 + Jason Cooper ja...@lakedaemon.net wrote: On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote: I know we usually try to adapt existing drivers instead of replacing them

Re: [PATCH] staging: crypto: fixed style errors in ablkcipher.c

Joshua, Your subject, [PATCH] staging: crypto: fixed style errors in ablkcipher.c is misleading. 'staging' is a location in the tree, drivers/staging/, not a separate git tree. So your subject for this series should have been [PATCH] crypto: ablkcipher: Cleanup minor checkpatch error. More

Re: [PATCH] staging: crypto: fixed style error in aead.c

Joshua, On Fri, Dec 05, 2014 at 02:24:44PM +0900, Joshua I. James wrote: From: Joshua I. James jos...@cybercrimetech.com Fixed style error identified by checkpatch. ERROR: do not use assignment in if condition + if ((err = crypto_register_instance(tmpl, inst))) { Short comment

Re: [PATCH] staging: crypto: fixed style error in af_alg.c

On Fri, Dec 05, 2014 at 02:38:40PM +0900, Joshua I. James wrote: From: Joshua I. James jos...@cybercrimetech.com Fixed style error identified by checkpatch. ERROR: space required before the open parenthesis '(' + switch(cmsg-cmsg_type) { Signed-off-by: Joshua I. James

Re: [PATCH] staging: crypto: fixed style error in ahash.c

On Fri, Dec 05, 2014 at 02:44:54PM +0900, Joshua I. James wrote: From: Joshua I. James jos...@cybercrimetech.com Fixed style error identified by checkpatch. WARNING: Missing a blank line after declarations + unsigned int unaligned = alignmask + 1 - (offset alignmask); +

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

together in one place? How do you suggest that is done? The API comments in the header file follow the Doxygen style. Note, Jason Cooper raised the concern that an API documentation separate from the code will surely deviate from the code relatively fast (although I do not really fear

Re: [PATCH] kernel crypto API interface specification

implementation. Original patch is here: https://lkml.kernel.org/r/7502136.9bkwhtz...@myon.chronox.de On Thu, Oct 16, 2014 at 09:19:08AM +0200, Stephan Mueller wrote: Am Mittwoch, 15. Oktober 2014, 13:58:00 schrieb Jason Cooper: Hi Jason, Stephan, Wow. This is very thorough

Re: [PATCH] kernel crypto API interface specification

On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote: + Grant, Geert, oops. It helps if I actually *add* them. Sorry for the noise. Stephan has created some great example code for both the kernel crypto API and the userspace crypto API. As examples tend to bitrot, I

Re: [PATCH] kernel crypto API interface specification

On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote: + Grant, Geert, Stephan has created some great example code for both the kernel crypto API and the userspace crypto API. As examples tend to bitrot, I was wondering if the code could serve as test code. Then it would have

Re: [PATCH] kernel crypto API interface specification

On Thu, Oct 16, 2014 at 06:50:58PM +0200, Stephan Mueller wrote: Am Donnerstag, 16. Oktober 2014, 11:06:05 schrieb Jason Cooper: Hi Jason, On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote: + Grant, Geert, Stephan has created some great example code for both the kernel

Re: [PATCH] kernel crypto API interface specification

Stephan, Wow. This is very thorough. Herbert and others will be making the final call on this, but if I may make a suggestion: On Tue, Oct 14, 2014 at 09:46:50PM +0200, Stephan Mueller wrote: The update adds a complete interface documentation of the kernel crypto API. All cipher types

Re: memset() in crypto code?

On Sat, Oct 04, 2014 at 11:09:40PM -0400, Sandy Harris wrote: There was recently a patch to the random driver to replace memset() because, according to the submitter, gcc sometimes optimises memset() away which might leave data unnecessarily exposed. The solution suggested was a function

Re: memset() in crypto code?

On Mon, Oct 06, 2014 at 01:59:06PM -0400, Sandy Harris wrote: On Mon, Oct 6, 2014 at 1:44 PM, Jason Cooper ja...@lakedaemon.net wrote: On Sat, Oct 04, 2014 at 11:09:40PM -0400, Sandy Harris wrote: There was recently a patch to the random driver to replace memset() because, according

Re: DMA support for mv_cesa

Muran, + free-electron's, mvebu maintainers On Mon, Jul 28, 2014 at 03:24:43PM +0200, Muran Hrun wrote: What is the status of DMA support for mv_cesa? I tried applying the patches at git://nwl.cc/~n0-1/linux.git (cesa-dma branch) on kernel 3.15.6 but the kernel just crashed on my DNS-320,

[PATCH] staging: crypto: skein: depend upon CRYPTO

this in the Kconfig by depending on CRYPTO. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/Kconfig b/drivers/staging/skein/Kconfig index

[PATCH V2 19/21] staging: crypto: skein: remove braces from single-statement block

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein

[PATCH V2 18/21] staging: crypto: skein: remove externs from .c files

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include

[PATCH V2 09/21] staging: crypto: skein: fixup pointer whitespace

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c

[PATCH V2 02/21] staging: crypto: skein: allow building statically

These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper ja...@lakedaemon.net --- Changes since

[PATCH V2 13/21] staging: crypto: skein: remove trailing whitespace

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein

[PATCH V2 04/21] staging: crypto: skein: remove skein_port.h

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions

[PATCH V2 06/21] staging: crypto: skein: remove unneeded typedefs

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6

[PATCH V2 15/21] staging: crypto: skein: fix do/while brace formatting

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers

[PATCH V2 21/21] staging: crypto: skein: add TODO file

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index

[PATCH V2 05/21] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers

[PATCH V2 00/21] staging: add skein/threefish crypto algos

like the adhoc macro definitions, nor the camelCase. The plan is to get skein and threefish registered into the crypto API, build as modules, and then move it to crypto/. thx, Jason. Jason Cooper (21): staging: crypto: skein: import code from Skein3Fish.git staging: crypto: skein: allow

[PATCH V2 03/21] staging: crypto: skein: remove brg_*.h includes

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions

[PATCH V2 17/21] staging: crypto: skein: wrap multi-line macros in do-while loops

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3

[PATCH V2 16/21] staging: crypto: skein: fix brace placement errors

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132

[PATCH V2 07/21] staging: crypto: skein: remove all typedef {struct,enum}

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c

[PATCH V2 08/21] staging: crypto: skein: use u8, u64 vice uint*_t

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

On Tue, Mar 18, 2014 at 02:28:20PM +, Greg KH wrote: On Tue, Mar 18, 2014 at 08:58:49AM -0400, Jason Cooper wrote: On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: These are the minimum changes required to get

[PATCH V3 02/21] staging: crypto: skein: allow building statically

These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper ja...@lakedaemon.net --- Changes since

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future

Re: [RFC PATCH 00/22] staging: add skein/threefish crypto algos

On Tue, Mar 11, 2014 at 09:32:32PM +, Jason Cooper wrote: To facilitate tinkering with this, One can pull from the following: git://git.infradead.org/users/jcooper/linux.git tags/staging-skein-3.14-rc1 This is based on v3.14-rc1, and is prone to rebasing based on comments. Hmmm

[RFC PATCH 00/22] staging: add skein/threefish crypto algos

based on comments. thx, Jason. Jason Cooper (22): scripts: objdiff: detect object code changes between two commits staging: crypto: skein: import code from Skein3Fish.git staging: crypto: skein: allow building statically staging: crypto: skein: remove brg_*.h includes staging: crypto

[RFC PATCH 01/22] scripts: objdiff: detect object code changes between two commits

values as diff(1). This was written specifically to support adding the skein and threefish cryto drivers to the staging tree. I needed a programmatic way to confirm that commits changing 90% of the lines didn't inadvertently change the code. Signed-off-by: Jason Cooper ja...@lakedaemon.net

[RFC PATCH 03/22] staging: crypto: skein: allow building statically

These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers

[RFC PATCH 16/22] staging: crypto: skein: fix do/while brace formatting

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers

[RFC PATCH 18/22] staging: crypto: skein: wrap multi-line macros in do-while loops

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3

[RFC PATCH 17/22] staging: crypto: skein: fix brace placement errors

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132

[RFC PATCH 10/22] staging: crypto: skein: fixup pointer whitespace

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c

[RFC PATCH 22/22] staging: crypto: skein: add TODO file

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index

[RFC PATCH 07/22] staging: crypto: skein: remove unneeded typedefs

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6

[RFC PATCH 04/22] staging: crypto: skein: remove brg_*.h includes

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions

[RFC PATCH 08/22] staging: crypto: skein: remove all typedef {struct,enum}

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c

[RFC PATCH 06/22] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers

[RFC PATCH 05/22] staging: crypto: skein: remove skein_port.h

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions

[RFC PATCH 14/22] staging: crypto: skein: remove trailing whitespace

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein

[RFC PATCH 20/22] staging: crypto: skein: remove braces from single-statement block

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein

[RFC PATCH 19/22] staging: crypto: skein: remove externs from .c files

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include

[RFC PATCH 21/22] staging: crypto: skein: remove unnecessary line continuation

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging

[RFC PATCH 09/22] staging: crypto: skein: use u8, u64 vice uint*_t

Signed-off-by: Jason Cooper ja...@lakedaemon.net --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

On Wed, Mar 05, 2014 at 06:52:27PM -0600, Matt Mackall wrote: On Wed, 2014-03-05 at 16:11 -0500, Jason Cooper wrote: In other words, if there are 4096 bits of unknownness in X to start with, and I can get those same 4096 bits of unknownness back by unmixing X' and Y, then there must

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

. Signed-off-by: Kees Cook keesc...@chromium.org --- drivers/char/hw_random/core.c |7 +++ 1 file changed, 7 insertions(+) fwiw, Reviewed-by: Jason Cooper ja...@lakedaemon.net thx, Jason. diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index a0f7724852eb

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

Matt, Kees, On Tue, Mar 04, 2014 at 04:39:57PM -0600, Matt Mackall wrote: On Tue, 2014-03-04 at 11:59 -0800, Kees Cook wrote: On Tue, Mar 4, 2014 at 11:53 AM, Jason Cooper ja...@lakedaemon.net wrote: On Tue, Mar 04, 2014 at 11:01:49AM -0800, Kees Cook wrote: On Tue, Mar 4, 2014 at 7:38

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

Kees, Ted, On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: When bringing a new RNG source online, it seems like it would make sense to use some of its bytes to make the system entropy pool more random, as done with all sorts of other devices that contain per-device or per-boot

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

On Tue, Mar 04, 2014 at 11:01:49AM -0800, Kees Cook wrote: On Tue, Mar 4, 2014 at 7:38 AM, Jason Cooper ja...@lakedaemon.net wrote: Kees, Ted, On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: When bringing a new RNG source online, it seems like it would make sense to use some

Re: [PATCH] Crypto: CESA: Add support for DT based instantiation.

On Mon, Sep 03, 2012 at 08:29:34PM +0200, Andrew Lunn wrote: Based on work by Michael Waller and Jason Cooper. Added support for getting the interrupt number and address of SRAM from DT. Signed-off-by: Andrew Lunn and...@lunn.ch Applied to: git://git.infradead.org/users/jcooper/linux.git

Re: [PATCH] Crypto: CESA: Add support for DT based instantiation.

On Mon, Sep 03, 2012 at 08:29:34PM +0200, Andrew Lunn wrote: Based on work by Michael Waller and Jason Cooper. nit. Michael Walle If nothing significant crops up in the next few days, I'll fix it when I pull it in. thx, Jason. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote: Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next) ARM: kirkwood: mv_cesa devicetree bindings fails to compile as follows: CC drivers/crypto/mv_cesa.o drivers/crypto/mv_cesa.c:1139: error: implicit