Re: drivers/char/random.c needs a (new) maintainer

2020-12-18 Thread Marcelo Henrique Cerri
Hi, Ted and Jason. Any updates on that? I don't believe Torsten's concerns are simply about *applying* patches but more about these long periods of radio silence. That kills collaboration and disengage people. More than simply reviewing patches I would expect a maintainer to give directions and d

Re: [PATCH v36 00/13] /dev/random - a new approach

2020-11-04 Thread Marcelo Henrique Cerri
On Mon, Nov 02, 2020 at 02:44:35PM +0100, Torsten Duwe wrote: > On Wed, 28 Oct 2020 19:07:28 +0100 > Greg Kroah-Hartman wrote: > > > On Wed, Oct 28, 2020 at 06:51:17PM +0100, Torsten Duwe wrote: > > > On Mon, 19 Oct 2020 21:28:50 +0200 > > > Stephan Müller wrote: > > > [...] > > > > * Sole use o

Re: [PATCH v3 0/5] DH: SP800-56A rev 3 compliant validation checks

2020-07-21 Thread Marcelo Henrique Cerri
Reviewed-by: Marcelo Henrique Cerri Tested-by: Marcelo Henrique Cerri On Mon, Jul 20, 2020 at 07:05:45PM +0200, Stephan Müller wrote: > Hi, > > This patch set adds the required checks to make all aspects of > (EC)DH compliant with SP800-56A rev 3 assuming that all keys > are eph

Re: [PATCH v2 2/5] lib/mpi: Add mpi_sub_ui()

2020-07-16 Thread Marcelo Henrique Cerri
On Thu, Jul 16, 2020 at 05:37:32PM +0300, Ard Biesheuvel wrote: > On Thu, 16 Jul 2020 at 17:23, Marcelo Henrique Cerri > wrote: > > > > On Thu, Jul 16, 2020 at 04:53:24PM +0300, Ard Biesheuvel wrote: > > > On Thu, 16 Jul 2020 at 16:41, Marcelo Henrique Cerri > >

Re: [PATCH v2 2/5] lib/mpi: Add mpi_sub_ui()

2020-07-16 Thread Marcelo Henrique Cerri
On Thu, Jul 16, 2020 at 04:53:24PM +0300, Ard Biesheuvel wrote: > On Thu, 16 Jul 2020 at 16:41, Marcelo Henrique Cerri > wrote: > > > > On Thu, Jul 16, 2020 at 04:09:39PM +0300, Ard Biesheuvel wrote: > > > On Thu, 16 Jul 2020 at 15:50, Marcelo Henrique Cerri > >

Re: [PATCH v2 2/5] lib/mpi: Add mpi_sub_ui()

2020-07-16 Thread Marcelo Henrique Cerri
On Thu, Jul 16, 2020 at 04:09:39PM +0300, Ard Biesheuvel wrote: > On Thu, 16 Jul 2020 at 15:50, Marcelo Henrique Cerri > wrote: > > > > No. The code is really based on Gnu MP. I used the header from > > lib/mpi/mpi-pow.c as reference and that's source of the m

Re: [PATCH v2 2/5] lib/mpi: Add mpi_sub_ui()

2020-07-16 Thread Marcelo Henrique Cerri
No. The code is really based on Gnu MP. I used the header from lib/mpi/mpi-pow.c as reference and that's source of the mention to GnuPG that went unnoticed by me. You can find the original Gnu MP source that I used as reference in the file gmp-6.2.0/mpz/aors_ui.h from: https://gmplib.org/download

Re: [PATCH v2 5/5] crypto: ECDH SP800-56A rev 3 local public key validation

2020-07-15 Thread Marcelo Henrique Cerri
Reviewed-by: Marcelo Henrique Cerri Tested-by: Marcelo Henrique Cerri On Sun, Jul 12, 2020 at 06:42:14PM +0200, Stephan Müller wrote: > After the generation of a local public key, SP800-56A rev 3 section > 5.6.2.1.3 mandates a validation of that key with a full validation > compliant t

Re: [PATCH v2 4/5] crypto: DH SP800-56A rev 3 local public key validation

2020-07-15 Thread Marcelo Henrique Cerri
Reviewed-by: Marcelo Henrique Cerri Tested-by: Marcelo Henrique Cerri On Sun, Jul 12, 2020 at 06:40:57PM +0200, Stephan Müller wrote: > After the generation of a local public key, SP800-56A rev 3 section > 5.6.2.1.3 mandates a validation of that key with a full validation > compliant t

Re: [PATCH v2 3/5] crypto: DH - check validity of Z before export

2020-07-15 Thread Marcelo Henrique Cerri
Reviewed-by: Marcelo Henrique Cerri Tested-by: Marcelo Henrique Cerri On Sun, Jul 12, 2020 at 06:40:20PM +0200, Stephan Müller wrote: > SP800-56A rev3 section 5.7.1.1 step 2 mandates that the validity of the > calculated shared secret is verified before the data is returned to the &g

Re: [PATCH v2 1/5] crypto: ECDH - check validity of Z before export

2020-07-15 Thread Marcelo Henrique Cerri
Reviewed-by: Marcelo Henrique Cerri Tested-by: Marcelo Henrique Cerri On Sun, Jul 12, 2020 at 06:39:26PM +0200, Stephan Müller wrote: > SP800-56A rev3 section 5.7.1.2 step 2 mandates that the validity of the > calculated shared secret is verified before the data is returned to the &g

Re: [PATCH v5 2/8] lib/mpi: Extend the MPI library

2020-07-10 Thread Marcelo Henrique Cerri
Hi, Tianjia. On Thu, Jul 09, 2020 at 04:40:09PM +0800, Tianjia Zhang wrote: > Expand the mpi library based on libgcrypt, and the ECC algorithm of > mpi based on libgcrypt requires these functions. > Some other algorithms will be developed based on mpi ecc, such as SM2. > > Signed-off-by: Tianjia

Re: [PATCH v2] crypto: vmx - Fix sleep-in-atomic bugs

2018-08-22 Thread Marcelo Henrique Cerri
That looks good to me. Maybe Paulo can help testing it. -- Regards, Marcelo On Wed, Aug 22, 2018 at 08:26:31AM +0200, Ondrej Mosnacek wrote: > This patch fixes sleep-in-atomic bugs in AES-CBC and AES-XTS VMX > implementations. The problem is that the blkcipher_* functions should > not be called

Re: [PATCH] crypto: vmx - Fix sleep-in-atomic bugs

2018-08-21 Thread Marcelo Henrique Cerri
On Tue, Aug 21, 2018 at 05:24:45PM +0200, Ondrej Mosnáček wrote: > CC: Paulo Flabiano Smorigo , > linuxppc-...@lists.ozlabs.org > > (Sorry, sent this before reading new e-mails in the thread...) > > ut 21. 8. 2018 o 17:18 Ondrej Mosnacek napísal(a): > > > > This patch fixes sleep-in-atomic bugs

Re: BUG: libkcapi tests trigger sleep-in-atomic bug in VMX code (ppc64)

2018-08-21 Thread Marcelo Henrique Cerri
CC: Paulo Flabiano Smorigo Yes, I do believe that CTR is doing it right. Preemption only needs to be disabled during the aes_p8_cbc_encrypt() call, to avoid trashing the VSX registers during the AES operation. -- Regards, Marcelo On Tue, Aug 21, 2018 at 05:03:50PM +0200, Christophe LEROY wrote

[PATCH] crypto: testmgr - mark ctr(des3_ede) as fips_allowed

2017-03-20 Thread Marcelo Henrique Cerri
3DES is missing the fips_allowed flag for CTR mode. Signed-off-by: Marcelo Henrique Cerri --- crypto/testmgr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/crypto/testmgr.c b/crypto/testmgr.c index 89f1dd1f4b13..cd075c7d8ee1 100644 --- a/crypto/testmgr.c +++ b/crypto/testmgr.c @@ -2645,6

[PATCH v2 2/2] crypto: ctr - Propagate NEED_FALLBACK bit

2017-02-27 Thread Marcelo Henrique Cerri
when calling the fallback implementation: p8_aes_ctr -> ctr(p8_aes) -> aes-generic However p8_aes will always delegate its calls to aes-generic. With this patch, p8_aes_ctr will be able to use ctr(aes-generic) directly as its fallback. The same applies to aes_s390. Signed-off-by: Marcelo He

[PATCH v2 0/2] Propagate fallback bit for cbc and ctr

2017-02-27 Thread Marcelo Henrique Cerri
Hi Hebert, For v2: - fixed the memory leakage in cbc. - included crypto/algapi.h in crypto/cbc.c for crypto_requires_off(); - ERR_CAST instead PTR_ERR in ctr. - Also propagated the fallback bit for rfc3686. Marcelo Henrique Cerri (2): crypto: cbc - Propagate NEED_FALLBACK bit crypto: ctr

[PATCH v2 1/2] crypto: cbc - Propagate NEED_FALLBACK bit

2017-02-27 Thread Marcelo Henrique Cerri
when calling the fallback implementation: p8_aes_cbc -> cbc(p8_aes) -> aes-generic However p8_aes will always delegate its calls to aes-generic. With this patch, p8_aes_cbc will be able to use cbc(aes-generic) directly as its fallback. The same applies to aes_s390. Signed-off-by: Marcelo He

[PATCH 2/2] crypto: ctr - Propagate NEED_FALLBACK bit

2017-02-26 Thread Marcelo Henrique Cerri
when calling the fallback implementation: p8_aes_ctr -> ctr(p8_aes) -> aes-generic However p8_aes will always delegate its calls to aes-generic. With this patch, p8_aes_ctr will be able to use ctr(aes-generic) directly as its fallback. The same applies to aes_s390. Signed-off-by: Marcelo He

[PATCH 1/2] crypto: cbc - Propagate NEED_FALLBACK bit

2017-02-26 Thread Marcelo Henrique Cerri
when calling the fallback implementation: p8_aes_cbc -> cbc(p8_aes) -> aes-generic However p8_aes will always delegate its calls to aes-generic. With this patch, p8_aes_cbc will be able to use cbc(aes-generic) directly as its fallback. The same applies to aes_s390. Signed-off-by: Marcelo He

[PATCH 0/2] Propagate fallback bit for cbc and ctr

2017-02-26 Thread Marcelo Henrique Cerri
uot;cbc(p8_aes)" and "ctr(p8_aes)". If you are ok with those changes, I can convert the remaining templates. Marcelo Henrique Cerri (2): crypto: cbc - Propagate NEED_FALLBACK bit crypto: ctr - Propagate NEED_FALLBACK bit crypto/cbc.c | 20 ++-- crypto/ctr.c