Re: Q for a new API for the random device driver

Hi Herald, On 6 June 2018 at 18:18, Harald Freudenberger wrote: > Hello Theodore, hi Linux Community > > my patch for the s390 arch_get_random_seed* implementation is about to > be integrated with the current merge window for kernel 4.18. > > So I'd like to start a discussion about a new API for

Re: [PATCH v3 3/4] crypto: jz4780-rng: Add RNG node to jz4780.dtsi

Hi Rob, On 6 March 2018 at 19:25, Rob Herring <robh...@kernel.org> wrote: > On Tue, Mar 6, 2018 at 3:32 AM, James Hogan <jho...@kernel.org> wrote: >> On Mon, Sep 18, 2017 at 07:32:40PM +0530, PrasannaKumar Muralidharan wrote: >>> Add RNG node to jz4780 dt

Re: [PATCH v3 3/4] crypto: jz4780-rng: Add RNG node to jz4780.dtsi

Hi Paul, On 7 March 2018 at 04:31, Paul Cercueil <p...@crapouillou.net> wrote: > Le 2018-03-06 10:32, James Hogan a écrit : >> >> On Mon, Sep 18, 2017 at 07:32:40PM +0530, PrasannaKumar Muralidharan >> wrote: >>> >>> Add RNG node to jz4780 d

Re: [PATCH v2] tpm: Move Linux RNG connection to hwrng

Hi Jarkko, On 17 November 2017 at 19:27, Jarkko Sakkinen wrote: > On Fri, Nov 17, 2017 at 03:28:53PM +0200, Jarkko Sakkinen wrote: > > At least signed-off-by from PrassanaKumar is missing from the 2nd > commit. I'll add it. I had the impression that my

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

Hi Jarkko, On 18 January 2018 at 21:50, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Wed, Jan 17, 2018 at 07:43:51PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Jarkko, >> >> On 14 November 2017 at 20:02, Jarkko Sakkinen >> <jarkko.sakki...

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

Hi Jarkko, On 14 November 2017 at 20:02, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Sun, Nov 12, 2017 at 10:53:35AM +0530, PrasannaKumar Muralidharan wrote: >> Did basic check on tpm rng patch, it works fine. As it depends on this >> patch this shoul

Re: [PATCH] [RFT] crypto: aes-generic - turn off -ftree-pre and -ftree-sra

Hi Ard, On 21 December 2017 at 17:52, Ard Biesheuvel wrote: > On 21 December 2017 at 10:20, Arnd Bergmann wrote: >> On Wed, Dec 20, 2017 at 10:46 PM, Jakub Jelinek wrote: >>> On Wed, Dec 20, 2017 at 09:52:05PM +0100, Arnd Bergmann

Re: [PATCH v2] hwrng: Clean up RNG list when last hwrng is unregistered

On 17 December 2017 at 14:53, PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> wrote: > Hi Gary, > > Some minor comments below. > > On 16 December 2017 at 01:25, Gary R Hook <gary.h...@amd.com> wrote: >> >> Commit 142a27f0a731 added support for a &q

Re: [PATCH v2] hwrng: Clean up RNG list when last hwrng is unregistered

Hi Gary, Some minor comments below. On 16 December 2017 at 01:25, Gary R Hook wrote: > > Commit 142a27f0a731 added support for a "best" RNG, and in doing so > introduced a hang from rmmod/modprobe -r when the last RNG on the list > was unloaded. Nice catch. Thanks for fixing

Re: [PATCH v2 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

t; +static int __maybe_unused exynos_trng_resume(struct device *dev) > +{ > + int ret; > + > + ret = pm_runtime_get_sync(dev); > + if (ret < 0) { > + dev_err(dev, "Could not get runtime PM.\n"); > + pm_runtime_put_noidle(dev); > + return ret; > + } > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(exynos_trng_pm_ops, exynos_trng_suspend, > +exynos_trng_resume); > + > +static const struct of_device_id exynos_trng_dt_match[] = { > + { > + .compatible = "samsung,exynos5250-trng", > + }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, exynos_rng_dt_match); > + > +static struct platform_driver exynos_trng_driver = { > + .driver = { > + .name = "exynos-trng", > + .pm = _trng_pm_ops, > + .of_match_table = exynos_trng_dt_match, > + }, > + .probe = exynos_trng_probe, > + .remove = exynos_trng_remove, > +}; > + > +module_platform_driver(exynos_trng_driver); > +MODULE_AUTHOR("Łukasz Stelmach"); > +MODULE_DESCRIPTION("H/W TRNG driver for Exynos chips"); > +MODULE_LICENSE("GPL"); > -- > 2.11.0 > Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> Regards, PrasannaKumar

Re: [PATCH v3 0/4] crypto: Add driver for JZ4780 PRNG

Hi Ralf, On 12 October 2017 at 22:59, PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> wrote: > Hi Herbert, > > On 12 October 2017 at 20:00, Herbert Xu <herb...@gondor.apana.org.au> wrote: >> On Mon, Sep 18, 2017 at 07:32:37PM +0530, PrasannaKumar Muralidharan w

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

On 24 November 2017 at 20:55, PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> wrote: > Hi Lukasz, > > Some minor comments below. > > On 23 November 2017 at 20:39, Łukasz Stelmach <l.stelm...@samsung.com> wrote: >> Add support for True Random Number Generato

Re: [PATCH 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

Hi Lukasz, Some minor comments below. On 23 November 2017 at 20:39, Łukasz Stelmach wrote: > Add support for True Random Number Generator found in Samsung Exynos > 5250+ SoCs. > > Signed-off-by: Łukasz Stelmach > --- > MAINTAINERS

Re: [PATCH] crypto: hifn_795x - Fix a memory leak in the error handling path of 'hifn_probe()'

r_out_free_regions: > pci_release_regions(pdev); > -- > 2.14.1 > Nice catch. Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> Regards, PrasannaKumar

Re: [PATCH] Fix NULL pointer deref. on no default_rng

rity strength of 256. > */ > if (crypto_get_default_rng()) > - err = -EFAULT; > + return -EFAULT; > > err = crypto_rng_get_bytes(crypto_default_rng, (u8 *)priv, nbytes); > crypto_put_default_rng(); > -- > 2.15.0

Re: PATCH : Fix NULL pointer dereference on no default_rng

Would you mind sending the patch using 'git send-email'? Kernel community does not accept attachments. Regards, PrasannaKumar

Re: [PATCH v2] tpm: Move Linux RNG connection to hwrng

Hi Jason, On 9 November 2017 at 21:59, Jason Gunthorpe <j...@ziepe.ca> wrote: > On Thu, Nov 09, 2017 at 09:49:33PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Jason, >> >> On 7 November 2017 at 21:34, Jason Gunthorpe <j...@ziepe.ca> wrote: >> >

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

Did basic check on tpm rng patch, it works fine. As it depends on this patch this should be working fine too. Tested-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> Regards, PrasannaKumar

Re: [PATCH v2] tpm: Move Linux RNG connection to hwrng

Hi Jason, On 7 November 2017 at 21:34, Jason Gunthorpe <j...@ziepe.ca> wrote: > On Tue, Nov 07, 2017 at 08:50:44AM +0530, PrasannaKumar Muralidharan wrote: > >> I am assuming you are talking about the following patches - using >> struct tpm_chip instead of chip number

Re: [PATCH v2] tpm: Move Linux RNG connection to hwrng

Hi Jason, On 6 November 2017 at 07:57, Jason Gunthorpe wrote: > On Sun, Nov 05, 2017 at 01:05:06PM +0200, Jarkko Sakkinen wrote: > >> I asked to create a series for a reason. Now this doesn't apply because I >> don't have an ancestor in my git history. > > It would be unusual for

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

Hi Herbert, On 6 November 2017 at 12:39, Herbert Xu wrote: > On Fri, Nov 03, 2017 at 09:57:21AM +, Jim Quigley wrote: >> moved the call to hwrng_register() out of the probe routine into the scan >> routine. We need to call hwrng_register() after a suspend/restore

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

Hi Jim, Have second thoughts on this. On 3 November 2017 at 20:55, PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> wrote: >> >> It would be cleaner to just get rid of probe_common() altogether in that >> case, and do whatever >> needs to be done in v

Fwd: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

Did reply instead of reply all. Forwarding my previous message. -- Forwarded message -- From: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> Date: 3 November 2017 at 20:19 Subject: Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume T

Re: virtio:rng: Virtio RNG devices need to be re-registered after suspend/resume

Hi Jim, On 3 November 2017 at 15:27, Jim Quigley wrote: > The patch for > > commit: 5c06273401f2eb7b290cadbae18ee00f8f65e893 > Author: Amit Shah > Date: Sun Jul 27 07:34:01 2014 +0930 > > virtio: rng: delay hwrng_register() till driver is

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

Hi Harald, On 30 October 2017 at 18:58, Harald Freudenberger <fre...@linux.vnet.ibm.com> wrote: > On 10/27/2017 07:04 PM, PrasannaKumar Muralidharan wrote: >> User is able to select a chosen rng by writing its name to rng_current >> but there is no way to reset it without u

Re: [PATCH] hw_random: core: Remove unnecessary new line in MODULE_PARM_DESC

Hi Herbert, On 30 October 2017 at 12:23, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Thu, Oct 26, 2017 at 10:00:29PM +0530, PrasannaKumar Muralidharan wrote: >> While using MODULE_PARM_DESC there is a new line which is not required. >> Remove it. >> >

Re: [PATCH] hw_random: Include device.h instead of declaring struct device

Hi Herbert, On 30 October 2017 at 12:22, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote: >> Include linux/device.h instead of declaring struct device. >> >> Signed-off-by: PrasannaKumar

Re: [PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

Hi Harald, On 30 October 2017 at 13:40, Harald Freudenberger wrote: > That's a really good idea. I also thought about something like that. Do you mind reviewing the code? Thanks, PrasannaKumar

[PATCH] hw_random: core: Reset user selected rng by writing "" to rng_current

User is able to select a chosen rng by writing its name to rng_current but there is no way to reset it without unbinding the rng. Let user write "" to rng_current and delesect the chosen rng. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/

Re: [PATCH 0/4] Rearrange functions to remove forward declarations

Hi David, On 26 October 2017 at 22:18, David Daney <dda...@caviumnetworks.com> wrote: > On 10/26/2017 08:34 AM, PrasannaKumar Muralidharan wrote: >> >> This patch series rearranges functions such that forward declarations >> becomes unnecessary. Remove those for

[PATCH] hw_random: core: Remove unnecessary new line in MODULE_PARM_DESC

While using MODULE_PARM_DESC there is a new line which is not required. Remove it. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/core.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/char/hw_random/co

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

On 26 October 2017 at 21:39, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Thu, Oct 26, 2017 at 07:40:49PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Jarkko, >> >> On 26 October 2017 at 19:24, Jarkko Sakkinen >> <jarkko.sakki...@linux.

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

On 26 October 2017 at 00:41, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Wed, Oct 25, 2017 at 08:21:16PM +0530, PrasannaKumar Muralidharan wrote: >> >> > 2. Moving struct tpm_rng to the TPM client is architecturally >> >> >uacceptabl

[PATCH 4/4] hw_random: core: Remove forward declaration of hwrng_init

Rearrange set_current_rng such that hwrng_init's forward declaration can be removed. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/core.c | 34 -- 1 file changed, 16 insertions(+), 18 deletions(-) diff

[PATCH 2/4] hw_random: core: Rearranging rng_get_data to remove forward declaration

Rearrange rng_get_data such that its forward declaration is not required. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/core.c | 41 +++-- 1 file changed, 19 insertions(+), 22 deletions(-) diff

[PATCH 1/4] hw_random: core: Remove forward declaration by rearranging code

Rearrange drop_current_rng such that its forward declaration is not required. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/core.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/driver

[PATCH 3/4] hw_random: core: Rearranging start_khwrngd to remove forward declaration

Rearrange start_khwrngd such that its forward declaration is not required. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/core.c | 75 +-- 1 file changed, 37 insertions(+), 38 deletions(-) diff

[PATCH 0/4] Rearrange functions to remove forward declarations

This patch series rearranges functions such that forward declarations becomes unnecessary. Remove those forward declaration. This patch series is boot tested without user space in qemu with CONFIG_HW_RANDOM=y. PrasannaKumar Muralidharan (4): hw_random: core: Remove forward declaration

Re: [PATCH v3] tpm: use struct tpm_chip for tpm_chip_find_get()

tpm2 = tpm_is_tpm2(TPM_ANY_NUM); > + tpm2 = tpm_is_tpm2(NULL); > if (tpm2 < 0) > return tpm2; > > @@ -917,7 +916,7 @@ static struct trusted_key_options > *trusted_options_alloc(void) > struct trusted_key_options *options; > int tpm2; > > - tpm2 = tpm_is_tpm2(TPM_ANY_NUM); > + tpm2 = tpm_is_tpm2(NULL); > if (tpm2 < 0) > return NULL; > > @@ -967,7 +966,7 @@ static int trusted_instantiate(struct key *key, > size_t key_len; > int tpm2; > > - tpm2 = tpm_is_tpm2(TPM_ANY_NUM); > + tpm2 = tpm_is_tpm2(NULL); > if (tpm2 < 0) > return tpm2; > > @@ -1008,7 +1007,7 @@ static int trusted_instantiate(struct key *key, > switch (key_cmd) { > case Opt_load: > if (tpm2) > - ret = tpm_unseal_trusted(TPM_ANY_NUM, payload, > options); > + ret = tpm_unseal_trusted(NULL, payload, options); > else > ret = key_unseal(payload, options); > dump_payload(payload); > @@ -1018,13 +1017,13 @@ static int trusted_instantiate(struct key *key, > break; > case Opt_new: > key_len = payload->key_len; > - ret = tpm_get_random(TPM_ANY_NUM, payload->key, key_len); > + ret = tpm_get_random(NULL, payload->key, key_len); > if (ret != key_len) { > pr_info("trusted_key: key_create failed (%d)\n", ret); > goto out; > } > if (tpm2) > - ret = tpm_seal_trusted(TPM_ANY_NUM, payload, options); > + ret = tpm_seal_trusted(NULL, payload, options); > else > ret = key_seal(payload, options); > if (ret < 0) > -- > 2.14.1 > Looks good to me. FWIW, Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com>. Regards, PrasannaKumar

[PATCH] hw_random: Include device.h instead of declaring struct device

Include linux/device.h instead of declaring struct device. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- include/linux/hw_random.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/hw_random.h b/include/linux/hw_random.h

Re: [PATCH] tpm: Move Linux RNG connection to hwrng

Hi Jason, On 25 October 2017 at 20:48, Jason Gunthorpe <jguntho...@obsidianresearch.com> wrote: > On Wed, Oct 25, 2017 at 08:15:09PM +0530, PrasannaKumar Muralidharan > wrote: > >> > +static int tpm_add_hwrng(struct tpm_chip *chip) >> > +{ >> > +

Re: [PATCH v2] tpm: use struct tpm_chip for tpm_chip_find_get()

Hi Jarkko, On 25 October 2017 at 17:25, Jarkko Sakkinen wrote: > Device number (the character device index) is not a stable identifier > for a TPM chip. That is the reason why every call site passes > TPM_ANY_NUM to tpm_chip_find_get(). > > This commit changes

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

Hi Jarkko, On 24 October 2017 at 23:52, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Tue, Oct 24, 2017 at 10:05:20PM +0530, PrasannaKumar Muralidharan wrote: >> > 1. Every user in the kernel is using TPM_ANY_NUM, which means there are >> >no ot

Re: [PATCH] tpm: Move Linux RNG connection to hwrng

for each TPM. This will > cause the kernel to read entropy from the TPM when it is plugged in, > and allow access to the TPM rng via /dev/hwrng. > > Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> > Signed-off-by: Jason Gunthorpe <jguntho...@obsidianresearch.com>

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

Hi Jason, On 24 October 2017 at 23:16, Jason Gunthorpe <jguntho...@obsidianresearch.com> wrote: > On Tue, Oct 24, 2017 at 09:44:30PM +0530, PrasannaKumar Muralidharan wrote: > >> I am wondering why it is wrong. Isn't the chip id valid till it is >> unregistered? If so th

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

On 24 October 2017 at 23:07, Jason Gunthorpe wrote: > On Tue, Oct 24, 2017 at 10:02:00AM -0700, Dmitry Torokhov wrote: >> tpm-rng is abomination that should be kicked out as soon as possible. >> It wrecks havoc with the power management (TPM chip drivers may go >>

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

On 24 October 2017 at 21:53, Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> wrote: > On Tue, Oct 24, 2017 at 09:21:15PM +0530, PrasannaKumar Muralidharan wrote: >> On 24 October 2017 at 21:14, Jarkko Sakkinen >> <jarkko.sakki...@linux.intel.com> wrote: >> >

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

On 24 October 2017 at 21:41, Jason Gunthorpe <jguntho...@obsidianresearch.com> wrote: > On Tue, Oct 24, 2017 at 09:37:33PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Jason, >> >> On 24 October 2017 at 21:25, Jason Gunthorpe >> <jguntho...@obsidianresearch.c

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

Hi Jason, On 24 October 2017 at 21:25, Jason Gunthorpe <jguntho...@obsidianresearch.com> wrote: > On Tue, Oct 24, 2017 at 09:21:15PM +0530, PrasannaKumar Muralidharan wrote: > >> Please check the RFC [1]. It does use chip id. The rfc has issues and >> has to be fix

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

On 24 October 2017 at 21:14, Jarkko Sakkinen wrote: > On Mon, Oct 23, 2017 at 10:31:39AM -0600, Jason Gunthorpe wrote: >> On Mon, Oct 23, 2017 at 10:07:31AM -0400, Stefan Berger wrote: >> >> > >-int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash) >> >

Re: [PATCH v3 0/4] crypto: Add driver for JZ4780 PRNG

Hi Herbert, On 12 October 2017 at 20:00, Herbert Xu <herb...@gondor.apana.org.au> wrote: > On Mon, Sep 18, 2017 at 07:32:37PM +0530, PrasannaKumar Muralidharan wrote: >> This patch series adds support of pseudo random number generator found >> in Ingenic's JZ4780 and X1

Re: [RFC PATCH] crypto: make the seed() function optional

Hi Herbert, On 7 October 2017 at 09:03, Herbert Xu wrote: > Mathieu Malaterre wrote: >> This makes it simplier for driver author to not provide the seed() function >> in case of a pseudo RNG where the seed operation is a no-op. >> >> Document that

Re: [PATCH] Documentation: hw_random: Fix issue related to feeding entropy pool

Hi Herbert, On 22 September 2017 at 14:47, Herbert Xu <herb...@gondor.apana.org.au> wrote: > PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> wrote: >> There is no need to use rng-tools for feeding random data into kernel >> entropy pool as hw_random cor

[PATCH v3 3/4] crypto: jz4780-rng: Add RNG node to jz4780.dtsi

. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v3: * Create a cgublock node with "simple-bus" compatible * Make CGU and RNG node as children of cgublock node. Changes in v2:

[PATCH v3 4/4] crypto: jz4780-rng: Enable PRNG support in CI20 defconfig

Enable PRNG driver support in MIPS Creator CI20 default config. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- No changes in v3 No changes in v2 arch/mips/configs/ci20_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/mips/c

[PATCH v3 0/4] crypto: Add driver for JZ4780 PRNG

river. Add 'syscon' compatible in CGU node in jz4780.dtsi. The jz4780-rng driver uses regmap exposed via syscon interface to access the RNG registers. CGU driver is not modified in this patch set as registers used by CGU driver and this driver are different. PrasannaKumar Muralidharan (4): crypto:

[PATCH v3 2/4] crypto: jz4780-rng: Add Ingenic JZ4780 hardware PRNG driver

; Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v3: * Add seeding support * Reduce delay Changes in v2: * Fixed buffer overflow in generate function pointed out in Stephan's review

[PATCH v3 1/4] crypto: jz4780-rng: Add JZ4780 PRNG devicetree binding documentation

Add devicetree bindings for hardware pseudo random number generator present in Ingenic JZ4780 SoC. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v3: * Create a cgublock node with "simple-bus" compatible * Make CGU and RNG node as children

[RFC] tpm: Register RNG device only on tpm chip init

RNG device is registered as soon as tpm-rng module is loaded even if there are no TPM chip available. Call hwrng_register once tpm chip has registered. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/tpm-rng.

Re: HWRNGs without quality attribute - are they used or not?

Hi Peter, On 5 September 2017 7:24:02 PM IST, Peter Huewe wrote: >Hi, > >while reading through the analysis of the Linux RNG by the BSI [1][2], >I was suprised by the lack of reflecting on the usage of HWRNGs except >RDRAND/RDSEED. > >In the paper it was mentioned that if

Re: [PATCH v2 0/4] crypto: Add driver for JZ4780 PRNG

On 23 August 2017 at 08:27, PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> wrote: > This patch series adds support of pseudo random number generator found > in Ingenic's JZ4780 and X1000 SoC. > > Based on Paul's review comments, add 'syscon' compatible in CGU node in >

Re: [PATCH v2 1/4] crypto: jz4780-rng: Add JZ4780 PRNG devicetree binding documentation

Hi Rob, On 26 August 2017 at 03:27, Rob Herring <r...@kernel.org> wrote: > On Wed, Aug 23, 2017 at 08:27:04AM +0530, PrasannaKumar Muralidharan wrote: >> Add devicetree bindings for hardware pseudo random number generator >> present in Ingenic JZ4780 SoC. >> >

Re: [PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

On 23 August 2017 at 22:24, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Wed, Aug 23, 2017 at 10:14:29PM +0530, PrasannaKumar Muralidharan wrote: >> Hi Krzysztof, >> >> On 23 August 2017 at 21:42, Krzysztof Kozlowski <k...@kernel.org> wrote: >> >

Re: [PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

Hi Krzysztof, On 23 August 2017 at 21:42, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Wed, Aug 23, 2017 at 08:34:43PM +0530, PrasannaKumar Muralidharan wrote: >> Samsung exynos PRNG driver is using crypto framework instead of >> hw_random framework. So move the devicet

Re: [PATCH v2 4/4] crypto: jz4780-rng: Enable PRNG support in CI20 defconfig

Hi Harvey, On 23 August 2017 at 20:21, Harvey Hunt <harvey.h...@imgtec.com> wrote: > Hi PrasannaKumar, > > > On 23/08/17 15:50, PrasannaKumar Muralidharan wrote: >> >> Hi Harvey, >> >> On 23 August 2017 at 14:39, Harvey Hunt <harvey.h...@imgtec.com>

[PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

Samsung exynos PRNG driver is using crypto framework instead of hw_random framework. So move the devicetree binding to crypto folder. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v2: * Modify MAINTAINERS file to reflect file rename .../devi

Re: [PATCH v2 4/4] crypto: jz4780-rng: Enable PRNG support in CI20 defconfig

Hi Harvey, On 23 August 2017 at 14:39, Harvey Hunt <harvey.h...@imgtec.com> wrote: > Hi PrasannaKumar, > > On 23/08/17 03:57, PrasannaKumar Muralidharan wrote: >> >> Enable PRNG driver support in MIPS Creator CI20 default config. >> >> Signed-off-by: Pr

Re: [PATCH] hw_random: timeriomem-rng: Remove 'max < 4' condition check

Hi Rick, On 22 August 2017 at 22:23, Rick Altherr <ralth...@google.com> wrote: > On Tue, Aug 22, 2017 at 9:22 AM, PrasannaKumar Muralidharan > <prasannatsmku...@gmail.com> wrote: >> >> In read routiene max is always >= 4. The check whether 'max < 4' is not

[PATCH v2 4/4] crypto: jz4780-rng: Enable PRNG support in CI20 defconfig

Enable PRNG driver support in MIPS Creator CI20 default config. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- No changes in v2 arch/mips/configs/ci20_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arc

[PATCH v2 3/4] crypto: jz4780-rng: Add RNG node to jz4780.dtsi

Add RNG node to jz4780 dtsi. This driver uses registers that are part of the register set used by Ingenic CGU driver. Make RNG node as child of CGU node. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v2: * Add "syscon" in CGU node's co

[PATCH v2 1/4] crypto: jz4780-rng: Add JZ4780 PRNG devicetree binding documentation

Add devicetree bindings for hardware pseudo random number generator present in Ingenic JZ4780 SoC. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v2: * Add "syscon" in CGU node's compatible section * Make RNG child node of CGU. .../binding

[PATCH v2 2/4] crypto: jz4780-rng: Add Ingenic JZ4780 hardware PRNG driver

; Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Changes in v2: * Fixed buffer overflow in generate function pointed out in Stephan's review * Fold patch that had only MAINTAINERS file change with this patch * Removed unnecessary comment in code MAINTAINERS

[PATCH v2 0/4] crypto: Add driver for JZ4780 PRNG

is not modified in this patch set as registers used by CGU driver and this driver are different. PrasannaKumar Muralidharan (4): crypto: jz4780-rng: Add JZ4780 PRNG devicetree binding documentation crypto: jz4780-rng: Add Ingenic JZ4780 hardware PRNG driver crypto: jz4780-rng: Add RNG node to jz4780

[PATCH] hw_random: timeriomem-rng: Remove 'max < 4' condition check

In read routiene max is always >= 4. The check whether 'max < 4' is not necessary. Remove it. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/timeriomem-rng.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/ch

[PATCH] Documentation: hw_random: Fix issue related to feeding entropy pool

There is no need to use rng-tools for feeding random data into kernel entropy pool as hw_random core handles it. Documentation suggested that rng-tools is required which is incorrect. So remove it. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- Documen

Re: [PATCH 2/6] crypto: jz4780-rng: Make ingenic CGU driver use syscon

Hi Paul, Thanks for your review. On 19 August 2017 at 02:18, Paul Burton <paul.bur...@imgtec.com> wrote: > Hi PrasannaKumar, > > On Thursday, 17 August 2017 11:25:16 PDT PrasannaKumar Muralidharan wrote: >> Ingenic PRNG registers are a part of the same hardware block as clo

Re: [PATCH 3/6] crypto: jz4780-rng: Add Ingenic JZ4780 hardware PRNG driver

Hi Stephan, On 18 August 2017 at 00:22, Stephan Mueller <smuel...@chronox.de> wrote: > Am Donnerstag, 17. August 2017, 20:25:17 CEST schrieb PrasannaKumar > Muralidharan: > > Hi PrasannaKumar, > >> + >> +static int jz4780_rng_generate(struct crypto_rng *tfm, >

[PATCH 6/6] crypto: jz4780-rng: Enable PRNG support in CI20 defconfig

Enable PRNG driver support in MIPS Creator CI20 default config. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- arch/mips/configs/ci20_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/mips/configs/ci20_defconfig b/arch/mips/configs/ci20_def

[PATCH 5/6] crypto: jz4780-rng: Add myself as mainatainer for JZ4780 PRNG driver

Add myself as the maintainer of JZ4780 SoC's PRNG drvier. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 45ec467..ee8c6f6 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 3/6] crypto: jz4780-rng: Add Ingenic JZ4780 hardware PRNG driver

; Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/crypto/Kconfig | 19 + drivers/crypto/Makefile | 1 + drivers/crypto/jz4780-rng.c | 173 3 files changed, 193 insertions(+) create mode 100644 drivers/c

[PATCH 4/6] crypto: jz4780-rng: Add RNG node to jz4780.dtsi

This patch adds RNG node to jz4780.dtsi. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz478

[PATCH 2/6] crypto: jz4780-rng: Make ingenic CGU driver use syscon

by the PRNG driver. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- arch/mips/boot/dts/ingenic/jz4740.dtsi | 14 +++ arch/mips/boot/dts/ingenic/jz4780.dtsi | 14 +++ drivers/clk/ingenic/cgu.c | 46 +- d

[PATCH 0/6] crypto: Add driver for JZ4780 PRNG

that are present after the PRNG registers. So instead of reducing the register range, syscon interface is used to expose a register map that is used by both CGU driver and this driver. Changes made to jz4740-cgu.c is only compile tested. PrasannaKumar Muralidharan (6): crypto: jz4780-rng: Add

[PATCH 1/6] crypto: jz4780-rng: Add devicetree bindings for RNG in JZ4780 SoC

Add devicetree bindings for hardware pseudo random number generator present in Ingenic JZ4780 SoC. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- .../devicetree/bindings/rng/ingenic,jz4780-rng.txt | 24 ++ 1 file changed, 24 insertions(+)

[PATCH] crypto: Kconfig: Correct help text about feeding entropy pool

Modify Kconfig help text to reflect the fact that random data from hwrng is fed into kernel random number generator's entropy pool. Signed-off-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> --- drivers/char/hw_random/Kconfig | 6 ++ 1 file changed, 2 insertions(+), 4 del

Re: [PATCH v4 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

truct mxc_rngc *rngc = platform_get_drvdata(pdev); > + > + hwrng_unregister(>rng); > + > + clk_disable_unprepare(rngc->clk); > + > + return 0; > +} > + > +#ifdef CONFIG_PM > +static int mxc_rngc_suspend(struct device *dev) > +{ > + struct mxc_rngc *rngc = dev_get_drvdata(dev); > + > + clk_disable_unprepare(rngc->clk); > + > + return 0; > +} > + > +static int mxc_rngc_resume(struct device *dev) > +{ > + struct mxc_rngc *rngc = dev_get_drvdata(dev); > + > + clk_prepare_enable(rngc->clk); > + > + return 0; > +} > + > +static const struct dev_pm_ops mxc_rngc_pm_ops = { > + .suspend= mxc_rngc_suspend, > + .resume = mxc_rngc_resume, > +}; > +#endif > + > +static const struct of_device_id mxc_rngc_dt_ids[] = { > + { .compatible = "fsl,imx25-rng", .data = NULL, }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, mxc_rngc_dt_ids); > + > +static struct platform_driver mxc_rngc_driver = { > + .driver = { > + .name = "mxc_rngc", > +#ifdef CONFIG_PM > + .pm = _rngc_pm_ops, > +#endif > + .of_match_table = mxc_rngc_dt_ids, > + }, > + .remove = __exit_p(mxc_rngc_remove), > +}; > + > +module_platform_driver_probe(mxc_rngc_driver, mxc_rngc_probe); > + > +MODULE_AUTHOR("Freescale Semiconductor, Inc."); > +MODULE_DESCRIPTION("H/W RNGC driver for i.MX"); > +MODULE_LICENSE("GPL"); > -- > 2.1.4 > Regardless of the minor suggestion, code looks good to me as is. Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com>. Note: Add my reviewed by tag if you are going for next version. Regards, PrasannaKumar

Re: [PATCH 3/3] hwrng: mxc-fsl - add support for Freescale RNGC

Hi Martin, On 18 July 2017 at 02:46, Martin Kaiser wrote: > From: Steffen Trumtrar > > The driver is ported from Freescales Linux git and can be > found in the > > vendor/freescale/imx_2.6.35_maintain > > branch. > > According to that code,

Re: [PATCH] crypto: change hwrng device default permissions to 0444

Hi Herbert, On 12 July 2017 at 15:43, Herbert Xu wrote: > Hmm, one usage scenario for /dev/hwrng is to feed rngd which then > feeds into /dev/random. In that case it may not be desirable to > allow arbitrary access to hwrgn since it may cause the rate of > entropy

Re: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user selected rng

+495,7 @@ void hwrng_unregister(struct hwrng *rng) > list_del(>list); > if (current_rng == rng) { > drop_current_rng(); > +cur_rng_set_by_user = 0; > /* rng_list is sorted by quality, use the best (=first) one */ > if (!list_empty(_list)) { &

Re: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user selected rng

Hi Harald, > Here is an updated version with just showing 0 or 1 in the new sysfs > attribute file: > == cut == > From: Harald Freudenberger > Date: Mon, 3 Jul 2017 10:19:22 +0200 > Subject: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user

Re: [PATCH 2/3] crypto: hwrng remember rng chosen by user

ng) { > drop_current_rng(); > + cur_rng_set_by_user = 0; > /* rng_list is sorted by quality, use the best (=first) one */ > if (!list_empty(_list)) { > struct hwrng *new_rng; > -- > 2.7.4 > Looks good to me. Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com>. Regards, PrasannaKumar

Re: [PATCH 1/3] crypto: hwrng use rng source with best quality

l = list_entry(rng_list.prev, struct hwrng, list); > + struct hwrng *new_rng; > > - set_current_rng(tail); > + new_rng = list_entry(rng_list.next, struct hwrng, > list); > + set_current_rng(new_rng); > } > } > > -- > 2.7.4 > Looks good to me. Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com>. Regards, PrasannaKumar

Re: [PATCH 3/3] crypto: hwrng add sysfs attribute to show user selected rng

On 3 July 2017 at 15:33, Harald Freudenberger wrote: > This patch introduces a new sysfs attribute file 'rng_selected' > which shows the the rng chosen by userspace. > > If a rng source is chosen by user via echo some valid string > to rng_current there should be a way

Re: [PATCH 1/2] crypto: Make hwrng choose rng source by quality.

tail = list_entry(rng_list.prev, struct hwrng, list); > + struct hwrng *new_rng; > > - set_current_rng(tail); > + new_rng = list_entry(rng_list.next, struct hwrng, > list); > + set_current_rng(new_rng); > } > } > > -- > 2.7.4 > This patch looks good. I am fine with this patch as is. Reviewed-by: PrasannaKumar Muralidharan <prasannatsmku...@gmail.com> If this patch is split into please go ahead and my reviewed-by tag. Regards, PrasannaKumar

Re: [PATCH] hwrng: do not warn when there are no devices

On 20 June 2017 at 00:33, Mike Frysinger <vap...@chromium.org> wrote: > On Mon, Jun 19, 2017 at 2:43 AM, PrasannaKumar Muralidharan wrote: >> On 19 June 2017 at 11:51, Herbert Xu wrote: >>> On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: >>>>

Re: [PATCH] hwrng: do not warn when there are no devices

On 19 June 2017 at 11:51, Herbert Xu wrote: > On Sun, Jun 18, 2017 at 10:00:17PM -0700, Mike Frysinger wrote: >> >> in order to make tpm-rng react in the way you're implying, the TPM >> subsystem would need to add a notification chain for transitions from >>

Re: [PATCH v6 4/5] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver

On 29 May 2017 at 14:51, Antoine Tenart wrote: >> As you have got help from other people for testing, wouldn't it be >> nice to add tested-by tag? > > Well, they're listed as authors of the driver: not only they helped to > test it but they developed parts of

Re: [PATCH v6 4/5] crypto: inside-secure: add SafeXcel EIP197 crypto engine driver

Hi Antonie, On 24 May 2017 at 19:40, Antoine Tenart wrote: > Add support for Inside Secure SafeXcel EIP197 cryptographic engine, > which can be found on Marvell Armada 7k and 8k boards. This driver > currently implements: ecb(aes), cbc(aes), sha1, sha224,

Re: [PATCH] crypto: exynoes-rng: Set cra_ctxsize to 0

On 21 May 2017 at 12:44, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Sun, May 21, 2017 at 9:11 AM, PrasannaKumar Muralidharan > <prasannatsmku...@gmail.com> wrote: >> Hi Krzysztof >> >> On 21 May 2017 at 11:56, Krzysztof Kozlowski <k...@kernel.org>

Re: [PATCH] crypto: exynoes-rng: Set cra_ctxsize to 0

Hi Krzysztof On 21 May 2017 at 11:56, Krzysztof Kozlowski <k...@kernel.org> wrote: > On Sun, May 21, 2017 at 8:09 AM, PrasannaKumar Muralidharan > <prasannatsmku...@gmail.com> wrote: >> As cra_ctxsize is set but the allocated space is not used, set it 0. > > Why do

  1   2   >