Re: [PATCH 000/141] Fix fall-through warnings for Clang

2020-11-22 Thread Sam Ravnborg
Hi James. > > > If none of the 140 patches here fix a real bug, and there is no > > > change to machine code then it sounds to me like a W=2 kind of a > > > warning. > > > > FWIW, this series has found at least one bug so far: > > https://lore.kernel.org/lkml/CAFCwf11izHF=g1mGry1fE5kvFFFrxzhPSM6q

Re: [PATCH v6 1/2] sparc: fix a building error reported by kbuild

2016-12-09 Thread Sam Ravnborg
_id(cpu) (cpu_data(cpu).proc_id) >^ > Let's include cpudata.h in topology_64.h. > > Cc: Sam Ravnborg > Cc: David S. Miller > Cc: sparcli...@vger.kernel.org > Suggested-by: Sam Ravnborg > Signed-off-by: Gonglei Acked-by: Sam Ravnbor

Re: [PATCH v5 1/1] crypto: add virtio-crypto driver

2016-12-07 Thread Sam Ravnborg
On Mon, Dec 05, 2016 at 03:12:52AM +, Gonglei (Arei) wrote: > I don't think the root cause of those warnings are introduced by > virtio-crypto driver. > > What's your opinion? Sam and David? Root cause here is that arch/sparc/include/asm/topology_64.h references cpu_data without including ar

Re: crypto: libcrc32c should select crc32c

2009-01-18 Thread Sam Ravnborg
On Sun, Jan 18, 2009 at 09:14:16AM +0100, Jan Engelhardt wrote: > > On Sunday 2009-01-18 06:37, Herbert Xu wrote: > >On Sat, Jan 17, 2009 at 11:48:42PM +0100, Jan Engelhardt wrote: > >> > >> Looking at libcrc32c.c shows that it essentially depends on the > >> crc32c crypto module, which was not pa

Re: [1/2] 2.6.22-rc2: known regressions with patches

2007-05-19 Thread Sam Ravnborg
t; > > > Unclassified > > Subject: 2.6.22-rc2: section mismatch > References : http://lkml.org/lkml/2007/5/19/59 > Submitter : Andrey Borzenkov <[EMAIL PROTECTED]> > Handled-By : Sam Ravnborg <[EMAIL PROTECTED]> > Status : fixed in kbuild-git.git 2 warning