Re: [PATCH v13 net-next 01/12] tls: support for Inline tls record

On Tue, 27 Mar 2018 23:06:30 +0530 Atul Gupta wrote: > +static struct tls_context *create_ctx(struct sock *sk) > +{ > + struct inet_connection_sock *icsk = inet_csk(sk); > + struct tls_context *ctx; > + > + /* allocate tls context */ > + ctx =

Re: [PATCH v13 net-next 07/12] crypto: chtls - Program the TLS session Key

On Tue, 27 Mar 2018 23:06:36 +0530 Atul Gupta wrote: > +static void __set_tcb_field(struct sock *sk, struct sk_buff *skb, u16 word, > + u64 mask, u64 val, u8 cookie, int no_reply) > +{ > + struct chtls_sock *csk =

Re: [PATCH v13 net-next 09/12] crypto: chtls - Inline TLS record Tx

On Tue, 27 Mar 2018 23:06:38 +0530 Atul Gupta wrote: > +static u8 tcp_state_to_flowc_state(u8 state) > +{ > + u8 ret = FW_FLOWC_MNEM_TCPSTATE_ESTABLISHED; > + > + switch (state) { > + case TCP_ESTABLISHED: > + ret =

Re: [PATCH v13 net-next 08/12] crypto : chtls - CPL handler definition

Werner <wer...@chelsio.com> > Reviewed-by: Sabrina Dubroca <sdubr...@redhat.com> > Reviewed-by: Stefano Brivio <sbri...@redhat.com> No, I haven't. -- Stefano

Re: [PATCH v13 net-next 09/12] crypto: chtls - Inline TLS record Tx

Signed-off-by: Michael Werner <wer...@chelsio.com> > Reviewed-by: Stefano Brivio <sbri...@redhat.com> Absolutely not. -- Stefano

Re: [PATCH v13 net-next 07/12] crypto: chtls - Program the TLS session Key

m user in > struct tls12_crypto_info_aes_gcm_128 and understood by hardware. > added socket option TLS_RX > > Signed-off-by: Atul Gupta <atul.gu...@chelsio.com> > Reviewed-by: Sabrina Dubroca <sdubr...@redhat.com> > Reviewed-by: Stefano Brivio <sbri...@redhat.com> Nope, sorry. -- Stefano

Re: [PATCH v12 net-next 06/12] crypto: chtls - structure and macro for Inline TLS

On Mon, 19 Mar 2018 19:25:39 +0530 Atul Gupta wrote: > +#define SOCK_INLINE (31) > > [...] > > +static inline int csk_flag(const struct sock *sk, enum csk_flags flag) > +{ > + struct chtls_sock *csk = rcu_dereference_sk_user_data(sk); > + > + if (!sock_flag(sk,

Re: [PATCH v12 net-next 10/12] crypto: chtls - Inline TLS record Rx

On Mon, 19 Mar 2018 19:25:43 +0530 Atul Gupta wrote: > +int chtls_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, > + int nonblock, int flags, int *addr_len) > +{ > > [...] > > + if (likely(!(flags & MSG_TRUNC))) { > +

Re: [PATCH v12 net-next 01/12] tls: support for Inline tls record

On Mon, 19 Mar 2018 19:25:34 +0530 Atul Gupta wrote: > @@ -268,6 +259,8 @@ static void tls_sk_proto_close(struct sock *sk, long > timeout) > skip_tx_cleanup: > release_sock(sk); > sk_proto_close(sk, timeout); > + if (ctx && ctx->tx_conf == TLS_HW_RECORD)

Re: [PATCH v12 net-next 09/12] crypto: chtls - Inline TLS record Tx

On Mon, 19 Mar 2018 19:25:42 +0530 Atul Gupta wrote: > +static bool is_tls_skb(struct chtls_sock *csk, const struct sk_buff *skb) > +{ > + return skb_ulp_tls_skb_flags(skb); > +} Do you need this function? > +/* Copy Key to WR */ > +static void

Re: [PATCH v12 net-next 00/12] Chelsio Inline TLS

On Mon, 19 Mar 2018 19:25:33 +0530 Atul Gupta wrote: > Series for Chelsio Inline TLS driver (chtls) > > [...] > > v12: patch against net-next > - fixed few build error > - replace set_queue with skb_set_queue_mapping [Sabrina] > - copyright year correction

Re: [PATCH v10 crypto 07/11] chtls: Program the TLS Key

On Sat, 10 Mar 2018 00:40:12 +0530 Atul Gupta wrote: > Initialize the space reserved for storing the TLS keys > get and free the location where key is stored for the TLS > connection > Program the tx and rx key as received from user in > struct

Re: [PATCH v10 crypto 09/11] chtls: Inline TLS request Tx/Rx

On Sat, 10 Mar 2018 00:40:14 +0530 Atul Gupta wrote: > TLS handler for record transmit and receive. > Create Inline TLS work request and post to FW. > Create Inline TLS record CPLs for hardware > > Signed-off-by: Atul Gupta > --- >

Re: [crypto 4/8] chtls: CPL handler definition

Hi Atul, On Thu, 7 Dec 2017 14:50:37 + Atul Gupta <atul.gu...@chelsio.com> wrote: > -Original Message- > From: linux-crypto-ow...@vger.kernel.org > [mailto:linux-crypto-ow...@vger.kernel.org] On Behalf Of Stefano Brivio > Sent: Tuesday, December 5, 2017 8:54 P

Re: [crypto 4/8] chtls: CPL handler definition

On Tue, 5 Dec 2017 17:10:00 +0530 Atul Gupta wrote: > CPL handlers for TLS session, record transmit and receive > > Signed-off-by: Atul Gupta > --- > drivers/crypto/chelsio/chtls/chtls_cm.c | 2048 > +++ > 1 file