Re: [PATCH v3 1/3] Documentation/bindings: Document the SafeXel cryptographic engine driver

2017-05-23 Thread Thomas Petazzoni
es soon. I'm sure there will be lots of comments :) Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH v3 1/3] Documentation/bindings: Document the SafeXel cryptographic engine driver

2017-05-22 Thread Thomas Petazzoni
river, and changes the Device Tree to refer to the ICU interrupt instead. Therefore, I don't think the binding should reference anything else than the usual info about the interrupts property. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engin

Re: [PATCH v5 1/4] Documentation/bindings: Document the SafeXel cryptographic engine driver

2017-05-22 Thread Thomas Petazzoni
lready been merged by Grégory are wrong for the same reason and should be fixed. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com

Re: [PATCH 4/7] arm64: marvell: dts: add crypto engine description for 7k/8k

2017-04-12 Thread Thomas Petazzoni
interrupts = | IRQ_TYPE_LEVEL_HIGH)>, Now that I look into this, does it makes sense for an interrupt to be both an edge interrupt and a level interrupt at the same time? This looks odd. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux and

Re: [PATCH] dt-bindings: rng: clocks property on omap_rng is optional

2017-03-17 Thread Thomas Petazzoni
s worth mentioning that the actual driver implementation simply makes the clock optional in all cases, without looking at the compatible to figure out if the clock must be there or not. But that's just the current driver implementation. The Device Tree binding specification can be more specific than what the

[PATCH v2] dt-bindings: rng: clocks property on omap_rng not always mandatory

2017-03-17 Thread Thomas Petazzoni
riant") Cc: <sta...@vger.kernel.org> Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- Changes since v1: - Instead of indicating the property as optional, indicate it as mandatory for the inside-secure,safexcel-eip76 compatible string, as suggested by

[PATCH] dt-bindings: rng: clocks property on omap_rng is optional

2017-03-07 Thread Thomas Petazzoni
it is in fact "Optional": some SoCs do not require a clock for this IP block. Fixes: 52060836f79 ("dt-bindings: omap-rng: Document SafeXcel IP-76 device variant") Cc: <sta...@vger.kernel.org> Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> ---

[PATCH 1/4] hwrng: omap - write registers after enabling the clock

2017-03-07 Thread Thomas Petazzoni
mmit fixes that by making the register access *after* enabling the clock. This issue was found by the kernelci.org testing effort. Fixes: 383212425c926 ("hwrng: omap - Add device variant for SafeXcel IP-76 found in Armada 8K") Cc: <sta...@vger.kernel.org> Signed-off-by: Thomas Petazz

[PATCH 2/4] hwrng: omap - use devm_clk_get() instead of of_clk_get()

2017-03-07 Thread Thomas Petazzoni
er.kernel.org> Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- drivers/char/hw_random/omap-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/omap-rng.c b/drivers/char/hw_random/omap-rng.c index efa3747..d286628 100

[PATCH 3/4] hwrng: omap - Do not access INTMASK_REG on EIP76

2017-03-07 Thread Thomas Petazzoni
evice variant for SafeXcel IP-76 found in Armada 8K") Cc: <sta...@vger.kernel.org> Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- drivers/char/hw_random/omap-rng.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH 0/4] hwrng: omap - fixes and improvements

2017-03-07 Thread Thomas Petazzoni
Hello, This small patch series brings a few fixes and improvements to the omap_rng driver. The first fix is particularly important, as it fixes using the driver built as a module on SoCs that require a clock for the IP to work properly. Thanks, Thomas Thomas Petazzoni (4): hwrng: omap

[PATCH 4/4] hwrng: omap - move clock related code to omap_rng_probe()

2017-03-07 Thread Thomas Petazzoni
it in omap_rng_probe() directly. Moreover, we make sure to bail out if we can't enable the clock. Indeed, while the clock is optional, if a clock is present, we really want to succeed in enabling it. And we fix the error message to fit on one line, so that it is grep-friendly. Signed-off-by: Thomas

Re: [PATCH 0/7] Various fixes for the cesa driver

2016-08-09 Thread Thomas Petazzoni
he series, to make it clear that they are the two fixes that are important to merge for the 4.8 release cycle. > crypto: marvell - Don't hardcode block size in mv_cesa_ahash_cache_req > > Thomas Petazzoni (4): > crypto: marvell: be explicit about destination in mv_cesa_dma_add_

Re: [PATCH 0/3] crypto: fixes for Marvell hash

2015-10-09 Thread Thomas Petazzoni
gt; (commit_signer:7/12=58%,authored:4/12=33%,removed_lines:1/12=8%) Vladimir Zapolskiy <vladimir_zapols...@mentor.com> (commit_signer:1/12=8%,authored:1/12=8%,removed_lines:3/12=25%) Krzysztof Kozlowski <k.kozlow...@samsung.com> (commit_signer:1/12=8%,authored:1/12=8%,removed_lines:1/

Re: [PATCH 0/3] crypto: fixes for Marvell hash

2015-10-09 Thread Thomas Petazzoni
; Picking up everyone who's ever touched a driver with as little as a spelling > fix in a git commit is abhorrent. Agreed. I myself never used get_maintainer.pl for this reason :-) Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-

[PATCH] MAINTAINERS: add maintainers for the Marvell Crypto driver

2015-10-09 Thread Thomas Petazzoni
rezil...@free-electrons.com> Cc: Arnaud Ebalard <a...@natisbad.org> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: Russell King <li...@arm.linux.org.uk> Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 i

[PATCH] crypto: marvell: properly handle CRYPTO_TFM_REQ_MAY_BACKLOG-flagged requests

2015-09-18 Thread Thomas Petazzoni
of mv_cesa_queue_req() are fixed to use this new helper function. Reported-by: Vincent Donnefort <vdonnef...@gmail.com> Fixes: db509a45339fd ("crypto: marvell/cesa - add TDMA support") Cc: <sta...@vger.kernel.org> # v4.2+ Signed-off-by: Thomas Petazzoni <thomas.petazz...@free-electrons

Re: [PATCH v7 04/14] crypto: add a new driver for Marvell's CESA

2015-06-19 Thread Thomas Petazzoni
(). For the vast majority of platforms, this is OK. It's only if you have 4 GB of RAM or more that it causes problem. And then we switch to mv_mbus_dram_info_nooverlap() as part of the -rc cycle. (2) is probably easier. Herbert, what do you think? Thomas -- Thomas Petazzoni, CTO, Free

Re: [PATCH v3 14/16] ARM: marvell/dt: enable crypto on armada-xp-gp

2015-05-27 Thread Thomas Petazzoni
+= board level ranges in .dts, we simply decided to always put: ranges = SoC level and board level ranges in the .dts. It does create some duplication, but that's the best we could do with the existing DT infrastructure. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons

Re: [PATCH v3 15/16] ARM: marvell/dt: add crypto node to armada 370 dtsi

2015-05-26 Thread Thomas Petazzoni
will disable it at the end of the boot. Check if crypto still works or not, and you'll get your answer :-) Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-crypto

Re: DMA support for mv_cesa

2014-07-28 Thread Thomas Petazzoni
started working on the crypto unit for Armada 370/XP/375/38x, so it's not a driver for which we have followed the recent developments. However, it might appear on our TODO-list at some point in the future. Best regards, Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel