[PATCH v3] staging: ccree: fix boolreturn.cocci warning

From: Suniel Mahesh This fixes the following coccinelle warning: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. return "false" instead of 0. Signed-off-by: Suniel Mahesh --- Changes for v3: - Changed the commit log even

[PATCH v2] staging: ccree: fix boolreturn.cocci warning

From: Suniel Mahesh Return "false" instead of 0. This fixes the following coccinelle warning: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. Signed-off-by: Suniel Mahesh --- Changes for v2: - Changed the commit log to give

[PATCH v2] staging: ccree: Fix bool comparison

From: Suniel Mahesh Comparision operator "equal to" not required on a variable "foo" of type "bool". Bool has only two values, can be used directly or with logical not. This fixes the following coccinelle warning: WARNING: Comparison of bool to 0/1 Signed-off-by: Suniel

[PATCH] staging: ccree: fix boolreturn.cocci warning

From: Suniel Mahesh This fixes the following coccinelle warning: WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool. Signed-off-by: Suniel Mahesh --- Note: - Patch was tested and built(ARCH=arm) on latest linux-next. - No

[PATCH] staging: ccree: Fix bool comparison

From: Suniel Mahesh Bool tests don't need comparisons. This fixes the following coccinelle warning: WARNING: Comparison of bool to 0/1 Signed-off-by: Suniel Mahesh --- Note: - Patch was tested and built(ARCH=arm) on latest linux-next. - No build

[PATCH] staging: ccree: local variable "dev" not required

From: Suniel Mahesh There is no need to create a local pointer variable "dev" and pass it various API's, instead use plat_dev which is enumerated by platform core on successful probe. Signed-off-by: Suniel Mahesh --- Note: - Patch was tested and

[PATCH v3] staging: ccree: Convert to platform_{get,set}_drvdata()

From: Suniel Mahesh Platform devices are expected to use wrapper functions, platform_{get,set}_drvdata() with platform_device as argument, for getting and setting the driver data. dev_{get,set}_drvdata() are using _dev->dev. For wrapper functions we can directly pass a

[PATCH] staging: ccree: else is not generally useful after a break or return

From: Suniel Mahesh Fixes checkpatch warnings: WARNING: else is not generally useful after a break or return Signed-off-by: Suniel Mahesh --- Note: - Patch was tested and built(ARCH=arm) on next-20170921. No build issues reported. ---

[PATCH v2] staging: ccree: Convert to platform_{get,set}_drvdata()

From: Suniel Mahesh Platform devices are expected to use wrapper functions, platform_{get,set}_drvdata() with platform_device as argument, for getting and setting the driver data. dev_{get,set}_drvdata() are using _dev->dev. For wrapper functions we can directly pass a

[PATCH] staging: ccree: Convert to platform_{get,set}_drvdata()

From: Suniel Mahesh Platform devices are expected to use wrapper functions, platform_{get,set}_drvdata() with platform_device as argument, for getting and setting the driver data. dev_{get,set}_drvdata() are using _dev->dev. For wrapper functions we can directly pass a

[PATCH] staging: ccree: Fix unnecessary NULL check before kfree'ing it

From: Suniel Mahesh kfree(NULL) is safe and their is no need for a NULL check. Pointed out by checkpatch. Signed-off-by: Suniel Mahesh --- Note: - Patch was compile tested and built(ARCH=arm) on next-20170719. No build issues reported. ---

[PATCH v2 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

From: Suniel Mahesh It is recommended to use managed function devm_kzalloc, which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace kzalloc with devm_kzalloc. (b) drop kfree(), because memory allocated with devm_kzalloc() is

[PATCH v2 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

From: Suniel Mahesh It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with

[PATCH v2 3/3] staging: ccree: Use platform_get_irq and devm_request_irq

From: Suniel Mahesh It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with

[PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

From: Suniel Mahesh It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with

[PATCH 3/3] staging: ccree: Use platform_get_irq and devm_request_irq

From: Suniel Mahesh It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with

[PATCH 0/3] staging: ccree: Employ devm_* functions, remove redundant code

From: Suniel Mahesh Hi This patch series replaces the current API's which request for device resources in driver probe, with devm_*() functions of the kernel framework as recommended by the kernel community. Doing so simplifies driver cleanup paths and code organization.