Re: [PATCH 2/7] Makefile, x86, LLVM: disable unsupported optimization flags

2017-04-10 Thread Masahiro Yamada
Hi. 2017-04-06 4:11 GMT+09:00 Michael Davidson : > It "works" for the cases that I currently care about but I have to say > that I am uneasy about adding -Werror to the cc-option test in this > way. > > Suppose that one of the *other* flags that is implicitly passed to the >

Re: [PATCH 2/7] Makefile, x86, LLVM: disable unsupported optimization flags

2017-04-05 Thread Michael Davidson
It "works" for the cases that I currently care about but I have to say that I am uneasy about adding -Werror to the cc-option test in this way. Suppose that one of the *other* flags that is implicitly passed to the compiler by cc-option - eg something that was explicitly specified in

Re: [PATCH 2/7] Makefile, x86, LLVM: disable unsupported optimization flags

2017-04-05 Thread Matthias Kaehlcke
Hi Masahiro, El Thu, Apr 06, 2017 at 03:08:26AM +0900 Masahiro Yamada ha dit: > 2017-03-17 9:15 GMT+09:00 Michael Davidson : > > Unfortunately, while clang generates a warning about these flags > > being unsupported it still exits with a status of 0 so we have > > to explicitly

Re: [PATCH 2/7] Makefile, x86, LLVM: disable unsupported optimization flags

2017-03-17 Thread H. Peter Anvin
On 03/17/17 14:32, H. Peter Anvin wrote: > > NAK. Fix your compiler, or use a wrapper script or something. It is > absolutely *not* acceptable to disable this since future versions of > clang *should* support that. > > That being said, it might make sense to look for a key pattern like >